Electrum

Merge pull request #10791 from SomberNight/202608_wallet_sign_message2

wallet: sign_message: strip whitespaces in GUis, do not strip in CLI

wallet: decrypt_message: nicer error msg if pubkey is unrelated

wallet: sign_message: force kwargs

wallet: sign_message: consolidate checks from UIs

wallet: decrypt_message: consolidate checks from UIs

wallet: refactor: add encrypt_message method, consolidated from UIs

wallet: refactor: add verify_message method, consolidated from UIs

lnwallet: don't blacklist htlc failures without channel update

The lightning spec changed so that htlc failures don't have to include
a channel_update message anymore (https://github.com/lightning/bolts/pull/1173).
We shouldn't blacklist a channel for not including a channel_update
if the error code signals a liquidity issue (TEMPORARY_CHANNEL_FAILURE), instead
it is sufficient to just record the liquidity hint and try with a smaller
part.

hww/qt: followup 898a4c270

Also make the other attribute private

test_lnwallet: add unittest for unchanged channel update from failed htlc

Tests that a TEMPORARY_CHANNEL_FAILURE whose channel update leaves the
policy unchanged does not blacklist the channel (the liquidity hint is
sufficient), while other failure codes still blacklist.

test_lnwallet: add unittest for single channel mpp split config

Tests that all parts of a multi-part payment over a single channel
are constructed using the channel of the split configuration.

json_db: set_modified after incomplete data

Set the JsonDB modified after `maybe_load_incomplete_data`
removed a corrupted patch. Otherwise we might not override
the file on disk, append more patches and lose them all again
on the next reload.

wallet_db: register onion_keys converter

`Channel.onion_keys` had no registered converter for hex -> bytes, causing
`pop_onion_key()` to return a hex str instead of bytes after the keys
got loaded from db following a restart.

qml: emit a single dataChanged when updating blockchain height

emit a single dataChanged signal over the whole model index range
once in `QETransactionListModel.updateBlockchainHeight()` instead
of emitting a separate signal for each transaction.

qml: don't compute notification balance delta for large tx batches

Don't compute the wallet balance delta for the new tx notification
shown after synchronizing the wallet if the notification batch
exceeds 10 txs. Otherwise the calculation will block the UI, especially
for large wallets with many new txs after initial sync.

qml: change event callback logs to debug

Change per-tx event callback logs to debug, might make the process
a bit less clogged if there are many txs.

qml: don't force-build address model from tx event handlers

The addressCoinModel property getter lazily constructs
QEAddressCoinListModel, whose __init__ runs a full (slow) initModel().
Instead of initializing it on a new transaction, blocking the UI,
just initialize it lazily when the user actually opens it.
Same pattern as importAddresses/importPrivateKeys.

qml: skip per-tx balance updates during sync

During synchronization, new_transaction fires for every incoming tx and
each balanceChanged emit makes QML recompute the balance on the GUI
thread. The balance isn't shown anyway during sync.

qml: QETransactionListModel: add txid->row index

Add a txid -> model row index dict to `QETransactionListModel`
instead of re-iterating the `tx_history` list on each event
to find the tx item.
This noticeably unblocks the UI during sync of a large wallet.

qml: android on-screen keyboard submit trigger accepted

qml: add wallets search option, allow loading hidden wallet iff search string
matches exact wallet name

update locale

update block header checkpoints

```
>>> network.export_checkpoints(f"/home/user/wspace/electrum/electrum/chains/{electrum.constants.net.NET_NAME}/checkpoints.json")
```

qt: fix crash through stale pi resolve

When multiple PIs get resolved consecutively through
repeated editing of the PI field, and the `on_resolve_done`
callback tries to access a PI that has been cleared by
a previous, failed callback an exception is raised.

I was able to reproduce this somehow by adding a sleep to
`PaymentIdentifier._do_resolve()` and entering lightning addresses.

Fixes https://github.com/spesmilo/electrum/issues/10724

(trivial) wallet: fix stale comment on on_event_invoice_status

The followup rename (_paid_invoice_keys -> _paid_invoice_keys_cache) and
the de-sloppify left this comment referring to the old name and claiming
the listener only tracks LN-driven changes; it is now the population path
for onchain invoices too.