What the developer wrote
Authored by Sander van Grieken
qml: improve HelpDialog styling
remove misalignment between pane and dialog, add bottom padding
What changed, and why it matters
This commit is a purely cosmetic update to a help dialog in Electrum's mobile-style QML user interface. It adjusts spacing, alignment, background colors, and padding so the dialog looks better. There is no security relevance.
No security action needed; this is a routine UI styling improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies electrum/gui/qml/components/controls/HelpDialog.qml, a QML UI component. Changes include adding an empty footer, setting dialog width to 4/5 of parent, darkening the modal overlay, making the dialog background transparent, binding rootPane width/height to parent, applying a lighter background color to the pane, and adding bottom padding. No logic, input handling, cryptography, networking, or data-flow changes are present.
Changed components
electrum/gui/qml/components/controls/HelpDialog.qmlInspect captured patch +16 / −5
diff --git a/electrum/gui/qml/components/controls/HelpDialog.qml b/electrum/gui/qml/components/controls/HelpDialog.qml
index 8d1b87d..ac7dac0 100644
--- a/electrum/gui/qml/components/controls/HelpDialog.qml
+++ b/electrum/gui/qml/components/controls/HelpDialog.qml
@@ -7,6 +7,7 @@ ElDialog {
id: dialog
header: Item { }
+ footer: Item { }
property string text
property string heading
@@ -18,20 +19,27 @@ ElDialog {
padding: 0
needsSystemBarPadding: false
- width: rootPane.width
+ width: parent.width * 4/5
Overlay.modal: Rectangle {
- color: "#55000000"
+ color: "#aa000000"
+ }
+
+ background: Rectangle {
+ color: "transparent"
}
Pane {
id: rootPane
- width: rootLayout.width + leftPadding + rightPadding
+ width: parent.width
+ implicitHeight: rootLayout.height + topPadding + bottomPadding
padding: constants.paddingLarge
-
+ background: Rectangle {
+ color: constants.lighterBackground
+ }
ColumnLayout {
id: rootLayout
- width: dialog.parent.width * 3/4
+ width: parent.width
spacing: constants.paddingLarge
RowLayout {
@@ -59,6 +67,9 @@ ElDialog {
color: 'transparent'
}
}
+ Item {
+ height: constants.paddingLarge
+ }
}
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.