AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 32 Bitcoin

qml: allow manual editing of fee/feerate also improve warning box styling consistency across finalizers, add CPFP new feerate > old feerate check, add relayfee checks for CPFP, DSCancel, proper warning string for no dynamic fee estimates

Public commit record

What the developer wrote

Authored by Sander van Grieken

73/100 · Adequate
qml: allow manual editing of fee/feerate
also improve warning box styling consistency across finalizers,
add CPFP new feerate > old feerate check,
add relayfee checks for CPFP, DSCancel,
proper warning string for no dynamic fee estimates
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
The short version

What changed, and why it matters

This commit adds a new 'Manual' fee mode to Electrum's QML (mobile-style) GUI, letting users type in an exact fee or fee rate. It also tightens safety checks for fee-bumping actions (CPFP, RBF bump, and RBF cancel) by warning when the new fee is too low to be relayed by the network or, in the case of CPFP, lower than the parent transaction's fee rate. The changes are mostly defensive UI hardening rather than a fix for an active vulnerability.

Recommended action

Review the manual-fee input sanitization (Decimal parsing, empty-string handling, and locale issues) and ensure the new relay-fee checks are consistently applied across all transaction finalizers, including the desktop GUI if it shares the same backend code.

Security signals we found

01

New manual fee/fee-rate input path in QML GUI

02

Added relay-fee validation before constructing RBF cancel and CPFP child transactions

03

Added CPFP combined-fee-rate must exceed parent fee rate check

04

Added explicit NoDynamicFeeEstimates handling with user-facing warning

05

Refactored CPFP child-fee calculation to separate total-fee vs total-feerate paths

Risk score

Why this scored 32/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 6/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.