Bitcoin Core

This commit removes three source files from the LevelDB build list in Bitcoin Core's CMake configuration. The files (c.cc, dumpfile.cc, histogram.cc) are reportedly unused. This is a routine build cleanup with no apparent security relevance.

This commit changes the Bitcoin Core Guix build scripts to stop using the 'sponge' tool from the 'moreutils' package. Instead of writing a checksum file directly through a pipeline, the scripts now write to a temporary file and then move it into place. This removes a third-party dependency from the trusted build environment, which is a hardening improvement rather than a fix for a known active vulnerability.

This commit only changes a Bitcoin Core test script. It disables certain file-permission and symlink checks when the test runs on Windows or as the root/admin user, because those checks rely on Unix-style behavior that doesn't apply in those environments. There is no change to the actual Bitcoin Core wallet software that users run, and no security vulnerability is being fixed or introduced.

This is a minor test-only change. It updates a single automated test in Bitcoin Core so that it checks for a stable, platform-independent error message ('Wallet file verification failed.') instead of a Windows-specific filesystem error string. There is no change to the actual Bitcoin Core wallet code that users run, and no security issue is present.

This commit is a simple cleanup of a test file. It takes one very long test function and splits it into smaller, named helper functions without changing what the test actually does. There is no change to Bitcoin Core's production code or to how wallets behave.

This commit only changes a test file. It reorganizes existing wallet-scanning tests so each error condition is checked separately, rather than lumping them together. There is no change to the actual Bitcoin Core wallet code, so it does not fix or introduce a security issue in the software users run.

This is a purely cosmetic code cleanup in a Bitcoin Core test file. It replaces repeated references to `self.nodes[0]` with a local variable named `node`. No production code, no behavior changes, and no security implications.

This commit simply removes an unused command-line option from a single test script. It is a cleanup change with no effect on Bitcoin Core's runtime behavior, network security, or user funds.

This is a test-only change that moves a single error-checking test case from one place to another within the same functional test file. It does not change any production code, wallet behavior, or security logic. The commit message explicitly calls it 'move-only'.

This is a harmless code cleanup in a test file. It moves some helper functions from inside a test method to the top of the file and renames one variable to avoid a Python language quirk. There is no change to Bitcoin Core's actual wallet behavior or security.

This is a small internal code cleanup in Bitcoin Core's transaction clustering/linearization logic. It replaces a loop that counted parent dependencies one-by-one with a faster set-difference count. There is no user-facing change, no network change, and no security-relevant behavior change.

This is a routine code optimization in Bitcoin Core's transaction clustering logic. It rewrites how one internal data structure (reachable transaction sets) is maintained when chunks of related transactions are split apart. The change is described by the author as a performance improvement and includes no indication of a security fix.

This is a pure performance optimization inside Bitcoin Core's transaction-cluster linearization code. It detects a common situation called a 'self-merge' earlier in the process and skips unnecessary work. There is no user-visible behavior change, no consensus change, and no security fix.

This commit is an internal refactoring of Bitcoin Core's transaction-cluster linearization code. It replaces a wasteful data structure (one 'SetInfo' per dependency) with a shared pool of SetInfos indexed separately from transactions. There is no user-facing change, no network protocol change, and no obvious security bug introduced. It is a preparation/cleanup change.

This commit refactors how Bitcoin Core launches external helper programs (used for hardware wallet signing). Previously, commands were passed as a single string that the library split into arguments automatically. Now, callers must provide the command and its arguments as a pre-split list. The change reduces the risk of shell-style injection or mis-parsing when command paths or arguments contain spaces or special characters, but it is a code-quality and hardening change rather than a fix for a known exploitable bug.

This commit fixes a typo in a comment inside a Guix codesigning helper script. The comment incorrectly named the build script as 'build.sh' when it should read 'codesign.sh'. No executable code was changed, so this has no effect on Bitcoin Core's behavior or security.

This commit changes two user-facing text strings in the Bitcoin Core wallet's PSBT (Partially Signed Bitcoin Transaction) dialog so they correctly use singular/plural forms in different languages. It is a localization/translation fix with no security relevance.

This commit is a cosmetic cleanup of debug log messages in Bitcoin Core. It removes extra spaces, fixes a couple of mismatched format specifiers (using %s instead of %i for a transaction ID), and makes a status string clearer. There is no security issue here.

This commit only adds a release note documenting that two old Bitcoin Core features, the `-paytxtxfee` startup option and the `settxfee` RPC, have been removed after being deprecated. It is a documentation-only change and does not modify any code.

This commit removes two old Bitcoin Core fee-setting mechanisms: the command-line option `-paytxfee` and the RPC command `settxfee`. These had already been marked as deprecated. Users must now set fees per transaction using explicit options like `fee_rate` instead of a global default. There is no security vulnerability here; it is a planned API cleanup that may break old scripts or workflows that still rely on the removed options.

This commit only renames variables and updates comments in Bitcoin Core's coin selection code. It changes names like 'descendants' to 'cluster_count' to make the code match what it actually does, with no change in behavior. There is no security issue here.

This is a code cleanup change that separates how fee rates are displayed (BTC/kvB versus sat/vB) from how fees are estimated. It introduces a new FeeRateFormat enum and removes display-only values from the FeeEstimateMode enum. There is no security fix or behavior change visible in the diff.

This commit is a simple code cleanup: it renames a local variable from 'descendant_count' to 'unused_cluster_count' in two wallet files to make clear that the value is not actually used. There is no functional change, no bug fix, and no security relevance.

This commit is a pure internal refactoring in Bitcoin Core. It adds a new optional tie-breaker function (called fallback_order) to the transaction graph (TxGraph) code, but explicitly does not use it yet. It is preparation for future work and does not change any network behavior, consensus rules, or security properties.

This is a code cleanup change in Bitcoin Core. It bundles the outputs of the 'createTransaction' function into a single result object instead of using separate reference arguments. The commit message says this makes the function less error-prone because the old way of passing back 'change position' and 'fee' through reference arguments had caused bugs before. There is no direct evidence in the diff of a currently exploitable security vulnerability being fixed.