What the developer wrote
Authored by Anthony Towns
util/stdmutex: Drop StdLockGuard
What changed, and why it matters
This commit removes a two-line backwards-compatibility type alias named StdLockGuard from a header file. It is a routine cleanup with no functional change to how the software behaves or to its security.
No security action needed. Treat as normal code-maintenance review.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff deletes using StdLockGuard = StdMutex::Guard; from src/util/stdmutex.h. The comment already indicated this alias was kept only for backwards compatibility and was intended to be removed. No call sites or locking logic are changed in this commit, and the remaining STDLOCK(...) macro and StdMutex::Guard remain intact.
Changed components
src/util/stdmutex.hInspect captured patch +0 / −2
diff --git a/src/util/stdmutex.h b/src/util/stdmutex.h
index 2cc05013..ab89a987 100644
--- a/src/util/stdmutex.h
+++ b/src/util/stdmutex.h
@@ -40,6 +40,4 @@ public:
// Provide STDLOCK(..) wrapper around StdMutex::Guard that checks the lock is not already held
#define STDLOCK(cs) StdMutex::Guard UNIQUE_NAME(criticalblock){StdMutex::CheckNotHeld(cs)}
-using StdLockGuard = StdMutex::Guard; // TODO: remove, provided for backwards compat only
-
#endif // BITCOIN_UTIL_STDMUTEX_H
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.