SW
← All projectsSparrow

Sparrow Wallet

Desktop Bitcoin wallet focused on security, privacy, multisignature, and hardware signers.

BitcoinHardware integrationSoftware walletsNormal
Repository coverage

630 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

102security candidates447second-pass queue606AI analyses
181commits · 30 days
220commits · 60 days
411commits · 180 days
584commits · 365 days
Backfill bands
Aug 5 → Feb 6100 seen9 candidatesComplete
Feb 6 → Jun 6128 seen15 candidatesComplete
Jun 6 → Jul 67 seen1 candidatesComplete
Jul 6 → Aug 546 seen8 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

49/100 average clarity
0Strong · 80–100
55Adequate · 60–79
520Thin · 40–59
55Opaque · 0–39
3security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Craig Raw61398589949
doblon8313048
Michele Balistreri212048
nzb-tuxxx212060
nroktib111050
Liz Lightning202045
Aaron Leeb101060
PeterXMR101045
craigraw101060
Ian McKenzie101050
Jan Dvořák101050
Kevin Abramczyk101050
Analysis record

Published AI watches

Last scanned 24 minutes ago

Informational 18 AI analysisMessage 60 · Adequate
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

document building v2.5.3 to v2.5.6 with lenient dependency verification, as two pom files were later republished to maven central with additional metadata

This commit only updates documentation. It explains that when building older Sparrow Wallet releases (versions 2.5.3 through 2.5.6), two dependency files on Maven Central were later republished with extra descriptive metadata, causing a ha…

Dependency checksum mismatch in recorded verification metadataPOM-only republication of two Sparrow-published artifacts (hid4java, usb4java)Documentation instructs lenient verification for reproducible builds of older releases
6a83c9a5by Craig Raw+15−01 file
No security note in commit
Low 34 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

warn that a bip353 name resolved to a silent payment address for a different network on the send tab and in send to many, rather than reporting it has no address

This commit improves user-facing error messages in the Sparrow Wallet when a BIP353 human-readable name (like a DNS-based Bitcoin payment alias) resolves to a silent payment address meant for a different Bitcoin network (for example, testn…

BIP353 DNS payment resolutionsilent payment address network mismatchuser-facing warning improvement
08f32515by Craig Raw+6−13 files
No security note in commit
Low 26 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

skip the keepalive ping while another request is awaiting its response

This change stops Sparrow Wallet from sending unnecessary 'are you still there?' keepalive pings when another request is already waiting for an answer. On some Electrum server backends (notably electrs), a ping would queue up behind the pe…

Avoidance of redundant keepalive pings that could delay synchronizationNew transport-level predicate exposing in-flight request stateUnit test added to assert correct pending-request lifecycle
4df18311by Craig Raw+50−13 files
No security note in commit
Low 38 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

wait for a slow electrum server response instead of resending the request, halving batch page sizes only after a request goes unanswered, and retry the keepalive ping once

This commit changes how the Trezor hardware wallet app talks to Bitcoin servers when responses are slow. Previously, the app would quickly resend a request if it didn't get an answer in time, and each timeout would double the wait and halv…

Change to timeout/retry logic that could affect denial-of-service resilienceReduction in retry count for keep-alive pings from 5 to 2Avoidance of duplicate request sending to slow servers, reducing amplification
96d217cfby Craig Raw+84−194 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

reduce the minimum window width to 750, fitting the send tab, transaction diagram and transaction tab views to narrow windows and narrowing the wallet menu and transaction tree below 900

This commit is a user-interface layout tweak for the Sparrow Wallet desktop app. It makes the main window usable at narrower widths by shrinking minimum sizes, wrapping labels, and making diagrams and menus responsive. There is no security…

86e52311by Craig Raw+117−4717 files
No security note in commit
Moderate 61 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

check a proof that does not reconstruct against the server chain before reporting it, as a server can report a transaction on a branch before announcing its tip

This commit fixes a bug in how Sparrow Wallet checks Bitcoin transaction proofs from an Electrum server. Previously, if a server had switched to a different blockchain branch (for example due to a reorganization) but had not yet announced …

Merkle proof verification bypass/relaxation under reorganization windowServer-side blockchain state synchronization before proof validationRisk of false-negative proof rejection leading to incorrect transaction confirmation status
f7357906by Craig Raw+91−22 files
No security note in commit
Low 33 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

decide whether a border wallets grid is hex from all of its cells rather than the selected ones

This commit fixes a bug in Sparrow Wallet's 'Border Wallets' feature. Previously, the app guessed whether a grid of seed-word abbreviations was hexadecimal (base-16) by looking only at the cells the user selected. If a user happened to pic…

Incorrect input classification leading to wrong BIP39 word derivationWallet seed/recovery correctness issueUI dialog parsing bug in mnemonic grid import
0d4f1482by Craig Raw+9−61 file
No security note in commit
Low 43 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

leave qr codes that zbar can only return as transcoded text to the other scanners

This commit fixes a bug in how Sparrow Wallet reads QR codes using the ZBar scanner. ZBar converts binary QR code data into text and silently stops at the first null byte, which can corrupt non-text data. The fix makes Sparrow only trust Z…

Data integrity issue in QR code parsingReliance on lossy text conversion for binary dataSilent truncation at NUL byte
0c28eafeby Craig Raw+25−12 files
No security note in commit
Low 27 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

save the freeze status and labels of nested wallet outputs to the wallet that stores them

This commit fixes a bookkeeping bug in Sparrow Wallet for users who have a main wallet with nested sub-wallets (for example, PayNym-style wallets). Previously, when you froze an unspent coin or changed its label, the change was recorded ag…

State-persistence bug: freeze/label changes for nested-wallet UTXOs were saved to the wrong walletUI/event routing now keyed by owning wallet rather than display walletNew unit tests added to assert correct ownership semantics
5c47c3a4by Craig Raw+116−2611 files
No security note in commit
Moderate 58 AI analysisMessage 62 · Adequate
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

keep the encrypted master secret of imported slip39 shares, so that the wallet decrypts it with any passphrase as the shares do

This commit fixes how Sparrow Wallet stores the backup/recovery seed when a user imports a wallet using SLIP39 shares (a type of multi-share mnemonic backup). Previously, the wallet decrypted the shares with the passphrase entered at impor…

SLIP39 passphrase handling changed from one-time decryption to persistent encrypted master secretStored seed now derives correct keys regardless of which passphrase is later usedNew unit test explicitly checks passphrase-variant key derivation parity
9b998a78by Craig Raw+47−43 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

keep the monospaced font of utxo addresses when the table is refreshed

This is a minor user-interface bug fix. It ensures that Bitcoin addresses in the wallet's UTXO list keep their fixed-width (monospaced) font after the table is refreshed. There is no security issue here.

868fa081by Craig Raw+2−11 file
No security note in commit
Low 46 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

refuse descriptors that do not derive on the standard receive and change chains when importing a wallet or keystore, and warn of them in the descriptor editor

This commit tightens how Sparrow Wallet handles Bitcoin output descriptors imported from files, hardware wallets, QR codes, and the descriptor editor. It now rejects (or warns about) descriptors whose key paths don't follow the standard 'r…

New validation of BIP32 derivation paths on all descriptor import pathsRejection of descriptors with non-standard receive/change chains during wallet/keystore importWarning (but not rejection) retained for descriptor editor where user can amend the descriptor
3d2fbac4by Craig Raw+23−910 files
No security note in commit
Moderate 58 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

apply the child derivations of keys in scanned output descriptors, and refuse those that do not derive on the standard chains

This commit changes how Sparrow Wallet handles QR code and file imports of Bitcoin wallet descriptors. Previously, when scanning a descriptor from a QR code, the wallet might ignore or mishandle 'child derivation' paths that tell it how to…

Input validation added for scanned output descriptor child derivationsRejection of non-standard child derivation chainsConsistent application of child derivations between QR/file import and text descriptor parsing
6a000160by Craig Raw+290−403 files
No security note in commit
Moderate 60 AI analysisMessage 55 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

refuse an extended private key in place of an xpub in imported wallet files, and use the public key of a private hdkey in a scanned output descriptor

This commit fixes a security issue in Sparrow Wallet where wallet import files or QR scans that were supposed to contain only public extended keys (xpubs) could accidentally or maliciously contain private extended keys (xprvs). The wallet …

Rejection of extended private keys where extended public keys are expectedPublic-key derivation from private HD keys in scanned output descriptorsAddition of defensive validation helper across multiple wallet import formats
97742cabby Craig Raw+52−298 files
Vendor flagged security relevance
Informational 19 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

let the terminal user choose the script type when transactions are found for more than one

This change improves the Sparrow Wallet terminal (command-line) interface. Previously, if the wallet discovery process found transactions matching more than one Bitcoin script type, it would silently pick the first one. Now it shows a menu…

Behavioral fix: prevents silent selection of first discovered wallet script typeUser-choice dialog added in terminal wallet creation flowNo cryptographic, network, or input-validation changes observed
a18db115by Craig Raw+18−41 file
No security note in commit
Low 33 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

use the bip352 derivation for silent payment wallets imported from a mnemonic or device, created in the terminal, scanned from a seedqr or added at another account

This commit changes how Sparrow Wallet picks the derivation path when creating or importing wallets. It makes the wallet choose BIP-352 (silent payments) paths when the wallet policy is a single-key silent-payment wallet, instead of always…

Derivation-path selection now depends on policy type, which can change wallet fingerprint/address generation for silent-payment walletsBroad surface area (12 files) increases risk of an import path being missed or behaving differentlySubmodule bump (drongo) likely contains the actual ScriptType.getDefaultDerivation(PolicyType) implementation, but its diff is not supplied
002b1b58by Craig Raw+41−3012 files
No security note in commit
Low 37 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

replace control characters in cosigner labels of an imported multisig configuration, and size alerts to include blank lines

This commit makes two small UI fixes in Sparrow Wallet. First, it strips hidden control characters from cosigner labels when importing a shared multisig wallet setup, preventing odd or misleading label display. Second, it fixes alert dialo…

Sanitization of user-supplied labels (control/format characters replaced)UI dialog sizing fix to prevent content clippingNo explicit security framing in commit message or diff
c1d4feeaby Craig Raw+3−12 files
No security note in commit
Low 34 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

truncate address, purpose node and keystore labels when updating a wallet, as a full save does

This commit fixes a bug where Sparrow Wallet's database update path failed to shorten (truncate) long labels for wallet addresses, purpose nodes, and keystores before saving them. The full save path already did this truncation, but the inc…

Data-integrity bug: inconsistent truncation between full save and incremental updatePotential denial-of-service against local wallet state via overly long labelsRegression test added to prevent future recurrence
0721ca98by Craig Raw+50−52 files
No security note in commit
Low 32 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

refuse the bwt fallback for bitcoin core over https and ignore the legacy wallet setting for it

This commit changes Sparrow Wallet so that when it connects to a Bitcoin Core node over HTTPS, it no longer falls back to an older 'BWT' connection method and no longer tries to use legacy Bitcoin Core wallets. The change appears to be a h…

Disables legacy wallet handling for HTTPS Bitcoin Core connectionsRemoves BWT fallback for HTTPS Bitcoin Core connectionsForces Bitcoin Core v24+ requirement for HTTPS connections
b935568aby Craig Raw+8−22 files
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
SW SparrowSparrow Wallet BitcoinHardware integrationSoftware wallets

check rsa server certificates against the ca trust store for the key exchange in use

This one-line change fixes how Sparrow Wallet checks a Bitcoin server’s TLS certificate. Previously, when the server used an RSA certificate, the app told Java’s certificate validator to expect an old-style RSA key exchange ("RSA"). That w…

TLS certificate validation logic changedX509TrustManager.checkServerTrusted authType correctedPotential for certificate acceptance/rejection mismatch before fix
1071ed7cby Craig Raw+1−11 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedpersist silent payment address mappings for safe rbf of sp-sending transactionsby Craig Raw · e985a03a · May 18, 2026 · 10 filesMessage 50 · ThinLow 30Details
Commit message · Craig Raw

persist silent payment address mappings for safe rbf of sp-sending transactions

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100

This commit adds a safety feature for a new Bitcoin privacy technology called 'silent payments.' It records the relationship between a regular-looking payment address and its silent-payment counterpart in the wallet's database. The main goal is to prevent users from accidentally breaking silent-payment outputs when they later modify (RBF) a transaction, such as by removing inputs. The commit also blocks one risky UI action with a warning dialog when such a change would be unsafe.

AI review queuedrelease electrum transport read lock during socket reads to avoid client request starvationby Craig Raw · 273d2aac · May 15, 2026 · 1 fileMessage 62 · AdequateLow 31Details
Commit message · Craig Raw

release electrum transport read lock during socket reads to avoid client request starvation

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Explains rationale or failure mode! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100

This commit fixes a concurrency bug in Sparrow Wallet's Electrum server connection code. Previously, a single read lock was held continuously while waiting for data from the server, which could starve or block other client requests. The change releases that lock during socket reads and restructures the read loop so responses are delivered only when the lock is held. This is a reliability/performance fix that reduces the chance of the wallet becoming unresponsive or misbehaving when talking to an Electrum server, but it is not a direct theft-of-funds vulnerability.

AI review queuedrestrict to required sighash types when sending sp outputsby Craig Raw · 97383a4e · May 15, 2026 · 2 filesMessage 50 · ThinLow 42Details
Commit message · Craig Raw

restrict to required sighash types when sending sp outputs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 42/100

This commit tightens which Bitcoin signature hash (sighash) types users can pick when sending to a silent payment address. Previously the UI offered all normal signing options; now it forces the recommended/required sighash (ALL for non-taproot, DEFAULT for taproot) and labels it as required. The change is defensive: using the wrong sighash type with silent payments could break privacy or make the transaction invalid, so the wallet now prevents that choice.

AI review queuedhide receive actions for address entry cells in sp walletsby Craig Raw · 712750a2 · May 15, 2026 · 1 fileMessage 50 · ThinLow 32Details
Commit message · Craig Raw

hide receive actions for address entry cells in sp wallets

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 32/100

This commit removes the 'Receive To' button and menu option for a specific type of wallet called a 'single sig single purpose' (SINGLE_SP) wallet. Previously, these receive actions were shown for all wallets except BIP47 (PayNym) wallets. The change appears to be a UI hardening measure to prevent users from accidentally or inappropriately reusing addresses in wallets that are intended to be used only once.

AI review queuedhide wallet rescan hyperlink when nothing further can be scannedby Craig Raw · 1be9ac10 · May 14, 2026 · 7 filesMessage 50 · ThinInformational 17Details
Commit message · Craig Raw

hide wallet rescan hyperlink when nothing further can be scanned

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit is a user-interface polish change for the Sparrow Wallet desktop app. It hides the 'Rescan Wallet' hyperlink when the wallet has already been scanned as far back as possible, and shows a helpful label instead. There is no indication it fixes a security vulnerability.

AI review queuedswitch electrum server notification detection to streaming json token parseby Craig Raw · 1ad237c6 · May 14, 2026 · 1 fileMessage 50 · ThinLow 49Details
Commit message · Craig Raw

switch electrum server notification detection to streaming json token parse

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 49/100

This commit changes how Sparrow Wallet decides whether a message from an Electrum server is a subscription notification. Previously it used a simple text search (looking for the word 'method' and absence of the word 'error'), which could be fooled by JSON strings containing those words. Now it uses a proper JSON parser to check whether the message actually has a 'method' field at the top level. This is a hardening fix: the old approach could misclassify server responses, possibly causing user notifications to be missed or processed incorrectly. There is no direct evidence in the commit that this was exploited or treated as a security bug by the vendor.

AI review queuedpreserve sp scan cache cancellation across widening rollbackby Craig Raw · 7e4aaacd · May 13, 2026 · 1 fileMessage 50 · ThinLow 31Details
Commit message · Craig Raw

preserve sp scan cache cancellation across widening rollback

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100

This commit fixes a small logic bug in how Sparrow Wallet caches scans for silent payments (a privacy-preserving way to receive Bitcoin). During a specific multi-step process called 'widening rollback,' if the user or a server disconnect had already cancelled the scan, the code could accidentally un-cancel it and restore old cached data. The fix simply checks 'if already cancelled, stay cancelled' before restoring the snapshot. It is a correctness/reliability fix rather than a direct theft-of-funds vulnerability, but it could cause the wallet to miss or misreport silent-payment transactions after a cancellation.

AI review queuedpre-populate sp self-spend node outputs to avoid partial first notificationby Craig Raw · 60d4cce1 · May 13, 2026 · 1 fileMessage 62 · AdequateInformational 23Details
Commit message · Craig Raw

pre-populate sp self-spend node outputs to avoid partial first notification

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Explains rationale or failure mode! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 23/100

This commit fixes a display timing issue in the Sparrow bitcoin wallet. When a user makes a payment to themselves (a 'self-spend'), the wallet could briefly show an incomplete transaction notification—showing the money leaving but not the matching change coming back. The patch pre-fills internal wallet records so the first notification is complete and accurate. It is a correctness/UX fix, not a vulnerability that lets an attacker steal funds.

AI review queuedincrease read timeouts when tor is configuredby Craig Raw · 7afb27b3 · May 12, 2026 · 1 fileMessage 45 · ThinInformational 21Details
Commit message · Craig Raw

increase read timeouts when tor is configured

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This commit adjusts network waiting periods when Sparrow Wallet connects to a Bitcoin server through the Tor privacy network. It gives Tor connections slightly more time before retrying, likely to reduce false failures caused by Tor's slower routing. There is no indication this fixes an exploitable security flaw.

AI review queuedremove bisq broadcast sourceby Craig Raw · 8f56e950 · May 12, 2026 · 1 fileMessage 35 · OpaqueInformational 19Details
Commit message · Craig Raw

remove bisq broadcast source

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit removes one of several ways Sparrow Wallet can broadcast Bitcoin transactions to the network. The deleted code supported broadcasting through Bisq's market service (both a clearnet website and a Tor onion address). It is a simple feature removal with no obvious security bug being fixed in the code itself.

AI review queueddiscard stale electrum responses with mismatched idsby Craig Raw · 1a5f97ce · May 12, 2026 · 2 filesMessage 50 · ThinModerate 57Details
Commit message · Craig Raw

discard stale electrum responses with mismatched ids

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This commit changes how Sparrow Wallet's connection to Electrum servers handles replies. Previously, the app tried to match an entire sent request object to a received response object to decide if the reply belonged to the current request. The new code instead compares only the numeric 'id' fields found in the JSON, and keeps reading and discarding any responses whose ids don't match. It also adds optional wire-level logging. The change is a defensive fix against 'stale' or out-of-order server responses being mistaken for the answer to the current request.

AI review queuedupdate bisq broadcast source urlsby Craig Raw · db3ebdb3 · May 12, 2026 · 1 fileMessage 45 · ThinInformational 18Details
Commit message · Craig Raw

update bisq broadcast source urls

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit simply swaps the web and Tor addresses used by Sparrow Wallet to broadcast Bitcoin transactions through the Bisq mempool service. It changes one line in a list of broadcast sources, replacing 'mempool.bisq.services' with 'markets.bisq.network' and updating the corresponding onion address. There is no code logic change and no indication of a security vulnerability being fixed.

AI review queuedimprove wallet update behaviour for silent payment self-sendsby Craig Raw · 0b012995 · May 12, 2026 · 1 fileMessage 50 · ThinLow 35Details
Commit message · Craig Raw

improve wallet update behaviour for silent payment self-sends

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit fixes how Sparrow Wallet updates its internal records when a user sends bitcoin to themselves using a 'silent payment' address. Previously, the wallet could fail to mark the coins being spent as spent, or could show an incorrect balance, because the wallet's update logic did not properly handle transactions discovered through the silent-payment channel. The patch makes the wallet consider both newly discovered silent-payment outputs and the inputs they spend in a single atomic update, and it also improves how broadcast transactions are tracked before they are sent to the network.

AI review queuedprevent tweakless address nodes in sp walletsby Craig Raw · 9b123617 · May 8, 2026 · 2 filesMessage 45 · ThinModerate 54Details
Commit message · Craig Raw

prevent tweakless address nodes in sp wallets

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 54/100

This commit changes how Sparrow Wallet creates address nodes when scanning silent payments. Previously, the wallet would fill a range of address indexes up to a target and then mark the matching one as a 'silent payment tweak' address. The new code adds a dedicated method that creates only the single silent-payment child node with its tweak value already set. The change appears intended to prevent silent-payment addresses from being created without their associated tweak data, which could otherwise lead to incorrect or missing balance tracking in single-sig (sp) wallets.

AI review queuedrefactor transaction diagram to dispatch on output wrapper typesby Craig Raw · 201d4b83 · May 7, 2026 · 6 filesMessage 50 · ThinInformational 11Details
Commit message · Craig Raw

refactor transaction diagram to dispatch on output wrapper types

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 11/100

This commit is a code cleanup in Sparrow Wallet's transaction diagram display. It changes how the wallet classifies and draws transaction outputs on screen, introducing new output wrapper types for silent-payment change and consolidation. There is no direct evidence in the commit that it fixes a security vulnerability; it appears to be a UI refactor with minor correctness improvements.

AI review queuedfix sp self-spend output discovery by always scanning all batch txsby Craig Raw · ab6416f3 · May 6, 2026 · 1 fileMessage 50 · ThinModerate 51Details
Commit message · Craig Raw

fix sp self-spend output discovery by always scanning all batch txs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 51/100

This commit fixes a bug in Sparrow Wallet's silent payments feature. Previously, when scanning for incoming silent payments, the wallet only looked at transactions it had not already seen. This meant it could miss a special kind of transaction: one where the user sends bitcoin to themselves (a 'self-spend'). Because the wallet already knew about the transaction, it skipped re-scanning it for silent payment outputs, potentially causing the wallet to not display or account for those funds. The fix makes the wallet scan all relevant transactions, whether already known or not.

AI review queuedrefactor transaction history fetch methodby Craig Raw · e96a7113 · Apr 30, 2026 · 1 fileMessage 45 · ThinInformational 12Details
Commit message · Craig Raw

refactor transaction history fetch method

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit is a straightforward internal code cleanup: it moves the logic that fetches wallet transaction history out of a nested background-service class and into the main ElectrumServer class. The actual behavior, synchronization, and data flow remain essentially unchanged. There is no indication this fixes or introduces a security issue.

AI review queuedadd silent payments rpc methods, capability check and notification dispatchby Craig Raw · abe1f9c9 · Apr 29, 2026 · 17 filesMessage 50 · ThinInformational 20Details
Commit message · Craig Raw

add silent payments rpc methods, capability check and notification dispatch

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit adds support for a new Bitcoin privacy feature called 'silent payments' in the Sparrow Wallet. It lets the wallet ask compatible servers to scan for silent-payment transactions and report them back. The change also improves how Sparrow detects what a server can do, and it makes one error type more specific when Bitcoin Core cannot handle silent payments. There is no obvious security bug in the diff, but it does involve sending private scanning keys to an external server, which is inherent to the silent-payments protocol and is now done through a new RPC call.

AI review queuedadd all singlesig importers to sp airgapped keystore importby Craig Raw · 69aef9c2 · Apr 28, 2026 · 2 filesMessage 50 · ThinInformational 19Details
Commit message · Craig Raw

add all singlesig importers to sp airgapped keystore import

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit expands the list of hardware-wallet and air-gapped importers that Sparrow Wallet shows when a user creates a single-signature wallet using a 'single SP' policy type. Previously only ColdcardSinglesig was offered; now all singlesig file importers (Jade, Keystone, Passport, SeedSigner, etc.) and all card importers (Tapsigner, Satochip, etc.) are available. The change also broadens an exception handler in SpecterDIY so that non-IO errors during import are reported to the user instead of crashing or being swallowed. There is no direct security vulnerability in the diff; it is a feature/robustness improvement.

AI review queuedupdate bitview logoby Craig Raw · 630ce0f3 · Apr 27, 2026 · 2 filesMessage 28 · OpaqueInformational 15Details
Commit message · Craig Raw

update bitview logo

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply swaps one SVG logo image for another in the Sparrow Wallet application. It changes the visual icon used for the BitView fee-rate source from a plain square to a stylized cube logo. There is no code change, no executable logic, and no security-relevant behavior.

AI review queuedavoid unnecessary xpub string roundtripby Craig Raw · 6cefec5c · Apr 27, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Craig Raw

avoid unnecessary xpub string roundtrip

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a small internal cleanup: it stops converting a hardware wallet's extended public key (xpub) to a text string and back again, and instead keeps it as a typed object throughout the code. There is no visible user-facing change and no indication of a security fix.

AI review queuedsupport retrieving silent payments spscan keys via connected devicesby Craig Raw · f5ee7bf2 · Apr 27, 2026 · 6 filesMessage 50 · ThinInformational 20Details
Commit message · Craig Raw

support retrieving silent payments spscan keys via connected devices

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit adds support for importing a special Bitcoin 'silent payments' scanning key from connected hardware wallets, while explicitly blocking three types of smartcards (Tapsigner, Keycard, Satochip) from being used with silent-payment wallets because they cannot support it. It is a feature addition, not a fix for an active security flaw.

AI review queuedhide gap limit field for sp walletsby Craig Raw · 0bb5e931 · Apr 23, 2026 · 2 filesMessage 45 · ThinInformational 21Details
Commit message · Craig Raw

hide gap limit field for sp wallets

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This commit hides the 'gap limit' setting from the user interface for single-signature single-key (SP) wallets. The gap limit controls how many unused addresses Sparrow scans ahead for transactions. For this specific wallet type, the setting is now hidden because it is not applicable or could confuse users. There is no direct security vulnerability in the code change itself; it is a UI cleanup change.

AI review queuedimplement silent payments receive uiby Craig Raw · 1c5602aa · Apr 23, 2026 · 5 filesMessage 45 · ThinInformational 15Details
Commit message · Craig Raw

implement silent payments receive ui

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds user-interface support for receiving Bitcoin 'silent payments' in Sparrow Wallet. It changes how receive addresses are displayed and copied when the wallet uses the new SINGLE_SP policy type. There is no security vulnerability visible in the diff; it is a feature implementation.

AI review queuedadd initial support for sp walletsby Craig Raw · 17a04510 · Apr 22, 2026 · 25 filesMessage 45 · ThinLow 28Details
Commit message · Craig Raw

add initial support for sp wallets

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit adds initial support for a new type of Bitcoin wallet called 'silent payments' (abbreviated as 'sp' or 'SINGLE_SP') to the Sparrow Wallet application. It updates many parts of the user interface and storage logic so that these wallets can be created, displayed, exported, and used alongside existing single-key and multi-key wallets. The changes are broad but appear to be a normal feature addition rather than a fix for a known security flaw.