Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit removes a former Monero maintainer's GPG key from the list of trusted keys used by the GUI wallet's automatic updater. It is a routine trust-list cleanup after a maintainer left the project, not a fix for an active security fla…
Removal of a trusted GPG key from the software-update trust anchor setChange affects the built-in GUI updater's maintainer verification list
This commit adds a new command-line option --ssl-check and runs it in CI. The check makes a simple HTTPS request to the Monero website to confirm SSL/TLS certificate validation is working in the build. It is a testing/diagnostic addition, …
Adds SSL/TLS connectivity self-testUnsets SSL_CERT_FILE/SSL_CERT_DIR in CI to test default certificate validation pathHidden CLI option not exposed in help
This commit changes the macOS build instructions to install a specific, pinned version of OpenSSL (version 3) rather than whatever the latest version happens to be. It also tells the build system exactly where that pinned version is locate…
Pins a critical cryptographic dependency (OpenSSL) to a known major versionAdds explicit OPENSSL_ROOT_DIR to prevent CMake from picking up an unintended OpenSSL installationReduces supply-chain risk from unpinned Homebrew formula updates
This merge changes how text is shown in the Monero GUI wallet. The main goal appears to be preventing rich-text formatting (HTML-like markup) from being interpreted in places where untrusted data could appear, such as scanned QR codes, dia…
Multiple QML text elements switched from AutoText/default to Text.PlainTextStandardDialog content area defaulted to TextEdit.PlainText instead of TextEdit.AutoTextQRCodeScanner removed MessageDialog usage and routes errors through informationPopup
This commit adds a new automated test that runs in the project's continuous integration (CI) pipeline. The test launches the Monero GUI wallet with a hidden '--ssl-check' flag, which tries to download a small file over HTTPS from the offic…
New hidden CLI flag added for SSL/TLS connectivity validationCI runs SSL check against real external endpoint (web.getmonero.org)Environment variables SSL_CERT_FILE and SSL_CERT_DIR are explicitly unset during CI test to ensure bundled certificates are used
This commit changes the macOS build instructions in an automated workflow so that the build explicitly uses OpenSSL version 3 instead of whatever version Homebrew currently provides by default. It is a build-hardening change, not a fix for…
Dependency version pinning in CI/CD workflowExplicit OPENSSL_ROOT_DIR to avoid picking up a different OpenSSL installationBuild reproducibility / supply-chain hardening
This is a small user-interface improvement for the Monero GUI wallet. When a user checks a 'reserve proof' (a cryptographic receipt showing how much Monero an address holds), the result popup now also shows the unspent amount. The code als…
No security-relevant signal: UI-only change adding an unspent amount label to reserve proof checksDefensive initialization of local output variables (good=false, total=0, spent=0), which is good practice but not a fix for an observed bug
This update fixes how the Monero GUI reads OpenPGP public keys. Previously, the software might have accepted a revoked (cancelled) subkey, or used an older signature that allowed signing even when a newer one did not. The patch now rejects…
OpenPGP subkey revocation not previously enforcedBinding signature selection did not consider creation time, allowing stale signing-capable signatures to override newer non-signing onesMarker/Trust packets now skipped without terminating subkey signature sequence
This commit updates the Monero GUI's message/file signing feature so users can now sign with any wallet subaddress, not just the main address. It also disables signing for hardware-backed and view-only wallets, shows clearer error messages…
Signing now bound to a user-selected wallet address/subaddress, reducing risk of signing under an unintended primary addressHardware-backed and view-only wallets are explicitly prevented from signing in the UIError handling added for failed sign operations
This is a user-interface performance patch for the Monero wallet app. It rewrites how the Account and Receive pages display long lists of subaddresses, replacing a layout that loaded every item at once with a scrollable list that reuses it…
No direct security signal in diff: no cryptographic, network, or wallet-seed handling changesOne defensive guard added: bounds check on subaddressListView.currentIndex before accessing wallet subaddress dataOne variable rename fixes a typo but has no security effect
This commit is a minor user-interface improvement for the Monero GUI wallet. When a user checks a 'reserve proof' (a cryptographic attestation about how much Monero is held and spent), the result dialog now also shows the 'unspent' amount.…
This change fixes how the Monero GUI reads OpenPGP public keys. Previously, the software might accept a revoked (cancelled) subkey or use an older signature that allowed signing even when a newer one did not. After the patch, revoked subke…
OpenPGP subkey revocation now enforcedBinding signature selection changed from first-match to newest-by-creation-timeMarker and Trust packets now explicitly skipped without terminating subkey signature sequence
This commit changes how the Monero wallet's user interface displays text that comes from outside sources. It switches several labels and dialogs from rich text (which can include formatting, links, or hidden instructions) to plain text, re…
Multiple QML text elements switched from AutoText/RichText-capable defaults to Text.PlainTextStandardDialog default textFormat changed from TextEdit.AutoText to TextEdit.PlainTextQR scanner MessageDialog removed; scanned data errors now shown through a controlled popup as plain text
This commit updates the Monero GUI wallet's signing feature so users can now sign messages and files using any wallet subaddress, not just the main address. It also disables signing for hardware-backed and view-only wallets, shows clearer …
Signing UI now disabled for hardware-backed wallets (isHwBacked) and view-only wallets (viewOnly)Backend error strings are now displayed to the user instead of silently failingForeign / non-wallet addresses are rejected by the underlying wallet implementation and produce an error dialog
This commit only updates the version pointer of an embedded dependency called 'quirc' (a QR-code decoding library) inside the Monero GUI repository. The actual code changes are not shown in the diff because the dependency is stored as a se…
This change tightens how the Monero GUI wallet handles its network proxy settings. Previously, the wallet's proxy address could be changed from many places in the app, which could let a bug or malicious UI flow silently switch traffic to a…
Removal of writable proxy address setter reduces attack surface for proxy misconfigurationCentralizes proxy reconnection logic in a single helper functionPrevents QML binding from silently overriding proxy address
This change hardens how the Monero GUI opens a printable PDF seed template. Previously, the app copied a bundled PDF to a predictable temporary path and opened it without checking whether the file had been tampered with. Now it creates a p…
Local file integrity verification added (SHA-256) before opening an embedded PDFPredictable temporary file path replaced with QTemporaryDir unique directoryReturn-value handling added so QML can surface verification failures to the user
This patch fixes a user-interface freeze in the Monero GUI wallet when using the 'sweep unmixable outputs' feature. The old code called a synchronous (blocking) function that could hang the interface; the new code uses an asynchronous call…
UI freeze / denial-of-service to the local user when sweeping unmixable outputsObject lifetime change in PendingTransaction parent assignmentNo input validation, cryptographic, or network security changes visible
This commit is a large cleanup and hardening of the OpenPGP signature verification code used by the Monero GUI's automatic updater. It adds stricter parsing of armored PGP data, validates armor headers and checksums, rejects unexpected sig…
Custom cryptographic code was significantly hardenedSignature verification now rejects unsupported signature typesArmor parsing now validates headers, tails, base64 alphabet, and CRC24
This commit is a user-interface cleanup, not a security fix. It moves the existing password-strength meter into a reusable component and adds it to the password-change dialog. The actual password-strength calculation is still performed by …
Don't try negative numbers when translating "%n second(s) ago"-style strings
When the local clock is running behind, transactions may appear to have been confirmed in the future, which seems to leave the %n in "%n second(s) ago" unreplaced, so round negative times ago to 0
Ref: #3284
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
✓ Subject identifies a change✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI review queuedp2pool v4.12by SChernykh · 7c6138ea · Nov 5, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · SChernykh
p2pool v4.12
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit simply updates the Monero GUI wallet to download and verify version 4.12 of the bundled P2Pool mining software instead of version 4.11. It changes download URLs, filenames, and the matching SHA-256 hashes for Windows, Linux, and macOS. There is no code change to how downloads are performed or verified, and no security issue is visible in the diff itself.