What changed, and why it matters
This commit updates the Monero GUI's message/file signing feature so users can now sign with any wallet subaddress, not just the main address. It also disables signing for hardware-backed and view-only wallets, shows clearer error messages, and adds tests. There is no direct evidence this is a security fix for an active vulnerability; it reads as a feature enhancement with defensive hardening.
Treat as a normal feature/hardening merge. Review the underlying wallet library's `signMessage(address)` implementation to confirm it validates the address belongs to the wallet and rejects invalid or foreign addresses safely. No urgent action required based on this diff alone.
Security signals we found
Signing now bound to a user-selected wallet address/subaddress, reducing risk of signing under an unintended primary address
Hardware-backed and view-only wallets are explicitly prevented from signing in the UI
Error handling added for failed sign operations
New test coverage for address-belonging validation and disabled signing paths
Evidence from the diff
The merge adds an optional address parameter to Wallet::signMessage() and wires it through to the underlying m_walletImpl->signMessage(..., signingAddress). The QML Sign page now exposes a ‘Signing address’ field, auto-selects the current subaddress account, disables the signing UI for hardware or view-only wallets, and surfaces signing errors via a new MessageDialog. A QML test suite verifies subaddress signing, hardware/view-only disabling, and error handling. The viewOnly property is marked CONSTANT in the header.
Changed components
pages/Sign.qmlsrc/libwalletqt/Wallet.cppsrc/libwalletqt/Wallet.htests/qml/tst_Sign.qmlInspect captured patch +324 / −10
### pages/Sign.qml
@@ -38,11 +38,35 @@ Rectangle {
property alias signHeight: mainLayout.height
property bool messageMode: true
property bool fileMode: false
+ property int lastActiveSigningAccount: -1
color: "transparent"
Clipboard { id: clipboard }
+ Connections {
+ target: appWindow
+ function onCurrentWalletChanged() {
+ lastActiveSigningAccount = -1
+ signingAddressLine.text = ""
+ selectCurrentSigningAddress()
+ }
+ }
+
+ Connections {
+ target: appWindow.currentWallet || null
+ function onCurrentSubaddressAccountChanged() { selectCurrentSigningAddress() }
+ }
+
+ function selectCurrentSigningAddress() {
+ var wallet = appWindow.currentWallet
+ var account = wallet ? wallet.currentSubaddressAccount : -1
+ if (account !== lastActiveSigningAccount) {
+ lastActiveSigningAccount = account
+ signingAddressLine.text = wallet && account < wallet.numSubaddressAccounts() ? wallet.address(account, 0) : ""
+ }
+ }
+
MessageDialog {
// dynamically change onclose handler
property var onCloseCallback
@@ -55,6 +79,19 @@ Rectangle {
}
}
+ MessageDialog {
+ id: signingErrorMessage
+ objectName: "signingErrorMessage"
+ title: qsTr("Error") + translationManager.emptyString
+ buttons: MessageDialog.Ok
+ }
+
+ function displaySigningError(previousError, filename) {
+ var error = appWindow.currentWallet.errorString
+ signingErrorMessage.text = error && (!filename || error !== previousError) ? error : qsTr("Failed to sign") + translationManager.emptyString
+ signingErrorMessage.open()
+ }
+
function displayVerificationResult(result) {
if (result.valid) {
signatureVerificationMessage.title = qsTr("Good signature") + translationManager.emptyString
@@ -165,9 +202,22 @@ Rectangle {
}
}
+ MoneroComponents.TextPlain {
+ objectName: "signingUnavailableMessage"
+ Layout.fillWidth: true
+ visible: !!appWindow.currentWallet && (appWindow.currentWallet.isHwBacked() || appWindow.currentWallet.viewOnly)
+ text: qsTr("Signing is not supported for hardware or view-only wallets.") + translationManager.emptyString
+ wrapMode: Text.Wrap
+ font.family: MoneroComponents.Style.fontRegular.name
+ font.pixelSize: 14
+ color: MoneroComponents.Style.defaultFontColor
+ }
+
ColumnLayout {
id: signSection
+ objectName: "signSection"
spacing: 10
+ enabled: !!appWindow.currentWallet && !appWindow.currentWallet.isHwBacked() && !appWindow.currentWallet.viewOnly
MoneroComponents.LabelSubheader {
Layout.fillWidth: true
@@ -177,6 +227,18 @@ Rectangle {
text: fileMode ? qsTr("Sign file") + translationManager.emptyString : qsTr("Sign message") + translationManager.emptyString
}
+ MoneroComponents.LineEditMulti {
+ id: signingAddressLine
+ objectName: "signingAddressLine"
+ Layout.fillWidth: true
+ labelFontSize: 14
+ labelText: qsTr("Signing address") + translationManager.emptyString
+ copyButton: true
+ pasteButton: true
+ onTextChanged: signSignatureLine.text = ""
+ wrapMode: Text.WrapAnywhere
+ }
+
ColumnLayout{
id: signMessageRow
Layout.fillWidth: true
@@ -185,6 +247,7 @@ Rectangle {
MoneroComponents.LineEditMulti{
id: signMessageLine
+ objectName: "signMessageLine"
Layout.fillWidth: true
labelFontSize: 14
labelText: qsTr("Message") + translationManager.emptyString;
@@ -203,6 +266,7 @@ Rectangle {
MoneroComponents.LineEditMulti {
id: signFileLine
+ objectName: "signFileLine"
labelFontSize: 14
labelText: qsTr("File") + translationManager.emptyString
placeholderFontSize: 16
@@ -231,6 +295,7 @@ Rectangle {
MoneroComponents.LineEditMulti {
id: signSignatureLine
+ objectName: "signSignatureLine"
labelFontSize: 14
labelText: qsTr("Signature") + translationManager.emptyString
placeholderFontSize: 16
@@ -260,33 +325,42 @@ Rectangle {
MoneroComponents.StandardButton {
id: signMessageButton
+ objectName: "signMessageButton"
visible: messageMode
text: qsTr("Sign Message") + translationManager.emptyString
- enabled: signMessageLine.text !== ''
+ enabled: signMessageLine.text !== '' && signingAddressLine.text !== ''
small: true
onClicked: {
- var signature = appWindow.currentWallet.signMessage(signMessageLine.text, false)
+ var previousError = appWindow.currentWallet.errorString
+ var signature = appWindow.currentWallet.signMessage(signMessageLine.text, false, signingAddressLine.text)
signSignatureLine.text = signature
+ if (!signature)
+ displaySigningError(previousError, false)
}
}
MoneroComponents.StandardButton {
id: signFileButton
+ objectName: "signFileButton"
visible: fileMode
small: true
Layout.alignment: Qt.AlignBottom
text: qsTr("Sign File") + translationManager.emptyString
- enabled: signFileLine.text !== ''
+ enabled: signFileLine.text !== '' && signingAddressLine.text !== ''
onClicked: {
- var signature = appWindow.currentWallet.signMessage(signFileLine.text, true);
+ var previousError = appWindow.currentWallet.errorString;
+ var signature = appWindow.currentWallet.signMessage(signFileLine.text, true, signingAddressLine.text);
signSignatureLine.text = signature;
+ if (!signature)
+ displaySigningError(previousError, true);
}
}
}
}
ColumnLayout {
id: verifySection
+ objectName: "verifySection"
spacing: 16
MoneroComponents.LabelSubheader {
@@ -440,5 +514,6 @@ Rectangle {
function onPageCompleted() {
console.log("Sign/verify page loaded");
+ selectCurrentSigningAddress()
}
}
### src/libwalletqt/Wallet.cpp
@@ -1020,8 +1020,9 @@ Q_INVOKABLE QString Wallet::checkReserveProof(const QString &address, const QStr
return QString::fromStdString(result);
}
-QString Wallet::signMessage(const QString &message, bool filename) const
+QString Wallet::signMessage(const QString &message, bool filename, const QString &address) const
{
+ const std::string signingAddress = address.toStdString();
if (filename) {
QFile file(message);
uchar *data = NULL;
@@ -1032,14 +1033,14 @@ QString Wallet::signMessage(const QString &message, bool filename) const
quint64 size = file.size();
if (size == 0) {
file.close();
- return QString::fromStdString(m_walletImpl->signMessage(std::string()));
+ return QString::fromStdString(m_walletImpl->signMessage(std::string(), signingAddress));
}
data = file.map(0, size);
if (!data) {
file.close();
return "";
}
- std::string signature = m_walletImpl->signMessage(std::string(reinterpret_cast<const char*>(data), size));
+ std::string signature = m_walletImpl->signMessage(std::string(reinterpret_cast<const char*>(data), size), signingAddress);
file.unmap(data);
file.close();
return QString::fromStdString(signature);
@@ -1052,7 +1053,7 @@ QString Wallet::signMessage(const QString &message, bool filename) const
}
}
else {
- return QString::fromStdString(m_walletImpl->signMessage(message.toStdString()));
+ return QString::fromStdString(m_walletImpl->signMessage(message.toStdString(), signingAddress));
}
}
### src/libwalletqt/Wallet.h
@@ -94,7 +94,7 @@ class Wallet : public QObject, public PassprasePrompter
Q_PROPERTY(Subaddress * subaddress READ subaddress)
Q_PROPERTY(SubaddressAccountModel * subaddressAccountModel READ subaddressAccountModel)
Q_PROPERTY(SubaddressAccount * subaddressAccount READ subaddressAccount)
- Q_PROPERTY(bool viewOnly READ viewOnly)
+ Q_PROPERTY(bool viewOnly READ viewOnly CONSTANT)
Q_PROPERTY(QString secretViewKey READ getSecretViewKey)
Q_PROPERTY(QString publicViewKey READ getPublicViewKey)
Q_PROPERTY(QString secretSpendKey READ getSecretSpendKey)
@@ -328,7 +328,7 @@ class Wallet : public QObject, public PassprasePrompter
Q_INVOKABLE QString integratedAddress(const QString &paymentId) const;
//! signing a message
- Q_INVOKABLE QString signMessage(const QString &message, bool filename = false) const;
+ Q_INVOKABLE QString signMessage(const QString &message, bool filename = false, const QString &address = QString()) const;
//! verify a signed message
Q_INVOKABLE bool verifySignedMessage(const QString &message, const QString &address, const QString &signature, bool filename = false) const;
### tests/qml/tst_Sign.qml
@@ -0,0 +1,238 @@
+// Copyright (c) 2026, The Monero Project
+//
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without modification, are
+// permitted provided that the following conditions are met:
+//
+// 1. Redistributions of source code must retain the above copyright notice, this list of
+// conditions and the following disclaimer.
+//
+// 2. Redistributions in binary form must reproduce the above copyright notice, this list
+// of conditions and the following disclaimer in the documentation and/or other
+// materials provided with the distribution.
+//
+// 3. Neither the name of the copyright holder nor the names of its contributors may be
+// used to endorse or promote products derived from this software without specific
+// prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY
+// EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
+// MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL
+// THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+// PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+// STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
+// THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import QtQuick
+import QtTest
+
+import moneroComponents.NetworkType 1.0
+import moneroComponents.WalletManager 1.0
+import "../../pages" as Pages
+
+Item {
+ id: appWindow
+ width: 800
+ height: 1000
+
+ property var currentWallet
+ property var currentItem
+ property bool themeTransition: false
+
+ function releaseFocus() {}
+
+ WalletManager { id: walletManager }
+
+ QtObject {
+ id: hardwareWallet
+ property int currentSubaddressAccount: 0
+ property string walletAddress
+ property bool viewOnly: false
+ function numSubaddressAccounts() { return 1 }
+ function address() { return walletAddress }
+ function isHwBacked() { return true }
+ }
+
+ Pages.Sign {
+ id: signView
+ width: parent.width
+ height: 850
+ }
+
+ TestCase {
+ name: "Sign"
+ when: windowShown
+
+ function test_wallet_address_signing() {
+ var wallet = walletManager.createWallet(moneroTestRoot + "/sign-wallet", "", "English", NetworkType.MAINNET, 1)
+ compare(wallet.status, 0, wallet.errorString)
+ appWindow.currentWallet = wallet
+ signView.onPageCompleted()
+
+ var addressLine = findChild(signView, "signingAddressLine")
+ var signatureLine = findChild(signView, "signSignatureLine")
+ var messageLine = findChild(signView, "signMessageLine")
+ var messageButton = findChild(signView, "signMessageButton")
+ var fileLine = findChild(signView, "signFileLine")
+ var fileButton = findChild(signView, "signFileButton")
+ var signSection = findChild(signView, "signSection")
+ var verifySection = findChild(signView, "verifySection")
+ var unavailableMessage = findChild(signView, "signingUnavailableMessage")
+ verify(addressLine !== null && signatureLine !== null)
+ verify(messageLine !== null && messageButton !== null)
+ verify(fileLine !== null && fileButton !== null)
+ verify(signSection !== null && verifySection !== null && unavailableMessage !== null)
+
+ var primaryAddress = wallet.address(0, 0)
+ compare(addressLine.text, primaryAddress)
+ compare(wallet.viewOnly, false)
+ verify(signSection.enabled && verifySection.enabled)
+ verify(!unavailableMessage.visible)
+ wallet.subaddressAccount.addRow("Second account")
+ wallet.switchSubaddressAccount(1)
+ var secondAddress = wallet.address(1, 0)
+ verify(primaryAddress !== secondAddress)
+ compare(addressLine.text, secondAddress)
+
+ var legacySignature = wallet.signMessage("legacy one-argument call")
+ verify(wallet.verifySignedMessageWithDetails("legacy one-argument call", primaryAddress, legacySignature, false).valid)
+ legacySignature = wallet.signMessage("legacy two-argument call", false)
+ verify(wallet.verifySignedMessageWithDetails("legacy two-argument call", primaryAddress, legacySignature, false).valid)
+
+ addressLine.text = primaryAddress
+ messageLine.text = "primary account"
+ messageButton.doClick()
+ var primarySignature = signatureLine.text
+ verify(primarySignature.length > 0, wallet.errorString)
+ verify(wallet.verifySignedMessageWithDetails("primary account", primaryAddress, primarySignature, false).valid)
+ verify(!wallet.verifySignedMessageWithDetails("primary account", secondAddress, primarySignature, false).valid)
+
+ addressLine.text = secondAddress
+ compare(signatureLine.text, "")
+ messageLine.text = "account one"
+ verify(messageButton.enabled)
+ messageButton.doClick()
+ var signature = signatureLine.text
+ verify(signature.length > 0, wallet.errorString)
+ verify(wallet.verifySignedMessageWithDetails("account one", secondAddress, signature, false).valid)
+ verify(!wallet.verifySignedMessageWithDetails("account one", primaryAddress, signature, false).valid)
+
+ signView.onPageCompleted()
+ compare(addressLine.text, secondAddress)
+ compare(signatureLine.text, signature)
+
+ wallet.addSubaddress("Extra address")
+ var minorAddress = wallet.address(1, 1)
+ verify(minorAddress !== secondAddress)
+ addressLine.text = minorAddress
+ compare(signatureLine.text, "")
+ messageLine.text = "minor index one"
+ messageButton.doClick()
+ var minorSignature = signatureLine.text
+ verify(minorSignature.length > 0, wallet.errorString)
+ verify(wallet.verifySignedMessageWithDetails("minor index one", minorAddress, minorSignature, false).valid)
+ verify(!wallet.verifySignedMessageWithDetails("minor index one", secondAddress, minorSignature, false).valid)
+
+ var filePath = moneroTestRoot + "/signed-file"
+ verify(settingsTestHelper.writeSetting(filePath, "test/value", "file contents"))
+ signView.messageMode = false
+ signView.fileMode = true
+ fileLine.text = filePath
+ verify(fileButton.enabled)
+ fileButton.doClick()
+ var fileSignature = signatureLine.text
+ verify(fileSignature.length > 0, wallet.errorString)
+ verify(wallet.verifySignedMessageWithDetails(filePath, minorAddress, fileSignature, true).valid)
+ verify(!wallet.verifySignedMessageWithDetails(filePath, primaryAddress, fileSignature, true).valid)
+
+ wallet.setSubaddressLabel(1, 0, "Renamed account")
+ compare(addressLine.text, minorAddress)
+ compare(signatureLine.text, fileSignature)
+ signView.onPageCompleted()
+ compare(addressLine.text, minorAddress)
+ compare(signatureLine.text, fileSignature)
+
+ wallet.subaddressAccount.addRow("Third account")
+ wallet.switchSubaddressAccount(2)
+ compare(addressLine.text, wallet.address(2, 0))
+ compare(signatureLine.text, "")
+ wallet.switchSubaddressAccount(0)
+ compare(addressLine.text, primaryAddress)
+
+ addressLine.text = ""
+ verify(!fileButton.enabled)
+ addressLine.text = primaryAddress
+
+ fileLine.text = moneroTestRoot + "/missing-file"
+ fileButton.doClick()
+ var errorDialog = findChild(signView, "signingErrorMessage")
+ verify(errorDialog !== null)
+ compare(errorDialog.text, "Failed to sign")
+
+ var previousWalletAddress = primaryAddress
+ signatureLine.text = "stale signature"
+ appWindow.currentWallet = undefined
+ compare(addressLine.text, "")
+ compare(signatureLine.text, "")
+ verify(!signSection.enabled && verifySection.enabled)
+
+ var otherWallet = walletManager.createWallet(moneroTestRoot + "/other-sign-wallet", "", "English", NetworkType.MAINNET, 1)
+ compare(otherWallet.status, 0, otherWallet.errorString)
+ appWindow.currentWallet = otherWallet
+ var otherAddress = otherWallet.address(0, 0)
+ compare(addressLine.text, otherAddress)
+ verify(otherAddress !== previousWalletAddress)
+ signView.messageMode = true
+ signView.fileMode = false
+ messageLine.text = "foreign address"
+ addressLine.text = previousWalletAddress
+ messageButton.doClick()
+ compare(signatureLine.text, "")
+ compare(errorDialog.text, "Address doesn't belong to the wallet")
+
+ hardwareWallet.walletAddress = otherAddress
+ appWindow.currentWallet = hardwareWallet
+ compare(addressLine.text, otherAddress)
+ verify(!signSection.enabled && verifySection.enabled)
+ verify(!messageButton.enabled && !fileButton.enabled)
+ verify(unavailableMessage.visible)
+
+ appWindow.currentWallet = undefined
+ walletManager.closeWallet()
+ }
+
+ function test_view_only_signing_disabled() {
+ var wallet = walletManager.createWallet(moneroTestRoot + "/sign-full-wallet", "", "English", NetworkType.MAINNET, 1)
+ compare(wallet.status, 0, wallet.errorString)
+ var viewOnlyPath = moneroTestRoot + "/sign-view-only-wallet"
+ verify(wallet.createViewOnly(viewOnlyPath, ""))
+ appWindow.currentWallet = undefined
+
+ var viewOnlyWallet = walletManager.openWallet(viewOnlyPath, "", NetworkType.MAINNET, 1)
+ compare(viewOnlyWallet.status, 0, viewOnlyWallet.errorString)
+ compare(viewOnlyWallet.viewOnly, true)
+ appWindow.currentWallet = viewOnlyWallet
+
+ var addressLine = findChild(signView, "signingAddressLine")
+ var signSection = findChild(signView, "signSection")
+ var verifySection = findChild(signView, "verifySection")
+ var unavailableMessage = findChild(signView, "signingUnavailableMessage")
+ var messageLine = findChild(signView, "signMessageLine")
+ var messageButton = findChild(signView, "signMessageButton")
+ var fileLine = findChild(signView, "signFileLine")
+ var fileButton = findChild(signView, "signFileButton")
+ compare(addressLine.text, viewOnlyWallet.address(0, 0))
+ verify(!signSection.enabled && verifySection.enabled)
+ verify(unavailableMessage.visible)
+ messageLine.text = "view-only cannot sign"
+ fileLine.text = moneroTestRoot + "/signed-file"
+ verify(!messageButton.enabled && !fileButton.enabled)
+
+ appWindow.currentWallet = undefined
+ walletManager.closeWallet()
+ }
+ }
+}Why this scored 32/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.