What changed, and why it matters
This commit adds a new command-line option --ssl-check and runs it in CI. The check makes a simple HTTPS request to the Monero website to confirm SSL/TLS certificate validation is working in the build. It is a testing/diagnostic addition, not a fix for a vulnerability and not an exploitable change.
No security action required. Treat as routine CI/test improvement. If reviewing for release readiness, verify the new CI job passes on all platforms and that the target URL is acceptable for privacy-conscious users running --ssl-check manually.
Security signals we found
Adds SSL/TLS connectivity self-test
Unsets SSL_CERT_FILE/SSL_CERT_DIR in CI to test default certificate validation path
Hidden CLI option not exposed in help
No change to cryptographic, networking, or wallet-handling logic
Evidence from the diff
The change introduces a hidden –ssl-check CLI flag in src/main/main.cpp. When set, the application fetches https://web.getmonero.org/downloads/hashes.txt via the existing Network helper, optionally through the configured socks proxy, and exits 0 if the response is non-empty or 1 on empty response or exception. The GitHub Actions workflow runs this check on macOS, Ubuntu, and Windows builds, unsetting SSL_CERT_FILE and SSL_CERT_DIR to ensure Qt’s bundled certificate store is used. No existing behavior is modified; no bug is fixed.
Changed components
src/main/main.cpp.github/workflows/build.ymlInspect captured patch +41 / −0
### .github/workflows/build.yml
@@ -19,6 +19,9 @@ jobs:
run: DEV_MODE=ON QML_TESTS=ON make release
- name: test qml
run: build/release/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --test-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR build/release/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --ssl-check
build-ubuntu:
runs-on: ubuntu-26.04
@@ -44,6 +47,12 @@ jobs:
QT_QPA_PLATFORM: offscreen
QT_QUICK_BACKEND: software
run: build/release/bin/monero-wallet-gui --test-qml
+ - name: check ssl
+ timeout-minutes: 2
+ env:
+ QT_QPA_PLATFORM: offscreen
+ QT_QUICK_BACKEND: software
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR build/release/bin/monero-wallet-gui --ssl-check
build-windows:
runs-on: windows-latest
@@ -69,6 +78,9 @@ jobs:
working-directory: build/release
- name: test qml
run: QT_FORCE_STDERR_LOGGING=1 build/release/bin/monero-wallet-gui --test-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR QT_FORCE_STDERR_LOGGING=1 build/release/bin/monero-wallet-gui --ssl-check
macos-bundle:
name: macOS ${{ matrix.arch }} bundle
@@ -108,6 +120,9 @@ jobs:
run: cmake --build build --target deploy
- name: check qml startup
run: build/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --check-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR build/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --ssl-check
- name: create archive
run: tar -C build/bin -czf "${{ matrix.archive_name }}" monero-wallet-gui.app
- uses: actions/upload-artifact@v7
@@ -133,6 +148,9 @@ jobs:
run: sudo apt -y install xvfb libopengl0 libegl1 libgl1 libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-render-util0 libxcb-shape0
- name: check qml startup
run: xvfb-run -a /home/runner/work/monero-gui/monero-gui/build/x86_64-linux-gnu/release/bin/monero-wallet-gui --check-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR xvfb-run -a /home/runner/work/monero-gui/monero-gui/build/x86_64-linux-gnu/release/bin/monero-wallet-gui --ssl-check
- uses: actions/upload-artifact@v7
with:
name: ${{ github.job }}
### src/main/main.cpp
@@ -249,8 +249,11 @@ Verify update binary using 'shasum'-compatible (SHA256 algo) output signed by tw
parser.addOption(socksProxyOption);
QCommandLineOption checkQmlOption("check-qml");
checkQmlOption.setFlags(QCommandLineOption::HiddenFromHelp);
+ QCommandLineOption sslCheckOption("ssl-check");
+ sslCheckOption.setFlags(QCommandLineOption::HiddenFromHelp);
parser.addOption(logPathOption);
parser.addOption(checkQmlOption);
+ parser.addOption(sslCheckOption);
parser.addHelpOption();
parser.process(app);
@@ -271,6 +274,26 @@ Verify update binary using 'shasum'-compatible (SHA256 algo) output signed by tw
Monero::WalletManagerFactory::setLogLevel(logLevel);
}
+ if (parser.isSet(sslCheckOption))
+ {
+ try
+ {
+ const Network network(parser.value(socksProxyOption));
+ if (network.get("https://web.getmonero.org/downloads/hashes.txt").empty())
+ {
+ qCritical() << "SSL check failed: empty response";
+ return 1;
+ }
+ qWarning() << "SSL check passed";
+ return 0;
+ }
+ catch (const std::exception &e)
+ {
+ qCritical() << "SSL check failed:" << e.what();
+ }
+ return 1;
+ }
+
if (parser.isSet(verifyUpdateOption))
{
const QString updateBinaryFullPath = parser.value(verifyUpdateOption);Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.