What changed, and why it matters
This commit adds a new automated test that runs in the project's continuous integration (CI) pipeline. The test launches the Monero GUI wallet with a hidden '--ssl-check' flag, which tries to download a small file over HTTPS from the official getmonero.org website. If the SSL/TLS connection works, the test passes; if it fails or returns empty, the test fails. It is a testing/diagnostic addition, not a fix for a security flaw in the wallet itself.
No security response required. Treat as a normal CI/test enhancement. Reviewers may optionally confirm the Network class handles exceptions safely and that the CI job timeout (2 minutes) is adequate across runners.
Security signals we found
New hidden CLI flag added for SSL/TLS connectivity validation
CI runs SSL check against real external endpoint (web.getmonero.org)
Environment variables SSL_CERT_FILE and SSL_CERT_DIR are explicitly unset during CI test to ensure bundled certificates are used
No patch of existing cryptographic or network code; purely additive test/diagnostic code
Evidence from the diff
The change introduces a hidden command-line option ‘–ssl-check’ in src/main/main.cpp. When set, the application instantiates a Network object (using an optional SOCKS proxy), performs an HTTPS GET to https://web.getmonero.org/downloads/hashes.txt, and exits with code 0 if a non-empty response is received, or code 1 on empty response or exception. The .github/workflows/build.yml file adds corresponding CI steps on macOS, Ubuntu, Windows, and bundle jobs that run the built binary with –ssl-check while unsetting SSL_CERT_FILE and SSL_CERT_DIR, intended to verify that the bundled SSL certificate store works in release builds.
Changed components
src/main/main.cpp.github/workflows/build.ymlInspect captured patch +41 / −0
### .github/workflows/build.yml
@@ -19,6 +19,9 @@ jobs:
run: DEV_MODE=ON QML_TESTS=ON make release
- name: test qml
run: build/release/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --test-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR build/release/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --ssl-check
build-ubuntu:
runs-on: ubuntu-26.04
@@ -44,6 +47,12 @@ jobs:
QT_QPA_PLATFORM: offscreen
QT_QUICK_BACKEND: software
run: build/release/bin/monero-wallet-gui --test-qml
+ - name: check ssl
+ timeout-minutes: 2
+ env:
+ QT_QPA_PLATFORM: offscreen
+ QT_QUICK_BACKEND: software
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR build/release/bin/monero-wallet-gui --ssl-check
build-windows:
runs-on: windows-latest
@@ -69,6 +78,9 @@ jobs:
working-directory: build/release
- name: test qml
run: QT_FORCE_STDERR_LOGGING=1 build/release/bin/monero-wallet-gui --test-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR QT_FORCE_STDERR_LOGGING=1 build/release/bin/monero-wallet-gui --ssl-check
macos-bundle:
name: macOS ${{ matrix.arch }} bundle
@@ -107,6 +119,9 @@ jobs:
run: cmake --build build --target deploy
- name: check qml startup
run: build/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --check-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR build/bin/monero-wallet-gui.app/Contents/MacOS/monero-wallet-gui --ssl-check
- name: create archive
run: tar -C build/bin -czf "${{ matrix.archive_name }}" monero-wallet-gui.app
- uses: actions/upload-artifact@v7
@@ -132,6 +147,9 @@ jobs:
run: sudo apt -y install xvfb libopengl0 libegl1 libgl1 libxkbcommon-x11-0 libxcb-icccm4 libxcb-image0 libxcb-keysyms1 libxcb-render-util0 libxcb-shape0
- name: check qml startup
run: xvfb-run -a /home/runner/work/monero-gui/monero-gui/build/x86_64-linux-gnu/release/bin/monero-wallet-gui --check-qml
+ - name: check ssl
+ timeout-minutes: 2
+ run: env -u SSL_CERT_FILE -u SSL_CERT_DIR xvfb-run -a /home/runner/work/monero-gui/monero-gui/build/x86_64-linux-gnu/release/bin/monero-wallet-gui --ssl-check
- uses: actions/upload-artifact@v7
with:
name: ${{ github.job }}
### src/main/main.cpp
@@ -249,8 +249,11 @@ Verify update binary using 'shasum'-compatible (SHA256 algo) output signed by tw
parser.addOption(socksProxyOption);
QCommandLineOption checkQmlOption("check-qml");
checkQmlOption.setFlags(QCommandLineOption::HiddenFromHelp);
+ QCommandLineOption sslCheckOption("ssl-check");
+ sslCheckOption.setFlags(QCommandLineOption::HiddenFromHelp);
parser.addOption(logPathOption);
parser.addOption(checkQmlOption);
+ parser.addOption(sslCheckOption);
parser.addHelpOption();
parser.process(app);
@@ -271,6 +274,26 @@ Verify update binary using 'shasum'-compatible (SHA256 algo) output signed by tw
Monero::WalletManagerFactory::setLogLevel(logLevel);
}
+ if (parser.isSet(sslCheckOption))
+ {
+ try
+ {
+ const Network network(parser.value(socksProxyOption));
+ if (network.get("https://web.getmonero.org/downloads/hashes.txt").empty())
+ {
+ qCritical() << "SSL check failed: empty response";
+ return 1;
+ }
+ qWarning() << "SSL check passed";
+ return 0;
+ }
+ catch (const std::exception &e)
+ {
+ qCritical() << "SSL check failed:" << e.what();
+ }
+ return 1;
+ }
+
if (parser.isSet(verifyUpdateOption))
{
const QString updateBinaryFullPath = parser.value(verifyUpdateOption);Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.