What changed, and why it matters
This patch fixes a user-interface freeze in the Monero GUI wallet when using the 'sweep unmixable outputs' feature. The old code called a synchronous (blocking) function that could hang the interface; the new code uses an asynchronous call so the wallet stays responsive. A separate one-line change in Wallet.cpp removes an incorrect parent object assignment, which could have caused a minor object-lifetime issue. There is no evidence in the commit of a security vulnerability exploitable by an attacker.
Treat as a normal bug-fix / UX improvement. No security response required unless further analysis shows the freeze can be triggered by untrusted input in a way that causes resource exhaustion or crash.
Security signals we found
UI freeze / denial-of-service to the local user when sweeping unmixable outputs
Object lifetime change in PendingTransaction parent assignment
No input validation, cryptographic, or network security changes visible
Evidence from the diff
The main.qml change replaces a synchronous currentWallet.createSweepUnmixableTransaction() call with currentWallet.createSweepUnmixableTransactionAsync(requestId) and moves transaction-status handling out of the immediate UI path, resolving a reported freeze. In Wallet.cpp, the PendingTransaction object is now constructed with parent 0 instead of this, decoupling its Qt parent from the Wallet instance. The commit title and message only describe fixing a freeze; no security impact is disclosed.
Changed components
monero-gui main.qml transaction confirmation flowsrc/libwalletqt/Wallet.cpp createSweepUnmixableTransactionInspect captured patch +6 / −21
### main.qml
@@ -1135,28 +1135,13 @@ ApplicationWindow {
txConfirmationPopup.clearFields();
txConfirmationPopup.sweepUnmixable = true;
- transaction = currentWallet.createSweepUnmixableTransaction();
+ txConfirmationPopup.bottomTextAnimation.running = false;
+ txConfirmationPopup.bottomText.text = qsTr("Creating transaction...") + translationManager.emptyString;
txConfirmationPopup.open();
- if (transaction.status !== PendingTransaction.Status_Ok) {
- console.error("Can't create transaction: ", transaction.errorString);
- txConfirmationPopup.errorText.text = qsTr("Can't create transaction: ") + transaction.errorString + translationManager.emptyString
- // deleting transaction object, we don't want memleaks
- currentWallet.disposeTransaction(transaction);
- transaction = null;
- } else if (transaction.txCount == 0) {
- console.error("No unmixable outputs to sweep");
- txConfirmationPopup.errorText.text = qsTr("No unmixable outputs to sweep") + translationManager.emptyString
- // deleting transaction object, we don't want memleaks
- currentWallet.disposeTransaction(transaction);
- transaction = null;
- } else {
- console.log("Transaction created, amount: " + walletManager.displayAmount(transaction.amount)
- + ", fee: " + walletManager.displayAmount(transaction.fee));
- txConfirmationPopup.transactionAmount = Utils.removeTrailingZeros(walletManager.displayAmount(transaction.amount));
- txConfirmationPopup.transactionFee = Utils.removeTrailingZeros(walletManager.displayAmount(transaction.fee));
- // committing transaction
- }
+ const requestId = ++transactionRequestId;
+ activeTransactionRequestId = requestId;
+ currentWallet.createSweepUnmixableTransactionAsync(requestId);
}
// called after user confirms transaction
### src/libwalletqt/Wallet.cpp
@@ -778,7 +778,7 @@ void Wallet::createTransactionAllAsync(const QString &dst_addr, const QString &p
PendingTransaction *Wallet::createSweepUnmixableTransaction()
{
Monero::PendingTransaction * ptImpl = m_walletImpl->createSweepUnmixableTransaction();
- PendingTransaction * result = new PendingTransaction(ptImpl, this);
+ PendingTransaction * result = new PendingTransaction(ptImpl, 0);
return result;
}
Why this scored 23/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.