AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Monero

Merge pull request #4752

Public commit record

What the developer wrote

Authored by tobtoht

61/100 · Adequate
Merge pull request #4752

31cd74f oshelper: verify seed template hash before opening (selsta)

ACKs: jpk68, plowsof
✓ Subject identifies a change✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This change hardens how the Monero GUI opens a printable PDF seed template. Previously, the app copied a bundled PDF to a predictable temporary path and opened it without checking whether the file had been tampered with. Now it creates a private temporary directory, verifies the PDF against a known SHA-256 hash before opening, and reports an error to the user if the check fails. The patch also adds a test that reminds developers to update the hash whenever the template PDF changes.

Recommended action

No immediate action required; this is a hardening patch. Users and downstream packagers should ensure the bundled wizard/template.pdf matches the hard-coded SHA-256 in src/main/oshelper.h, otherwise the print-template feature will fail. Developers should keep the new regression test passing after any PDF update.

Security signals we found

01

Local file integrity verification added (SHA-256) before opening an embedded PDF

02

Predictable temporary file path replaced with QTemporaryDir unique directory

03

Return-value handling added so QML can surface verification failures to the user

04

New regression test ties embedded resource hash to code constant

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.