AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 61 Monero

openpgp: reject revoked subkeys and use newest binding signature

Public commit record

What the developer wrote

Authored by jpk68

55/100 · Thin
openpgp: reject revoked subkeys and use newest binding signature
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
The short version

What changed, and why it matters

This change fixes how the Monero GUI reads OpenPGP public keys. Previously, the software might accept a revoked (cancelled) subkey or use an older signature that allowed signing even when a newer one did not. After the patch, revoked subkeys are rejected and only the newest valid binding signature is used to decide whether a subkey can sign. This prevents an attacker who controls an OpenPGP key file from tricking the wallet into trusting a subkey that should not be trusted.

Recommended action

Treat this commit as a security fix. Backport to supported branches, verify that OpenPGP key validation tests cover revoked subkeys and multiple binding signatures with conflicting creation times, and review whether other OpenPGP consumers in the project share the old logic.

Security signals we found

01

OpenPGP subkey revocation now enforced

02

Binding signature selection changed from first-match to newest-by-creation-time

03

Marker and Trust packets now explicitly skipped without terminating subkey signature sequence

04

Signature parsing now extracts signature creation time subpacket (type 2)

05

Subkey acceptance now gated on both non-revoked status and latest signing-capable binding signature

Risk score

Why this scored 61/100

Our methodology →
Potential impact 18/30
Exploitability 14/25
Stealth signal 10/15
Affected reach 8/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.