What changed, and why it matters
This is a small user-interface improvement for the Monero GUI wallet. When a user checks a 'reserve proof' (a cryptographic receipt showing how much Monero an address holds), the result popup now also shows the unspent amount. The code also initializes three local variables to safe default values. There is no security vulnerability visible in the change.
No security action required. Treat as a normal feature/UX update.
Security signals we found
No security-relevant signal: UI-only change adding an unspent amount label to reserve proof checks
Defensive initialization of local output variables (good=false, total=0, spent=0), which is good practice but not a fix for an observed bug
Evidence from the diff
The commit modifies two files. In Wallet.cpp, local variables good, total, and spent are now initialized (false, 0, 0), and the returned pipe-delimited string gains a fourth numeric field: total - spent. In main.qml, the success message consumes that new field and displays it as ‘%3 unspent’. The change is purely presentational and does not alter wallet logic, cryptographic verification, or how funds are handled.
Changed components
Monero GUI wallet reserve proof verification dialogsrc/libwalletqt/Wallet.cpp checkReserveProof() return formatmain.qml reserve proof result displayInspect captured patch +5 / −5
### main.qml
@@ -1281,7 +1281,7 @@ ApplicationWindow {
else if (isReserveProof && results[0] === "true") {
var good = results[1] === "true";
informationPopup.title = qsTr("Reserve proof check") + translationManager.emptyString;
- informationPopup.text = good ? qsTr("Good signature on %1 total and %2 spent.").arg(walletManager.displayAmount(results[2])).arg(walletManager.displayAmount(results[3])) : qsTr("Bad signature");
+ informationPopup.text = good ? qsTr("Good signature on %1 total, %2 spent, %3 unspent.").arg(walletManager.displayAmount(results[2])).arg(walletManager.displayAmount(results[3])).arg(walletManager.displayAmount(results[4])) : qsTr("Bad signature");
}
else {
informationPopup.title = qsTr("Error") + translationManager.emptyString;
### src/libwalletqt/Wallet.cpp
@@ -1012,11 +1012,11 @@ Q_INVOKABLE QString Wallet::getReserveProof(bool all, quint32 account_index, con
Q_INVOKABLE QString Wallet::checkReserveProof(const QString &address, const QString &message, const QString &signature) const
{
- bool good;
- uint64_t total;
- uint64_t spent;
+ bool good = false;
+ uint64_t total = 0;
+ uint64_t spent = 0;
bool success = m_walletImpl->checkReserveProof(address.toStdString(), message.toStdString(), signature.toStdString(), good, total, spent);
- std::string result = std::string(success ? "true" : "false") + "|" + std::string(good ? "true" : "false") + "|" + QString::number(total).toStdString() + "|" + QString::number(spent).toStdString();
+ std::string result = std::string(success ? "true" : "false") + "|" + std::string(good ? "true" : "false") + "|" + QString::number(total).toStdString() + "|" + QString::number(spent).toStdString() + "|" + QString::number(total - spent).toStdString();
return QString::fromStdString(result);
}
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.