What changed, and why it matters
This change tightens how the Monero GUI wallet handles its network proxy settings. Previously, the wallet's proxy address could be changed from many places in the app, which could let a bug or malicious UI flow silently switch traffic to a different proxy. The patch makes the proxy address read-only inside the core wallet object and forces the app to reconnect through a single, controlled function when the user changes proxy settings. This reduces the chance that traffic accidentally bypasses Tor or another privacy proxy, but the commit itself does not claim to fix a specific active security bug.
Treat as a hardening or defense-in-depth change rather than a confirmed vulnerability. Users and auditors should verify that `reconnectWallet()` is the only path that changes the active proxy and that `initAsync()` correctly applies the proxy to existing network connections. No urgent patch deployment is indicated unless a specific exploit is disclosed.
Security signals we found
Removal of writable proxy address setter reduces attack surface for proxy misconfiguration
Centralizes proxy reconnection logic in a single helper function
Prevents QML binding from silently overriding proxy address
May mitigate privacy risks from traffic unexpectedly bypassing a configured proxy
Evidence from the diff
The commit removes the writable setProxyAddress slot from the C++ Wallet class and changes the proxyAddress QML property from READ/WRITE/NOTIFY to READ/NOTIFY. It also removes a direct QML binding that set currentWallet.proxyAddress from settings, and instead adds an explicit reconnectWallet() helper that calls initAsync() with the current proxy address whenever proxyAddress or proxyEnabled changes while using a remote node. This centralizes proxy reconfiguration and prevents arbitrary QML-side writes to the wallet’s proxy address.
Changed components
Monero GUI wallet proxy handlingsrc/libwalletqt/Wallet.cppsrc/libwalletqt/Wallet.hmain.qmlInspect captured patch +17 / −36
### main.qml
@@ -381,7 +381,6 @@ ApplicationWindow {
currentWallet.deviceButtonPressed.connect(onDeviceButtonPressed);
currentWallet.walletPassphraseNeeded.connect(onWalletPassphraseNeededWallet);
currentWallet.transactionCommitted.connect(onTransactionCommitted);
- currentWallet.proxyAddress = Qt.binding(persistentSettings.getWalletProxyAddress);
middlePanel.paymentClicked.connect(handlePayment);
middlePanel.sweepUnmixableClicked.connect(handleSweepUnmixable);
middlePanel.getProofClicked.connect(handleGetProof);
@@ -780,6 +779,17 @@ ApplicationWindow {
passwordDialog.close();
}
+ function reconnectWallet() {
+ currentWallet.initAsync(
+ currentDaemonAddress,
+ isTrustedDaemon(),
+ 0,
+ false,
+ false,
+ 0,
+ persistentSettings.getWalletProxyAddress());
+ }
+
function connectRemoteNode() {
if (!currentWallet || currentWallet.initializing)
return;
@@ -797,14 +807,7 @@ ApplicationWindow {
const remoteNode = remoteNodesModel.currentRemoteNode();
currentDaemonAddress = remoteNode.address;
currentWallet.setDaemonLogin(remoteNode.username, remoteNode.password);
- currentWallet.initAsync(
- currentDaemonAddress,
- isTrustedDaemon(),
- 0,
- false,
- false,
- 0,
- persistentSettings.getWalletProxyAddress());
+ reconnectWallet();
walletManager.setDaemonAddressAsync(currentDaemonAddress);
};
@@ -827,14 +830,7 @@ ApplicationWindow {
persistentSettings.useRemoteNode = false;
currentDaemonAddress = localDaemonAddress
currentWallet.setDaemonLogin("", "");
- currentWallet.initAsync(
- currentDaemonAddress,
- isTrustedDaemon(),
- 0,
- false,
- false,
- 0,
- persistentSettings.getWalletProxyAddress());
+ reconnectWallet();
walletManager.setDaemonAddressAsync(currentDaemonAddress);
firstBlockSeen = 0;
}
@@ -1668,6 +1664,9 @@ ApplicationWindow {
property string proxyAddress: "127.0.0.1:9050"
property bool proxyEnabled: isTails
+ onProxyAddressChanged: if (currentWallet && useRemoteNode) appWindow.reconnectWallet()
+ onProxyEnabledChanged: if (currentWallet && useRemoteNode) appWindow.reconnectWallet()
+
function getProxyAddress() {
if (socksProxyFlagSet) {
return socksProxyFlag == "" ? "" : "socks5://" + socksProxyFlag;
### src/libwalletqt/Wallet.cpp
@@ -219,23 +219,6 @@ QString Wallet::getProxyAddress() const
return m_proxyAddress;
}
-void Wallet::setProxyAddress(QString address)
-{
- m_scheduler.run([this, address] {
- {
- QMutexLocker locker(&m_proxyMutex);
-
- if (!m_walletImpl->setProxy(address.toStdString()))
- {
- qCritical() << "failed to set proxy" << address;
- }
-
- m_proxyAddress = address;
- }
- emit proxyAddressChanged();
- });
-}
-
bool Wallet::synchronized() const
{
return m_walletImpl->synchronized();
### src/libwalletqt/Wallet.h
@@ -100,7 +100,7 @@ class Wallet : public QObject, public PassprasePrompter
Q_PROPERTY(QString secretSpendKey READ getSecretSpendKey)
Q_PROPERTY(QString publicSpendKey READ getPublicSpendKey)
Q_PROPERTY(QString daemonLogPath READ getDaemonLogPath CONSTANT)
- Q_PROPERTY(QString proxyAddress READ getProxyAddress WRITE setProxyAddress NOTIFY proxyAddressChanged)
+ Q_PROPERTY(QString proxyAddress READ getProxyAddress NOTIFY proxyAddressChanged)
Q_PROPERTY(quint64 walletCreationHeight READ getWalletCreationHeight WRITE setWalletCreationHeight NOTIFY walletCreationHeightChanged)
public:
@@ -472,7 +472,6 @@ class Wallet : public QObject, public PassprasePrompter
void refreshingSet(bool value);
void setConnectionStatus(ConnectionStatus value);
QString getProxyAddress() const;
- void setProxyAddress(QString address);
void startRefreshThread();
private:Why this scored 46/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.