Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit adds support in LND for a new Lightning protocol message called InvoiceError. It is used to politely tell another node why their payment invoice or invoice request was rejected, sent privately through an onion-routed message. T…
New unsigned onion message type added with no cryptographic signature or bech32 formWriter-side validation prevents empty or non-UTF-8 error strings and disallowed suggested_value without erroneous_fieldReader-side BOLT 1 must-understand rule enforced: unknown even TLVs rejected, unknown odd TLVs tolerated
This commit adds validation checks for BOLT 12 invoices in the LND Lightning node software. It ensures invoices contain required fields (creation time, amount, payment hash, node ID, payment paths), match their originating invoice requests…
New validation gate added to Invoice.Encode() to reject malformed invoices before serializationReader rejects unknown even invoice TLV types and unknown even feature bitsReader enforces chain compatibility against activeChain
This commit adds new code to support BOLT 12 invoices in the LND Lightning node. It introduces a data structure, encoding/decoding logic, and helper functions to filter fallback addresses and blinded payment paths. There is no bug fix or s…
This commit is a hardening and cleanup of a GitHub Actions workflow that automatically labels pull requests by severity. It does not change any LND node code, wallet logic, or network protocol. Instead, it splits the workflow into two jobs…
Principle of least privilege: write token moved out of the model-bearing jobUntrusted input (model-generated comment) sanitized before privileged API useExternal action pinned to immutable commit SHA instead of mutable tag
This commit is a straightforward internal code cleanup in LND's channel-opening machinery. It swaps one internal type name (channeldb.OpenChannel) for another (chanstate.OpenChannel) across function signatures in the funding manager and it…
This commit fixes a bug in how the Lightning Network Daemon (LND) copies payment channel data. When the program made a copy of an HTLC (a pending payment in a Lightning channel), it failed to copy several important fields and did not prope…
Incomplete deep copy of security-relevant channel stateMissing fields in HTLC clone (RHash, OnionBlob, HtlcIndex, LogIndex)Nil-slice copy bug for Signature and ExtraData
This commit adds a new RPC called SubmitPackage to LND's WalletKit. It lets users submit a group of related Bitcoin transactions together so a zero-fee parent can be accepted because a later child transaction pays its fee. This is a featur…
New RPC endpoint gated by onchain:write macaroon permissionPackage size bounded to 25 transactions to limit deserialization workFee-rate ceiling passed through to backend; explicit 0 disables limit
This commit adds validation checks for BOLT 12 invoice requests in the LND Lightning node. It ensures that invoice requests follow protocol rules when being created (written) and received (read), rejecting malformed or non-compliant reques…
New input validation functions added for protocol messagesValidation now runs before encoding, preventing malformed outbound messagesOverflow guard added for amount*quantity calculation
This commit adds a new data structure and serialization code for BOLT 12 invoice requests in the LND Lightning node. It is purely an implementation of a protocol message format and includes a round-trip test. There is no indication in the …
This is a large dependency upgrade for the LND Lightning node software. It moves LND from older btcd Bitcoin library packages to new 'v2' packages and updates related wallet and network libraries. The commit is almost entirely mechanical i…
Large dependency upgrade touching core Bitcoin primitives (wire, txscript, chainhash, btcutil, psbt, address)Migration to new v2 module layout with API changes in address handlingPins new upstream releases (btcd 0.26.0, btcwallet 0.17.0, neutrino 0.18.0, lightning-onion 1.4.0) that may include undisclosed fixes
This commit fixes a bug in LND's DNS seed bootstrap code that could crash the node. The code assumed every record in a DNS response was an SRV record, so a non-SRV record (like a normal A or CNAME record) would cause a panic. The fix safel…
Unconditional type assertion panic in DNS fallback pathMissing bounds check on LookupHost result before array indexingMissing network deadline on manually dialed DNS TCP connection
This commit removes a temporary security workaround in a Go module file. The workaround forced the use of a newer, fixed version of a compression library (xz) to avoid a known historical vulnerability. The commit message says the library i…
Removal of a dependency-level vulnerability workaroundReference to historical advisory GHSA-25xm-hr59-7c27 in deleted commentNo code changes; only go.mod cleanup
This commit removes an old workaround in LND's dependency file (go.mod) that pinned a safe version of the 'xz' compression library. The workaround was originally added because another dependency once pulled in a vulnerable version of xz. T…
Removal of a dependency override that was a security mitigation for CVE-2021-29482Commit explicitly references the original GHSA advisory (GHSA-25xm-hr59-7c27)No actual downgrade or re-introduction of the vulnerable module is visible in the diff
This commit is a cleanup-only change that removes unnecessary loop-variable copies in Go test files. Since Go 1.22, loop variables are already scoped per-iteration, so the old `x := x` workarounds are redundant. The change affects only tes…
This commit only changes a dependency version label in LND's package manifest. The underlying code (commit 70a94ea39e9c) stays exactly the same; the dependency is simply tagged as v0.16.18 instead of being referenced by a pseudo-version. T…
This commit updates a dependency version in LND's build files. It bumps the internal 'kvdb' submodule from version 1.5.0 to 1.5.1 so that downstream projects importing kvdb directly do not pull in an older, vulnerable telemetry library (Op…
Dependency bump explicitly motivated by a known vulnerability identifier (GO-2026-4394)No source code changes in LND itself; only module metadata updatedVendor describes the root build as already unaffected, limiting direct security impact on LND
This commit removes support for obsolete Tor v2 onion addresses from the Lightning Network Daemon (lnd). Tor v2 services were shut down by the Tor network in October 2021, so lnd will no longer create, accept, or dial v2 onion addresses. H…
Removal of deprecated network protocol (Tor v2) reduces attack surface and prevents futile/unsafe dials to unreachable services.Input validation added at operator boundaries (ParseAddressString, parseAddr) to reject v2 .onion addresses with a clear error.On-disk legacy key fallback now validates decrypted key type and rejects non-v3 (RSA1024) keys before passing them to Tor.
This commit simply updates a software library dependency (neutrino) used by the Lightning Network Daemon (LND). The new version is said to add a faster way to import blockchain headers and fix a bug that could stop peer-to-peer header sync…
Dependency update to a newer tagged release of neutrinoCommit message references a 'ResetHeaderState fix' for P2P sync continuation after chain importNo direct code-level security fix is visible in the supplied diff
This commit fixes a bug in LND's remote-signing setup where zero-value previous transaction outputs were wrongly ignored when preparing a PSBT for a remote signer. The most concrete affected use case is BIP-322 message attestation, where t…
Functional denial-of-service in remote-signer BIP-322 workflows due to PSBT rejectionIncorrect zero-value UTXO validation caused legitimate outputs to be droppedFix removes Value check while preserving non-empty PkScript sanity check
This commit only adds new unit tests for an existing helper function in LND's RPC wallet code. It does not change any production logic, so it cannot introduce a security vulnerability or directly fix one in the code being committed. The te…
lnwallet/chancloser: move nonce rotation to LocalOfferSent
Move the RemoteCloseeNonce update from updateAndValidateCloseTerms to LocalOfferSent.ProcessEvent. This keeps updateAndValidateCloseTerms focused on close term validation, and makes the nonce rotation point explicit in the state machine — it happens when processing the LocalSigReceived event, alongside signature extraction.
Update TestNextCloseeNonceStorageFromClosingSig to verify that updateAndValidateCloseTerms no longer modifies RemoteCloseeNonce.
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Informational 12/100
This is a small internal code cleanup in LND's cooperative channel-closing logic. It moves where a cryptographic nonce is updated from one function to another within the same state machine, with no indication of a security bug or user-facing behavior change. The change is framed by the author as improving code organization, not fixing a vulnerability.
This commit introduces a new TLV structure LocalNoncesData that contains a map of transaction IDs to MuSig2 nonces. This structure enables coordinating multiple nonces for different purposes (e.g., channel commits, splice operations) within a single wire message.
This is a prep for upcoming spec changes to allow a party that has in-prorgess splices to tell the remote party which nonces to use for which splice.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
nonce handling
AI analysis · Informational 15/100
This commit adds a new data structure and wire format for exchanging groups of cryptographic nonces used in multi-signature Lightning transactions. It is purely preparatory code: it defines how to pack and unpack the data and includes unit tests. There is no actual use of this structure in message handling yet, and nothing in the commit suggests a security bug or fix.
Security candidatelncli: add `sign` subcommand to `lncli wallet psbt`by Oli · 99712e1c · Mar 24, 2026 · 1 fileMessage 65 · AdequateInformational 18Details
Commit message · Oli
lncli: add `sign` subcommand to `lncli wallet psbt`
Adds a new sub command `lncli wallet psbt sign` to `lncli` that calls the wallet RPC's `SignPsbt` method.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100
This commit adds a new command-line option to LND's wallet tool that lets users sign partially-built Bitcoin transactions (PSBTs). It is a feature addition that exposes an already-existing wallet RPC through the lncli interface. There is no indication in the commit that it fixes a bug or addresses a security vulnerability.
lnwire: validate MuSig2 nonce points on wire decode
Add point-on-curve validation for MuSig2 public nonces at the TLV decode layer. A MuSig2 nonce is 66 bytes (two 33-byte compressed secp256k1 public keys). Previously, nonce bytes were accepted without validation, with invalid points only failing later during MuSig2 session creation deep in the signing flow. Now, malformed nonces from a peer are rejected immediately at decode time with clear errors.
This hardens all nonce-carrying messages: ClosingComplete (JIT closer nonces in PartialSigWithNonce), ClosingSig (NextCloseeNonce), Shutdown, ChannelReestablish, CommitSig, and others.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
This change tightens input checking for a special type of cryptographic value (a MuSig2 nonce) that peers send to each other in Lightning Network messages. Before, a peer could send bytes that looked like a nonce but were not valid points on the Bitcoin curve; those invalid values would only be caught later, deep inside the signing code. Now they are rejected immediately when the message is first decoded. This is a defensive hardening fix: it makes the protocol more robust against malformed or malicious peer input and prevents potential crashes or unexpected behavior in the signing flow.
channeldb: add V2 (taproot) waiting proof codec support
Introduce the WaitingProofInner interface and two concrete implementations — V1WaitingProof (AnnounceSignatures1) and V2WaitingProof (AnnounceSignatures2 + optional aggregate MuSig2 nonce).
WaitingProof.Encode/Decode now dispatch on the type prefix byte added in the previous commit, so the store can transparently persist either proof variant.
The gossiper is updated with a V1 type assertion to maintain existing behaviour; full V2 gossiper integration will follow when taproot channel announcements are wired up.
No live code path creates V2 waiting proofs yet — this commit only lands the codec and storage readiness so the schema is in place before new writers are introduced.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarynonce handling
AI analysis · Informational 18/100
This commit adds database support for a new kind of channel-announcement proof used by upcoming taproot channels. It does not change any live network behavior; it only prepares the code so future taproot features can store their proofs safely. Existing V1 proofs keep working exactly as before, and the gossiper is explicitly restricted to V1 proofs only.
Security candidatechanneldb: add type-prefix to waiting proof store recordsby Elle Mouton · e0256a7d · Mar 17, 2026 · 7 filesMessage 95 · StrongLow 26Details
Commit message · Elle Mouton
channeldb: add type-prefix to waiting proof store records
Existing waiting proof records encode a bare isRemote flag followed by a raw AnnounceSignatures1 payload. A future gossip v2 implementation will store AnnounceSignatures2 (taproot) proofs in the same bucket, so each record needs a discriminator byte to select the correct decoder.
This commit:
1. Defines WaitingProofTypeV1 (= 0x00) for the current AnnounceSignatures1-based proofs. 2. Updates WaitingProofKey to 10 bytes [proofType(1) || scid(8) || isRemote(1)] to avoid cross-version key collisions. 3. Adds migration 35, which rewrites every existing record to prepend the type byte and rewrites keys to the new format. 4. Updates WaitingProof.Encode/Decode to always write/expect the prefix.
The migration, codec changes, and tests are kept in one atomic commit so there is no intermediate revision where the new Decode can encounter unmigrated records.
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Low 26/100
This commit is a forward-looking database format change for LND's 'waiting proof store,' which holds channel announcement proofs. It adds a one-byte type marker to each stored record and its lookup key so that a future gossip v2/Taproot version can safely store a different proof type in the same place. It also ships a database migration that rewrites all existing records to the new format. The change is defensive and structural, not a fix for an active vulnerability.
Security candidategraph,discovery: version IsZombieChannelby Elle Mouton · cb99637f · Mar 16, 2026 · 5 filesMessage 63 · AdequateLow 40Details
Commit message · Elle Mouton
graph,discovery: version IsZombieChannel
Change the IsZombieChannel / isStillZombieChannel function signature throughout the gossip and routing stacks from func(time.Time, time.Time) bool to func(ChannelUpdateInfo) bool.
This allows zombie detection to inspect the full channel update info— including version and freshness type—rather than receiving two raw unix timestamps that carry no meaning for v2 channels.
Builder.IsZombieChannel is updated to extract version-appropriate freshness from the ChannelUpdateInfo: unix-time expiry for v1, and a block-count expiry (derived from ChannelPruneExpiry and avgBitcoinBlockTime) for v2. The gossipSyncer, SyncManager, and gossiper Config fields are updated to use the new signature.
This commit updates how the Lightning Network Daemon (LND) decides whether a payment channel is a 'zombie'—meaning it has gone stale and should be ignored or pruned. Previously, zombie detection only looked at wall-clock timestamps, which works for older v1 gossip channels but not for newer v2 channels that use block heights to show freshness. The change lets the code inspect the full channel update information, including its version and freshness type, so v2 channels are correctly evaluated by block height rather than by time. This is a correctness improvement, not an obvious active vulnerability, but misclassifying v2 channels could affect routing reliability and graph health.
Security candidategraph/db: version FilterChannelRangeby Elle Mouton · 3c06daed · Mar 16, 2026 · 5 filesMessage 73 · AdequateLow 28Details
Commit message · Elle Mouton
graph/db: version FilterChannelRange
Add a gossip version parameter to FilterChannelRange in the Store interface, both KV and SQL implementations, and the ChannelGraph wrapper.
KVStore guards against non-v1 versions with ErrVersionNotSupportedForKVDB. SQLStore accepts any known gossip version, filtering the channel results by version and using it in policy lookups. The SQL query still uses GetPublicV1ChannelsBySCID for now (a TODO marks where a version-aware query will be substituted in a follow-up).
VersionedGraph.FilterChannelRange shadows the ChannelGraph method with a version-free signature, passing its baked-in version to the store. This keeps the ChannelGraphTimeSeries interface and ChanSeries implementation unchanged.
Add TestFilterChannelRangeVersionGuard to verify that the KV store returns ErrVersionNotSupportedForKVDB for v2 requests while the SQL store handles them gracefully.
This commit changes how LND's graph database filters channel ranges by adding a 'gossip version' parameter. It is a preparatory/infrastructure change: the older KV database now explicitly refuses version 2 requests, while the newer SQL database accepts them but still mostly uses the old version-1 query path (marked with a TODO for a future update). There is no obvious security vulnerability in the patch itself; it is more about making the code ready for future gossip protocol versions.
Security candidatemod+multi: bump neutrino to v0.16.2, btcwallet to 70a94ea39e9cby Olaoluwa Osuntokun · 641ff68c · Mar 10, 2026 · 12 filesMessage 88 · StrongLow 32Details
Commit message · Olaoluwa Osuntokun
mod+multi: bump neutrino to v0.16.2, btcwallet to 70a94ea39e9c
In this commit, we update our two core chain backend dependencies: neutrino is bumped from v0.16.1 to v0.16.2, and btcwallet is updated to commit 70a94ea39e9c (a pre-release past v0.16.17).
The updated btcwallet changes the `chain.Interface` `Start` method signature from `Start() error` to `Start(context.Context) error`. The same change was made to neutrino's `ChainService.Start`. We update all call sites and interface implementations across the codebase to pass a `context.Background()` at non-test call sites, and `t.Context()` in tests.
The affected packages are: chainntnfs/bitcoindnotify, chainreg, config_builder, lnmock, lntest/unittest, lnwallet/btcwallet, lnwallet/test, and routing/chainview.
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 32/100
This commit updates two core software building blocks (neutrino and btcwallet) used by the Lightning Network Daemon (LND). The main visible change is that the 'Start' method of these building blocks now requires a context parameter, so the LND code is adjusted to pass one. The commit also pulls in newer versions of many supporting libraries. There is no direct evidence in the commit message or diff that this fixes a specific security vulnerability; it looks like a routine dependency and API-signature update. However, because it bumps chain-backend and cryptographic libraries, it could indirectly include security fixes from those upstream projects.
Merge pull request #9637 from Roasbeef/chan-type-required
feature: start to set the require bit for channel_type
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit is a massive repository import or rebase that adds the entire LND codebase plus many new GitHub workflow, documentation, and configuration files. The stated title refers to a Lightning protocol feature ('start to set the require bit for channel_type'), but the supplied diff does not show any code changes related to channel_type; it only shows newly added repository scaffolding. There is no evidence in the provided materials of a security vulnerability or a security-relevant code change.
Security candidatepayments/migration1: freeze lnwire and record dependencyby ziggie · 6c28cc4d · Feb 27, 2026 · 33 filesMessage 85 · StrongLow 28Details
Commit message · ziggie
payments/migration1: freeze lnwire and record dependency
Also freeze the lnwire and record packages used by the migration.
Copy the minimal subset of lnwire files (16) into payments/db/migration1/lnwire/ and all record files (6) into payments/db/migration1/record/. Three lnwire files are trimmed to avoid pulling in the full message-type dispatch tree — all changes are purely subtractive and can be verified with:
All migration1 files now import only the frozen packages, removing the live dependency on lnwire and record so future changes to those packages cannot affect migration correctness.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathboot or update path
AI analysis · Low 28/100
This commit is a defensive code-hygiene change. It copies a small, frozen snapshot of two shared code packages (lnwire and record) into an old database migration folder so that future updates to the live versions of those packages cannot accidentally change how past payment data is decoded. There is no direct vulnerability being fixed; instead, the change prevents a class of future migration-correctness bugs.
Security candidategraph/db/migration1: fix defer commit/rollback in test tx executorby ziggie · 932fbc33 · Feb 25, 2026 · 1 fileMessage 83 · StrongInformational 21Details
Commit message · ziggie
graph/db/migration1: fix defer commit/rollback in test tx executor
The defer closure checked a local err variable for commit/rollback decisions, but err remained nil after a successful BeginTx. When txBody failed, the error was returned directly without assigning to err, so the defer always committed instead of rolling back.
Additionally, since err was not a named return value, the defer's Commit error assignment was silently swallowed.
Replace the error-prone defer pattern with explicit rollback on txBody failure and a direct Commit return.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Informational 21/100
This commit fixes a bug in a test helper that runs database transactions for LND's graph database migration tests. The old code accidentally committed every transaction, even when the inner test work failed, because of a subtle Go error-handling mistake. The fix makes failed transactions roll back and successful ones commit properly. This is test-only code, so it does not directly affect live Lightning nodes, but it could have caused migration tests to leave partial or incorrect data in the database instead of rolling back as intended.
Security candidatescripts: switch verify-install.sh from curl to wgetby ziggie · 99eceba7 · Feb 13, 2026 · 2 filesMessage 88 · StrongLow 29Details
Commit message · ziggie
scripts: switch verify-install.sh from curl to wget
Replace curl with wget for downloading release manifests and signatures in verify-install.sh. wget handles redirects, retries, and error reporting more robustly by default, which avoids silent download failures that caused misleading "Invalid signature!" errors.
Also add error checking to all download calls so failures are reported immediately with the URL that failed, and log which signature file and user failed gpg verification.
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validation
AI analysis · Low 29/100
This commit changes the LND release verification helper script from using curl to using wget, and adds clearer error messages when downloads fail. The practical security issue being fixed is that curl could silently fail to download release signatures, which then made the script wrongly report 'Invalid signature!' instead of admitting the file simply didn't download. That misleading error could confuse users or hide network/download problems during install verification. It is a hardening/usability fix in a verification helper, not a fix for a vulnerability in the Lightning node itself.
scripts: log failing signature details in verify-install
When gpg --verify fails, include the signature filename, username, and full GPG output in the error message. Previously only a generic "Invalid signature!" was printed, making it hard to identify which signer's signature was invalid.
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 19/100
This commit improves an error message in a release-verification script. When a GPG signature check fails, it now prints the signature filename, the username, and the full GPG output instead of just a generic 'Invalid signature!' message. This is a usability/debugging improvement, not a security fix.
Security candidategraph/db: treat empty channel signatures as missingby Elle Mouton · 6328c4d8 · Feb 13, 2026 · 5 filesMessage 100 · StrongModerate 51Details
Commit message · Elle Mouton
graph/db: treat empty channel signatures as missing
This commit improves handling of missing channel signatures in the database:
- Return nil from auth proof accessors instead of empty slices so that missing signatures are stored as NULL in SQL. - Update public channel checks to require signature length > 0, which properly handles existing empty bytea values in the database. - Add regression test covering empty v1 and v2 channel signatures to prevent future issues.
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryfuzzing or regression evidenceauthentication path
AI analysis · Moderate 51/100
This commit fixes a bug in LND's Lightning Network graph database where empty channel signatures were being treated as valid proof that a channel was publicly announced. Because the code previously treated empty byte slices the same as real signatures, a node connected only by such a 'channel' could incorrectly be considered public. The fix makes the database store empty signatures as NULL and changes all public-channel checks to require a signature length greater than zero. The commit message frames this as a correctness improvement and adds regression tests, but does not label it a security vulnerability.
Security candidategraph/db: support v2 channel proofs in AddEdgeProofby Elle Mouton · 99d622ca · Feb 13, 2026 · 2 filesMessage 78 · AdequateLow 32Details
Commit message · Elle Mouton
graph/db: support v2 channel proofs in AddEdgeProof
Update AddEdgeProof to handle both v1 (four separate signatures) and v2 (single aggregated signature) channel authentication proofs using the appropriate SQL queries.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryaccess control
AI analysis · Low 32/100
This commit extends a database function in the LND Lightning node so it can store both old-style (v1) and new-style (v2) channel authentication proofs. Previously, the code only accepted v1 proofs and would reject v2 proofs with an error. The change is a feature completion / bug fix for the new gossip protocol support, not a fix for an active security vulnerability. It adds the matching SQL query and tests for both versions.
Security candidategraph/db: add version parameter to IsPublicNodeby Elle Mouton · 971c0f6e · Feb 13, 2026 · 6 filesMessage 78 · AdequateInformational 24Details
Commit message · Elle Mouton
graph/db: add version parameter to IsPublicNode
Make IsPublicNode version-aware by routing to the appropriate SQL query based on gossip version. V1 and v2 have different criteria for determining node publicity (v1 requires four signatures, v2 requires one). Convert TestNodeIsPublic to versioned test for both protocols.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundary
AI analysis · Informational 24/100
This commit updates how LND decides whether a Lightning node is 'public' so that the decision respects the network's gossip protocol version. In the older v1 protocol, a node needed four signatures to be considered public; in the newer v2 protocol, one signature is enough. Previously the code always used the v1 rule, which could misclassify v2 nodes as private. The change is a correctness fix rather than an obvious remote-exploitable vulnerability, but misclassified publicity could affect routing, channel selection, or policy decisions.
Security candidatesqldb/sqlc: add IsPublicV2Node queryby Elle Mouton · a99604c7 · Feb 13, 2026 · 3 filesMessage 73 · AdequateInformational 3Details
Commit message · Elle Mouton
sqldb/sqlc: add IsPublicV2Node query
Add SQL query to determine if a node has public v2 channels. Unlike v1 which requires all four individual signatures, v2 channels are considered public when the single aggregated signature is present.
73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 3/100
This commit adds a new database query helper that checks whether a Lightning node has any 'version 2' public channels. It is purely additive and does not change any existing behavior or fix a known bug. There is no indication in the commit that this is a security patch.
Security candidatesqldb/sqlc: add AddV2ChannelProof queryby Elle Mouton · 315f5ed7 · Feb 13, 2026 · 3 filesMessage 73 · AdequateInformational 15Details
Commit message · Elle Mouton
sqldb/sqlc: add AddV2ChannelProof query
Add SQL query to update the signature column for v2 channel auth proofs. Unlike v1 which requires four separate signatures, v2 channels use a single aggregated signature.
73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 15/100
This commit adds a new database query to support v2 Lightning channel proofs. It simply updates a single signature column for v2 channels, whereas the older v1 proof format required four separate signatures. There is no security issue visible in the change itself.
Security candidategraph/db: add version parameter to createEdge test helperby Elle Mouton · 6bb3bdc8 · Feb 13, 2026 · 1 fileMessage 88 · StrongInformational 15Details
Commit message · Elle Mouton
graph/db: add version parameter to createEdge test helper
Extend the createEdge test helper to accept a gossip version, enabling creation of both v1 and v2 test channels. V2 channels include the appropriate auth proof (single signature), merkle root hash, and funding script fields.
88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 15/100
This commit only changes test code. It extends a helper function used in unit tests so it can create both old-style (v1) and new-style (v2) fake Lightning channels for testing. No production code is modified, so it cannot directly affect real users or funds.
Security candidatemulti: update models.ChannelAuthProof with v2 fieldby Elle Mouton · 7a260ee1 · Feb 13, 2026 · 11 filesMessage 78 · AdequateLow 32Details
Commit message · Elle Mouton
multi: update models.ChannelAuthProof with v2 field
Also update it to more closely match the persisted version which has the v1 and v2 only fields as optional.
Refactor ChannelAuthProof to support both v1 and v2 channel announcements:
- Add Version field to distinguish v1 from v2 proofs - Wrap v1-specific fields (NodeSig1/2, BitcoinSig1/2) in fn.Option since v2 doesn't use them - Add optional Signature field for v2's single schnorr signature - Add constructor functions NewV1ChannelAuthProof and NewV2ChannelAuthProof to enforce correct initialization - Add getter methods (NodeSig1(), BitcoinSig1(), etc.) that safely unwrap options, returning empty slices when not present
The IsEmpty() check is updated to handle both versions correctly. Both stores validate v1-only for now.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
This commit refactors how Lightning Network channel authentication proofs are represented in the lnd codebase. It adds support for a future v2 channel announcement format (using a single Schnorr signature) while keeping v1 (four ECDSA signatures) as the only currently supported version. The change is structural and preparatory; it does not appear to fix an active security bug, nor does it introduce obvious new vulnerabilities. Both database stores explicitly reject v2 proofs for now.
Security candidategraph/db: update SQLStore to read and write v2 channelsby Elle Mouton · fa24d336 · Feb 13, 2026 · 2 filesMessage 78 · AdequateLow 30Details
Commit message · Elle Mouton
graph/db: update SQLStore to read and write v2 channels
Extends the SQL store to support v2 (taproot) channel announcements: - Add version validation in AddChannelEdge - Store v2-specific fields: FundingPkScript, MerkleRootHash, Signature - Update buildEdgeInfoWithBatchData to reconstruct v2 channels from DB with optional bitcoin keys and funding script handling - Add WithMerkleRootHash edge modifier for ChannelV2Fields
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Low 30/100
This commit extends LND's SQL graph database to store and retrieve a newer type of Lightning channel announcement (called 'v2' or 'taproot' channels). It adds support for new fields like funding scripts, Merkle root hashes, and a single signature, and it replaces hard-coded 'v1 only' checks with version-aware logic. There is no direct evidence in the commit that this fixes an active security bug; it reads as a feature-completion change to support a new protocol version.
Security candidatesqldb/sqlc: update graph CreateChannel query for v2by Elle Mouton · ec46480a · Feb 13, 2026 · 2 filesMessage 78 · AdequateInformational 15Details
Commit message · Elle Mouton
sqldb/sqlc: update graph CreateChannel query for v2
Add three new optional fields to the CreateChannel SQL query to support v2 channel announcements: - signature: single schnorr signature (replaces four ECDSA sigs) - funding_pk_script: the funding output script - merkle_root_hash: for taproot channels
These fields are NULL for v1 channels and populated for v2 channels.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 15/100
This commit updates a database query used to store Lightning Network channel announcements. It adds three new optional fields needed for newer 'v2' channel types (a single Schnorr signature, the funding output script, and a Merkle root hash). For older 'v1' channels these fields are left empty/NULL. There is no security fix or vulnerability here; it is a straightforward schema/query update to support a new channel format.
Security candidategraph/db: remove unused sig field from ChannelEdgePolicyby Elle Mouton · 6fda2e8d · Feb 13, 2026 · 2 filesMessage 78 · AdequateInformational 15Details
Commit message · Elle Mouton
graph/db: remove unused sig field from ChannelEdgePolicy
Remove the cached parsed signature field and its lazy getter method from ChannelEdgePolicy. This field was unused throughout the codebase and the signature is already stored as raw bytes in SigBytes.
The SetSigBytes method is updated to remove the cache invalidation logic.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 15/100
This commit removes an unused internal cache field that stored a parsed cryptographic signature alongside the raw signature bytes. It is a straightforward code cleanup with no security-relevant behavior change: callers still access the raw signature bytes, and the only consumer is updated to set the field directly instead of through a helper method.
actor: introduce generic Mailbox interface with iter.Seq support
This commit introduces a new Mailbox interface that abstracts the message queue implementation for actors. Previously, actors used a direct channel for their mailbox, which limited flexibility and made it difficult to implement alternative mailbox strategies.
The new Mailbox interface provides methods for sending, receiving, and draining messages, with full context support for cancellation. The Receive method leverages Go 1.23's iter.Seq pattern, providing a clean iterator-based API that allows natural for-range loops over messages.
The ChannelMailbox implementation maintains the existing channel-based behavior while conforming to the new interface. It stores the actor's context internally, ensuring both caller and actor contexts are properly respected during send and receive operations. This simplifies context handling compared to complex context merging approaches.
This abstraction enables future implementations such as priority mailboxes, persistent mailboxes, or bounded mailboxes with overflow strategies, without requiring changes to the actor implementation.
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Informational 12/100
This commit adds a new internal message-queue abstraction for LND's actor system. It is purely a refactoring/new-code change: it introduces a generic Mailbox interface and a channel-based implementation, with no existing callers shown and no obvious security bug. The code is defensive (uses mutexes and atomic flags to avoid send-on-closed-channel panics) and does not change any externally reachable behavior.