AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 51 Bitcoin

Merge pull request #10708 from jtobin/alias-perms

Public commit record

What the developer wrote

Authored by Olaoluwa Osuntokun

68/100 · Adequate
Merge pull request #10708 from jtobin/alias-perms

routerrpc: add XFindBaseLocalChanAlias to macPermissions
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a missing permission check on a new Lightning routing RPC called XFindBaseLocalChanAlias. Without the entry, any valid macaroon could call that RPC, bypassing the normal access-control list. The patch adds the required permission and a regression test that ensures every Router RPC has a matching permission entry.

Recommended action

Review the permissions assigned to XFindBaseLocalChanAlias to confirm "offchain:read" is the least-privilege requirement. Ensure the new regression test passes in CI and consider applying the same coverage test to other gRPC services.

Security signals we found

01

Missing macaroon authorization entry for an RPC endpoint

02

Potential privilege escalation: any valid macaroon could invoke an unprotected RPC

03

Regression test added to enforce macPermissions coverage

Risk score

Why this scored 51/100

Our methodology →
Potential impact 12/30
Exploitability 10/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.