AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 61 Bitcoin

Merge pull request #11330 from Roasbeef/remote-next-rev-option

Public commit record

What the developer wrote

Authored by ziggieXXX

73/100 · Adequate
Merge pull request #11330 from Roasbeef/remote-next-rev-option

lnwallet+chanstate: reject unexpected revocations, make RemoteNextRevocation an fn.Option
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit hardens how LND handles revocation messages during Lightning channel state updates. Previously, parts of the code treated a missing 'next revocation point' as a nil pointer, which could lead to state updates being applied in the wrong order or to invalid revocations partially updating the channel state. The change makes the optional nature of that point explicit, validates the revocation before touching stored secrets, and rejects unexpected revocations cleanly. It is a defensive bug-fix rather than a confirmed exploited vulnerability.

Recommended action

Treat this as a security-hardening bug fix and include it in the next maintenance release. Operators should upgrade to a version containing this commit. No immediate incident-response action is required unless anomalous channel-force-close patterns are already observed, in which case channels should be monitored for unexpected revocation errors.

Security signals we found

01

State-transition validation reordered before destructive bookkeeping in ReceiveRevocation

02

New error ErrUnexpectedRevocation returned when no unacked remote commitment exists

03

New error ErrNoNextRevocation returned when the remote next revocation point is unknown

04

Revocation secret added to RevocationStore only after point validation succeeds

05

Nil-pointer-like optional field converted to explicit fn.Option type

06

chain_watcher now refuses to sign a remote pending commitment if next revocation point is absent

07

Release notes explicitly label the change as a bug fix for revocation processing

Risk score

Why this scored 61/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 12/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.