AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 28 Bitcoin

walletrpc: support leases without expiry

Public commit record

What the developer wrote

Authored by yyforyongyu

78/100 · Adequate
walletrpc: support leases without expiry

Select the existing depth-one wallet lifetime through explicit flags.
Reuse capability resolution, caller ownership and acquisition rollback,
and report the effective policy through boolean acknowledgements.

Give conflicting lifetimes and invalid owner IDs stable error
identities. Cover acquisition, validation and same-owner renewal through
the public handlers. Remove count response assignments and the obsolete
count-based RPC integration test before retiring their generated
declarations.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
The short version

What changed, and why it matters

This commit changes how LND's wallet RPC lets users lock (lease) unspent bitcoin outputs. It adds a new 'no expiry' mode where a lease stays active until the output is spent and confirmed, instead of expiring after a set number of seconds. The change also removes an older confirmation-count based field from some responses and adds clearer error messages for conflicting lease settings. It is primarily a feature/API refactor, not a clear security fix or vulnerability.

Recommended action

Treat as a normal feature/API change. Review the generated protobuf changes (not shown) to confirm the new NoExpiry fields and removed count fields are correctly versioned. Ensure callers cannot accidentally create permanent locks by misusing the flag, and verify that owner-ID validation prevents the internal LND lock ID from being used for no-expiry leases.

Security signals we found

01

New RPC option changes lease lifetime semantics (no wall-clock expiry)

02

Stable error identities added for conflicting lease parameters and invalid owner IDs

03

Custom lock ID now required for persistent no-expiry input leases, with checks for zero and reserved internal IDs

04

Same-owner renewal preserves existing no-expiry/timed policy via readback

05

Old confirmation-count integration test removed; count response assignments retired

Risk score

Why this scored 28/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 6/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.