AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 35 Bitcoin

Merge pull request #11396 from yyforyongyu/task-lease-policy

Public commit record

What the developer wrote

Authored by Yong

73/100 · Adequate
Merge pull request #11396 from yyforyongyu/task-lease-policy

walletrpc: make no-expiry leases explicit
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit changes how LND's wallet locks (leases) unspent coins through its RPC interface. It removes a recently added 'release after N confirmations' option and replaces it with an explicit 'no expiry' flag. Old clients that still send the removed option now get a clear error instead of silently falling back to a timed lease. The change is a deliberate API cleanup with security-relevant hardening against silent downgrade, but it is not a fix for an active vulnerability.

Recommended action

Operators and integrators using `LeaseOutput` or `FundPsbt` should migrate before upgrading: replace any use of `release_after_spend_confs` / `input_release_after_spend_confs` with `no_expiry` / `input_lease_no_expiry`, ensure a persisted custom lock ID is used for no-expiry input leases, and verify the returned `no_expiry` acknowledgement. Review any logic that relied on leases surviving a reorg or being released after N confirmations, because no-expiry leases now release at first confirmed spend and do not survive reorgs.

Security signals we found

01

Breaking API change that reserves removed protobuf fields to prevent accidental reintroduction

02

Explicit rejection of legacy `release_after_spend_confs` parameters from old clients instead of silent fallback

03

Validation prevents conflicting no-expiry + duration lease settings before wallet state is touched

04

Custom lock ID required for no-expiry input leases to prevent accidental shared ownership

05

Reorg behavior changed: no-expiry leases are removed at first confirmed spend and are not restored by a reorg

Risk score

Why this scored 35/100

Our methodology →
Potential impact 8/30
Exploitability 5/25
Stealth signal 4/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.