AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 39 Bitcoin

Merge pull request #11374 from bitromortac/20261016-c7e5-dispatch

Public commit record

What the developer wrote

Authored by bitromortac

73/100 · Adequate
Merge pull request #11374 from bitromortac/20261016-c7e5-dispatch

bolt12handler+devrpc: dispatch invoice requests and add CreateOffer
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds the first end-to-end BOLT 12 'Offers' flow to LND: a new dev-only RPC and CLI command to create offers, plus a dispatcher that listens for incoming onion-message invoice requests and replies with signed BOLT 12 invoices. It also adds rate/inflight limits and reply-path handling to avoid obvious DoS, but the feature is gated behind dev/native-SQL builds and explicitly marked as not yet returning invoice_error replies for failed requests.

Recommended action

Treat this as an early-stage feature merge rather than an active vulnerability. Reviewers should monitor for: completeness of invoice_error replies, robust validation of invoice-request signatures/amounts/quantities, correct handling of malformed reply paths, and whether the rate/concurrency limits adequately protect against CPU/queue exhaustion. Because it is dev-only and opt-in, no immediate production action is required.

Security signals we found

01

New network-facing dispatcher answers invoice requests from any peer; rate and concurrency limits are applied

02

Blinded-path PathID check prevents reply linking to self-created paths, but TODO notes the check should move once offers can have offer_paths

03

CreateOffer RPC is restricted to dev builds and requires offchain:write macaroon permission

04

BOLT 12 handler is only instantiated when offerStore (native SQL/dev migrations) is present

05

Release notes explicitly state 'A failed request gets no invoice_error reply yet', indicating incomplete error handling

06

HopPeeler decrypts own-hop recipient data to advance reply path; malformed data is logged and dropped

Risk score

Why this scored 39/100

Our methodology →
Potential impact 8/30
Exploitability 7/25
Stealth signal 6/15
Affected reach 7/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.