EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsActive incident
Repository coverage

1361 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

108security candidates322second-pass queue1084AI analyses
90commits · 30 days
200commits · 60 days
570commits · 180 days
1124commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
252Strong · 80–100
675Adequate · 60–79
388Thin · 40–59
46Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight42533373163
ThomasV16511104163
ghost4376626170
f321x44128400070
Sander van Grieken12412112057
Felix54720070
user323062
ekzyis222053
accumulator28111072
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 24 minutes ago

Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11172 from accumulator/qml_crash_reporter_threading

This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…

Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
45ad42f7by Felix+4−11 file
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: crash reporter: handle threading.excepthook arguments

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…

Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
2e7fe460by Sander van Grieken+4−11 file
No security note in commit
Low 40 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…

Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
ff273162by ThomasV+4−11 file
No security note in commit
Low 29 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

wallet: make_unsigned_tx: follow-up prev

This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…

Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
462f631dby SomberNight+2−01 file
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11097 from SomberNight/202610_bump_deps

This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…

Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
84345fdcby ghost43+934−103048 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11139 from accumulator/consolidate_platform_checks

This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…

22e24580by ghost43+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

consolidate platform checks into platform.py

This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…

9715f882by Sander van Grieken+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

version: bump to 4.8.4

This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.

0c661eb8by f321x+1−11 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

make_unsigned_transaction: do not require coins if there is a base_tx

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…

Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
876360deby ThomasV+2−11 file
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11111 from accumulator/qml_bip39recovery_task_refactor

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…

Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
896a68d7by Felix+44−332 files
No security note in commit
Informational 12 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: refactor BIP39 account scan to asyncio tasks.

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…

00ed883aby Sander van Grieken+44−332 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: paytoedit: complete contacts to their key, not 'name <key>'

This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…

UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
dd1b50fbby f321x+47−132 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11092 from f321x/qml_address_history_labels

This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…

No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
9242c505by Felix+334−8412 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: avoid potential Ok signal by tapping while dialog is closing,

This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…

Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
00f981edby Sander van Grieken+8−01 file
No security note in commit
Informational 21 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11091 from f321x/fix_num_parents_perf_simple

This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …

Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
4ec70746by ThomasV+82−463 files
No security note in commit
Informational 24 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11047 from fametrano/old-seed-odd-length

This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…

Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
fc31115eby ghost43+93−157 files
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11096 from f321x/followup_11094

This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…

Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
54c355feby Felix+9−75 files
No security note in commit
Informational 23 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11094 from devdavidejesus/fix-10760-storage-not-utf8

This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…

Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
2a20256fby Felix+10−12 files
No security note in commit
Informational 20 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: show StorageReadWriteError to user instead of crash reporting it

This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…

No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
5a971b11by f321x+2−11 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

keystore: follow-up prev: small clean-up

This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…

Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
ead42d09by SomberNight+35−154 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedhww/qt: followup 898a4c270by f321x · f3af41de · Jul 30, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · f321x

hww/qt: followup 898a4c270

Also make the other attribute private

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply renames an internal variable from `dialog_label` to `_dialog_label` to mark it as private. It is a minor code cleanup with no visible behavior change and no security relevance.

Security candidatetrezor: drop session after closing itby f321x · 071b1e24 · Jul 30, 2026 · 1 fileMessage 68 · AdequateLow 25Details
Commit message · f321x

trezor: drop session after closing it

Set `TrezorClientBase._session = None` after closing a session
(e.g. after session timeout) so the next session access will prompt
for the pin on the device instead of throwing an `InvalidSessionError`
when trying to access the device.

E.g. when trying to sign a tx after the session timed out:
```
80.64 | I | plugins.trezor.clientbase.TrezorClientBase | timed out
80.64 | I | plugins.trezor.clientbase.TrezorClientBase | clear session: <electrum.plugins.trezor.clientbase.TrezorClientBase object at 0x7f24cd34f080>
80.64 | I | plugins.trezor.clientbase.TrezorClientBase | locking: <trezorlib.protocol_v1.TrezorClientV1 object at 0x7f24cd34e160>
80.90 | I | plugins.trezor.clientbase.TrezorClientBase | closing: SessionV1(id=d5e6015e501acf4b10b3a3e50f1f9307768e434330568e7d5e7b1babed066438)
112.83 | I | plugin.DeviceMgr | getting client for keystore
112.83 | I | plugin.DeviceMgr | end client for keystore
113.10 | I | plugin.DeviceMgr | getting client for keystore
113.10 | I | plugin.DeviceMgr | end client for keystore
113.11 | E | gui.qt.main_window.[trezor] | on_error
Traceback (most recent call last):
File "/var/home/user/code/code_vm/electrum/electrum/gui/common_qt/util.py", line 165, in run
result = task.task()
File "/var/home/user/code/code_vm/electrum/electrum/wallet.py", line 2822, in sign_transaction
k.sign_transaction(tmp_tx, password)
~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/var/home/user/code/code_vm/electrum/electrum/plugins/trezor/trezor.py", line 100, in sign_transaction
self.plugin.sign_transaction(self, tx, prev_tx)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^
File "/var/home/user/code/code_vm/electrum/electrum/plugin.py", line 1000, in wrapper
return run_in_hwd_thread(partial(func, *args, **kwargs))
File "/var/home/user/code/code_vm/electrum/electrum/plugin.py", line 993, in run_in_hwd_thread
return fut.result()
~~~~~~~~~~^^
File "/usr/lib64/python3.14/concurrent/futures/_base.py", line 454, in result
return self.__get_result()
~~~~~~~~~~~~~~~~~^^
File "/usr/lib64/python3.14/concurrent/futures/_base.py", line 396, in __get_result
raise self._exception
File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 86, in run
result = ctx.run(self.task)
File "/usr/lib64/python3.14/concurrent/futures/thread.py", line 73, in run
return fn(*args, **kwargs)
File "/var/home/user/code/code_vm/electrum/electrum/plugins/trezor/trezor.py", line 344, in sign_transaction
signatures, _ = client.sign_tx(self.get_coin_name(),
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
inputs, outputs,
^^^^^^^^^^^^^^^^
...<3 lines>...
serialize=False,
^^^^^^^^^^^^^^^^
prev_txes=prev_tx)
^^^^^^^^^^^^^^^^^^
File "/var/home/user/code/code_vm/electrum/electrum/plugin.py", line 1000, in wrapper
return run_in_hwd_thread(partial(func, *args, **kwargs))
File "/var/home/user/code/code_vm/electrum/electrum/plugin.py", line 990, in run_in_hwd_thread
return func()
File "/var/home/user/code/code_vm/electrum/electrum/plugins/trezor/clientbase.py", line 356, in sign_tx
return trezorlib.btc.sign_tx(self.session, *args, **kwargs)
~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/var/home/user/code/code_vm/electrum/env/lib64/python3.14/site-packages/trezorlib/tools.py", line 379, in wrapper
result = self.func(session, *args, **kwargs)
File "/var/home/user/code/code_vm/electrum/env/lib64/python3.14/site-packages/trezorlib/btc.py", line 329, in sign_tx
res = session.call(signtx, expect=messages.TxRequest)
File "/var/home/user/code/code_vm/electrum/env/lib64/python3.14/site-packages/trezorlib/client.py", line 113, in call
raise exceptions.InvalidSessionError(self.id)
trezorlib.exceptions.InvalidSessionError: b'\xd5\xe6\x01^P\x1a\xcfK\x10\xb3\xa3\xe5\x0f\x1f\x93\x07v\x8eCC0V\x8e}^{\x1b\xab\xed\x06d8'
```

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundaryaccess control
AI analysis · Low 25/100

This commit fixes a bug in Electrum's support for Trezor hardware wallets. After a Trezor session times out or is closed, Electrum now forgets the old session ID. Previously it kept the stale session ID, so the next attempt to sign a transaction would crash with an InvalidSessionError instead of asking the user for their PIN again. It is a usability/reliability fix, not a direct theft-of-funds vulnerability, because the failure mode was a crash rather than an unauthorized transaction.

AI review queuedtest_lnwallet: add unittest for unchanged channel update from failed htlcby f321x · 1f5b9adb · Jul 30, 2026 · 1 fileMessage 83 · StrongInformational 12Details
Commit message · f321x

test_lnwallet: add unittest for unchanged channel update from failed htlc

Tests that a TEMPORARY_CHANNEL_FAILURE whose channel update leaves the
policy unchanged does not blacklist the channel (the liquidity hint is
sufficient), while other failure codes still blacklist.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds a new unit test to Electrum's Lightning wallet test suite. It checks that when a payment fails due to a temporary lack of liquidity (TEMPORARY_CHANNEL_FAILURE) and the accompanying channel policy update is identical to what the wallet already knows, the channel is not blacklisted. Instead, only a 'liquidity hint' is recorded so smaller retry amounts can still use the channel. For other failure types, even an unchanged update still causes blacklisting. There is no production code change here.

Lower-prioritylnwallet: rename flag in handle_error_code_from_failed_htlcby f321x · 8e3aed1f · Jul 30, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · f321x

lnwallet: rename flag in handle_error_code_from_failed_htlc

As with the previous commit it is not strictly updating anything
when returning (False, True), so calling the second return value
`handled` instead of `updated` might be less misleading.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit only renames a local variable from 'update' to 'handled' in a Lightning Network payment-failure handler. It does not change any program logic, behavior, or security properties. The change is purely cosmetic/clarifying.

Lower-prioritylnwallet: don't blacklist chan on unchanged channel updateby f321x · 6a97e74c · Jul 30, 2026 · 1 fileMessage 73 · AdequateLow 45Details
Commit message · f321x

lnwallet: don't blacklist chan on unchanged channel update

Stop blacklisting a channel for 1h if they send us a
`TEMPORARY_CHANNEL_FAILURE` containing a channel update we already
know about.

If our channel db is up-to-date it is quite likely they will send
us a channel policy we already know about. However it might just
mean that the htlc we sent exceeds their available liquidity.
For this purpose we already record liquidity hints in `LNPathFinder`
so future attempts through this channel will consider this limitation,
no need to blacklist the whole channel for 1h and render it unusable for us.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 45/100

This commit fixes a bug in Electrum's Lightning payment routing. Previously, if a payment failed because a channel didn't have enough money (a temporary liquidity issue), Electrum would incorrectly 'blacklist' that channel for an hour, even when it already knew the channel's rules. This made future payments through that channel impossible for an hour, even when smaller payments would have worked. The fix stops this unnecessary blacklisting and instead relies on recorded liquidity hints to retry with smaller amounts.

Lower-prioritylnrouter: LiquidityHints: add note about thread-safetyby SomberNight · a3bb67b7 · Jul 29, 2026 · 1 fileMessage 65 · AdequateInformational 11Details
Commit message · SomberNight

lnrouter: LiquidityHints: add note about thread-safety

and maybe make reading the LiquidAmounts thread-safe(?) without actually locking

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 11/100

This commit adds a code comment warning that a performance-sensitive part of Electrum's Lightning payment routing reads shared data without a lock. It also makes a tiny code change to store a reference to an object before reading it, which slightly reduces the chance of a value changing between two consecutive reads. There is no actual fix for a race condition, and no evidence this is exploitable as a security vulnerability.

Lower-prioritylnrouter: (trivial) rename LiquidityHintItem -> LiquidAmountby SomberNight · 0c14d740 · Jul 29, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · SomberNight

lnrouter: (trivial) rename LiquidityHintItem -> LiquidAmount

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a simple, non-functional rename of a class and all references to it. No behavior of the program changes, and there is no security relevance.

Lower-prioritylnrouter: add note about can_pay() false positives for concurrent MPP routesby SomberNight · 82b6602a · Jul 29, 2026 · 1 fileMessage 50 · ThinInformational 11Details
Commit message · SomberNight

lnrouter: add note about can_pay() false positives for concurrent MPP routes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 11/100

This commit only adds a code comment explaining a known limitation in Electrum's Lightning payment routing. It does not change any behavior. The note warns that when sending a payment split across multiple routes (multi-path payments, or MPP), the router's check of whether a channel can afford a given amount may occasionally give a wrong answer because it doesn't yet know about other routes being constructed at the same time. This is a documentation-only change, not a fix or an active vulnerability.

Lower-prioritylnrouter: use separate timestamp per liquidity hint valueby f321x · 03c2b412 · Jul 29, 2026 · 2 filesMessage 85 · StrongModerate 51Details
Commit message · f321x

lnrouter: use separate timestamp per liquidity hint value

Use a separate timestamp for each value in a `LiquidityHint`
instead of a single shared one for all values.

Fixes:
1. We send 1M sat, failure, record cannot_send = 1M
2. Two hours pass, hint expired (shared ts reset)
3. We send 10k, update_can_send resets the shared ts
> cannot_send is active again, even though it is outdated
> We won't try sending >1M sat through the channel until the
process is restarted and the in-memory data is gone.

The setter method comparisons now also use the value from the getter
to prevent an expired larger value from blocking a new smaller one.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Moderate 51/100

This commit fixes a bug in Electrum's Lightning payment routing that could cause the wallet to avoid using a channel for large payments longer than it should. After a small payment succeeded, an old record of a failed large payment could incorrectly become active again, making Electrum think the channel still could not handle large amounts until the app was restarted. The fix gives each routing hint its own expiration timestamp instead of sharing one across all hints.

Lower-prioritylnrouter: LiquidityHints: add comment to update_liquidity_hintsby SomberNight · c1342d00 · Jul 29, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · SomberNight

lnrouter: LiquidityHints: add comment to update_liquidity_hints

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only renames an internal method from update_inflight_htlcs to update_num_inflight_htlcs and expands a code comment explaining how Lightning Network payment routing hints are updated. There are no functional code changes and no security relevance.

Lower-prioritylnrouter: LiquidityHints: add more type hintsby SomberNight · cee9f06d · Jul 29, 2026 · 3 filesMessage 68 · AdequateInformational 15Details
Commit message · SomberNight

lnrouter: LiquidityHints: add more type hints

and rename "amount" to "amount_msat"
- it's an easy mistake to pass an amount with a different unit, and we don't have type-checking against that... this is the least we should do

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a code-quality refactor: it adds Python type hints and renames variables from 'amount' to 'amount_msat' in Electrum's Lightning routing code to make it clear amounts are in millisatoshis. There is no functional behavior change and no security fix.

AI review queuedtest_lnwallet: add unittest for single channel mpp split configby f321x · 14f7fa0b · Jul 28, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · f321x

test_lnwallet: add unittest for single channel mpp split config

Tests that all parts of a multi-part payment over a single channel
are constructed using the channel of the split configuration.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit adds a new automated test to the Electrum project. It does not change any production wallet or Lightning code. The test verifies that when Electrum splits a multi-part payment across a single channel, all payment parts actually use that chosen channel rather than letting the pathfinder pick a different cheaper route. It is purely a test-case addition.

Lower-prioritytests: move ln graph definitions and prepare_invoice to lnhelpers.pyby f321x · e281a4c4 · Jul 28, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · f321x

tests: move ln graph definitions and prepare_invoice to lnhelpers.py

This makes them reusable from test files other than test_lnpeer and
removes the deferred test_lnpeer import in prepare_chans_and_peers_in_graph.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit is purely a test-code refactoring: it moves Lightning Network test helpers (graph definitions and an invoice preparation function) from one test file to another shared helper file. There is no change to production code, no security fix, and no vulnerability introduced.

Lower-prioritylnwallet: use split config channel for single channel mppby f321x · bf1b4a1b · Jul 28, 2026 · 1 fileMessage 85 · StrongLow 30Details
Commit message · f321x

lnwallet: use split config channel for single channel mpp

Use the channel returned by the split config when sending a
single channel mpp (multiple parts on a single channel), instead
of allowing the pathfinding to use any channel.
Otherwise it can happen that we have a good split config fitting a
specific channel, but the pathfinding then tries to put both parts
on another channel that cannot handle the sum of the parts, raising
at _assert_can_add_htlc later on and failing the payment.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 30/100

This commit fixes a bug in Electrum's Lightning payment logic. When sending a payment split into multiple parts over a single channel, the app could previously ignore the intended channel and route all parts through a different channel that lacked enough capacity. That caused the payment to fail with an internal assertion error. The fix ensures the chosen channel from the split configuration is actually used.

Lower-prioritytests: check liquidity hints are updated for all htlcsby f321x · 2f82eca1 · Jul 27, 2026 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · f321x

tests: check liquidity hints are updated for all htlcs

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds new automated tests for Electrum's Lightning payment routing code. It checks that internal 'liquidity hints' correctly track in-flight payment parts and are cleaned up after multipart payments succeed or time out. There are no changes to production wallet code, so users are not directly affected by this patch.

Lower-prioritylnworker/lnrouter: update liquidity hints in htlc callbacksby f321x · b176c50a · Jul 27, 2026 · 2 filesMessage 73 · AdequateLow 34Details
Commit message · f321x

lnworker/lnrouter: update liquidity hints in htlc callbacks

Update the channel liquidity hints in the
`htlc_fulfilled`/`htlc_failed` callbacks instead of the htlc
log handler (`_process_htlc_log()`).
`_process_htlc_log()` would raise `PaymentSuccess()` on the first fulfilled
htlc, removing the inflight htlcs counted in `LiquidityHintMgr` only for this
htlc's route.
All other htlcs that arrive later would leak and not get removed anywhere,
so the inflight htlc counter didn't get decreased and successful routes
would be punished by the penalty.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 34/100

This commit fixes a bug in Electrum's Lightning payment routing. Previously, when a multi-part payment succeeded, only the first successful payment chunk properly updated the wallet's internal channel-liquidity bookkeeping. Later chunks were never cleaned up, so the wallet kept treating those routes as if they still had money in flight. Over time this could make the wallet wrongly avoid or penalize channels that had actually worked fine, degrading payment reliability. The fix moves the cleanup into the proper success/failure callbacks so every chunk is accounted for.

Lower-prioritytest_lnpeer: add unittest for mpp fee budget checkby f321x · 42cb99d0 · Jul 27, 2026 · 1 fileMessage 50 · ThinInformational 12Details
Commit message · f321x

test_lnpeer: add unittest for mpp fee budget check

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum's Lightning code. It checks that when a payment is split into multiple parts (MPP), the fee budget is correctly shared across all parts so total fees cannot exceed the budget. There is no change to production code, no bug fix, and no security patch in this commit itself.

Lower-priorityLNWallet: fix fee budget check regressionby f321x · fc407c39 · Jul 27, 2026 · 1 fileMessage 78 · AdequateModerate 63Details
Commit message · f321x

LNWallet: fix fee budget check regression

The fee budget during local pathfinding route creation incorrectly
compared the full payment amount against the full budget on every
route instead of the partial amount against its fraction of the budget.
This is a regression introduced by df5c8c4c9 and makes it possible
for a payment to exceed the budget or a route to be incorrectly considered
too expensive.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Moderate 63/100

This commit fixes a bug in Electrum's Lightning Network payment routing. When splitting a payment into multiple parts, the app was checking each partial route's fees against the entire payment's fee budget instead of that part's fair share. This could cause a payment to silently overspend on fees, or wrongly reject a valid route as too expensive. The fix makes each partial route responsible only for its proportional share of the fee budget.

Lower-priorityci: bump security review ci model to opus 5by Felix · 1334146d · Jul 27, 2026 · 1 fileMessage 77 · AdequateInformational 15Details
Commit message · Felix

ci: bump security review ci model to opus 5

Bump the LLM used by the security review CI script from Claude Opus 4.8 to Claude Opus 5

77/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
AI analysis · Informational 15/100

This commit simply changes the version string of an AI model used by an internal continuous-integration (CI) security-review script. It does not modify Electrum wallet code, cryptography, networking, or any user-facing behavior. There is no indication this introduces or fixes a security vulnerability.

Lower-priorityqt: rename color themes (the user-visible names of the themes)by SomberNight · 1408d6d4 · Jul 23, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · SomberNight

qt: rename color themes (the user-visible names of the themes)

"Light" is actually the Platform-dependent system theme, where we let Qt define the palette and it leave it alone. Qt in turn mostly defers to the OS. On modern windows/macos/gnome/kde/etc, if the OS is set to "dark mode", Electrum will end up using a system-specific dark mode. Hence the name "Light" is confusing.

"Dark" is the qdarkstyle theme, which is largely platform-independent.

I think it's fine if these names are not completely "user-friendly".

closes https://github.com/spesmilo/electrum/issues/10767

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit simply renames two color theme labels shown in Electrum's settings window. 'Light' is renamed to 'System' and 'Dark' is renamed to 'qdarkstyle' to better describe what each option actually does. There are no code logic changes, no security fixes, and no behavior changes beyond the visible text.

AI review queuedjson_db: set_modified after incomplete databy f321x · f75f1958 · Jul 21, 2026 · 2 filesMessage 80 · StrongLow 47Details
Commit message · f321x

json_db: set_modified after incomplete data

Set the JsonDB modified after `maybe_load_incomplete_data`
removed a corrupted patch. Otherwise we might not override
the file on disk, append more patches and lose them all again
on the next reload.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 47/100

This commit fixes a bug in Electrum's wallet storage recovery. If a wallet file was partially corrupted (a 'patch' was cut off mid-write), the app could recover the old data but then fail to mark the wallet as changed. As a result, later updates might be appended to the still-corrupted file instead of replacing it, and those updates could be lost the next time the wallet was opened. The fix marks the wallet as modified after recovery so it gets rewritten cleanly. This is a data-loss bug, not a remote attack.

Lower-priorityjson_db: escape '\' and '~' in json patch pointerby f321x · 97007d9e · Jul 21, 2026 · 2 filesMessage 88 · StrongModerate 59Details
Commit message · f321x

json_db: escape '\' and '~' in json patch pointer

> Because the characters '~' (%x7E) and '/' (%x2F) have special
meanings in JSON Pointer, '~' needs to be encoded as '~0' and '/'
needs to be encoded as '~1' when these characters appear in a
reference token.

https://www.rfc-editor.org/info/rfc6901/

88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
AI analysis · Moderate 59/100

This commit fixes a bug in how Electrum builds JSON Patch pointers when wallet data contains special characters like '/' or '~' in keys. Before the fix, these characters were not escaped, which could cause patch operations to target the wrong location in the wallet database or fail. The fix follows RFC 6901 by escaping '~' as '~0' and '/' as '~1'. This is a data-integrity bug in wallet storage synchronization, but the commit itself does not describe it as a security vulnerability.

AI review queuedwallet_db: register onion_keys converterby f321x · 5b2eb060 · Jul 21, 2026 · 2 filesMessage 58 · ThinLow 44Details
Commit message · f321x

wallet_db: register onion_keys converter

`Channel.onion_keys` had no registered converter for hex -> bytes, causing
`pop_onion_key()` to return a hex str instead of bytes after the keys
got loaded from db following a restart.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit fixes a bug in Electrum's Lightning wallet database handling. After a wallet restart, a specific type of encryption key used in Lightning payments was being loaded as a text string instead of raw bytes. This mismatch could cause payment error decoding to fail or behave incorrectly, potentially leading to misleading error reports or degraded handling of failed Lightning transactions. The patch registers a proper converter so the keys are loaded as bytes, and adds a warning log when decoding fails.

Security candidateqml: update ConfirmTxDialog onValidChangedby f321x · bd776e24 · Jul 14, 2026 · 1 fileMessage 58 · ThinInformational 18Details
Commit message · f321x

qml: update ConfirmTxDialog onValidChanged

Commit 2de11eac923d51befe44dcc748505714196a7f2c gated the
ConfirmTxDialog amount behind `finalizer.valid`.
When sweeping private keys from the sweep view the resulting
`ConfirmTxDialog` is not valid in the beginning, and after it
turns valid nothing causes it to update. This results in the amount
being displayed as `0` even after it finished fetching the keys balances.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
secret or key material
AI analysis · Informational 18/100

This is a small user-interface fix for the Electrum mobile/QML app. When sweeping private keys, the confirmation dialog that shows how much money will be moved initially displayed an amount of 0 because it did not refresh after the transaction became valid. The patch makes the dialog refresh its amount display when validity changes, so users see the correct amount before confirming. There is no security vulnerability here.

Lower-priorityswaps: destroy swap transport on failed initializationby f321x · c5a38e5a · Jul 14, 2026 · 2 filesMessage 85 · StrongLow 26Details
Commit message · f321x

swaps: destroy swap transport on failed initialization

Call `swap_transport.destroy()` when the swap transport initialization
task fails, otherwise the task will keep the swap transport tasks alive,
leaking a swap transport for each failed connection attempt.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 26/100

This commit fixes a resource leak in Electrum's submarine-swap feature. When a connection to a swap server failed to start, the program was not properly cleaning up the connection object, so each failed attempt could leave behind leftover background tasks and memory. The patch now explicitly destroys the failed transport object before discarding it. This is a reliability bug rather than an active security vulnerability, though resource leaks can in some cases contribute to denial-of-service conditions.