qt: rename color themes (the user-visible names of the themes)
What the developer wrote
Authored by SomberNight
qt: rename color themes (the user-visible names of the themes)
"Light" is actually the Platform-dependent system theme, where we let Qt define the palette and it leave it alone. Qt in turn mostly defers to the OS. On modern windows/macos/gnome/kde/etc, if the OS is set to "dark mode", Electrum will end up using a system-specific dark mode. Hence the name "Light" is confusing.
"Dark" is the qdarkstyle theme, which is largely platform-independent.
I think it's fine if these names are not completely "user-friendly".
closes https://github.com/spesmilo/electrum/issues/10767
What changed, and why it matters
This commit simply renames two color theme labels shown in Electrum's settings window. 'Light' is renamed to 'System' and 'Dark' is renamed to 'qdarkstyle' to better describe what each option actually does. There are no code logic changes, no security fixes, and no behavior changes beyond the visible text.
No security action needed. This is a non-security UI labeling change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is a two-line string update in electrum/gui/qt/settings_dialog.py. It changes the user-visible labels in a QComboBox for selecting the Qt color theme. The underlying values (‘default’ and ‘dark’) and all surrounding logic remain unchanged. It is a UI clarity/usability patch only.
Changed components
electrum/gui/qt/settings_dialog.pyInspect captured patch +2 / −2
diff --git a/electrum/gui/qt/settings_dialog.py b/electrum/gui/qt/settings_dialog.py
index 81a7eb4..e37c834 100644
--- a/electrum/gui/qt/settings_dialog.py
+++ b/electrum/gui/qt/settings_dialog.py
@@ -205,8 +205,8 @@ class SettingsDialog(QDialog, QtEventListener):
qr_combo.currentIndexChanged.connect(on_video_device)
colortheme_combo = QComboBox()
- colortheme_combo.addItem(_('Light'), 'default')
- colortheme_combo.addItem(_('Dark'), 'dark')
+ colortheme_combo.addItem(_("System"), "default")
+ colortheme_combo.addItem("qdarkstyle", "dark")
index = colortheme_combo.findData(self.config.GUI_QT_COLOR_THEME)
colortheme_combo.setCurrentIndex(index)
colortheme_label = QLabel(self.config.cv.GUI_QT_COLOR_THEME.get_short_desc() + ':')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.