What the developer wrote
Authored by f321x
qml: update ConfirmTxDialog onValidChanged
Commit 2de11eac923d51befe44dcc748505714196a7f2c gated the
ConfirmTxDialog amount behind `finalizer.valid`.
When sweeping private keys from the sweep view the resulting
`ConfirmTxDialog` is not valid in the beginning, and after it
turns valid nothing causes it to update. This results in the amount
being displayed as `0` even after it finished fetching the keys balances.
What changed, and why it matters
This is a small user-interface fix for the Electrum mobile/QML app. When sweeping private keys, the confirmation dialog that shows how much money will be moved initially displayed an amount of 0 because it did not refresh after the transaction became valid. The patch makes the dialog refresh its amount display when validity changes, so users see the correct amount before confirming. There is no security vulnerability here.
No security action needed. Treat as a normal UI bug fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The QML ConfirmTxDialog component now listens to the finalizer’s onValidChanged signal and calls updateAmountText(). This corrects a stale UI state introduced by commit 2de11eac, which gated the displayed amount on finalizer.valid. Previously, if the dialog started invalid (e.g., during a private-key sweep while balances were being fetched), the amount text was never updated once the finalizer became valid, leaving 0 shown to the user.
Changed components
electrum/gui/qml/components/ConfirmTxDialog.qmlInspect captured patch +3 / −0
diff --git a/electrum/gui/qml/components/ConfirmTxDialog.qml b/electrum/gui/qml/components/ConfirmTxDialog.qml
index 2faa088..78e5638 100644
--- a/electrum/gui/qml/components/ConfirmTxDialog.qml
+++ b/electrum/gui/qml/components/ConfirmTxDialog.qml
@@ -112,6 +112,9 @@ ElDialog {
function onEffectiveAmountChanged() {
updateAmountText()
}
+ function onValidChanged() {
+ updateAmountText()
+ }
}
}
}
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.