BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3170 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

318security candidates668second-pass queue3006AI analyses
148commits · 30 days
327commits · 60 days
1300commits · 180 days
2862commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
1175Strong · 80–100
1206Adequate · 60–79
701Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script2024588389
Antoine Poinsot22422170
Ava Chow19868191069
MarcoFalke41421408074
fanquake23121228058
Lőrinc18121177081
Hennadii Stepanov22316211064
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 28 minutes ago

Low 32 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…

Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
ed7dd7cfby Ava Chow+36−203 files
No security note in commit
Low 28 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…

New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
f80aaf4bby Ava Chow+303−7930 files
No security note in commit
Moderate 64 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …

Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
e19f83e9by Ava Chow+37−82 files
Vendor flagged security relevance
Low 35 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…

Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
65e075f8by Ava Chow+2−21 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…

d26f19c7by Ava Chow+5−42 files
No security note in commit
Low 44 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …

Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
e8e7e91aby Ava Chow+43−14 files
No security note in commit
Informational 18 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md

This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…

No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
bfdcd979by merge-script+2−21 file
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35675: mining: add block template manager

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…

Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
5c726f20by Ryan Ofsky+561−44926 files
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …

New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
be5d0b55by Ava Chow+6951−010 files
No security note in commit
Low 45 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35440: wallet: check descriptor cache xpub length before decoding

This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…

Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
b3f846ecby Ava Chow+225−8511 files
Vendor flagged security relevance
Informational 20 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35813: wallet, rpc: Add listrawtransactions RPC

This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…

No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
2b95b45aby Ava Chow+334−276 files
No security note in commit
Moderate 68 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35752: wallet: make encryption state updates atomic

This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …

Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
7ee3d622by Ava Chow+379−16418 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-ups

This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …

248ce46fby merge-script+18−244 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36261: test: cover PSBT unknown field merging

This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…

bbc40edeby merge-script+130−01 file
No security note in commit
Informational 18 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followups

This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…

No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
4a583f38by merge-script+97−429 files
No security note in commit
Informational 21 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…

OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
5f05d8c5by merge-script+6−63 files
No security note in commit
Informational 20 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

rpc: Correct OpenRPC default metadata

This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…

No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
b7f740c5by will+6−63 files
No security note in commit
Informational 24 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36286: crypto: Fix MuHash3072 division by itself

This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…

Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
d48e76e6by merge-script+11−13 files
No security note in commit
Informational 18 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36285: refactor: Use static const over inline const to work around ld64 bug

This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…

No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
ad97933aby merge-script+8−82 files
No security note in commit
Informational 23 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34861: wallet: Add importdescriptors interface

This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…

Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
2bbbeaa6by Ava Chow+619−26415 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedwallet: mark `bip125-replaceable` key as deprecated in transaction RPCsby rkrux · c4a7613e · May 21, 2026 · 5 filesMessage 73 · AdequateInformational 20Details
Commit message · rkrux

wallet: mark `bip125-replaceable` key as deprecated in transaction RPCs

Transactions are replaceable by default since v28 and the corresponding
tweaking argument has been removed since v29. The related key from the
mempool RPC has been marked deprecated as well since v29, this patch
does the same for the wallet transaction RPCs such as listtransactions,
listsinceblock, and gettransaction.

Users can pass the -deprecatedrpc=bip125 startup argument to retrieve
this key in the responses of above mentioned RPCs.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This is a routine Bitcoin Core change that hides an old transaction status field called 'bip125-replaceable' from wallet RPC responses by default, marking it as deprecated. Users can still get it back by starting the node with -deprecatedrpc=bip125. It is not a security fix and does not introduce a vulnerability; it is a user-interface/API cleanup following earlier changes that made transactions replaceable by default.

Lower-prioritytest: Add test for BuildSkip() and skip heightsby optout · 131fa570 · May 21, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · optout

test: Add test for BuildSkip() and skip heights

Add new test that calls `CBlockIndex::BuildSkip()` and verifies skip height values.
It tests that:
- `pprev` field is set (to an earlier block index),
- the skip is to the index as dictated by the `GetSkipHeight()` bit-manipulation logic.

Co-authored-by: sipa <pieter@wuille.net>
Co-authored-by: Lőrinc <pap.lorinc@gmail.com>

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new automated test for an existing Bitcoin Core data structure. It does not change any production code, network behavior, or wallet logic. There is no security issue here.

AI review queuedrpc: Fix for duplicate external signers caseby optout · f05b1a35 · May 21, 2026 · 2 filesMessage 78 · AdequateLow 25Details
Commit message · optout

rpc: Fix for duplicate external signers case

In case of multiple external signers, with some duplicates,
de-duplicate them: keep one signer per fingerprint, and
keep all non-duplicates as well. Add a new test check.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit fixes a bug in how Bitcoin Core lists external hardware wallets (signers). Previously, if the list contained duplicate signers, the code would stop processing entirely after the first duplicate, potentially hiding valid non-duplicate signers from the user. The fix changes the behavior so duplicates are skipped while the rest of the list is still processed. This is a correctness and usability fix rather than a direct theft-of-funds vulnerability, but it could mislead a user about which hardware wallets are available.

AI review queuedrefactor: store wallet names to MigrationResultby Pol Espinasa · 97d08d62 · May 20, 2026 · 4 filesMessage 80 · StrongInformational 15Details
Commit message · Pol Espinasa

refactor: store wallet names to MigrationResult

Store wallet names into MigrationResult struct when migrating a wallet.
Also refactor the RPC and the wallet interface to rely on them instead of pointers to shared_ptr<CWallet> objects.

This allows in a future commit migrate wallet without loading them.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a straightforward internal code cleanup in Bitcoin Core's wallet migration feature. It changes how wallet names are passed around so that the code stores names directly in a result structure rather than fetching names from live wallet objects. There is no security-relevant change visible in the diff, and the commit message explicitly calls it a refactor.

Lower-priorityqa: regenerate hardcoded regtest chain for kernel lib unit testsby Antoine Poinsot · 98f706c6 · May 20, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Antoine Poinsot

qa: regenerate hardcoded regtest chain for kernel lib unit tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates hardcoded test data used by Bitcoin Core's internal unit tests. The data is a pre-generated regtest (regression test) blockchain, and the change regenerates it so the tests continue to work with the current code. There is no change to production code, no network-facing change, and no security fix or vulnerability introduced.

Lower-prioritymempool: remove all subsequent tx in pkg on failureby Greg Sanders · ac9aa71b · May 20, 2026 · 1 fileMessage 73 · AdequateLow 39Details
Commit message · Greg Sanders

mempool: remove all subsequent tx in pkg on failure

This belt-and-suspenders check, if ever hit in production,
could result in an inconsistent mempool if somehow the
parent failed in the ConsensusScriptChecks but the child did
not. Rather than allow the mempool to get in an inconsistent
state, remove the following txs in the package.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 39/100

This change tightens a safety check in Bitcoin Core's transaction memory pool (mempool) handling. When a group (package) of related transactions is submitted and one fails a final consensus check, the code now removes that failing transaction plus every transaction that comes after it in the package. The commit message calls it a 'belt-and-suspenders' fix to prevent the mempool from becoming internally inconsistent if a parent transaction fails but a child transaction does not. It is a defensive hardening patch rather than a confirmed exploitable bug.

Lower-prioritychainparams: encapsulate deployment configuration logicby Antoine Poinsot · df7ed5f3 · May 20, 2026 · 3 filesMessage 85 · StrongInformational 15Details
Commit message · Antoine Poinsot

chainparams: encapsulate deployment configuration logic

This encapsulates the soft fork configuration logic as set by the `-testactivationheight` (for
buried deployments) and `-vbparams` (for version bits deployments) options which for the moment
are regtest-only, in order to make them available on other networks as well in the next commit.

Can be reviewed using git's `--color-moved` option with `--color-moved-ws=allow-indentation-change`.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This commit is a straightforward internal code reorganization. It moves the logic that applies custom soft-fork activation settings from one place in the code to another, grouping it into a reusable helper function. There is no change to how Bitcoin Core behaves, no bug fix, and no security-relevant change visible in the diff.

Lower-prioritytest: add fuzz harness for CDBWrapperby Andrew Toth · b63ef20d · May 20, 2026 · 3 filesMessage 90 · StrongInformational 15Details
Commit message · Andrew Toth

test: add fuzz harness for CDBWrapper

Introduces a libFuzzer harness that exercises CDBWrapper operations
against a std::map oracle, with a DeterministicEnv that captures LevelDB
background compaction for single-threaded determinism.

A sibling dbwrapper_threaded target uses a bare memenv so LevelDB's real
background thread runs, exercising force_compact and threaded compaction
paths that the deterministic variant cannot reach.

Adds an implicit-integer-sign-change suppression for
BytewiseComparatorImpl::FindShortSuccessor (leveldb/util/comparator.cc:58)
to the test ubsan suppressions list. LevelDB's bytewise comparator
implicitly converts a signed `char` byte to `uint8_t` there. The path
is only reached when compaction picks an SST boundary key, so it
requires a small enough max_file_size for compaction to fire during
the fuzz run.

Co-authored-by: l0rinc <pap.lorinc@gmail.com>

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit only adds new fuzz testing code and a sanitizer suppression for a known, harmless LevelDB sign-conversion issue. It does not change any production Bitcoin Core code, so it cannot introduce a runtime vulnerability in the software users run.

Lower-prioritydbwrapper: make max_file_size a configurable DBParams fieldby Andrew Toth · 8d390c93 · May 20, 2026 · 2 filesMessage 50 · ThinInformational 19Details
Commit message · Andrew Toth

dbwrapper: make max_file_size a configurable DBParams field

Useful for fuzzing different values.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 19/100

This change makes a LevelDB database file-size setting configurable rather than hard-coded. It is described by the author as useful for fuzzing (automated testing with random inputs). There is no direct security fix here; it is a test/development plumbing change.

Lower-prioritydbwrapper: accept optional testing leveldb::Env in DBParamsby Andrew Toth · 32169c38 · May 20, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · Andrew Toth

dbwrapper: accept optional testing leveldb::Env in DBParams

Allow callers to inject a custom leveldb::Env via DBParams::testing_env,
which takes priority over the memory_only in-memory environment. This
enables fuzz harnesses to supply a deterministic environment.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This change adds a new testing-only option for Bitcoin Core's internal database wrapper. It lets fuzz tests and other test code inject a fake, deterministic LevelDB environment. It does not change normal node behavior and is not a security fix or vulnerability.

Lower-priorityutil: Expose IOErrorIsPermanent in sock headerby Fabian Jahr · 376e7ef0 · May 20, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Fabian Jahr

util: Expose IOErrorIsPermanent in sock header

Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit simply moves a small helper function from one internal source file to a header file so it can be reused elsewhere. There is no change to what the function does, no bug fix, and no security-relevant behavior change.

Lower-prioritynetbase: Add timeout parameter to ConnectDirectlyby Fabian Jahr · 5d562430 · May 20, 2026 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Fabian Jahr

netbase: Add timeout parameter to ConnectDirectly

Co-authored-by: w0xlt <94266259+w0xlt@users.noreply.github.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 12/100

This commit is a straightforward code cleanup: it adds a timeout parameter to a low-level network connection helper function. Existing callers keep using the same default timeout they used before, so observable behavior is unchanged. There is no indication this fixes a security bug.

Lower-prioritytest: [move-only] Extract create_new_rpc_connectionby MarcoFalke · fa37c6a5 · May 20, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · MarcoFalke

test: [move-only] Extract create_new_rpc_connection

Re-using the same rpc connection on multiple threads is obviously
unsafe, so this helper can be used to create one connection per thread.

This refactor does not change any behavior and can be reviewed with the
git options:

--color-moved=dimmed-zebra --color-moved-ws=ignore-all-space

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a harmless code cleanup in Bitcoin Core's internal test framework. A developer extracted a small block of code that creates an RPC connection into a reusable helper function. No behavior changed, no user-facing code was modified, and there is no security issue.

Lower-prioritycli: Add HTTPResponseHeaders class for parsing response headersby Fabian Jahr · a988ac59 · May 20, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Fabian Jahr

cli: Add HTTPResponseHeaders class for parsing response headers

Adds a small class to parse and query the field lines of an HTTP
response. Used by the upcoming libevent-free HTTPClient implementation.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit adds a small helper class for reading HTTP response headers in the bitcoin-cli command-line tool. It is purely new infrastructure code with no obvious security bug. There is no fix for a reported vulnerability and no indication this change itself introduces a vulnerability.

AI review queuedtest: restore assertion that tx contains exactly 2500 sigopsby ismaelsadeeq · ae73b69b · May 20, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · ismaelsadeeq

test: restore assertion that tx contains exactly 2500 sigops

Co-authored-by: Antoine Poinsot <darosior@protonmail.com>

87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a tiny test-only change that adds a missing assertion in a unit test. It does not change any production code, network rules, or wallet behavior. There is no security issue here.

Lower-prioritykernel: document overwritten validation state outputsby w0xlt · 0358c26d · May 19, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · w0xlt

kernel: document overwritten validation state outputs

Document btck_transaction_check and btck_block_check validation state output parameters as overwritten in-place. This matches their reset-on-entry behavior and avoids implying callers should preserve prior state.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit only changes comments in a public header file. It clarifies that two Bitcoin kernel functions overwrite their validation-state output parameter rather than preserving any prior contents. No code behavior is changed, so there is no security impact.

Lower-prioritytest: Document rare failure in test_inv_block betterby MarcoFalke · fa890988 · May 19, 2026 · 1 fileMessage 72 · AdequateInformational 14Details
Commit message · MarcoFalke

test: Document rare failure in test_inv_block better

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 14/100

This commit only updates comments and test-only assertions in a Bitcoin Core functional test file. It documents why a test can rarely fail and adds checks to make the test more robust. There is no change to production code, no security fix, and no vulnerability.

Lower-prioritykernel: Return btck_BlockValidationState from process_block_header APIby yuvicc · 88d9bc5a · May 19, 2026 · 4 filesMessage 73 · AdequateInformational 18Details
Commit message · yuvicc

kernel: Return btck_BlockValidationState from process_block_header API

Remove redundant int return from btck_chainstate_manager_process_block_header.
Previously returned both an int result and an output validation state parameter, creating ambiguity
where non-zero could mean either invalid header or processing failure. Since ProcessNewBlockHeaders
already provides complete validation info, the int return was redundant.

Co-authored-by: stringintech <stringintech@gmail.com>
Co-authored-by: stickies-v <stickies-v@protonmail.com>
Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit is a small cleanup of a Bitcoin Core programming interface (API) used by the experimental 'libbitcoinkernel' library. It removes a redundant integer return value from the function that processes new block headers, so callers now rely only on the structured validation-state object to tell whether a header is valid. The change is not a security fix and does not appear to introduce a vulnerability; it mainly makes error handling less ambiguous for developers.

Security candidatemusig: Reject empty pubkey list in GetMuSig2KeyAggCacheby nervana21 · 8ce84321 · May 18, 2026 · 2 filesMessage 50 · ThinLow 37Details
Commit message · nervana21

musig: Reject empty pubkey list in GetMuSig2KeyAggCache

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 37/100

This commit fixes a small but real bug in Bitcoin Core's MuSig2 multi-signature helper. Previously, if someone asked the code to aggregate an empty list of public keys, it would pass an invalid empty list deeper into the cryptographic library, which could cause undefined behavior or a crash. The change now rejects an empty list immediately and returns a failure, and a test was added to make sure this stays fixed.

Security candidatetest: add PSBT proprietary merge regression coverageby w0xlt · da769855 · May 17, 2026 · 2 filesMessage 95 · StrongInformational 15Details
Commit message · w0xlt

test: add PSBT proprietary merge regression coverage

Add unit and functional regression tests asserting that combine/merge preserves proprietary fields at the global, input, and output scopes.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundaryfuzzing or regression evidencesigning or wallet path
AI analysis · Informational 15/100

This commit only adds new regression tests for Bitcoin Core's PSBT (Partially Signed Bitcoin Transaction) combine/merge logic. It checks that custom 'proprietary' data fields are preserved when two PSBTs are merged at global, input, and output levels. There is no production code change, no bug fix, and no security patch in the diff itself.

Security candidatepsbt: preserve proprietary fields when combining PSBTsby w0xlt · 3f5b3c7a · May 17, 2026 · 1 fileMessage 85 · StrongLow 28Details
Commit message · w0xlt

psbt: preserve proprietary fields when combining PSBTs

CombinePSBTs currently preserves unknown records but drops proprietary records at the global, input, and output levels because the Merge() paths never union m_proprietary.

Preserve proprietary records in PartiallySignedTransaction::Merge(), PSBTInput::Merge(), and PSBTOutput::Merge() so combine/merge keeps all PSBT key-value data.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 28/100

This commit fixes a bug in Bitcoin Core's handling of PSBTs (Partially Signed Bitcoin Transactions). When two PSBTs were combined, the software correctly kept 'unknown' extra data but accidentally discarded 'proprietary' custom data fields added by wallets or tools. The patch makes sure proprietary fields are preserved during merging, preventing potential loss of transaction metadata that some wallets rely on.

Lower-prioritykernel: doc: document wipe lifecycle and best entry nullabilityby csjones · 6189335f · May 16, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · csjones

kernel: doc: document wipe lifecycle and best entry nullability

Document on `btck_chainstate_manager_options_set_wipe_dbs` that a wipe must be followed by `btck_chainstate_manager_import_blocks` before the chainstate manager is used for anything else, as the existing kernel tests already do (e.g. `chainman_reindex_test`).

Note in the `@return` of `btck_chainstate_manager_get_best_entry` that it can return null when no block headers have been loaded.

Refactor the `@return` documentation to fit on a single line.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only changes comments in a single header file. It documents that a database wipe must be followed by importing blocks, and that a function can return null when no block headers are loaded. There are no code changes and no security fix.

Lower-prioritycommon: Add unused UrlEncode functionby Fabian Jahr · c471c508 · May 15, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · Fabian Jahr

common: Add unused UrlEncode function

Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit adds a new helper function called UrlEncode that converts text into URL-safe format, plus tests for it. The function is not used anywhere in the actual program yet, so it cannot directly affect live behavior or introduce a practical security flaw. It is a routine, standard implementation following RFC 3986.

Lower-priorityci: Tolerate unused free functions in intermediate commitsby Fabian Jahr · 9687ef1b · May 15, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · Fabian Jahr

ci: Tolerate unused free functions in intermediate commits

When bigger changes are split across multiple commits, intermediate
commits may introduce unused functions. Do not check for this error
in intermediate commits.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit changes a CI (Continuous Integration) script used during Bitcoin Core's automated testing. It adds a compiler warning suppression for 'unused free functions' in addition to the existing suppression for 'unused member functions'. This only affects how intermediate commits in a pull request are validated, not the actual Bitcoin software that users run. There is no security issue here.

AI review queuedIWYU fixesby Anthony Towns · 57d7495f · May 15, 2026 · 5 filesMessage 13 · OpaqueInformational 15Details
Commit message · Anthony Towns

IWYU fixes

Add missing includes of logging.h in preparation for the next commit,
switching to util/log.h. Also removes some unnecessary util/check.h
includes that CI complains about.

13/100 · OpaqueMessage clarity
✓ Provides detailed explanatory context! Very short subject! Too few words to establish purpose
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine code cleanup. It adds missing header file includes for logging and removes one unnecessary include. There is no functional code change and no security issue.