depends: Drop trailing slash from `CMAKE_INSTALL_LIBDIR`
What the developer wrote
Authored by Hennadii Stepanov
depends: Drop trailing slash from `CMAKE_INSTALL_LIBDIR`
1. The trailing slash is redundant.
2. It causes warnings when using CMake >=3.31:
```
CMake Warning (dev) at CMakeLists.txt:596 (install):
Policy CMP0177 is not set: install() DESTINATION paths are normalized. Run
"cmake --help-policy CMP0177" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
This warning is for project developers. Use -Wno-dev to suppress it.
```
What changed, and why it matters
This commit removes a single unnecessary trailing slash from a CMake build setting in Bitcoin Core's dependency build system. It is a cosmetic cleanup that silences a harmless developer warning in newer CMake versions. There is no security relevance.
No security action needed. This is a routine build-system cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change modifies depends/funcs.mk, which generates CMake command lines for building Bitcoin Core’s depends. It changes -DCMAKE_INSTALL_LIBDIR=lib/ to -DCMAKE_INSTALL_LIBDIR=lib. The trailing slash caused CMake 3.31+ to emit a CMP0177 policy warning about normalized install() DESTINATION paths. The functional behavior is identical because CMake normalizes the path anyway.
Changed components
depends/funcs.mkInspect captured patch +1 / −1
diff --git a/depends/funcs.mk b/depends/funcs.mk
index 60e7889a..f6221ef1 100644
--- a/depends/funcs.mk
+++ b/depends/funcs.mk
@@ -222,7 +222,7 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
-DCMAKE_AR=`which $$($(1)_ar)` \
-DCMAKE_NM=`which $$($(1)_nm)` \
-DCMAKE_RANLIB=`which $$($(1)_ranlib)` \
- -DCMAKE_INSTALL_LIBDIR=lib/ \
+ -DCMAKE_INSTALL_LIBDIR=lib \
-DCMAKE_POSITION_INDEPENDENT_CODE=ON \
-DCMAKE_VERBOSE_MAKEFILE:BOOL=$(V) \
-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY:BOOL=TRUE \
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.