Bitcoin Core

This commit only adds a new automated test to Bitcoin Core. It does not change any production code. The test documents an existing quirk where marking a block as invalid affects all descendant blocks, but reversing that decision only clears the failure flag on the same chain branch, not on parallel 'sibling' branches. The underlying issue it guards against was already fixed in an earlier commit (37bc207).

This commit only adds and reorganizes automated tests for the wallet's coin-selection algorithm. It does not change any production code that handles Bitcoin transactions, keys, networking, or consensus rules. There is no security vulnerability here.

This commit only adds new test cases for an existing coin-selection algorithm called SRD (Single Random Draw). It does not change any production wallet code, network rules, or consensus behavior. The change is purely in the test suite and verifies that SRD succeeds for simple, realistic selection targets. There is no security issue here.

This commit only changes test code for Bitcoin Core's coin selection logic. It moves and expands tests that check what happens when a wallet doesn't have enough funds to make a transaction. No production wallet code is changed, so this cannot directly affect real users' funds or transaction behavior.

This commit only changes test code. It updates the list of transaction fee rates used in wallet coin-selection unit tests to reflect a recent lowering of Bitcoin Core's default minimum fee rate and to cover more edge cases. No production code is modified, so this has no direct security impact on running Bitcoin nodes or wallets.

This commit only changes Bitcoin Core's internal coin-selection unit tests. It refactors how test parameters are initialized so that the fee rate can be passed in directly, and it makes sure one group of failure tests uses the same parameters as the rest of the test loop. There is no change to production wallet code, network behavior, or consensus rules, and no security issue is introduced or fixed.

This is a test-only code cleanup. It moves the setup of a shared test fixture from the entire test suite down to individual test cases, so future tests added to these files won't automatically inherit an expensive 100-block chain setup unless they actually need it. There is no change to production Bitcoin Core code, no bug fix, and no security vulnerability.

This commit is a bulk cleanup of Bitcoin Core's Python functional tests. It mechanically replaces plain `assert x == y` statements with a project-specific `assert_equal(x, y)` helper. The change only affects test code, not the Bitcoin node software that users run, so it cannot directly impact live Bitcoin operations, wallets, or consensus. It improves the quality of test failure messages but introduces no security vulnerability and fixes no exploitable bug.

This commit only adds missing Python imports for a helper function named assert_equal in test files. It does not change how Bitcoin Core runs, validates transactions, or handles user funds. It is a routine test-code cleanup with no security relevance.

This commit only changes test code. It replaces loose truthiness checks (like `assert x` or `assert not x`) with stricter equality checks (`assert_equal(x, True/False)`) in two Python test files. It does not change any production Bitcoin Core code, so it cannot directly affect live wallets, nodes, or transactions.

This commit only changes test code. It replaces plain Python assert statements with a custom assert_equal helper in two test files. There is no change to Bitcoin Core's production code, network behavior, wallet logic, or consensus rules, so it has no security impact on users.

This commit only changes Bitcoin Core's internal test code. It rewrites some test assertions by hand so that a later automated cleanup can safely convert them. There is no change to the actual Bitcoin node software that users run, so it cannot affect live wallets, transactions, or network security.

This commit only changes Bitcoin Core's internal test code. It splits combined `assert` statements into separate assertions so that when a test fails, the error message points to the exact condition that failed. There is no change to the actual Bitcoin node software that users run, and no security vulnerability is being fixed.

This commit only changes test code. It replaces plain Python `assert x == y` checks with a helper called `assert_equal` in a handful of test files. The reason is cosmetic/preparatory: some test lines contain inline comments, list literals, or descriptor strings with `#` characters, so they need to be converted by hand before a later automated rewrite can safely convert the rest. There is no change to Bitcoin Core's actual node or wallet logic, so it cannot affect live users, funds, or network security.

This commit only rewrites a handful of test-file assertions from the form 'x equals a or x equals b' to the equivalent form 'x is in the set (a, b)'. It does not change any production code, does not alter what the tests check, and has no security relevance for running Bitcoin software.

This commit updates the version of binutils (a set of tools used to build Bitcoin Core's release binaries inside a reproducible build environment called Guix) from 2.44 to 2.46.0. It is a routine build-system dependency bump. There is no direct evidence in the commit or supplied references that this fixes a security vulnerability, introduces a known exploit, or changes any runtime code that end users interact with.

This commit improves a fuzz test for Bitcoin Core's Tor control code and adds a small safety check in the real Tor control logic. The production change guards against an empty reply from Tor during the SAFECOOKIE authentication challenge, preventing a potential out-of-bounds read or crash. The rest of the change is test cleanup and expanded fuzzing coverage.

This is a small internal code cleanup in Bitcoin Core's custom signal/slot system. It merges two separate shared pointers (one tracking whether a callback is still active, and one used as a construction tag) into a single shared pointer. There is no user-facing change, no bug fix, and no security-relevant behavior change visible in the diff.

This commit replaces Bitcoin Core's use of the Boost signals2 library with a new, simplified in-house implementation called btcsignals. It is a code refactoring/reimplementation intended to reduce dependency on Boost. The change itself does not fix a known bug or vulnerability, but any reimplementation of a threading/callback mechanism carries risk of introducing subtle concurrency or lifetime bugs.

This is a small cleanup of a test file. It removes version-specific workarounds for older Boost library versions, keeping only the behavior needed for the newest Boost version. There is no security issue here.

This commit only adds new automated tests for an internal signal/slot library called btcsignals. It does not change any production code, fix a bug, or alter behavior visible to users or attackers. The tests are described by the author as preparation for a future replacement implementation.

This commit fixes a subtle startup bug in Bitcoin Core's RPC help system. Some help text for commands like 'decodepsbt' and 'getblock' was being built before all global constants were ready, which could cause crashes or garbled output when the program starts. The fix delays building that help text until it is actually needed. It is a reliability fix, not a remote attack vector.

This commit changes how the Bitcoin Core 'dumptxoutset' RPC command creates snapshots of older UTXO sets. Previously, it temporarily invalidated a block to roll back the chain, which suspended network activity and could leave the node in a bad state if something went wrong. The new approach copies the UTXO set to a temporary database and rolls it back there, leaving the main chain untouched. It also uses a prune lock to prevent needed blocks from being deleted during the operation. This is a robustness and operational-safety improvement rather than a fix for a remote exploit.

This commit is a small internal code cleanup in Bitcoin Core's wallet database code. It removes a special 'mock' flag used only for testing and replaces it with a more general way to pass extra SQLite database options. The change only affects test helper code and how mock (in-memory) wallets are created during tests. There is no indication it fixes a security bug or introduces a security risk.

This change fixes a bug in a benchmark test program, not in the main Bitcoin wallet that users run. The benchmark creates a fake wallet to measure how long migration takes, and the fake wallet's database helper object was not being closed before the migration step tried to close the database. That could make the benchmark crash or fail, but it does not affect real wallets or network security.