What the developer wrote
Authored by fanquake
ci: use true|false over "true|false"
What changed, and why it matters
This commit is a minor cleanup in Bitcoin Core's continuous integration (CI) configuration. It changes the way some on/off settings are written in shell scripts from quoted strings like "true" and "false" to unquoted true and false. There is no security issue here; it is purely a style or consistency improvement in test automation files.
No security action needed. Treat as routine CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies four CI environment setup shell scripts under ci/test/. It removes double quotes around boolean string values assigned to environment variables such as RUN_UNIT_TESTS, RUN_FUNCTIONAL_TESTS, DOWNLOAD_PREVIOUS_RELEASES, BARE_METAL_RISCV, and NO_DEPENDS. The values remain semantically identical (true/false). This is a cosmetic/normalization change with no functional or security impact on the Bitcoin Core software itself.
Changed components
ci/test/00_setup_env_native_fuzz_with_msan.shci/test/00_setup_env_native_previous_releases.shci/test/00_setup_env_openbsd_cross.shci/test/00_setup_env_riscv_bare_cross.shInspect captured patch +9 / −9
diff --git a/ci/test/00_setup_env_native_fuzz_with_msan.sh b/ci/test/00_setup_env_native_fuzz_with_msan.sh
index c35a9362..7f6ad828 100755
--- a/ci/test/00_setup_env_native_fuzz_with_msan.sh
+++ b/ci/test/00_setup_env_native_fuzz_with_msan.sh
@@ -28,6 +28,6 @@ export BITCOIN_CONFIG="\
-DAPPEND_CPPFLAGS='-DBOOST_MULTI_INDEX_ENABLE_SAFE_MODE -U_FORTIFY_SOURCE' \
"
export USE_INSTRUMENTED_LIBCPP="MemoryWithOrigins"
-export RUN_UNIT_TESTS="false"
-export RUN_FUNCTIONAL_TESTS="false"
+export RUN_UNIT_TESTS=false
+export RUN_FUNCTIONAL_TESTS=false
export RUN_FUZZ_TESTS=true
diff --git a/ci/test/00_setup_env_native_previous_releases.sh b/ci/test/00_setup_env_native_previous_releases.sh
index d6af52c4..5e189f8c 100755
--- a/ci/test/00_setup_env_native_previous_releases.sh
+++ b/ci/test/00_setup_env_native_previous_releases.sh
@@ -14,7 +14,7 @@ export DEP_OPTS="CC=gcc-12 CXX=g++-12"
export TEST_RUNNER_EXTRA="--previous-releases --coverage --extended --exclude feature_dbcrash" # Run extended tests so that coverage does not fail, but exclude the very slow dbcrash
export GOAL="install"
export CI_LIMIT_STACK_SIZE=1
-export DOWNLOAD_PREVIOUS_RELEASES="true"
+export DOWNLOAD_PREVIOUS_RELEASES=true
# Use -Werror as the CMake version does not support CMAKE_COMPILE_WARNING_AS_ERROR
export BITCOIN_CONFIG="\
--preset=dev-mode \
diff --git a/ci/test/00_setup_env_openbsd_cross.sh b/ci/test/00_setup_env_openbsd_cross.sh
index 3d80e286..a3ee96fc 100755
--- a/ci/test/00_setup_env_openbsd_cross.sh
+++ b/ci/test/00_setup_env_openbsd_cross.sh
@@ -31,5 +31,5 @@ export BITCOIN_CONFIG="\
-DREDUCE_EXPORTS=ON \
-DWITH_USDT=OFF \
"
-export RUN_UNIT_TESTS="false"
-export RUN_FUNCTIONAL_TESTS="false"
+export RUN_UNIT_TESTS=false
+export RUN_FUNCTIONAL_TESTS=false
diff --git a/ci/test/00_setup_env_riscv_bare_cross.sh b/ci/test/00_setup_env_riscv_bare_cross.sh
index b6843408..c5459e78 100755
--- a/ci/test/00_setup_env_riscv_bare_cross.sh
+++ b/ci/test/00_setup_env_riscv_bare_cross.sh
@@ -31,7 +31,7 @@ export BITCOIN_CONFIG="-DCMAKE_C_COMPILER=/opt/riscv-ilp32/bin/riscv32-unknown-e
-DIFADDR_LINKS_WITHOUT_LIBSOCKET=ON \
"
-export BARE_METAL_RISCV="true"
-export RUN_UNIT_TESTS="false"
-export RUN_FUNCTIONAL_TESTS="false"
-export NO_DEPENDS="true"
+export BARE_METAL_RISCV=true
+export RUN_UNIT_TESTS=false
+export RUN_FUNCTIONAL_TESTS=false
+export NO_DEPENDS=true
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.