BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3170 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

318security candidates668second-pass queue3006AI analyses
148commits · 30 days
328commits · 60 days
1301commits · 180 days
2862commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

71/100 average clarity
1175Strong · 80–100
1206Adequate · 60–79
701Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script2024588389
Antoine Poinsot22422170
Ava Chow19868191069
MarcoFalke41421408074
fanquake23121228058
Lőrinc18121177081
Hennadii Stepanov22316211064
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 49 minutes ago

Low 32 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…

Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
ed7dd7cfby Ava Chow+36−203 files
No security note in commit
Low 28 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…

New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
f80aaf4bby Ava Chow+303−7930 files
No security note in commit
Moderate 64 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …

Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
e19f83e9by Ava Chow+37−82 files
Vendor flagged security relevance
Low 35 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…

Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
65e075f8by Ava Chow+2−21 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…

d26f19c7by Ava Chow+5−42 files
No security note in commit
Low 44 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …

Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
e8e7e91aby Ava Chow+43−14 files
No security note in commit
Informational 18 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md

This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…

No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
bfdcd979by merge-script+2−21 file
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35675: mining: add block template manager

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…

Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
5c726f20by Ryan Ofsky+561−44926 files
No security note in commit
Informational 12 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …

New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
be5d0b55by Ava Chow+6951−010 files
No security note in commit
Low 45 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35440: wallet: check descriptor cache xpub length before decoding

This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…

Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
b3f846ecby Ava Chow+225−8511 files
Vendor flagged security relevance
Informational 20 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35813: wallet, rpc: Add listrawtransactions RPC

This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…

No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
2b95b45aby Ava Chow+334−276 files
No security note in commit
Moderate 68 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35752: wallet: make encryption state updates atomic

This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …

Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
7ee3d622by Ava Chow+379−16418 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35619: test: ExtendedPrivateKey follow-ups

This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …

248ce46fby merge-script+18−244 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36261: test: cover PSBT unknown field merging

This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…

bbc40edeby merge-script+130−01 file
No security note in commit
Informational 18 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36230: wallet: Improve `HasWalletDescriptor` performance and other canonical descriptor string followups

This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…

No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
4a583f38by merge-script+97−429 files
No security note in commit
Informational 21 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36297: rpc: Correct invalid OpenRPC defaults

This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…

OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
5f05d8c5by merge-script+6−63 files
No security note in commit
Informational 20 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

rpc: Correct OpenRPC default metadata

This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…

No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
b7f740c5by will+6−63 files
No security note in commit
Informational 24 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36286: crypto: Fix MuHash3072 division by itself

This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…

Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
d48e76e6by merge-script+11−13 files
No security note in commit
Informational 18 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36285: refactor: Use static const over inline const to work around ld64 bug

This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…

No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
ad97933aby merge-script+8−82 files
No security note in commit
Informational 23 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#34861: wallet: Add importdescriptors interface

This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…

Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
2bbbeaa6by Ava Chow+619−26415 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityfuzz: add p2p_private_broadcast harnessby frankomosh · d24d3cba · Jul 8, 2026 · 2 filesMessage 68 · AdequateInformational 15Details
Commit message · frankomosh

fuzz: add p2p_private_broadcast harness

Add a fuzz harness targeting ConnectionType::PRIVATE_BROADCAST.
Seeds m_tx_for_private_broadcast via InitiateTxBroadcastPrivate
so PushPrivateBroadcastTx reaches the send-INV and other paths.
Guarantees one PRIVATE_BROADCAST peer per iteration, optionally
adds peers of other types, uses CallOneOf() branching between
guided and arbitrary message types, and verifies the outbound
INV is well-formed after the handshake completes.

Co-authored-by: Greg Sanders <gsanders87@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit adds a new automated fuzz test for Bitcoin Core's private transaction broadcast feature. It is purely a testing/quality-assurance change and does not modify any production networking or consensus code. There is no security vulnerability here.

Lower-prioritytest: add negative zero CSV failure script test vectorby azuchi · c4068cf3 · Jul 8, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · azuchi

test: add negative zero CSV failure script test vector

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit only adds a new test case to Bitcoin Core's script test suite. It verifies that a special edge-case number ('negative zero') is treated as plain zero by the CHECKSEQUENCEVERIFY opcode and therefore fails with the expected 'unsatisfied locktime' error rather than a 'negative number' error. There is no change to production code, no bug fix, and no security patch.

Lower-prioritytest: add CHECKLOCKTIMEVERIFY failure-path script test vectorsby azuchi · 37edf0e2 · Jul 8, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · azuchi

test: add CHECKLOCKTIMEVERIFY failure-path script test vectors

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit only adds new test cases to a JSON test file for the Bitcoin Core test suite. It exercises ways the CHECKLOCKTIMEVERIFY (CLTV) script operation can fail, but does not change any production code, consensus rules, or network behavior. It is a test-only addition with no direct security impact on running software.

Lower-prioritydoc: add release notes for 32800by Musa Haruna · 29b12441 · Jul 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Musa Haruna

doc: add release notes for 32800

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds release notes describing a prior code change (PR #32800). It documents that several RPC calls now expose two separate virtual-size fields and that the old `vsize` field is deprecated. There is no code change here, only documentation.

AI review queuedrpc: add `vsize_adjusted` field to getrawtransaction output for mempool transactionsby Musa Haruna · 5d25a0c2 · Jul 7, 2026 · 2 filesMessage 83 · StrongInformational 19Details
Commit message · Musa Haruna

rpc: add `vsize_adjusted` field to getrawtransaction output for mempool transactions

Extend the `getrawtransaction` RPC to include a new field `vsize_adjusted` when the transaction is in the mempool.
The `vsize_adjusted` field provides the mempool's accounting size for the transaction based on its sigop cost,
which can exceed its serialized vsize under `-bytespersigop` policies.

Test coverage is added to verify the correct calculation and exposure of the `vsize_adjusted` field via `mempool_sigoplimit.py`.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit adds a new read-only field called vsize_adjusted to the getrawtransaction RPC output, but only when the transaction is currently in the memory pool. It exposes information the node already calculates for mempool policy, so it does not change behavior, fix a bug, or introduce a vulnerability. It is a transparency/feature improvement for RPC users.

Lower-priorityrpc: add `vsize_adjusted` and `vsize_bip141` field to mempool-related RPCsby Musa Haruna · eaef8d31 · Jul 7, 2026 · 5 filesMessage 83 · StrongInformational 21Details
Commit message · Musa Haruna

rpc: add `vsize_adjusted` and `vsize_bip141` field to mempool-related RPCs

This commit adds a new `vsize_adjusted` and `vsize_bip141` field to mempool acceptance and submission RPCs,
including `testmempoolaccept` and `submitpackage`,
to report the sigop-adjusted virtual transaction size and virtual transaction size as defined in BIP 141 respectively.
While `vsize` is now marked as deprecated.

RPC help texts are updated to reflect this addition.
Tests in `mempool_accept.py, mempool_accept, p2p_segwit, rpc_packages, mempool_sigoplimit` are extended
to verify the presence and correctness of the new fields.

Co-authored-by: Gloria Zhao <gloriajzhao@gmail.com>

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 21/100

This Bitcoin Core change fixes a labeling problem in several RPC (remote procedure call) responses. The old 'vsize' field was actually reporting a sigop-adjusted size, not the plain BIP 141 virtual size its documentation claimed. The patch keeps the old 'vsize' value for backward compatibility but marks it deprecated, and adds two new clearly-named fields: 'vsize_bip141' for the true BIP 141 virtual size and 'vsize_adjusted' for the sigop-adjusted size. It is an API clarity/documentation correction, not a consensus or mempool rule change.

Lower-priorityrefactor: Move LoadGenesisBlock to ChainstateManagerby MarcoFalke · fa615bd1 · Jul 7, 2026 · 6 filesMessage 85 · StrongInformational 15Details
Commit message · MarcoFalke

refactor: Move LoadGenesisBlock to ChainstateManager

The function does not need anything from any chainstate, so it should
not sit in the Chainstate class.

Also, mark it [[nodiscard]], and the one place that ignores the return
value with (void).

Also, change the error log strings to not include the __func__, which is
redundant with -logsourcelocations. This is not a refactor, but this log
is only for debugging extremely rare errors.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a straightforward internal code reorganization: it moves the LoadGenesisBlock function from the Chainstate class to the ChainstateManager class, marks its return value as important to check, and slightly rewords two rare error log messages. There is no change to how Bitcoin Core validates blocks, handles transactions, or protects against attacks. It does not fix a security bug or introduce a known vulnerability.

Lower-prioritytest: align test better with described scenarioby stickies-v · 191bdcba · Jul 7, 2026 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · stickies-v

test: align test better with described scenario

Add the tx that was just removed, instead of an earlier one, for
improved clarity.

82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a tiny change to a single unit test in Bitcoin Core. It swaps which test transaction is used in one assertion so the test matches the scenario described in the comment above it. There is no change to production code, no security fix, and no vulnerability.

Lower-priorityprivate broadcast: remove no-op [[nodiscard]]by stickies-v · 8ac22248 · Jul 7, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · stickies-v

private broadcast: remove no-op [[nodiscard]]

The header file already properly uses the attribution.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a trivial code-cleanup commit. It removes a duplicate [[nodiscard]] marker from a function definition in a source file, because the same marker is already present on the function's declaration in the header file. The duplicate had no effect on program behavior or security.

AI review queuedrpc: define and use new RPC_LIMIT_EXCEEDED error codeby stickies-v · 82a02a2a · Jul 7, 2026 · 3 filesMessage 73 · AdequateInformational 20Details
Commit message · stickies-v

rpc: define and use new RPC_LIMIT_EXCEEDED error code

The server isn't running out of memory when the private broadcast
transaction queue is full. Add a new RPC_LIMIT_EXCEEDED code that
can be used whenever a resource is bound and currently at capacity.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit changes the error code returned when Bitcoin Core's private broadcast transaction queue is full. Previously, the node reported an 'out of memory' error (-7), which was misleading because the server is not actually running out of memory. The new error code (-37, RPC_LIMIT_EXCEEDED) more accurately tells the caller that a configured capacity limit has been reached. This is a correctness and clarity improvement, not a security fix for a vulnerability.

Lower-prioritytest: use BOOST_CHECK_EQUAL for PrivateBroadcast::AddResultby stickies-v · 7ad311be · Jul 7, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · stickies-v

test: use BOOST_CHECK_EQUAL for PrivateBroadcast::AddResult

Makes the failure output more useful.

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes test code. It swaps generic true/false checks for equality checks on an enum and adds a helper so that if a test fails, the output shows the actual enum value (e.g., 'QueueFull') instead of just 'false'. There is no change to production code, no bug fix, and no security relevance.

AI review queuedwallet: avoid call bumpfeediscount with negative valuesby Pol Espinasa · 3ae3a94f · Jul 7, 2026 · 1 fileMessage 85 · StrongModerate 57Details
Commit message · Pol Espinasa

wallet: avoid call bumpfeediscount with negative values

ChooseSelectionResult computes the bump-fee discount as: summed_bump_fees - combined_bump_fee
Where summed_bump_fees is the sum of per-UTXO ancestor bump fees and combined_bump_fee is the
true combined cost taking into account shared ancestors.

Both variables use creates a fresh MiniMiner snapshot of the mempool. Because of that
the two snapshots of the mempool might be different. An artificial feerate decrease
of an ancestor using prioritizesettransaction can make combined_bump_fee > summed_bump_fees.
This cause calling bumpfeediscount with a negative vaule triggering an assertion >= 0.

This commit fixes this by only calling bumpfeediscount when the discount is strictly positive.

Co-authored-by: dergoegge <n.goeggi@gmail.com>

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This commit fixes a crash bug in Bitcoin Core's wallet coin selection. When the wallet tried to estimate fees for spending unconfirmed coins, it took two separate snapshots of the mempool. If the mempool changed between those snapshots—such as when someone artificially lowered a transaction's fee priority—the second fee could be higher than the first. That produced a negative 'discount' value, which then triggered an internal assertion that the value must be zero or positive, causing the wallet process to crash. The fix simply skips applying the discount when it would be negative.

Lower-prioritytest: cover -externalip/onlynet interaction in functional testby will · dab7f2c9 · Jul 7, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · will

test: cover -externalip/onlynet interaction in functional test

Extend p2p_addr_selfannouncement to restart the node with -onlynet=ipv4
-externalip=<onion> and verify the onion address appears in
localaddresses despite its network being unreachable.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds a new automated test to Bitcoin Core. It checks that a user-configured onion address still gets advertised even when the node is told to only use IPv4. There is no code change to the actual Bitcoin node behavior, so this commit does not introduce or fix a security vulnerability on its own.

Lower-prioritytest: cover -externalip bypassing -onlynetby will · 657a5aa3 · Jul 7, 2026 · 1 fileMessage 90 · StrongInformational 14Details
Commit message · will

test: cover -externalip bypassing -onlynet

Add unit coverage for the -onlynet/-externalip interaction.

Check that an unreachable address still fails with normal AddLocal()
arguments, while the same address succeeds when the unreachable-net
override is set for explicit local-address configuration.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 14/100

This commit only adds a new automated test to Bitcoin Core. It checks that the -externalip command-line option can bypass the -onlynet restriction when a user explicitly configures an external address, while normal local-address registration still respects network reachability rules. There is no change to production code, no bug fix, and no security vulnerability being patched.

Lower-prioritynet: let -externalip bypass -onlynetby will · 8c87e32b · Jul 7, 2026 · 2 filesMessage 68 · AdequateInformational 22Details
Commit message · will

net: let -externalip bypass -onlynet

When -onlynet excludes a network, AddLocal() rejects local addresses
from that network. This also rejects addresses explicitly configured via
-externalip, so a configuration like -onlynet=ipv4 -externalip=<onion>
never advertises the onion address.

Set the AddLocal() unreachable-net override only when adding -externalip
addresses so the bypass remains limited to explicit user configuration.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 22/100

This commit fixes a configuration bug in Bitcoin Core. Previously, if a user told their node to only use one network type (for example, only IPv4) and also manually set an external address on a different network (for example, a Tor onion address), the node would silently ignore the manually configured address. The change makes the node honor the user's explicit -externalip setting even when it belongs to a network otherwise excluded by -onlynet. It is a usability/configuration fix, not a vulnerability that allows attackers to take over nodes or steal funds.

Lower-prioritynet: add an add_even_if_unreachable argument to AddLocalby will · f4af02e8 · Jul 7, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · will

net: add an add_even_if_unreachable argument to AddLocal

Prepare for letting explicitly configured local addresses bypass the
reachable-net filter without tying that behavior to LOCAL_MANUAL score.

Pass an `add_even_if_unreachable` bool through `AddLocal()`, defaulting
to `false`.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a small, non-functional code cleanup. It adds a new optional parameter to an internal networking function so that a future change can allow user-specified local addresses to bypass a network-reachability check. The new parameter defaults to false, so existing behavior is unchanged. There is no security bug or fix here.

Lower-prioritynet: optimize compact block extra tx iterationby Lőrinc · 1a3cbf1b · Jul 6, 2026 · 1 fileMessage 68 · AdequateInformational 16Details
Commit message · Lőrinc

net: optimize compact block extra tx iteration

`vExtraTxnForCompact` was resized to its configured capacity on the first insertion.
Before the ring was filled, compact block reconstruction scanned default `{Wtxid::ZERO, nullptr}` entries created for unused slots.

Reserve the configured capacity and append entries until the cache is full, then keep the same ring-buffer overwrite behavior.
This preserves the configured maximum and replacement order while keeping reconstruction from scanning unused capacity.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 16/100

This is a small performance cleanup in Bitcoin Core's network code. A temporary cache used when reconstructing compact blocks used to be fully sized up front, meaning the code would repeatedly scan empty placeholder slots. The change instead grows the cache only as it fills, so reconstruction skips unused slots. There is no direct security vulnerability being fixed; it is an optimization that may slightly reduce CPU work during block reconstruction.

Lower-prioritydoc: archive release notes for v31.1by fanquake · 2b6e767d · Jul 6, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · fanquake

doc: archive release notes for v31.1

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply archives the release notes for Bitcoin Core version 31.1. It adds a documentation file summarizing what changed in that release, but does not change any program code. There is no direct security risk from this documentation-only change.

Lower-priorityp2p: Don't participate in addr relay with feeler connectionsby Daniela Brozzoni · b0735336 · Jul 6, 2026 · 2 filesMessage 83 · StrongInformational 19Details
Commit message · Daniela Brozzoni

p2p: Don't participate in addr relay with feeler connections

Feeler connections are short-lived connections made to check that a node
is alive, useful for test-before-evict from addrman, and for moving
addresses from the new to the tried table.

We currently send a GETADDR message to feelers, but then disconnect
before being able to receive a response. This wastes some bandwidth, so
we can avoid sending the GETADDR altogether.

Not sending the initial GETADDR will effectively disable addr relay:
we initialize addr relay for the peer when we send GETADDR, and the peer
initializes addr relay to us when they receive it. So the
peer will not relay any announcement to us, and we will not relay any
to them either. This is ok, since the use of feelers is to test if there
is a bitcoin node behind an address, not exchange addresses with them.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 19/100

This change is a small network-efficiency cleanup, not a security fix. Bitcoin Core's 'feeler' connections are brief probes used to check whether another node is online. Previously, the software would ask feeler peers for addresses (sending a GETADDR message) even though it disconnects almost immediately and never reads the reply. The patch stops that unnecessary request, saving a little bandwidth. It does not fix a vulnerability and does not change how attackers could interact with the network.

Lower-priorityinit: wake genesis wait after ImportBlocks() returnsby ismaelsadeeq · c1313b19 · Jul 6, 2026 · 2 filesMessage 83 · StrongLow 30Details
Commit message · ismaelsadeeq

init: wake genesis wait after ImportBlocks() returns

If shutdown interrupts ImportBlocks() before genesis activation,
no blockTip notification is sent. The wait predicate allows
shutdown to occur, but the condition variable is never
notified, so init can remain stuck waiting for genesis activation.

Notify the tip condition variable after ImportBlocks() returns so
interrupted imports wake the wait and let it observe the shutdown request.

Add test coverage for interrupting startup after reindex block files import
begins, which exercises the path where ImportBlocks() can return before genesis
activation.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Low 30/100

This commit fixes a bug where Bitcoin Core could hang during shutdown if the user started a 'reindex' and then asked the program to quit before it finished loading the very first block. The fix adds a notification so the shutdown request is noticed, plus a test that simulates this exact scenario. It is a reliability/availability fix, not a security vulnerability that an attacker can exploit.

Lower-priorityrefactor: Use `NetworkErrorString` for macOS code in `netif.cpp`by Hennadii Stepanov · eccb04a3 · Jul 6, 2026 · 1 fileMessage 97 · StrongInformational 15Details
Commit message · Hennadii Stepanov

refactor: Use `NetworkErrorString` for macOS code in `netif.cpp`

Although these `sysctl` calls report generic system errors rather
than network errors, `NetworkErrorString()` is identical to
`SysErrorString()` on POSIX systems, so this does not change behavior.
It allows removing `#include <util/syserror.h>`, which was only needed
by `__APPLE__` code and would otherwise require an `#ifdef` guard to
silence an IWYU unused-include warning on other platforms.

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This is a minor code cleanup in Bitcoin Core. It swaps one internal error-message helper for another that produces the exact same text on macOS and Linux, and removes an unused header include. There is no functional change and no security impact.

Lower-priorityci: ensure we use correct lld version in OpenBSD jobby fanquake · 22ac4ad9 · Jul 6, 2026 · 1 fileMessage 77 · AdequateInformational 15Details
Commit message · fanquake

ci: ensure we use correct lld version in OpenBSD job

If we don't suffix with -${APT_LLVM_V}, then lld-21 will be installed.

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a minor continuous-integration (CI) build fix for Bitcoin Core's OpenBSD cross-compilation job. It changes one package name so the build system installs the matching version of the LLVM linker (lld-22) instead of accidentally installing a different version (lld-21). It does not change any code that runs on users' wallets, nodes, or the Bitcoin network, and there is no security issue here.

Lower-prioritydepends: move FreeBSD SDK handling to CIby fanquake · 244739db · Jul 6, 2026 · 3 filesMessage 76 · AdequateInformational 15Details
Commit message · fanquake

depends: move FreeBSD SDK handling to CI

As pointed out by Hebasto, the approach used in #35397 and #35412 is
better, rather than hardcoding flags and putting the SDK handling into
depends.

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit is a build-system cleanup. It moves the handling of the FreeBSD software development kit (SDK) out of the shared dependency build files and into the continuous integration (CI) configuration. The actual compiler flags and download logic remain essentially the same; they are just placed in a more appropriate file. There is no user-facing change and no security fix or vulnerability introduced.

Lower-priorityci: FreeBSD 15.1by fanquake · 495f43f7 · Jul 6, 2026 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · fanquake

ci: FreeBSD 15.1

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply updates the FreeBSD version number used in automated testing from 15.0 to 15.1. It is a routine CI (continuous integration) maintenance change with no security relevance.

Lower-prioritytest: add CHECKSIGVERIFY/CHECKMULTISIGVERIFY failure script test vectorsby azuchi · a86a96d1 · Jul 6, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · azuchi

test: add CHECKSIGVERIFY/CHECKMULTISIGVERIFY failure script test vectors

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidence
AI analysis · Informational 15/100

This commit only adds two new test cases to a JSON test file used by Bitcoin Core's automated test suite. The tests verify that certain script operations (CHECKSIGVERIFY and CHECKMULTISIGVERIFY) produce the expected error codes when they fail. No production code was changed, so this cannot introduce or fix a security vulnerability on its own.