What the developer wrote
Authored by fanquake
guix: modernise style in *-base-gcc
What changed, and why it matters
This commit is a cosmetic/style update to the Guix build manifest used to compile Bitcoin Core. It replaces older Scheme quoting syntax with newer 'gexp' syntax but does not change which compiler flags are actually used. There is no security-relevant change here.
No security action required. Treat as routine code modernization.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch in contrib/guix/manifest_build.scm converts two substitute-keyword-arguments blocks from legacy quasiquote/unquote syntax ((append ,flags ...) and(modify-phases ,phases …)) to Guix’s modern gexp syntax (#~(append #$flags …) and #~(modify-phases #$phases …)). The configure flags, phases, and overall build behavior remain identical. No functional or security-relevant change is introduced.
Changed components
contrib/guix/manifest_build.scmInspect captured patch +21 / −21
diff --git a/contrib/guix/manifest_build.scm b/contrib/guix/manifest_build.scm
index 6646a052..f151824e 100644
--- a/contrib/guix/manifest_build.scm
+++ b/contrib/guix/manifest_build.scm
@@ -165,14 +165,14 @@ chain for " target " development."))
(arguments
(substitute-keyword-arguments (package-arguments base-gcc)
((#:configure-flags flags)
- `(append ,flags
+ #~(append #$flags
;; https://gcc.gnu.org/install/configure.html
- (list "--enable-threads=posix",
- "--enable-default-ssp=yes",
- "--enable-host-bind-now=yes",
- "--disable-gcov",
- "--disable-libgomp",
- building-on)))))))
+ (list "--enable-threads=posix"
+ "--enable-default-ssp=yes"
+ "--enable-host-bind-now=yes"
+ "--disable-gcov"
+ "--disable-libgomp"
+ #$building-on)))))))
(define-public linux-base-gcc
(package
@@ -180,22 +180,22 @@ chain for " target " development."))
(arguments
(substitute-keyword-arguments (package-arguments base-gcc)
((#:configure-flags flags)
- `(append ,flags
+ #~(append #$flags
;; https://gcc.gnu.org/install/configure.html
- (list "--enable-initfini-array=yes",
- "--enable-default-ssp=yes",
- "--enable-default-pie=yes",
- "--enable-host-bind-now=yes",
- "--enable-standard-branch-protection=yes",
- "--enable-cet=yes",
- "--enable-gprofng=no",
- "--disable-gcov",
- "--disable-libgomp",
- "--disable-libquadmath",
- "--disable-libsanitizer",
- building-on)))
+ (list "--enable-initfini-array=yes"
+ "--enable-default-ssp=yes"
+ "--enable-default-pie=yes"
+ "--enable-host-bind-now=yes"
+ "--enable-standard-branch-protection=yes"
+ "--enable-cet=yes"
+ "--enable-gprofng=no"
+ "--disable-gcov"
+ "--disable-libgomp"
+ "--disable-libquadmath"
+ "--disable-libsanitizer"
+ #$building-on)))
((#:phases phases)
- `(modify-phases ,phases
+ #~(modify-phases #$phases
;; Given a XGCC package, return a modified package that replace each instance of
;; -rpath in the default system spec that's inserted by Guix with -rpath-link
(add-after 'pre-configure 'replace-rpath-with-rpath-link
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.