Bitcoin Core

This is a routine cleanup of a Bitcoin Core functional test file. It moves shared test setup out of individual test methods, fixes a couple of log comments, and replaces a plain Python assert with a proper test-framework assertion. There is no change to production code or to any security-sensitive behavior.

This commit is a routine test-code refactor. It splits the existing IPC (inter-process communication) functional tests into two files: one for simple echo/inspector checks and a new one specifically for mining-interface checks. No production code, consensus rules, or network behavior were changed.

This commit is a simple code cleanup in Bitcoin Core's test suite. It moves helper functions used by the IPC (inter-process communication) tests from one file into a new shared utility file and renames some functions for clarity. No production code, consensus rules, or wallet/security logic is changed.

This commit is a routine update of the English translation source files for the Bitcoin Core graphical user interface. It adds, removes, and reorders user-facing text strings so that translators can keep the application's messages up to date. There is no code change that affects how Bitcoin Core behaves, processes transactions, or secures funds.

This commit changes a single configuration line that tells Bitcoin Core's translation system which online Transifex resource to use for the 31.x release. It is a routine version-string update with no security relevance.

This commit is a code cleanup in Bitcoin Core's RPC (remote procedure call) output code. It removes explicit type casts when adding numeric values to JSON responses, relying on the underlying types instead. There is no direct evidence this fixes a security vulnerability; it is presented by the author as a refactoring to make the code less confusing and brittle.

This commit adds a new automated testing configuration file for Bitcoin Core's continuous integration (CI) system. It sets up a build environment using Chimera Linux with link-time optimization (LTO) enabled. There is no code change to Bitcoin Core itself, no bug fix, and no security-relevant change.

This commit simply removes an unused internal data structure called PreSelectedInputs from a wallet header file. It is a code cleanup change with no functional behavior change and no apparent security relevance.

This change improves the error message shown when a Bitcoin wallet user tries to send an amount that fits their balance but leaves no room for the network transaction fee. Previously the wallet just said 'Insufficient funds.' Now it explains that the total exceeds the balance once the fee is included. It is a user-experience and diagnostic improvement, not a security fix.

This is a Bitcoin Core wallet code cleanup that replaces an internal data structure called PreSelectedInputs with a cleaner one called CoinsResult. The commit message says the old structure was confusing because a field named total_amount could hold two different kinds of amounts, which could lead to accidentally mixing them. The patch separates those amounts and adds an explicit safety check where it matters. It is a defensive refactor rather than a fix for a known live bug or exploit.

This commit is a pure cleanup of the Windows CI (Continuous Integration) script. It moves two test-preparation tasks—installing a Python package for normal tests and cloning test data for fuzz tests—into a single helper function. There is no change to Bitcoin Core's actual code, no security fix, and no new vulnerability.

This change only affects how Bitcoin Core's automated Windows build system reports failures. It makes the CI (continuous integration) script retry a failed parallel build with a single-threaded verbose build to get clearer logs. There is no change to Bitcoin's networking, consensus, wallet, or any code users run.

This commit is a pure CI (Continuous Integration) refactor for Windows builds. It moves the existing Windows build command from the GitHub Actions YAML file into a shared Python helper script, using a new Python 3.13 function to count CPU cores. There is no change to Bitcoin Core's actual code, no security fix, and no vulnerability introduced.

This commit simply moves the Windows CI build command out of the GitHub Actions YAML file and into a small Python helper script. It does not change what software is built, how it is built, or any user-facing behavior. There is no security issue here.

This commit only adds a comment to a configuration file explaining why a clang-tidy linting option is turned off. It does not change any executable code, build settings, or security behavior. It is purely documentation.

This is a routine code cleanup in Bitcoin Core that swaps one internal data-reading helper (DataStream) for another (SpanReader) across many files. The commit message explicitly says it does not change behavior, and the diff only shows mechanical replacements with no new logic. There is no security issue visible in the change.

This Bitcoin Core change fixes a subtle bug in how the wallet keeps track of selected coins. Previously, the wallet used a set of coin objects directly, which automatically prevented duplicates. After a recent refactor, it started using a set of pointers to coin objects, where the default behavior only prevents duplicate pointer addresses—not duplicate coins. This meant two different pointers representing the same coin could both end up in the selection, potentially causing the wallet to try to spend the same coin twice or miscalculate fees and change. The fix makes the set compare the actual coin data, not just pointer addresses, restoring the old duplicate-prevention behavior.

This is a small, clean code refactor inside the Bitcoin Core wallet. It moves an existing calculation into a new helper function and makes a few methods 'const' (read-only). There is no change to behavior, no bug fix, and no security issue visible in the diff.

This is a tiny performance fix in the Bitcoin Core wallet code. A helper function that gathers all spendable coins into one flat list was reserving memory based on the number of coin categories (for example, how many output types exist) rather than the actual total number of coins. The change makes it reserve the correct, larger amount of memory up front. It does not change any security logic, balances, or transaction construction rules.

This is a small code cleanup in Bitcoin Core's wallet coin-selection logic. The change makes a cached optional value behave as actually optional (unset by default) and only updated when it has a value. It fixes a logic inconsistency found during code review, but there is no direct evidence it prevents a real-world exploit or user-visible bug on its own.

This is a build-system cleanup. It swaps a custom Bitcoin Core option called WERROR for a standard CMake option called CMAKE_COMPILE_WARNING_AS_ERROR, which does the same thing: turn compiler warnings into build errors. No security vulnerability is present; it is purely a maintenance change to use upstream CMake functionality.

This is a routine code cleanup change. It removes forward declarations of the Boost signals2 library and replaces them with a direct include of a project header named btcsignals.h. There is no functional change to program behavior and no security relevance visible in the diff.

This commit is a simple code cleanup: it creates a project-specific alias `btcsignals` for the external library namespace `boost::signals2`, and replaces all direct uses of `boost::signals2` with the new alias. There is no functional change, no bug fix, and no security-relevant behavior change.

This commit is a simple code cleanup: it creates a new internal header file called btcsignals.h that currently just forwards to Boost's signals library, and then replaces direct Boost signals includes across several source files with this new header. There is no functional change, no bug fix, and no security-relevant behavior change.

This is a one-line CMake build fix that adds a missing reference to USDT (Userland Statically Defined Tracing) headers for the test_bitcoin target. It ensures the test suite compiles correctly when USDT tracing support is enabled. There is no indication this is a security vulnerability or that it affects runtime behavior of Bitcoin Core.