What the developer wrote
Authored by fanquake
tidy: clang-tidy is required
Otherwise this check will "pass", like:
```bash
-- Detecting CXX compile features - done
-- Found LLVM 21.1.8
-- Found clang-tidy: CLANG_TIDY_EXE-NOTFOUND
-- Configuring done (0.5s)
```
What changed, and why it matters
This is a build-system hardening change for a developer tool. It makes the clang-tidy program mandatory when configuring the bitcoin-tidy CMake project, so the build fails clearly if clang-tidy is missing instead of silently continuing with a placeholder 'NOTFOUND' path. It does not change Bitcoin Core's runtime behavior, consensus code, or network handling.
No security action needed. Treat as a normal developer-experience/build-quality improvement.
Security signals we found
No security-relevant code change
Build/CI tooling only
Fail-closed configuration improvement
Evidence from the diff
In contrib/devtools/bitcoin-tidy/CMakeLists.txt, the find_program() call for CLANG_TIDY_EXE is changed from optional to REQUIRED. Previously, if neither ‘clang-tidy-
Changed components
contrib/devtools/bitcoin-tidy/CMakeLists.txtInspect captured patch +1 / −1
diff --git a/contrib/devtools/bitcoin-tidy/CMakeLists.txt b/contrib/devtools/bitcoin-tidy/CMakeLists.txt
index c6f683f7..a7422a28 100644
--- a/contrib/devtools/bitcoin-tidy/CMakeLists.txt
+++ b/contrib/devtools/bitcoin-tidy/CMakeLists.txt
@@ -21,7 +21,7 @@ set(CMAKE_DISABLE_FIND_PACKAGE_ZLIB ON)
set(CMAKE_DISABLE_FIND_PACKAGE_zstd ON)
find_package(LLVM REQUIRED CONFIG)
-find_program(CLANG_TIDY_EXE NAMES "clang-tidy-${LLVM_VERSION_MAJOR}" "clang-tidy" HINTS ${LLVM_TOOLS_BINARY_DIR})
+find_program(CLANG_TIDY_EXE REQUIRED NAMES "clang-tidy-${LLVM_VERSION_MAJOR}" "clang-tidy" HINTS ${LLVM_TOOLS_BINARY_DIR})
message(STATUS "Found LLVM ${LLVM_PACKAGE_VERSION}")
message(STATUS "Found clang-tidy: ${CLANG_TIDY_EXE}")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.