Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md
What the developer wrote
Authored by merge-script
Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md
be30864ed1a63cad0e109ebc98fe17bd852bc8d0 doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md (GuTS805)
Pull request description:
`funded_psbt.txt` and `final_psbt.txt` should only ever have one line in them, since later steps just do `$(cat ...)` to read them back. but the tutorial uses `>>` (append) instead of `>` (overwrite), so if you run the `send` or `walletprocesspsbt` step twice without deleting the file, it adds a second line instead of replacing the first one. then `$(cat ...)` picks up both lines as separate args and the next command fails with too many arguments.
Fixes #35862.
ACKs for top commit:
Sjors:
ACK be30864ed1a63cad0e109ebc98fe17bd852bc8d0
sedited:
ACK be30864ed1a63cad0e109ebc98fe17bd852bc8d0
Tree-SHA512: af388ffd3f0beb6e9d0e54e5e745d36380f11cdbea64c3563015aded882872401a4a3032c46493381a8b5eed510530a2c3f5a81701d7d3039c9c1c9741a8bd7b
What changed, and why it matters
This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two lines instead of one, and the next command would read both lines and fail with a 'too many arguments' error. There is no software vulnerability or security risk in the Bitcoin Core code itself.
No security action required. The documentation fix is already merged. Users following the tutorial will simply avoid a command-line error if they re-run a step.
Security signals we found
No security signal: change is limited to documentation
No code changes to Bitcoin Core binaries, RPC, wallet, or consensus logic
No cryptographic, network, or privilege-boundary implications
Evidence from the diff
The commit modifies doc/offline-signing-tutorial.md, changing two shell redirections from append (>>) to overwrite (>). The affected commands write a base64 PSBT to a one-shot file that is later read back with $(cat …). Using append could cause duplicate lines if the tutorial step is repeated, leading the subsequent $(cat …) expansion to pass multiple PSBT strings as separate arguments and produce a CLI argument-count error. This is a user-experience/documentation correctness issue, not a code defect.
Changed components
doc/offline-signing-tutorial.mdInspect captured patch +2 / −2
### doc/offline-signing-tutorial.md
@@ -112,7 +112,7 @@ tb1qtu5qgc6ddhmqm5yqjvhg83qgk2t4ewajg0h6yh
[online]$ ./build/bin/bitcoin-cli -signet -rpcwallet="watch_only_wallet" send \
'{"tb1q9k5w0nhnhyeh78snpxh0t5t7c3lxdeg3erez32": 0.009}' \
| jq -r '.psbt' \
- >> /path/to/funded_psbt.txt
+ > /path/to/funded_psbt.txt
[online]$ cat /path/to/funded_psbt.txt
@@ -170,7 +170,7 @@ Use the walletpassphrase command to unlock the `offline_wallet` with the passphr
[offline]$ ./build/bin/bitcoin-cli -signet -rpcwallet="offline_wallet" walletprocesspsbt \
$(cat /path/to/funded_psbt.txt) \
| jq -r .hex \
- >> /path/to/final_psbt.txt
+ > /path/to/final_psbt.txt
```
### Broadcast the Signed and Finalized PSBTWhy this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.