interpreter: remove clang-tidy suppression
What the developer wrote
Authored by fanquake
interpreter: remove clang-tidy suppression
What changed, and why it matters
This commit simply removes a code comment block that told a code-checking tool (clang-tidy) to ignore a minor style warning about how two boolean member variables are initialized. The actual code behavior is unchanged, so there is no security impact.
No security action needed. This is a routine cleanup of a static-analysis suppression.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes a NOLINTBEGIN/NOLINTEND suppression pair and its explanatory comment around the fHashSingle and fHashNone member declarations in CTransactionSignatureSerializer. The referenced clang-tidy bug (LLVM issue #160394) is reportedly fixed in clang-tidy 22, so the suppression is no longer needed. No executable code, initialization order, or consensus logic is modified.
Changed components
src/script/interpreter.cppInspect captured patch +0 / −4
diff --git a/src/script/interpreter.cpp b/src/script/interpreter.cpp
index 49fa2bd9..443714ce 100644
--- a/src/script/interpreter.cpp
+++ b/src/script/interpreter.cpp
@@ -1258,12 +1258,8 @@ private:
const CScript& scriptCode; //!< output script being consumed
const unsigned int nIn; //!< input index of txTo being signed
const bool fAnyoneCanPay; //!< whether the hashtype has the SIGHASH_ANYONECANPAY flag set
- // Temporary workaround for a clang-tidy bug fixed in version 22.
- // See: https://github.com/llvm/llvm-project/issues/160394.
- // NOLINTBEGIN(modernize-use-default-member-init)
const bool fHashSingle; //!< whether the hashtype is SIGHASH_SINGLE
const bool fHashNone; //!< whether the hashtype is SIGHASH_NONE
- // NOLINTEND(modernize-use-default-member-init)
public:
CTransactionSignatureSerializer(const T& txToIn, const CScript& scriptCodeIn, unsigned int nInIn, int nHashTypeIn) :
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.