What the developer wrote
Authored by Hennadii Stepanov
cmake: Fix `FindQt` module
The `find_package(Qt .. MODULE REQUIRED COMPONENTS ...)` call must treat
any missing component as a fatal error.
What changed, and why it matters
This is a one-line fix to a CMake build script that looks for the Qt GUI library. Previously, the build could proceed even if a required Qt component was missing, because the script only checked that Qt's main directory was set. Now it also checks that Qt was actually found. This prevents silent misconfiguration of the build, but it is a build-time correctness issue rather than a runtime vulnerability in Bitcoin Core itself.
Treat as a low-risk build-hardening fix. Merge as normal. No special security response is needed. Users building from source with Qt should ensure required Qt components are installed; the build will now clearly fail if they are missing.
Security signals we found
Build configuration hardening: missing required dependency now fails fast instead of silently proceeding
Potential for misconfigured GUI build if Qt components are absent, which could lead to build artifacts that omit expected GUI functionality
No runtime code, memory safety, or cryptographic changes present in the diff
Evidence from the diff
The commit modifies cmake/module/FindQt.cmake. The find_package_handle_standard_args() call now includes Qt${Qt_FIND_VERSION_MAJOR}_FOUND in REQUIRED_VARS in addition to Qt${Qt_FIND_VERSION_MAJOR}_DIR. This ensures that a missing required Qt component causes a fatal CMake error instead of allowing configuration to continue with an incomplete Qt setup. The change affects only the build configuration phase and has no direct effect on compiled binaries or network behavior.
Changed components
cmake/module/FindQt.cmakeBitcoin Core GUI build configuration (Qt dependency detection)Inspect captured patch +1 / −1
diff --git a/cmake/module/FindQt.cmake b/cmake/module/FindQt.cmake
index d98af5bb..8ac47a60 100644
--- a/cmake/module/FindQt.cmake
+++ b/cmake/module/FindQt.cmake
@@ -36,7 +36,7 @@ unset(_qt_homebrew_prefix)
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(Qt
- REQUIRED_VARS Qt${Qt_FIND_VERSION_MAJOR}_DIR
+ REQUIRED_VARS Qt${Qt_FIND_VERSION_MAJOR}_DIR Qt${Qt_FIND_VERSION_MAJOR}_FOUND
VERSION_VAR Qt${Qt_FIND_VERSION_MAJOR}_VERSION
)
Why this scored 17/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.