AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Bitcoin

Merge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendall

Public commit record

What the developer wrote

Authored by Ava Chow

81/100 · Strong
Merge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendall

df2994b14a4ba26c4ccebd6df4c24d8aaf22d851 wallet: accept uppercase addresses without amount in sendall (FlashW)

Pull request description:

`sendall` keeps the recipients that were given without an amount as the strings the user passed (spend.cpp:1399). Later it finds their outputs by comparing against `EncodeDestination` of each output script (spend.cpp:1564), which for bech32 is the canonical lowercase form.

An address given in uppercase is valid bech32, and `validateaddress` and `sendtoaddress` accept it. In `sendall` it never matches, so its output keeps the placeholder amount of 0 and the call fails:

```
sendall '["BCRT1Q..."]'
error code: -8
Specified output amount to bcrt1q... is below dust threshold.
```

This stores the decoded destinations of those addresses instead and compares them with the destinations of the outputs, so the match doesn't depend on how the address was written. Invalid addresses are still rejected later when the transaction is constructed.

The new `sendall_uppercase_address` in `wallet_sendall.py` sweeps the wallet to the uppercase form of an address. It fails on master with the dust error above and passes with the fix. `wallet_send.py` still passes.

ACKs for top commit:
maflcko:
lgtm ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
achow101:
ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
polespinasa:
ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851

Tree-SHA512: 57fc356d52c69517aaef2ed67abad8c7c8350a984be914b4f6e1d79b871b269d6bb6d4bbc0b0a87cb55c560fe215b0fd310977f95856c3d54134a65fc92bf15c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This patch fixes a bug in Bitcoin Core's `sendall` wallet command. If a user typed a bech32 address in uppercase letters, the command would fail with a confusing 'below dust threshold' error instead of sending the funds. The fix compares decoded address data rather than raw text, so uppercase and lowercase addresses are treated the same. It is a usability/functional bug, not a vulnerability that lets someone steal funds.

Recommended action

No urgent security action required. Treat as a normal bug-fix merge; ensure the new regression test passes.

Security signals we found

01

Functional bug in RPC command causing unexpected transaction failure

02

Case-sensitivity mismatch between user input and canonical address encoding

03

No memory safety, cryptographic, or authorization issue evident

04

Regression test added to prevent re-introduction

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 2/25
Stealth signal 2/15
Affected reach 4/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.