BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

2889 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

253security candidates604second-pass queue1634AI analyses
208commits · 30 days
502commits · 60 days
1528commits · 180 days
2883commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

70/100 average clarity
927Strong · 80–100
1188Adequate · 60–79
686Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Antoine Poinsot22416170
Ava Chow15750134064
MarcoFalke40921179074
Lőrinc17721117081
fanquake22719115057
Hennadii Stepanov20914111063
rkrux57954074
Sjors Provoost89855074
Sebastian Falbesoner33719073
David Gumberg55650072
Pieter Wuille95520066
Hodlinator66532076
Analysis record

Published AI watches

Last scanned 14 minutes ago

Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35895: refactor: Enable clang-tidy rule to reject anon namespace in header

This is a code cleanup change that turns on a static-analysis rule to prevent a specific C++ coding pattern (anonymous namespaces in header files) and updates two headers to comply. It does not change how Bitcoin Core behaves at runtime an…

No security-relevant code changeNo memory safety, cryptography, consensus, or network changesTooling-only refactor (clang-tidy configuration)
c4fbd3c7by merge-script+9−123 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35630: test: Add importdescriptors rpc error test coverage

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production wallet, node, or RPC code. The tests verify that the importdescriptors RPC reports errors in the right order, rejects bad times…

465196d0by merge-script+77−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35180: coins: group private cache helpers

This change is purely a code cleanup: it moves two internal helper functions of a Bitcoin Core cache class into the private section of the class and removes a duplicate 'private:' label. There is no change to what the code does, no bug fix…

c940fd75by merge-script+13−141 file
No security note in commit
Low 29 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35582: rpc: reject null for optional parameters

This Bitcoin Core change tightens how three RPC commands (scantxoutset, scanblocks, deriveaddresses) handle the value null when it is passed for optional parameters. Previously, explicitly passing null could be treated differently from sim…

RPC parameter validation changeNull value handling changeAddition of explicit error checks for missing required contextual parameters
3db96eb5by merge-script+18−75 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Enable misc-definitions-in-headers

This commit is a code cleanup: it turns on a clang-tidy style check called 'misc-definitions-in-headers' and suppresses that check around a large inline implementation block in a benchmark header. There is no change to Bitcoin's runtime be…

fa93132dby MarcoFalke+3−02 files
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Enable clang-tidy rule to reject anon namespace in header

This commit only changes a linting configuration file for the project's code style checker. It enables a rule that prevents anonymous namespaces from being used in header files, which is a code-quality and build-hygiene practice. There is …

No security-relevant signals in the diff or commit message.Change is purely a static-analysis/linting configuration update.
fa5ca877by MarcoFalke+2−11 file
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Use C++20 std::identity over IntIdentity

This commit is a straightforward code cleanup: it replaces a small custom helper named IntIdentity with the standard C++20 std::identity from the <functional> header. The behavior of the ConvertBits function is unchanged; only the implemen…

fafe5042by MarcoFalke+4−111 file
No security note in commit
Informational 15 AI analysisMessage 87 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: test the result order of a multiple import request is correct

This commit only adds a new automated test to Bitcoin Core. It checks that when a user asks the wallet to import multiple descriptors at once, the list of results comes back in the same order as the original request, including any error me…

3ac8b806by Pol Espinasa+40−01 file
No security note in commit
Informational 15 AI analysisMessage 87 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: test invalid or missing timestamp throws importdescriptors

This commit only adds new automated tests for the Bitcoin Core wallet's importdescriptors RPC. It checks that the command correctly rejects requests with a missing or invalid timestamp. No production wallet code is changed, so this cannot …

No changes to consensus, networking, wallet logic, or cryptographyOnly functional test code is modifiedAdded assertions are for expected error handling paths
e4732bf0by Pol Espinasa+28−11 file
No security note in commit
Informational 15 AI analysisMessage 80 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Remove unused #include in common/system

This is a minor code cleanup that removes one unused header file include and swaps another for a more specific one. It does not change any program behavior or fix any security issue.

fa7304f3by MarcoFalke+1−22 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

iwyu: Fix warnings in `src/consensus` and treat them as errors

This commit is a routine code cleanup: it adjusts which C++ header files are included in several consensus-related source files and turns on a stricter compiler hygiene check (Include What You Use, or IWYU) for the src/consensus directory.…

13b53f8bby Hennadii Stepanov+42−79 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

fuzz: don't connman.ReceiveMsgFrom oversized msg

This is a small fix to a Bitcoin Core fuzz test (an automated internal testing harness), not to the live network code. The fuzzer was sometimes creating fake P2P messages larger than the real protocol allows and passing them into a test he…

Test-only fuzz harness hardeningOversized message guard added before ReceiveMsgFrom() in fuzz targetNo change to production P2P message acceptance logic
bb19f1daby Greg Sanders+5−01 file
No security note in commit
Informational 15 AI analysisMessage 97 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: Temporarily remove riscv32 config from GHA matrix

This commit simply removes one failing test configuration (RISC-V 32-bit bare metal) from the project's GitHub Actions CI matrix because it was failing. It is a routine CI maintenance change with no security implications.

fa06ea42by MarcoFalke+0−61 file
No security note in commit
Low 47 AI analysisMessage 90 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: verify cross-build SDK archives

This change adds checksum verification to the build system's downloads of Apple, FreeBSD, NetBSD, and OpenBSD software development kits (SDKs). Before this patch, those SDK archives were downloaded at build time and extracted without confi…

Adds cryptographic digest verification for downloaded SDK archivesRemoves unchecked extraction of remote SDK archives in CIHardens CI supply chain for macOS/BSD cross-builds
873550beby Lőrinc+25−126 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 80 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: update NetBSD cross-build SDK

This is a routine maintenance update to Bitcoin Core's continuous integration (CI) system. It changes the version number of the NetBSD operating system used for cross-compilation testing from a release candidate (11.0_RC6) to the final rel…

2c87337eby Lőrinc+1−11 file
No security note in commit
Informational 15 AI analysisMessage 72 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: require `TryGetTotalRam()` detection

This commit only changes a test file and build configuration. It removes the option to skip a test when the system cannot detect total RAM, and instead requires the RAM detection to succeed. It does not change any production wallet, networ…

6a2de55aby Lőrinc+3−112 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

scripted-diff: use `MIN_DBCACHE_BYTES`

This commit is a simple automated rename of a constant from MIN_DB_CACHE to MIN_DBCACHE_BYTES across five files. The value stays the same (4 MiB), and no behavior changes. It is a code-cleanup/refactoring change with no security relevance.

7cfa21d6by Lőrinc+5−55 files
No security note in commit
Informational 20 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

kernel: allow setting chainstate `dbcache`

This commit adds a new public API knob to the Bitcoin Core 'libbitcoinkernel' library so that programs using the kernel can choose how much memory to use for the chainstate database cache. It also enforces minimum and maximum size limits. …

New configurable cache-size API with explicit min/max validationReplaces hard-coded DEFAULT_KERNEL_CACHE with caller-supplied valueAdds unit tests for out-of-range rejection and 32-bit upper-bound rejection
8bd9f460by Lőrinc+41−14 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

kernel, node: colocate dbcache bounds

This commit is a small code cleanup: it moves two constants that define the minimum and maximum size of the database cache (dbcache) into a shared kernel header so that both the node and kernel code use the same limits. There is no change …

8aa21e11by Lőrinc+7−74 files
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

node, qt: inline `DEFAULT_DB_CACHE`

This is a small code cleanup change in Bitcoin Core. It removes a misleading alias named DEFAULT_DB_CACHE and replaces it with the underlying name DEFAULT_KERNEL_CACHE in a few places. The behavior of the program is unchanged; only the nam…

cd086c16by Lőrinc+5−74 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidatetest: add PSBT proprietary merge regression coverageby w0xlt · da769855 · May 17, 2026 · 2 filesMessage 95 · StrongInformational 15Details
Commit message · w0xlt

test: add PSBT proprietary merge regression coverage

Add unit and functional regression tests asserting that combine/merge preserves proprietary fields at the global, input, and output scopes.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing boundaryfuzzing or regression evidencesigning or wallet path
AI analysis · Informational 15/100

This commit only adds new regression tests for Bitcoin Core's PSBT (Partially Signed Bitcoin Transaction) combine/merge logic. It checks that custom 'proprietary' data fields are preserved when two PSBTs are merged at global, input, and output levels. There is no production code change, no bug fix, and no security patch in the diff itself.

Security candidatepsbt: preserve proprietary fields when combining PSBTsby w0xlt · 3f5b3c7a · May 17, 2026 · 1 fileMessage 85 · StrongLow 28Details
Commit message · w0xlt

psbt: preserve proprietary fields when combining PSBTs

CombinePSBTs currently preserves unknown records but drops proprietary records at the global, input, and output levels because the Merge() paths never union m_proprietary.

Preserve proprietary records in PartiallySignedTransaction::Merge(), PSBTInput::Merge(), and PSBTOutput::Merge() so combine/merge keeps all PSBT key-value data.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 28/100

This commit fixes a bug in Bitcoin Core's handling of PSBTs (Partially Signed Bitcoin Transactions). When two PSBTs were combined, the software correctly kept 'unknown' extra data but accidentally discarded 'proprietary' custom data fields added by wallets or tools. The patch makes sure proprietary fields are preserved during merging, preventing potential loss of transaction metadata that some wallets rely on.

Lower-prioritykernel: doc: document wipe lifecycle and best entry nullabilityby csjones · 6189335f · May 16, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · csjones

kernel: doc: document wipe lifecycle and best entry nullability

Document on `btck_chainstate_manager_options_set_wipe_dbs` that a wipe must be followed by `btck_chainstate_manager_import_blocks` before the chainstate manager is used for anything else, as the existing kernel tests already do (e.g. `chainman_reindex_test`).

Note in the `@return` of `btck_chainstate_manager_get_best_entry` that it can return null when no block headers have been loaded.

Refactor the `@return` documentation to fit on a single line.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only changes comments in a single header file. It documents that a database wipe must be followed by importing blocks, and that a function can return null when no block headers are loaded. There are no code changes and no security fix.

Lower-prioritycommon: Add unused UrlEncode functionby Fabian Jahr · c471c508 · May 15, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · Fabian Jahr

common: Add unused UrlEncode function

Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit adds a new helper function called UrlEncode that converts text into URL-safe format, plus tests for it. The function is not used anywhere in the actual program yet, so it cannot directly affect live behavior or introduce a practical security flaw. It is a routine, standard implementation following RFC 3986.

Lower-priorityci: Tolerate unused free functions in intermediate commitsby Fabian Jahr · 9687ef1b · May 15, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · Fabian Jahr

ci: Tolerate unused free functions in intermediate commits

When bigger changes are split across multiple commits, intermediate
commits may introduce unused functions. Do not check for this error
in intermediate commits.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit changes a CI (Continuous Integration) script used during Bitcoin Core's automated testing. It adds a compiler warning suppression for 'unused free functions' in addition to the existing suppression for 'unused member functions'. This only affects how intermediate commits in a pull request are validated, not the actual Bitcoin software that users run. There is no security issue here.

AI review queuedIWYU fixesby Anthony Towns · 57d7495f · May 15, 2026 · 5 filesMessage 13 · OpaqueInformational 15Details
Commit message · Anthony Towns

IWYU fixes

Add missing includes of logging.h in preparation for the next commit,
switching to util/log.h. Also removes some unnecessary util/check.h
includes that CI complains about.

13/100 · OpaqueMessage clarity
✓ Provides detailed explanatory context! Very short subject! Too few words to establish purpose
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a routine code cleanup. It adds missing header file includes for logging and removes one unnecessary include. There is no functional code change and no security issue.

AI review queuedscripted-diff: logging: Drop LogAcceptCategoryby Anthony Towns · 611878b4 · May 15, 2026 · 7 filesMessage 78 · AdequateInformational 15Details
Commit message · Anthony Towns

scripted-diff: logging: Drop LogAcceptCategory

-BEGIN VERIFY SCRIPT-
sed -i 's/LogAcceptCategory(\(.*\), [a-zA-Z:]*::Level::Debug)/util::log::ShouldDebugLog(\1)/g' $(git grep -l LogAcceptCategory -- '*.cpp')
sed -i 's/LogAcceptCategory(\(.*\), [a-zA-Z:]*::Level::Trace)/util::log::ShouldTraceLog(\1)/g' $(git grep -l LogAcceptCategory -- '*.cpp')
sed -i '/Return true if log accepts specified category/,/^$/d' src/logging.h
-END VERIFY SCRIPT-

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a routine internal code cleanup in Bitcoin Core. It replaces an older logging helper function called LogAcceptCategory with newer, more specific helper functions (ShouldDebugLog and ShouldTraceLog). The behavior of the program is intended to remain exactly the same; only the names of the functions used to decide what to log have changed. There is no indication this fixes or introduces a security vulnerability.

Security candidatelogging: use util/log.h where possibleby Anthony Towns · 02b2c411 · May 15, 2026 · 58 filesMessage 60 · AdequateInformational 15Details
Commit message · Anthony Towns

logging: use util/log.h where possible

Replace usage of logging.h with util/log.h where it
suffices.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
seed or entropy pathsigning or wallet pathparser or protocol path
AI analysis · Informational 15/100

This commit is a simple internal cleanup: it swaps the full logging header file for a smaller, more focused one in many source files. There is no change to program behavior, no bug fix, and no security relevance.

Lower-priorityutil/log, logging: Provide ShouldDebugLog and ShouldTraceLog instead of a generic ShouldLogby Anthony Towns · 34332dba · May 15, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · Anthony Towns

util/log, logging: Provide ShouldDebugLog and ShouldTraceLog instead of a generic ShouldLog

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup in Bitcoin Core's logging system. It replaces one generic helper function with two more specific ones (one for debug logs, one for trace logs) and updates the macros that use them. There is no change to user-facing behavior, no bug fix, and no security relevance visible in the code.

Lower-prioritylogging: Move GetLogCategory into Logger classby Anthony Towns · abea304d · May 15, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Anthony Towns

logging: Move GetLogCategory into Logger class

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a simple code cleanup: it moves a helper function that converts a log category name into an internal flag from the global namespace into the Logger class. There is no change in behavior, no user-visible effect, and no security relevance.

Lower-priorityutil/log: Rename LogPrintLevel_ into detail_ namespaceby Anthony Towns · 58113e58 · May 15, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Anthony Towns

util/log: Rename LogPrintLevel_ into detail_ namespace

After the previous commit, LogPrintLevel_ is only used to implement
other macros.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a simple code cleanup change that renames an internal logging helper macro from LogPrintLevel_ to detail_LogWithSrcLoc. The macro does exactly the same thing as before; only its name changed. There is no security issue here.

Lower-priorityutil/log: Provide util::log::NO_RATE_LIMIT to avoid rate limitsby Anthony Towns · f69d1ae5 · May 15, 2026 · 6 filesMessage 62 · AdequateInformational 18Details
Commit message · Anthony Towns

util/log: Provide util::log::NO_RATE_LIMIT to avoid rate limits

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Explains rationale or failure mode! No meaningful explanatory body
AI analysis · Informational 18/100

This commit is a code cleanup, not a security fix. It introduces a cleaner way for Bitcoin Core developers to mark certain important log messages as exempt from automatic rate-limiting. The rate-limiting protection itself already existed; this change just makes the code easier to read and maintain. There is no indication it fixes a known vulnerability.

Lower-prioritylogging: Protect ShrinkDebugFile by m_csby Anthony Towns · 72e92d67 · May 15, 2026 · 2 filesMessage 60 · AdequateLow 32Details
Commit message · Anthony Towns

logging: Protect ShrinkDebugFile by m_cs

We should not be logging while shrinking the debug file, so make sure
that's true by using our mutex.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 32/100

This commit fixes a potential crash or data corruption bug in Bitcoin Core's debug log handling. The ShrinkDebugFile() function, which trims the large debug.log file down to size, was not using the same lock (mutex) that protects normal logging. That meant logging could happen at the same time the file was being shrunk, possibly causing the program to behave incorrectly or crash. The fix wraps the shrink operation in the logging mutex and changes one internal warning call so it works while that lock is held.

Lower-prioritydoc: Move mutex and thread section into guideline sectionby MarcoFalke · faf6afd9 · May 15, 2026 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · MarcoFalke

doc: Move mutex and thread section into guideline section

Previously, they have been in the "Tips and tricks" section, which seems a bit off.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is a pure documentation reorganization. It moves the 'Locking/mutex usage notes' and 'Threads' sections from the 'Tips and tricks' area into a new 'Development guidelines' section in the developer notes. No code, logic, or security behavior changed.

Lower-prioritydoc: move-only Valgrind sectionby MarcoFalke · fa514caa · May 15, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · MarcoFalke

doc: move-only Valgrind section

Valgrind is often used as a sanitizer, so move it closer to the Sanitizer section.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
defensive validationdocumentation-only discount
AI analysis · Informational 15/100

This commit simply moves the existing Valgrind documentation section to a different place in the developer notes file. No code, configuration, or behavior changed. It is purely a documentation reorganization.

Lower-prioritydoc: move-only Python sectionby MarcoFalke · fa0202f3 · May 15, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · MarcoFalke

doc: move-only Python section

Doxygen is about the C++ comment style, so move the Python section to have all C++ style sections in one flow.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply moves a documentation section about Python coding style to a different place in the developer notes. It is a non-functional, move-only change with no security relevance.

Lower-prioritydoc: Regroup clang-tidy rulesby MarcoFalke · fa37606c · May 15, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · MarcoFalke

doc: Regroup clang-tidy rules

* Remove the explicit modernize-use-nullptr rule mention, which has not been needed for years.
* Encourage devs to refer to the upstream clang-tidy rules documentation.
* Move NOLINTNEXTLINE(misc-no-recursion) into a subsection under the new clang-tidy section.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only reorganizes developer documentation about code style and the clang-tidy checking tool. It removes an outdated note, moves a recursion-related note into a new subsection, and adds a link to upstream clang-tidy documentation. No program code was changed, so there is no security impact.

Lower-prioritydoc: Fix to use lower-case anchors in links to C++ Core Guidelinesby MarcoFalke · fa9c2dde · May 15, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · MarcoFalke

doc: Fix to use lower-case anchors in links to C++ Core Guidelines

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only fixes the capitalization of web link anchors in developer documentation. It changes three URLs from upper-case anchors (like #Renum-caps) to lower-case anchors (like #renum-caps) so the links work correctly. There is no change to any program code, no security issue, and no risk to users.

Lower-prioritycmake: Check dependencies after build option interactionby Hennadii Stepanov · a154c05d · May 15, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

cmake: Check dependencies after build option interaction

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit reorganizes the CMake build scripts so that dependency checks happen after build options have been finalized. It is a build-system correctness and maintainability improvement, not a security fix. There is no indication it addresses a vulnerability or changes runtime behavior of Bitcoin Core.

Lower-prioritybench: add benchmark for GetMappedAS()by 0xb10c · 096bb0b5 · May 15, 2026 · 2 filesMessage 86 · StrongInformational 15Details
Commit message · 0xb10c

bench: add benchmark for GetMappedAS()

With #28792 merged, we can use the embedded ASMap file to benchmark
the IP -> ASN lookups. Before, this would have been cumbersome as it
required having a real, external ASMap file. We want to benchmark
against a real file, as a smaller test file has significantly faster
lookups.

The benchmarks cover individual IP address lookups of mapped and
unmapped IPv4 and IPv6 addresses along with a multi-IP lookup.
For the IPs we assume to be mapped, we assert that they are mapped.
Updating the embedded ASMap file might change the benchmark results
slightly as some lookups will be a bit faster and others slower.

```
$ ./build/bin/bench_bitcoin --filter=ASMapGetMappedAS.* -min-time=5000

| ns/op | op/s | err% | total | benchmark
|--------------------:|--------------------:|--------:|----------:|:----------
| 460.41 | 2,171,994.61 | 0.2% | 5.48 | `ASMapGetMappedASCloudflarev4`
| 356.96 | 2,801,460.45 | 0.0% | 5.33 | `ASMapGetMappedASCloudflarev6`
| 476.58 | 2,098,304.01 | 0.1% | 5.51 | `ASMapGetMappedASGooglev4`
| 359.17 | 2,784,224.15 | 0.0% | 5.33 | `ASMapGetMappedASGooglev6`
| 398.82 | 2,507,410.35 | 0.1% | 5.50 | `ASMapGetMappedASMulti`
| 346.11 | 2,889,237.31 | 0.3% | 5.32 | `ASMapGetMappedASQuad9v4`
| 274.21 | 3,646,832.70 | 0.1% | 5.50 | `ASMapGetMappedASQuad9v6`
| 5.32 | 187,875,440.96 | 0.1% | 5.50 | `ASMapGetMappedASUnmappedv4`
| 65.19 | 15,339,680.04 | 0.1% | 5.51 | `ASMapGetMappedASUnmappedv6`
```

Co-authored-by: Fabian Jahr <fjahr@protonmail.com>
Co-authored-by: Lőrinc <pap.lorinc@gmail.com>

86/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit only adds a new performance benchmark for an existing IP-to-ASN lookup feature. It does not change any production code, network behavior, or security logic. There is no security issue here.

Security candidatei2p: clean up SAM error loggingby takeshikurosawaa · b6c36704 · May 15, 2026 · 1 fileMessage 73 · AdequateLow 35Details
Commit message · takeshikurosawaa

i2p: clean up SAM error logging

SESSION CREATE requests can contain the I2P private key. Keep using the redacted request text in error messages, and avoid echoing raw SAM replies in the generic reply error path.

This keeps the error useful while avoiding logging either the private-key-bearing request or unescaped router-controlled reply bytes. No network behavior change is intended.

73/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
secret or key material
AI analysis · Low 35/100

This commit tightens up error messages in Bitcoin Core's I2P (anonymous networking) code. Previously, error messages could accidentally include the full text of a SAM request that may carry the user's I2P private key, or the full raw reply from an I2P router. The patch keeps the error useful by still referencing the redacted request, but stops echoing the sensitive request body and unescaped router replies into logs. It is a defensive information-disclosure fix, not a change to network behavior.

Lower-prioritytest: avoid non-loopback network traffic from node_init_tests/init_testby Vasil Dimov · 1c500b17 · May 15, 2026 · 2 filesMessage 100 · StrongInformational 23Details
Commit message · Vasil Dimov

test: avoid non-loopback network traffic from node_init_tests/init_test

The test calls:
`AppInitMain()` -> `StartMapPort()` -> `StartThreadMapPort()` ->
`ThreadMapPort()` -> `ProcessPCP()` -> `PCPRequestPortMap()` ->
`CreateSock()` and on the returned value from `CreateSock()` it calls
the `Connect()` method.

Thus, change `BasicTestingSetup::BasicTestingSetup()` to set `-natpmp`
to 0. This way `node_init_tests/init_test` or other tests will not do
network activity due to `ThreadMapPort()`.

Also add a comment about `natpmp=0` in
`test/functional/test_framework/util.py`.

Also set `-dnsseed=0` in `BasicTestingSetup::BasicTestingSetup()` to
avoid DNS queries.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 23/100

This is a test-hardening change, not a fix for an exploitable vulnerability in live Bitcoin Core. The patch stops automated tests from accidentally sending real network traffic (router NAT-PMP packets and DNS queries) to non-localhost destinations. It does not change how normal node software behaves when users run it.

Lower-priorityp2p: Release m_peer_mutex early in InitiateTxBroadcastToAllby MarcoFalke · fa2afba2 · May 15, 2026 · 2 filesMessage 50 · ThinInformational 23Details
Commit message · MarcoFalke

p2p: Release m_peer_mutex early in InitiateTxBroadcastToAll

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 23/100

This change refactors how Bitcoin Core sends transaction announcements to all connected peers. Previously, the code held a broad internal lock (m_peer_mutex) while iterating over every peer and preparing messages. The patch copies the peer list under the lock, then releases the lock before doing the slower per-peer work. This reduces the chance of lock contention and removes a known ThreadSanitizer suppression for a deadlock in Chainstate::ConnectTip. It is a robustness improvement, not a fix for an exploitable vulnerability.

AI review queueddoc: external signer: update interface, --stdin flag, IPC-command signtx, contains updates from #33947by Danny van Heumen · 3381855e · May 14, 2026 · 1 fileMessage 58 · ThinInformational 15Details
Commit message · Danny van Heumen

doc: external signer: update interface, --stdin flag, IPC-command signtx, contains updates from #33947

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates documentation for Bitcoin Core's external signer feature. It renames a command from 'signtransaction' to 'signtx', documents a new required '--stdin' flag, adds '--chain' flag details, and fixes examples. No actual code was changed, so this cannot directly introduce or fix a security vulnerability.

Lower-prioritydoc: Add release notes for #32220by Hennadii Stepanov · 3142e5f8 · May 14, 2026 · 1 fileMessage 53 · ThinInformational 15Details
Commit message · Hennadii Stepanov

doc: Add release notes for #32220

53/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds documentation: a new release-notes file explaining that an obscure build-system environment variable was removed and how users can still disable git detection. There is no code change, no bug fix, and no security-relevant behavior change in the commit itself.