BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
171commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 22 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36365: fees: fall back to `block_policy` and minor api changeby Ava Chow · 0198c853 · Sep 29, 2026 · 13 filesMessage 93 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36365: fees: fall back to `block_policy` and minor api change

5b77288673e2b74de1512180a8911f435311ca7a fees: clear mined-block stats when the mempool load fails (ismaelsadeeq)
c0b7ca3dbdbaecdd045c8a36d9758470358880a0 fees: fall back to block_policy when the mempool estimator can't estimate (ismaelsadeeq)
4056908f0feae2a1caf9b53cfbe77bb8091246c9 fees: rename the default fee_rate_estimator value to "auto" (ismaelsadeeq)

Pull request description:

This is split from #36182 to allow review of the first three commits that we want to backport to 32.x.

This is a simple PR that does three things:

1. A minor, non-breaking `estimatesmartfee` API update: it renames the default estimator option from "none" to "auto". See the rationale here: https://github.com/bitcoin/bitcoin/pull/36182#issuecomment-5817784558

2. Falls back to the `block_policy` fee rate estimator when `mempool_policy` is not available. This preserves the previous behavior and lets users who update their node keep using `block_policy` estimates until the mempool policy has finished gathering stats and is ready to serve estimates.

3. After a restart in which mempool loading fails, we clear the data gathered by the mempool fee rate estimator, to prevent it from returning the fee rate floor just because the node lost its mempool transactions.

ACKs for top commit:
davidgumberg:
re-crACK https://github.com/bitcoin/bitcoin/commit/5b77288673e2b74de1512180a8911f435311ca7a
achow101:
ACK 5b77288673e2b74de1512180a8911f435311ca7a
willcl-ark:
reACK 5b77288673e2b74de1512180a8911f435311ca7a
w0xlt:
ACK 5b77288673e2b74de1512180a8911f435311ca7a

Tree-SHA512: 4e5742899992ae6d0f062e436ed4da159896b02b7c60ce6aec0d2e4beb635e922d34154995256d33972e77269f5e60141432d6276df58e2e8b75300d3043de83

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36381: test: avoid testing at the exact `-maxfeerate` boundaryby Ava Chow · ba8fdb97 · Sep 29, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36381: test: avoid testing at the exact `-maxfeerate` boundary

025768fb37cefdffcfc47376055bedb103699565 test: avoid testing at the exact `-maxfeerate` boundary (ismaelsadeeq)

Pull request description:

Fixes #36363

`test_maxfeerate` configured `-maxfeerate=0.00001009` and then created a
transaction requesting the exact same fee rate. This is fragile because the
wallet sizes the fee from the estimated (maximum) signed vsize, while the
`-maxfeerate` limit is checked against the actual signed vsize.

When the actual signature is smaller than the estimate, the actual vsize is smaller than
estimated resulting in a higher feerate and the transaction is rejected, causing
intermittent CI failures.

Request a fee rate slightly below `-maxfeerate` so the transaction is accepted
regardless of the signature size, while still exercising the limit.

Can be reproduced with

```diff
--- a/test/functional/wallet_send.py
+++ b/test/functional/wallet_send.py
@@ -221,8 +221,17 @@ class WalletSendTest(BitcoinTestFramework):
self.nodes[0].sendtoaddress, address=self.nodes[0].getnewaddress(), amount=1, fee_rate=11)
self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), amount=1, fee_rate=9)

- self.restart_node(0, extra_args=['-maxfeerate=0.00001009'])
- self.nodes[0].sendtoaddress(self.nodes[0].getnewaddress(), amount=1, fee_rate=Decimal("1.009"))
+ self.restart_node(0, extra_args=['-maxfeerate=0.00001009', '-changetype=bech32m'])
+ w = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
+ tr_addr = w.getnewaddress(address_type="bech32m")
+ funding_txid = w.sendtoaddress(tr_addr, 5)
+ self.generate(self.nodes[0], 1)
+ vout = next(o["n"] for o in w.gettransaction(funding_txid, verbose=True)["decoded"]["vout"]
+ if o["scriptPubKey"]["address"] == tr_addr)
+ # Spend the taproot input at exactly maxfeerate. The tr() descriptor
+ # estimates a 65-byte sig but the key-path spend is 64 bytes, so the
+ # estimated vsize always exceeds the actual deterministic rejection.
+ w.send(outputs={w.getnewaddress(): 1}, fee_rate=Decimal("1.009"),
+ options={"inputs": [{"txid": funding_txid, "vout": vout}], "add_inputs": False})
```

The actual failure in #36363 is intermittent because legacy output signatures only sometimes result in a tx size smaller than estimated. It can be reproduced in master by running the test on the file from 100 to 200 times.

And running it again at the same time with this PR does not fail.

ACKs for top commit:
maflcko:
lgtm ACK 025768fb37cefdffcfc47376055bedb103699565
achow101:
ACK 025768fb37cefdffcfc47376055bedb103699565
furszy:
utACK 025768fb37cefdffcfc47376055bedb103699565

Tree-SHA512: 9e70b238f22e6d75108c1b10096008aad5f1bea7ddbb51a11fe722674adcd2dada3dabe577a6049b242fcf826ccd582c16a025b406742ad6b3195a0dae27b44f

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit fixes a flaky automated test in Bitcoin Core. The test was checking the maximum transaction fee rate by creating a transaction at the exact boundary, which sometimes failed because the real transaction size could be slightly smaller than estimated. The fix simply lowers the requested fee rate in the test so it no longer sits exactly on the boundary. There is no change to production code or to any real security behavior.

AI review queuedMerge bitcoin/bitcoin#36233: guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8`by merge-script · 619185d5 · Sep 29, 2026 · 3 filesMessage 91 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36233: guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8`

feb77d838eda70dfc27df78537da89f2b568f52c guix: Update time-machine to `60f6956aeffa7f30285745bd0ea615e9acfc74f8` (Hennadii Stepanov)
f14a3ef8c5c6480f2e452d9668db71786cdb83fc guix: Skip some packages' tests in `python-lief` and `nsis-x86_64` (fanquake)

Pull request description:

On the master branch @ 17817818da3cb67c95320b7a5d4d69bd649c1fbf, building on a RISC-V system [fails](https://github.com/bitcoin/bitcoin/issues/36232):
```
guix shell: error: package python-lief@0.17.5 does not support riscv64-linux
```

Also see https://github.com/bitcoin/bitcoin/pull/34550#issuecomment-3921035276.

This is caused by the `python-msgspec` package, an indirect dependency of `python-lief`:

`python-lief` <-- `python-scikit-build-core` <-- `python-cattrs` <-- `python-msgspec`

Also see https://github.com/bitcoin/bitcoin/pull/34550#issuecomment-3926767282.

This [commit](https://codeberg.org/guix/guix/commit/b35905695afd2e24c56e6950433dd4f571581873) updates `python-msgspec` and removes `(supported-systems (list "x86_64-linux" "aarch64-linux"))` from its definition.

Package updates:
- `git-minimal`: 2.52.0 -> 2.54.0
- `linux-headers` 6.1.166 -> 6.1.172
- `python-lief`: 0.17.5 -> 0.17.6
- `python-minimal`: 3.11.14 -> 3.12.12

Additionally, `python-lief` and `nsis-x86_64` transitively pull in packages whose tests fail when building natively on `riscv64`:
- `python-lief`: `python-psutil`, `python-pytest-xprocess`, `python-sh`
- `nsis-x86_64`: `python-psutil`

Tests for the problematic packages are temporarily disabled.

Fixes https://github.com/bitcoin/bitcoin/issues/36232.

ACKs for top commit:
maflcko:
re-review ACK feb77d838eda70dfc27df78537da89f2b568f52c 🦏
willcl-ark:
ACK feb77d838eda70dfc27df78537da89f2b568f52c

Tree-SHA512: c89c57e0f3f8090c3eaa52cbc6b55c6564f297158afebf8306bcae692f4f5121156e64e5af3fb9e6dcb0091a9cd2d65e002854abb5befd7df6df31f1618ed280

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discountsecond-pass: broader security terminology
AI analysis · Informational 20/100

This is a build-system maintenance update for Bitcoin Core's reproducible build environment (Guix). It updates the Guix time-machine commit and several dependency versions, and temporarily disables some test suites that fail when building on the RISC-V processor architecture. The change is not a security fix for Bitcoin's consensus or networking code; it is a portability fix so that builds work on RISC-V machines.

Lower-priorityMerge bitcoin/bitcoin#36275: build: enable `-Wunused-const-variable`by Hennadii Stepanov · 3b9768a0 · Sep 29, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36275: build: enable `-Wunused-const-variable`

cf57dc281e8f371075f85a82883e04a32876156c build: add -Wunused-const-variable (fanquake)
b45a7084d8096ba57803808630386d30709b12cb refactor: use inline constexpr (fanquake)

Pull request description:

Split out of #36167.

Fixes:
```bash
/root/bitcoin/src/leveldb/db/dbformat.h:42:18: warning: ‘leveldb::config::kMaxMemCompactLevel’ defined but not used [-Wunused-const-variable=]
42 | static const int kMaxMemCompactLevel = 2;
| ^~~~~~~~~~~~~~~~~~~
/root/bitcoin/src/leveldb/db/dbformat.h:28:18: warning: ‘leveldb::config::kL0_CompactionTrigger’ defined but not used [-Wunused-const-variable=]
28 | static const int kL0_CompactionTrigger = 4;
| ^~~~~~~~~~~~~~~~~~~~~
In file included from /root/bitcoin/src/leveldb/db/dbformat.h:13:
/root/bitcoin/src/leveldb/include/leveldb/db.h:19:18: warning: ‘leveldb::kMinorVersion’ defined but not used [-Wunused-const-variable=]
19 | static const int kMinorVersion = 22;
| ^~~~~~~~~~~~~
/root/bitcoin/src/leveldb/include/leveldb/db.h:18:18: warning: ‘leveldb::kMajorVersion’ defined but not used [-Wunused-const-variable=]
18 | static const int kMajorVersion = 1;
| ^~~~~~~~~~~~~
```

```bash
In file included from /home/runner/work/_temp/src/init/common.cpp:11:
/home/runner/work/_temp/src/logging.h:66:24: error: ‘BCLog::RATELIMIT_MAX_BYTES’ defined but not used [-Werror=unused-const-variable=]
66 | constexpr uint64_t RATELIMIT_MAX_BYTES{1_MiB}; // maximum number of bytes per source location that can be logged within the RATELIMIT_WINDOW
| ^~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
```
etc.

ACKs for top commit:
maflcko:
lgtm ACK cf57dc281e8f371075f85a82883e04a32876156c
BrandonOdiwuor:
ACK cf57dc281e8f371075f85a82883e04a32876156c
hebasto:
ACK cf57dc281e8f371075f85a82883e04a32876156c.

Tree-SHA512: b1a2dac38f942da7f0250f4040007f06de14a9f3ddc1554ef090ea12bcb1c79c2a66449189f39503d203d4dd549f74103b2e8545f3cfcb8f1dcc1a0ca774563b

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36364: tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-walletby merge-script · dc2a9987 · Sep 29, 2026 · 3 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36364: tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet

4048909a53422bf86b207a9b5c8650e8edd25737 tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet (Torkel Rogstad)

Pull request description:

Only kernel::Context users selected a hardware SHA256 implementation, so these tools fell back to the generic one. On an M2 Max, grind is ~5x faster and signing 2000 P2PKH inputs with bitcoin-tx ~2.3x.

ACKs for top commit:
maflcko:
lgtm ACK 4048909a53422bf86b207a9b5c8650e8edd25737
furszy:
utACK 4048909a53422bf86b207a9b5c8650e8edd25737

Tree-SHA512: 0edc6b78efbf0c84c22bbe98bd1ab295accc9530e24cee8f0faed9f63515fe8b677e8c33d3b46e0f1c0a44b422374cd7395ce163468d98772ea72a8faa9a1cfa

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This change makes three Bitcoin command-line tools (bitcoin-tx, bitcoin-util, and bitcoin-wallet) automatically pick the fastest SHA-256 hashing implementation available on the computer, such as hardware-accelerated versions on modern CPUs. Previously, only some parts of Bitcoin Core did this, so these tools used a slower generic implementation. The result is a significant speedup for operations that do a lot of hashing, but there is no security bug being fixed here.

Security candidateMerge bitcoin/bitcoin#36321: net: cast vector size to avoid overflow, truncation, sign changeby merge-script · ced4c6e6 · Sep 29, 2026 · 1 fileMessage 98 · StrongInformational 23Details
Commit message · merge-script

Merge bitcoin/bitcoin#36321: net: cast vector size to avoid overflow, truncation, sign change

308cd670195d908fbd50caf76a8a215386121bd0 net: cast vector size to avoid overflow, truncation, sign change (Eugene Siegel)

Pull request description:

When running with `-fsanitize=integer` compiled, the following can error [here](https://github.com/bitcoin/bitcoin/blob/b3f846ec3e5c21b08779ac6c13475f3ab37e7d9c/src/net_processing.cpp#L3662):

```
SUMMARY: UndefinedBehaviorSanitizer: unsigned-integer-overflow /bitcoin/src/net_processing.cpp:3662:33
SUMMARY: UndefinedBehaviorSanitizer: implicit-signed-integer-truncation-or-sign-change /bitcoin/src/net_processing.cpp:3662:18
```

When `stop_index->nHeight` is less than `CFCHECKPT_INTERVAL`, the `headers` vector will be empty. This will just set the loop counter to -1 and never enter the loop, so this is harmless anyways. Fix this by casting `headers.size()` to `int`.

ACKs for top commit:
maflcko:
lgtm ACK 308cd670195d908fbd50caf76a8a215386121bd0
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/308cd670195d908fbd50caf76a8a215386121bd0

Tree-SHA512: 1074667b644e42507b32043e98a0541fff6de9a3711003a43b9874b31956a8e10efe65af89ed2b23322a7aa3df7d6a8606db5c1ab342f070a625b9e9650ae1fa

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
memory safetydefensive validationmerge-commit duplicate discount
AI analysis · Informational 23/100

This is a one-line fix in Bitcoin Core's network code. It changes how the size of a list of block headers is converted to a signed integer inside a loop. Previously, if the list was empty, the conversion could trigger undefined-behavior warnings under special compiler sanitizers because subtracting 1 from an unsigned zero produced a very large positive number, which then got squeezed into a signed integer. The code already did not enter the loop in that case, so there was no practical exploit path. The patch simply makes the conversion explicit and clean.

Lower-priorityMerge bitcoin/bitcoin#36235: ci: fail iwyu job on compiler errors instead of silently logging themby merge-script · e7a18350 · Sep 29, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36235: ci: fail iwyu job on compiler errors instead of silently logging them

622817f097d68cb1a59004ca7c115110d8bf64a0 ci, iwyu: fail job on compiler errors instead of ignoring them (David-Uka)

Pull request description:

The IWYU invocation ends in `2>&1 || true`, added as a TODO when pipefail was introduced in fa99a3ccace. That `|| true` swallows the non-zero exit from a compiler `fatal error:` (for example a generated header that was not built before IWYU ran), so such errors only reached the raw CI logs and never failed the job, as reported in #35361.

Dropping the `|| true` lets pipefail propagate the failure, so the job fails loudly instead of passing silently. The recent header-generation fixes (#35468, #36228) mean the current master `iwyu` job is already free of such errors, so this does not turn CI red today.

Closes #35361.

ACKs for top commit:
maflcko:
lgtm ACK 622817f097d68cb1a59004ca7c115110d8bf64a0
hebasto:
ACK 622817f097d68cb1a59004ca7c115110d8bf64a0.

Tree-SHA512: 0ca19989777818454c654a847176a7c1bbec6b57a0f6e48acfbc0cf4644770d1bcd50e8e7e62671ed10ddda128cd9cce433ad721a0612f4c3e0aecde663a8d83

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36024: ci: Make `test_bitcoin-qt.exe` output visibleby Hennadii Stepanov · 05bc2f53 · Sep 28, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Hennadii Stepanov

Merge bitcoin/bitcoin#36024: ci: Make `test_bitcoin-qt.exe` output visible

70701de7c55512b4c8dbc3eaca91659980bf5300 ci: Make `test_bitcoin-qt.exe` output visible (Hennadii Stepanov)

Pull request description:

When run in the GHA environment, there is no console attached, so Qt's [`stderrHasConsoleAttached()`](https://github.com/qt/qtbase/blob/5d8cae8a76ee5293ea885bd8fd8b2604819edfe3/src/corelib/global/qlogging.cpp#L296) returns false and the entire test report is lost. Set `QT_ASSUME_STDERR_HAS_CONSOLE=1` to override the detection, as documented in Qt's [`qlogging.cpp`](https://github.com/qt/qtbase/blob/5d8cae8a76ee5293ea885bd8fd8b2604819edfe3/src/corelib/global/qlogging.cpp#L302-L303):
```c++
if (qEnvironmentVariableIntValue("QT_ASSUME_STDERR_HAS_CONSOLE"))
return true;
```

ACKs for top commit:
davidgumberg:
utACK https://github.com/bitcoin/bitcoin/pull/36024/commits/70701de7c55512b4c8dbc3eaca91659980bf5300
maflcko:
lgtm ACK 70701de7c55512b4c8dbc3eaca91659980bf5300

Tree-SHA512: ed6d25e47dcb5f9953f336ddc52d841c6b8f11fccce417d401bca227763c99f81153751318c675673de8333ba7f218b5424b2c07eea422e62de42e167c574755

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactionsby Ava Chow · ed7dd7cf · Sep 25, 2026 · 3 filesMessage 91 · StrongLow 32Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#34371: wallet: allow importprunedfunds for spending transactions

c2da52d3660f178a9c11210216d295515988e89d wallet: allow importprunedfunds for spending transactions (8144225309)

Pull request description:

`importprunedfunds` only allowed importing transactions that credit the wallet
(checked via `IsMine`), rejecting transactions that spend from it. This could
leave a pruned wallet showing an incorrect balance: if a spending transaction
was removed with `removeprunedfunds`, it couldn't be re-imported and would fail
with "No addresses in wallet correspond to included transaction".

This routes the import through `AddToWalletIfInvolvingMe()`, which already
checks both `IsMine()` and `IsFromMe()`, so spending transactions are accepted
and the involvement check is no longer duplicated in `importprunedfunds`. A
functional test imports a transaction that spends from the wallet but has no
outputs to it (entire UTXO sent externally).

Fixes #21647

ACKs for top commit:
achow101:
ACK c2da52d3660f178a9c11210216d295515988e89d
Bicaru20:
re-ACK c2da52d366

Tree-SHA512: 0ece38c75d3608948f1c29c5fca29b6420197b0a153e361decf232fd27edd5dd1f2e5d6f9625eee6f7691abd9992f95ef89c904d486ee927d03c88475e479b9c

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 32/100

This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing transactions can be re-imported, so a pruned wallet's balance and transaction history stay accurate.

AI review queuedMerge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup optionby Ava Chow · f80aaf4b · Sep 25, 2026 · 30 filesMessage 91 · StrongLow 28Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#29278: Wallet: Add `maxfeerate` wallet startup option

f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9 [doc]: add release notes (ismaelsadeeq)
40ab7aa90de5a6382fe6f8946cde735e05308a20 [wallet]: warn when `-maxtxfee` conflicts with `-minrelaytxfee` (ismaelsadeeq)
df1feeb487dc54dc44ac8eff96650319bb3a2584 [wallet]: enforce `-maxfeerate` on wallet transactions (ismaelsadeeq)
d2c832e9e79d0f8691e64f25bcfe198ae34805d5 [util]: add a new transaction error type (ismaelsadeeq)
633c08d3f7af95953a818c645a4ad4c90f0bbdb0 [node]: update `BroadcastTransaction` to check fee rate limit (ismaelsadeeq)
7bfce65801bf5a7ae45f5f75a627e6cd03d9c8c0 [wallet]: add `maxfeerate` wallet startup option (ismaelsadeeq)
607568f2b00260ac54fd4c2c904002be17edebfd [wallet]: update `max_fee` to `max_tx_fee` (ismaelsadeeq)
6b913b6224bdafac6b83328441a347a00d7d4d06 doc: add missing verb to make sentence readable (ismaelsadeeq)
a9c39696f4be2ffe02cd78d152f4e5960692c833 scripted-diff: rename `m_default_max_tx_fee` to `m_max_tx_fee` (ismaelsadeeq)

Pull request description:

This PR fixes #29220

- The PR adds a wallet `-maxfeerate` startup option, as the upper limit of wallet transactions fee rate.

- This fixes the ambiguity of using `maxtxfee` value to check the upper limit of transactions fee rate.

- Wallet will not create a transaction with fee rate above `maxfeerate` value.

- This PR adds a functional test that ensure the behavior is enforced.

ACKs for top commit:
achow101:
ACK f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9
polespinasa:
ACK f69e56bc1c43ca2bebd4d733bce1afc8de8f58b9

Tree-SHA512: 595f451a2fd49ca887705e16ca82373c840c610d079de893bb67fba06e8b5c78646fb723255f226fdae7a6ad57a6f2b42e5d54b07d320c5c2b3a17c943add4ab

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wallet only had -maxtxfee, which limits the total absolute fee. The change also makes the error messages clearer so users can tell whether a transaction was rejected because of the total fee or the fee rate. It is a defensive feature, not a fix for an active vulnerability, and it helps prevent users from accidentally paying extremely high per-byte fees.

Security candidateMerge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding outputby Ava Chow · e19f83e9 · Sep 25, 2026 · 2 filesMessage 86 · StrongModerate 64Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35984: sign: skip signing SIGHASH_SINGLE inputs with no corresponding output

8df006f233839736b6d7b856bcf8673526c7acef wallet: skip signing SIGHASH_SINGLE inputs with no corresponding output (furszy)

Pull request description:

`SIGHASH_SINGLE` only commits to the output at the input's index. If the output at such
position doesn't exist, it commits to no output at all (legacy uses a fixed sighash of 1, segwit
v0 zeroes `hashOutputs`), which means the signature stays valid even when outputs are
swapped, which is a footgun that lets funds be redirected without the owner's consent.

`SignTransaction()` already skipped these inputs, but `SignPSBTInput()` did not, so
`walletprocesspsbt` signed them. This moves the check into the `CreateSig` so both
paths, and any future one, skip producing the detached signature.

Note: if there is a valid use for the segwit v0 case, I would rather re-allow it through
an explicit opt-in arg than by default, so it is always a deliberate choice.

Fixes #35977

ACKs for top commit:
thomasbuilds:
ACK 8df006f
achow101:
ACK 8df006f233839736b6d7b856bcf8673526c7acef

Tree-SHA512: ac1c9659910eae889475c65b8dde68e711c4d85d0d520af06411728591e573bf027b41a9ac6dd0f6e93de425841ac6c7d9e6c9f07936b9d8ae390941fbe6f1f1

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Moderate 64/100

This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if someone later changed where the money goes, creating a risk of funds being redirected without the original owner's consent. The fix makes the signer refuse to create such signatures in the first place, closing the gap for both normal transaction signing and PSBT signing.

Lower-priorityMerge bitcoin/bitcoin#36135: fuzz: test HTTPRequest state machine in http_requestby Ava Chow · ab803356 · Sep 25, 2026 · 1 fileMessage 96 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36135: fuzz: test HTTPRequest state machine in http_request

fca8fef8f903d841df693d18e4b9078f0867e07f fuzz: assert HTTP framing is independent of stream segmentation (frankomosh)
c368de3eec9c381ce69936a83f8024e2c7f8c0f1 fuzz: exercise the HTTPRequest state machine (frankomosh)
d23b53e0cfbc8fdb2e5b820e2db875cf6cde7d55 fuzz: allow http_request inputs to reach MAX_HEADERS_SIZE (frankomosh)
56af5e072a0d1056bcf6a650c6057b44ab7f9756 fuzz: extract http_request parse and framing check into helpers (frankomosh)

Pull request description:

Follow-up to #35735, adding a test to the state machine added there. As it is, the target parses the whole input in one pass, so the paths that resume a partly-read request are unreachable from it.

This target now parses each input twice, once whole and once in random slices with a parse attempt after each, and requires both runs to produce the same request. HTTP framing is defined by the byte stream, so how it was split must not change the result.

Also raises the input cap from 4096, which sat below MAX_HEADERS_SIZE and kept the header size limit out of reach.

ACKs for top commit:
jeanpablojp:
tACK fca8fef8f903d841df693d18e4b9078f0867e07f
hodlinator:
ACK fca8fef8f903d841df693d18e4b9078f0867e07f
pinheadmz:
ACK fca8fef8f903d841df693d18e4b9078f0867e07f

Tree-SHA512: 705fd05894c43de067365543f6e67387cf19e22f52191b4ede75ab9d8043c545ecdda21fc05097ac228378d27afacb9afad65e89e433cf8a7355d91b82a080c8

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35696: i2p: update leaseset encryption typesby Ava Chow · 65e075f8 · Sep 25, 2026 · 1 fileMessage 86 · StrongLow 35Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35696: i2p: update leaseset encryption types

412540e18d877c4a34cf9c8fb43dfd34a603d5f5 i2p: update leaseset encryption types (jpk68)

Pull request description:

Updates the I2P SAM leaseset parameters to `6,4` (MLKEM-768/ECIES-X25519), as is [now recommended](https://i2p.net/en/docs/api/samv3/#signature-and-encryption-types) by the I2P project. ElGamal leasesets are now considered "legacy" and likely should not be used anymore.

ACKs for top commit:
kevkevinpal:
ACK [412540e](https://github.com/bitcoin/bitcoin/pull/35696/commits/412540e18d877c4a34cf9c8fb43dfd34a603d5f5)
davidgumberg:
ACK 412540e
achow101:
ACK 412540e18d877c4a34cf9c8fb43dfd34a603d5f5
jonatack:
ACK 412540e18d877c4a34cf9c8fb43dfd34a603d5f5
janb84:
ACK 412540e18d877c4a34cf9c8fb43dfd34a603d5f5

Tree-SHA512: 639f6c58700f0a6ec471652d31b62d36ee16226afc13267a2064c199fd7e6102d7ac1b146fecaaee611235f8463fb1572318d21aa774c0a7e06ea4be06062a8c

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymerge-commit duplicate discount
AI analysis · Low 35/100

This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal encryption, which the I2P project now labels 'legacy' and no longer recommends. This is a hardening improvement rather than a fix for a known active attack, but it reduces future cryptographic risk for users who route Bitcoin traffic over I2P.

Security candidateMerge bitcoin/bitcoin#35948: init: correct first-run disk space estimateby Ava Chow · d26f19c7 · Sep 25, 2026 · 2 filesMessage 81 · StrongInformational 15Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35948: init: correct first-run disk space estimate

42215b85811a4950265fa2d02b22e83046ed95d5 init: correct first-run disk space estimate (Lőrinc)

Pull request description:

**Problem:** The assumed blockchain size is maintained in GiB, but the first-run disk-space warning labels it as GB.
For pruned nodes, the warning also displays the full-chain estimate even though the check uses the lower of the prune target and that estimate.
The chainparams API comments likewise describe both assumed sizes as GB.

**Fix:** Label the warning as GiB, display the same rounded-up GiB estimate that the disk-space check uses, and document both assumed sizes as GiB.

This PR revives the first-run warning fixes from #29678.

ACKs for top commit:
jeanpablojp:
tACK 42215b85811a4950265fa2d02b22e83046ed95d5
achow101:
ACK 42215b85811a4950265fa2d02b22e83046ed95d5
murchandamus:
ACK 42215b85811a4950265fa2d02b22e83046ed95d5

Tree-SHA512: fa8a0e1eeefd674a4344772fa5e8f63fc3af9c106057c34fef47817d41cf162ad21f0e06412ad5bebc1504c57bb720e1c0ca5392e6f3d4052d3f8c7c360bac69

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-chain size instead of the smaller pruned size. The patch corrects the label to GiB and shows the same rounded-up value that the actual disk-space check uses. There is no security vulnerability here.

Lower-priorityMerge bitcoin/bitcoin#36335: Remove my key from SECURITY.mdby merge-script · 90374132 · Sep 25, 2026 · 1 fileMessage 86 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36335: Remove my key from SECURITY.md

5820537e1b4b8379fa64aaced33e9266e78eebd4 Remove my key from SECURITY.md (dergoegge)

Pull request description:

As mentioned in the IRC meeting yesterday: https://bitcoin-irc.chaincode.com/bitcoin-core-dev/2026-09-24#1790265718-1790265731;

ACKs for top commit:
Sjors:
ACK 5820537e1b4b8379fa64aaced33e9266e78eebd4
stickies-v:
ACK 5820537e1b4b8379fa64aaced33e9266e78eebd4 :(

Tree-SHA512: 414596d01daec6c75732b956d862a53afbcf8df5f1aecab11b2af80a6548aa0841fe6510446f37a799385013d4e7fc73a6a896b8ecae444de61cdb60e4515562

86/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
documentation-only discountmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36322: init: fee estimates can lag behind the chain after restartby merge-script · f6b19b19 · Sep 25, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36322: init: fee estimates can lag behind the chain after restart

8c27c38526419de2eaca1d4857df2172ad1da1ab init: drain callbacks before saving fee estimates (Lőrinc)
08729e6ef9c9c5ec75834633a39f51f768d789c7 test: characterize fee callback loss at shutdown (Lőrinc)

Pull request description:

**Problem:** The mempool estimator added in #34075 persists mined-block stats for restart.
Shutdown saves and unregisters the fee estimator before draining queued validation callbacks.
A queued block update can leave the saved stats behind the active chain tip, so the mempool estimator ignores its file on restart.

**Fix:** Save and unregister the fee estimator after the existing callback drain, which follows the first chainstate flush.

ACKs for top commit:
davidgumberg:
crACK https://github.com/bitcoin/bitcoin/commit/8c27c38526419de2eaca1d4857df2172ad1da1ab
maflcko:
review ACK 8c27c38526419de2eaca1d4857df2172ad1da1ab 🚸
w0xlt:
ACK 8c27c38526419de2eaca1d4857df2172ad1da1ab
ismaelsadeeq:
ACK 8c27c38526419de2eaca1d4857df2172ad1da1ab
sedited:
ACK 8c27c38526419de2eaca1d4857df2172ad1da1ab

Tree-SHA512: 38f06f810f97f2fbc971234b1c7488b78a73fd3286d6c926d2d46c05dbeece392dc554c95c00c02841585e744e0718d567f352363dff04b9c57eccdd029c2a8e

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36324: test: Fixup MAX_BODY_SIZE http throttling testby merge-script · da03790d · Sep 25, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36324: test: Fixup MAX_BODY_SIZE http throttling test

fa2c62036b1d1a1f5858e7ea96cbc719503a942d test: Fixup MAX_BODY_SIZE http throttling test (MarcoFalke)

Pull request description:

The `check_slow_read_throttle` test asserts that throttling happens during a hard-coded time limit, via a hard-coded `tries` limit.

This is mostly fine, but can intermittently fail on slow CPUs or when using unoptimized sanitizers.

Fix it by waiting for a time scaled by `--timeout-factor`, without a hard-coded `tries` limit. Also, retain the hard-coded 5s sleep to "verify" throttling happened.

ACKs for top commit:
davidgumberg:
utcrACK https://github.com/bitcoin/bitcoin/commit/fa2c62036b1d1a1f5858e7ea96cbc719503a942d
pinheadmz:
ACK fa2c62036b1d1a1f5858e7ea96cbc719503a942d
winterrdog:
tACK fa2c62036b1d1a1f5858e7ea96cbc719503a942d
willcl-ark:
ACK fa2c62036b1d1a1f5858e7ea96cbc719503a942d

Tree-SHA512: 5315eef2df242947831a9973accba77b5c9f7ec6f69aece1726ffa5ed63a5c259cb2d121f73b80b72515afb59d6bb7ea1651c25f78a6672ccad6d461b67ba1d9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationmerge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36312: net: don't discourage private broadcast peersby merge-script · 37969fc1 · Sep 25, 2026 · 4 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36312: net: don't discourage private broadcast peers

eab6630addc385d013db5fe6779679228e445d09 net: don't discourage private broadcast peers (Andrew Toth)

Pull request description:

Discouraging a private broadcast connection may be observable.
Prevent this by keeping private broadcast connections outside normal discouragement handling.
Misbehaving private broadcast peers are still disconnected.

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/36312/commits/eab6630addc385d013db5fe6779679228e445d09 with same caveat
ViniciusCestarii:
ACK eab6630addc385d013db5fe6779679228e445d09 confirmed the added test captures the regression
vasild:
ACK eab6630addc385d013db5fe6779679228e445d09
mzumsande:
Code Review ACK eab6630addc385d013db5fe6779679228e445d09
danielabrozzoni:
tACK eab6630addc385d013db5fe6779679228e445d09

Tree-SHA512: 17539236a6c6f57d4ed01e0e1ee1b9ff35c69c0467fc723400c08a5a26fa6dd9b1d2616beef34ae623415c78c99418b54a9c913db84c585f25442d2bf28e98e9

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspendsby Ava Chow · e8e7e91a · Sep 24, 2026 · 4 filesMessage 91 · StrongLow 44Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36284: wallet: don't double discard output groups with avoidpartialspends

719324977a41ab5132699d9c81032f8b2687f599 test: Check that ineligible output groups are discarded only once (Fabian Jahr)
20307f0ac0e17c6e478e2e11318dc7a9b18fc5d1 wallet: don't double count discarded output groups with avoidpartialspends (Fabian Jahr)

Pull request description:

With `-avoidpartialspends` or `avoid_reuse`, `GroupOutputs` puts every positive-value output into both the mixed and the positive-only map and runs `push_output_groups` on each, so a group rejected by the eligibility filters lands in `discarded_groups` twice. `AutomaticCoinSelection` then subtracts it twice and could fail with an insufficient funds error even when there would be enough confirmed coins to cover the payment.

Not a problem in a default wallet but it can happen with `sendtoaddress` from an `avoid_reuse` wallet, or with `-avoidpartialspends=1`.

The simplest possible fix is to record discards only from the mixed map pass, which contains every output anyway. Also adds a test that reproduces the issue.

ACKs for top commit:
achow101:
ACK 719324977a41ab5132699d9c81032f8b2687f599
pablomartin4btc:
ACK 719324977a41ab5132699d9c81032f8b2687f599
vicjuma:
ACK 719324977a41ab5132699d9c81032f8b2687f599
polespinasa:
code reviewed ACK 719324977a41ab5132699d9c81032f8b2687f599

Tree-SHA512: 3028f8feeacecc601aacfce757fc885b7bd25cf6ea2ad9d9b65c56b5da71096aa48d0d70ce04d80fc2b147d67109c47d190e5dc925d06c67dfcf33cf8cc715d8

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That double-counting could make the wallet wrongly believe there are not enough spendable coins and fail to create a transaction, even though the user actually has enough confirmed funds. The fix makes sure each rejected group is recorded only once, and adds tests to prove it.

Security candidateMerge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.mdby merge-script · bfdcd979 · Sep 24, 2026 · 1 fileMessage 81 · StrongInformational 18Details
Commit message · merge-script

Merge bitcoin/bitcoin#35890: doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md

be30864ed1a63cad0e109ebc98fe17bd852bc8d0 doc: use overwrite (>) instead of append (>>) for one-shot PSBT files in offline-signing-tutorial.md (GuTS805)

Pull request description:

`funded_psbt.txt` and `final_psbt.txt` should only ever have one line in them, since later steps just do `$(cat ...)` to read them back. but the tutorial uses `>>` (append) instead of `>` (overwrite), so if you run the `send` or `walletprocesspsbt` step twice without deleting the file, it adds a second line instead of replacing the first one. then `$(cat ...)` picks up both lines as separate args and the next command fails with too many arguments.

Fixes #35862.

ACKs for top commit:
Sjors:
ACK be30864ed1a63cad0e109ebc98fe17bd852bc8d0
sedited:
ACK be30864ed1a63cad0e109ebc98fe17bd852bc8d0

Tree-SHA512: af388ffd3f0beb6e9d0e54e5e745d36380f11cdbea64c3563015aded882872401a4a3032c46493381a8b5eed510530a2c3f5a81701d7d3039c9c1c9741a8bd7b

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathdocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 18/100

This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two lines instead of one, and the next command would read both lines and fail with a 'too many arguments' error. There is no software vulnerability or security risk in the Bitcoin Core code itself.

Lower-priorityMerge bitcoin/bitcoin#36316: ci: use POSIX threads for Nix Windows buildsby merge-script · de9f42c4 · Sep 24, 2026 · 3 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36316: ci: use POSIX threads for Nix Windows builds

9fd18aedb088b5ca6a7c424aab2a4a1ec3ef4eeb ci: print Windows cross compiler thread model (will)
1d59d5ad2550b2ff6aaea2a630d1c6afa877ea2b ci: use POSIX threads in Nix Windows cross shell (will)
96d487c11e8ff55f5df3975272916a6d13c70162 ci: raise BuildKit step log limit (will)

Pull request description:

Guix release binaries use GCC’s POSIX thread model, while the pinned Nixpkgs toolchain defaults to mcf. This makes POSIX the default for Nix Windows cross builds. Nightly builds can select `mcf` or `win32` with the `threadModel` argument.

The Nixpkgs `threads` setting selects the model before GCC is built. Only the mcf model pulls in `mcfgthreads`. For POSIX, GCC’s target libraries need winpthreads headers and libraries during the compiler build. The `EXTRA_*_FOR_TARGET` flags provide those paths without exposing target headers to GCC’s native build tools, which caused the earlier build failure.

The compiler wrapper includes winpthreads through `extraPackages`, so the shell no longer needs to export pthread include and library flags manually. CI also prints GCC’s configured thread model to make mismatches visible.

Fixes #36314

ACKs for top commit:
hebasto:
ACK 9fd18aedb088b5ca6a7c424aab2a4a1ec3ef4eeb.

Tree-SHA512: b8ce5b19c82ecc347df161e4698d7f023c82b83f1907fea35b66ca37f54a00f1011dbd7642ba4d7ce2ca9ffd16e48e9327b69caa4108a44ca451194ac070e389

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#35675: mining: add block template managerby Ryan Ofsky · 5c726f20 · Sep 24, 2026 · 26 filesMessage 91 · StrongInformational 19Details
Commit message · Ryan Ofsky

Merge bitcoin/bitcoin#35675: mining: add block template manager

3d7d190b6995b3c0adb6528c2d9eac81a8f839d9 ci: enforce iwyu for block template manager (ismaelsadeeq)
ffe3a631f38b1224db8b0ea246a3c976f358c59e node: remove NodeContext::mining and EnsureMining (ismaelsadeeq)
6c71166bcfa4339d5019f2b27d477eb45ce7fe86 test: create templates via BlockTemplateManager (ismaelsadeeq)
ec4f24ef181a7987bcea72a21e507f59dc1b8126 rpc: wait for tips via BlockTemplateManager (ismaelsadeeq)
8372721f20e2ea2c15bae38a046476736169d801 rpc: build generation templates via BlockTemplateManager (ismaelsadeeq)
38556f817e060187b48cd31490f578cdf63134ee rpc: only copy the header in getblocktemplate (ismaelsadeeq)
951fac807d37302e7de5e289c0ab05f8dfcb1e1c rpc: do not copy template data in getblocktemplate (ismaelsadeeq)
0998c0bbdfcc3c3f7c105a1fb7223bace529556a rpc: build getblocktemplate via BlockTemplateManager (ismaelsadeeq)
011cbfbcd2e3a3282ae7e5afdfd923bc444d1845 rpc: route getblocktemplate internals through node (ismaelsadeeq)
400ac328c91b653e793bd140b89e8fabfb42e3ac interfaces: create block template via BlockTemplateManager (ismaelsadeeq)
037d3519f2ff9937aa82060a42939aafab4179f1 node: move tip and wait helpers into BlockTemplateManager (ismaelsadeeq)
07964c525d4769d00004b9942225a2cb1306e09d miner: move SubmitBlock into BlockTemplateManager (ismaelsadeeq)
bcdadf2b7111a061d2bbeba350233db7b258a787 node: move mining_args to BlockTemplateManager (ismaelsadeeq)
482a5d27124c4241c27ed323659914cd38409650 node: introduce BlockTemplateManager (ismaelsadeeq)

Pull request description:

This PR introduces `node::BlockTemplateManager` and moves block template
creation, submission, and mining wait helpers behind it.

#### Motivation

Instead of keeping template-related state and helper functions spread across
`NodeContext`, `miner.cpp`, the mining interface, RPC, and tests, the manager
now owns the node's init-time mining options and exposes methods needed by callers.

This also prevents some redundant copies previously done when using the mining
interface to create a block template and then retrieve the template data.

This keeps the IPC `Mining` interface focused on IPC-facing mining objects, while RPC
and tests use the block template manager directly.

#### Changes

- `NodeContext` no longer stores `BlockCreateOptions` directly.
- `BlockTemplateManager` stores the parsed init-time mining options and applies
them to unset per-call options before creating templates.
- Block submission through the mining interface is routed through
`BlockTemplateManager::SubmitBlock()`, preserving the existing
`BlockChecked` state-capture behavior.
- Tip lookup, tip waiting, cooldown, and `waitNext()` template creation helpers
are moved from miner helper functions into `BlockTemplateManager`.
- In-process RPC and tests create raw `CBlockTemplate` objects directly through
`BlockTemplateManager`, avoiding cached `BlockTemplateImpl` objects that hold
`NodeContext` references during shutdown.

#### Note: This change is intended to be a pure refactor that preserves behavior.

ACKs for top commit:
Sjors:
re-ACK 3d7d190b6995b3c0adb6528c2d9eac81a8f839d9
marcofleon:
light code review ACK 3d7d190b6995b3c0adb6528c2d9eac81a8f839d9
pablomartin4btc:
re-ACK 3d7d190b6995b3c0adb6528c2d9eac81a8f839d9

Tree-SHA512: 885af752ecd105f9813e75de87b9e022b151e5959aae3ef00de838ca4b07ce19ee24a80629dd80bb5261d4b090b4f7832f09c4d8147e4265c54c7f8926694590

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 19/100

This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across several modules. The pull request description explicitly says it is intended to be a pure refactor that preserves behavior. No new user-facing feature is added and no vulnerability is evident in the diff.

Lower-priorityMerge bitcoin/bitcoin#35923: mempool: count unbroadcast txids in memory usageby Ava Chow · 26241482 · Sep 23, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35923: mempool: count unbroadcast txids in memory usage

db21e03c9d50386072a1123568f917ba65dcf348 mempool: include unbroadcast txid memory (Lőrinc)
8d5c4a9290b0bc0c323cf77619f1620aa3d4caf0 test: characterize unbroadcast memory accounting (Lőrinc)

Pull request description:

**Problem:** The mempool memory estimate omits the txid set used to retry the initial broadcast of locally submitted transactions, so `getmempoolinfo` and `-maxmempool` undercount retained memory.

**Fix:** Count this set when calculating mempool memory usage.

ACKs for top commit:
jeanpablojp:
ACK db21e03c9d50386072a1123568f917ba65dcf348
bartoli:
ACK db21e03c9d50386072a1123568f917ba65dcf348
achow101:
ACK db21e03c9d50386072a1123568f917ba65dcf348
musaHaruna:
Tested ACK [db21e03](https://github.com/bitcoin/bitcoin/pull/35923/changes/db21e03c9d50386072a1123568f917ba65dcf348)
instagibbs:
ACK db21e03c9d50386072a1123568f917ba65dcf348
ismaelsadeeq:
ACK db21e03c9d50386072a1123568f917ba65dcf348

Tree-SHA512: 1d00381efb65839057a731101753ffd492596c76c23d4a2c229c720dec13b0558bdc4e6e5be0de52b65004872a1a8f87342b085eb1827bb15a7732646101d486

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#35177: test: use MiniWallet for getblockstats test data generationby Ava Chow · a632d4f6 · Sep 23, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35177: test: use MiniWallet for getblockstats test data generation

b7cbd804284bb70f40c5beebf8d1d3ff614ae406 test: use MiniWallet for getblockstats test data generation (AgustinRivera)

Pull request description:

Fixes #31838.
Follow-up to #33184.

This updates `rpc_getblockstats.py --gen-test-data` to generate its fixture data using `MiniWallet` instead of wallet RPCs.

The normal test path still loads predefined block/stat data from `rpc_getblockstats.json`, so the test continues to compare `getblockstats` results against fixed expected data rather than against freshly computed RPC output.

This keeps the generator independent of wallet behavior while preserving the existing regression-test structure.

Tested on a wallet-disabled Linux build:
- `python3 /tmp/bitcoin-build/test/functional/rpc_getblockstats.py`
- `python3 /tmp/bitcoin-build/test/functional/rpc_getblockstats.py --gen-test-data --test-data /tmp/rpc_getblockstats.generated.json`
- `python3 /tmp/bitcoin-build/test/functional/rpc_getblockstats.py --test-data /tmp/rpc_getblockstats.generated.json`

ACKs for top commit:
achow101:
ACK b7cbd804284bb70f40c5beebf8d1d3ff614ae406
theStack:
ACK b7cbd804284bb70f40c5beebf8d1d3ff614ae406
sedited:
ACK b7cbd804284bb70f40c5beebf8d1d3ff614ae406

Tree-SHA512: f763acd0467143c4f151fa2acd5b154c073fea8551eafcf102ef2d1cc0f4b2ce13b7828bd2736d0cdda782a78dfa6aea60b61bee27e9ca8a2b72d76dffc09340

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)by Ava Chow · be5d0b55 · Sep 23, 2026 · 10 filesMessage 91 · StrongInformational 12Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#35301: Silent Payments: Implement bip352 (take 2)

e3ee0ebd89e9955da94c8d806cfa1793baba9860 tests: add BIP352 test vectors as unit tests (josibake)
f133d1373af6f58488f73fe3dc795d37c4796dd9 common: add bip352.{h,cpp} secp256k1 module (josibake)
44997c391afc1f3ae75d2331606e1261fd365801 Add "sp" HRP (josibake)
356c91f6ae51bd9e48db0920110ac9303f54f714 crypto: add KeyPair::GetSecpKeypair (josibake)

Pull request description:

This PR is part of integrating silent payments into Bitcoin Core. It is the second iteration of https://github.com/bitcoin/bitcoin/pull/28122, now based on https://github.com/bitcoin-core/secp256k1/pull/1765.

This project is tracked in https://github.com/bitcoin/bitcoin/issues/28536.

BIP352
This PR focuses strictly on the BIP logic and attempts to separate it from the wallet and transaction implementation details. This is accomplished by working directly with public and private keys, instead of needing a wallet backend and transactions for testing. Labels for the receiver are optional and thus deferred for a later PR.

Test vectors from the BIP are included as unit tests.

ACKs for top commit:
rustaceanrob:
reACK e3ee0ebd89e9955da94c8d806cfa1793baba9860
theStack:
re-ACK e3ee0ebd89e9955da94c8d806cfa1793baba9860
achow101:
ACK e3ee0ebd89e9955da94c8d806cfa1793baba9860

Tree-SHA512: 9b5706e35a49606ac53303c4be0c08f0a08ee273bd69855ff2c869ebcf63dc1e798f8295b8800a41a7094658ab17134366b1ebf2b79dbda5d4af377b05bb2854

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialfuzzing or regression evidencemerge-commit duplicate discount
AI analysis · Informational 12/100

This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The change introduces new code for encoding/decoding silent payment addresses, deriving output public keys, and scanning transactions for outputs belonging to the recipient. It is a feature addition, not a fix for a known security bug. There is no evidence in the commit or supplied references that this introduces a vulnerability or that any security incident occurred.