Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.
This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…
Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…
Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…
Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…
Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…
No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…
This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …
Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…
This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…
This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …
This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…
This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…
This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …
Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…
Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…
This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…
No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…
This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…
This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-priorityMerge bitcoin/bitcoin#36349: rpc: avoid copying unbroadcast transaction IDs just to count themby merge-script · b42ea675 · Oct 5, 2026 · 2 filesMessage 93 · StrongTriage 0Details
Commit message · merge-script
Merge bitcoin/bitcoin#36349: rpc: avoid copying unbroadcast transaction IDs just to count them
052cf121ab0a5373d1753564d90075f1997f4610 rpc: avoid copying unbroadcast txids to count them (Musa Haruna)
Pull request description:
Follow-up to [#35923](https://github.com/bitcoin/bitcoin/pull/35923/#issuecomment-5799823742).
`getmempoolinfo` currently calls `GetUnbroadcastTxs().size()` to report `unbroadcastcount`. The getter returns the set by value, so every call copies its entries under the mempool lock and immediately discards the copy after reading its size.
**Fix:** Add `GetUnbroadcastTxCount()` and use it in the RPC to read the size under the same lock without allocating a temporary set. This is a separate accessor because broadcast retry and persistence still need the transaction IDs returned by the existing `GetUnbroadcastTxs()`.
I also searched for similar cases nearby: the ancestor/descendant count helpers and the cluster-count path build vectors just to read their sizes, while the mining RPC uses `GetDust(...).empty()` to check whether any dust outputs exist. These could potentially use count-only or boolean helpers, but would require separate changes to the graph and policy code, so I left them out of this PR.
Added a temporary [bench_bitcoin](https://github.com/bitcoin/bitcoin/compare/master...musaHaruna:bitcoin:bench-unbroadcast-count) benchmark on my branch, comparing both getters.
Results below are medians from five runs on an Apple M5, using Apple clang 17/libc++ with `-O2`:
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36426: test: check IBD insufficient work disconnect of outbound peersby merge-script · 714261b5 · Oct 5, 2026 · 1 fileMessage 91 · StrongTriage 0Details
Commit message · merge-script
Merge bitcoin/bitcoin#36426: test: check IBD insufficient work disconnect of outbound peers
c502b65c007bce1a5d9c6399e836b5372eef3399 test: check IBD insufficient work disconnect of outbound peers (Bruno Garcia)
Pull request description:
While in IBD, outbound peers (full-relay and block-relay-only) whose headers chain has less work than `nMinimumChainWork` are disconnected. This behavior was not covered by any test, since the functional tests only connect nodes to each other via manual connections, and the default minimum chain work is zero.
This adds a test case that restarts node2 with a higher `-minimumchainwork` and check that both outbound-full-relay and block-relay-only peers serving headers below it are disconnected, while inbound and manual peers are not.
ACKs for top commit: kevkevinpal: ACK [c502b65](https://github.com/bitcoin/bitcoin/pull/36426/commits/c502b65c007bce1a5d9c6399e836b5372eef3399) maflcko: lgtm ACK c502b65c007bce1a5d9c6399e836b5372eef3399 sedited: ACK c502b65c007bce1a5d9c6399e836b5372eef3399
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36320: test: refactor: make chain_dir consistent with CreateBaseChainParamsby merge-script · 36711901 · Oct 5, 2026 · 5 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script
Merge bitcoin/bitcoin#36320: test: refactor: make chain_dir consistent with CreateBaseChainParams
a4bc96966faa9efcd7b387907d51b4ac53f7039d test: refactor: make chain_dir consistent with CreateBaseChainParams (ekzyis)
Pull request description:
The chain_dir() method of test framework nodes returned the chain *name* for every non-signet chain, but mainnet stores its data in the top-level data directory. Mainnet tests worked around this by setting self.chain to the empty string, which doubles as the datadir name.
Instead of this workaround, we now set self.chain to "main" and map it to an empty datadir and config section key, so tests can name the chain the way the rest of the codebase does.
This was mentioned in https://github.com/bitcoin/bitcoin/pull/34566#discussion_r3667623302.
ACKs for top commit: ismaelsadeeq: reACK a4bc96966faa9efcd7b387907d51b4ac53f7039d maflcko: lgtm ACK a4bc96966faa9efcd7b387907d51b4ac53f7039d sedited: ACK a4bc96966faa9efcd7b387907d51b4ac53f7039d
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#32895: wallet: Prepare for future upgrades by recording versions of last client to open and decryptby merge-script · 6e419391 · Oct 5, 2026 · 6 filesMessage 81 · StrongInformational 19Details
Commit message · merge-script
Merge bitcoin/bitcoin#32895: wallet: Prepare for future upgrades by recording versions of last client to open and decrypt
7b32155458cc87e50da1fa9f245cc84bc203f25a wallet: Set last opened and decrypted features during migration (Ava Chow) f998a740fc9f56c813973155cef44c757f1955dd wallet: Record the supported features of the last client to decrypt a wallet (Ava Chow) 8453ad801b63ec92af1652cdcf801165c59f2ab2 wallet: Introduce LastClientFeatures flags and LAST_OPENED_FEATURES record (Ava Chow) 0f104733cc8e4b1736efa6a3bc92a8e3dba1a1b3 walletdb: Decouple last client record from CLIENT_VERSION (Ava Chow)
Pull request description:
When a wallet is automatically upgraded, we always do so in a way that allows the user to load their wallet in an older version. When the user loads their wallet into an upgraded version again, the wallet may not perform the automatic upgrade and end up with upgraded and non-upgraded material in the wallet.
If we write some information about the last client to open the wallet, we would be able to detect these upgrade-downgrade-upgrade situations and perform another upgrade if so. However, in order for this to work, we need to have implemented writing such information into versions prior to the ones which introduce new automatic upgrades.
We are already writing the CLIENT_VERSION into all wallets in a "version" record, although this record is not updated in the same way across all previous versions. Since v24.0, we are always updating the record when the client version differs, but prior to that, the record would only be updated when the client version is newer. Even so, we can use this record to store the last client version.
The first commit decouples the written client version from the node version. This aids in development of new features. The version is entirely decoupled from previous versions by requiring all versions to have bit 19 set, and the initial version being `0 | (1 << 19)`. The versions just need to be at least 299900, and forcing bit 19 to be set was an easy way to achieve this.
However, using version numbers is not as flexible as feature flags, so the second commit introduces the concept of Wallet Client Features. These flags are distinct from the existing Wallet Feature Flags since they are conceptually different. These are written in a separate record, and the wallet client version is incremented to `(1 << 19) + 1`.
Lastly, since some upgrades may need private keys and can only occur after the wallet is decrypted, the third commit also adds a last decrypted features flags record to record the features of the last client to decrypt the wallet.
The result is that we will now be able to detect a downgrade down to v24.0 and be able to implement in parallel multiple features that require automatic upgrades.
ACKs for top commit: polespinasa: ACK 7b32155458cc87e50da1fa9f245cc84bc203f25a w0xlt: reACK 7b32155458cc87e50da1fa9f245cc84bc203f25a
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
secret or key materialupdate trustsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 19/100
This change is a wallet infrastructure improvement, not a fix for an active security bug. It records which Bitcoin Core version and feature set last opened or decrypted a wallet so that future releases can detect 'upgrade-downgrade-upgrade' cycles and re-run automatic wallet upgrades safely. There is no direct exploit here, but any bug in this bookkeeping could in theory cause a wallet to skip needed upgrades or behave unexpectedly after being loaded in older software.
Security candidateMerge bitcoin/bitcoin#36080: p2p: Suspend ping timeout while downloading blocks from a peerby merge-script · c7835db1 · Oct 5, 2026 · 3 filesMessage 100 · StrongLow 34Details
Commit message · merge-script
Merge bitcoin/bitcoin#36080: p2p: Suspend ping timeout while downloading blocks from a peer
d83647e7c48a11dc54ad697342a4b7e3bce9061b p2p: Don't apply ping timeout while downloading blocks (Martin Zumsande) 2b43c62d8ef53edfadf8f097731f48a01b9570cd p2p: move ping timeout check into SendMessages (Martin Zumsande) 8b5bbfe1fca1f4100f858ebfd187dcf74d9d3c82 test: add functional test for pings during IBD (Martin Zumsande)
Pull request description:
While serving blocks, there is a system in place that prioritizes a peer's block requests before answering other p2p messages: See https://github.com/bitcoin/bitcoin/blob/11090c8bb359f894ef7d97b65aff52fe8191aec1/src/net_processing.cpp#L5436
As a result it can happen that if we do IBD with a low download bandwidth (that is distributed over 10 peers) a peer will not get around to answering our ping before the timeout of 20 minutes, in which case we would disconnect them, although they have done nothing wrong and are not even slow themselves (we are). This situation has been described in #35761.
This PR fixes the issue by not enforcing the ping timeout from a peer while downloading blocks from them. In order to do that, the ping timeout check is moved out of `MaybeSendPing()` (which was a slightly awkward place anyway, given the name of the function) and suspended until there are no longer blocks in flight with that peer (with a grace period, so that we don't disconnect immediately after the last block was received before the peer got a chance to send us the `pong`).
Note that during block download, there are still other timeouts: - A dynamic timeout (`BLOCK_DOWNLOAD_TIMEOUT_BASE` / `BLOCK_DOWNLOAD_TIMEOUT_PER_PEER`) which will result in a timeout of `600s × (1 + 0.5×9) = 55 minutes` per block when downloading from 10 peers in parallel - the stalling logic which hits if the peer is much slower in comparison to other peers - the socket inactivity check disconnects a peer that hasn't sent us anything at all in the last 20 minutes.
So the ping timeout didn't add much value anyway in that situation.
Fixes #35761
ACKs for top commit: maflcko: review ACK d83647e7c48a11dc54ad697342a4b7e3bce9061b 🌎 fjahr: reACK d83647e7c48a11dc54ad697342a4b7e3bce9061b danielabrozzoni: ACK d83647e7c48a11dc54ad697342a4b7e3bce9061b sedited: ACK d83647e7c48a11dc54ad697342a4b7e3bce9061b
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This change fixes a bug where Bitcoin Core could wrongly disconnect a peer during Initial Block Download (IBD). The problem happened because the node demanded a ping reply within 20 minutes even while the peer was busy sending blocks. With slow bandwidth, the peer could be too busy serving blocks to reply to the ping in time, so the node would drop a perfectly good peer. The fix pauses the ping timeout while blocks are being downloaded from a peer, and adds a one-minute grace period after the last block before the timeout applies again. It is a reliability/availability fix, not a remote exploit.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
consensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only adds new test cases to Bitcoin Core's test suite. It does not change any production consensus code. The tests are designed to catch accidental code changes ('mutants') in the script interpreter that could break consensus rules, but the commit itself is a defensive testing improvement, not a vulnerability fix.
Security candidateMerge bitcoin/bitcoin#36327: test: speed up secp256k1 fixed-base multiplication and Schnorr signingby merge-script · b6a1b0ff · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36327: test: speed up secp256k1 fixed-base multiplication and Schnorr signing
b6fc3cf0046d3106e0dfb30f320d48514eff6fb2 test: speed up secp256k1 fixed-base multiplication (brunoerg)
Pull request description:
This PR speeds up the test framework’s fixed-base multiplication and Schnorr signing by:
- Changing FastGEMul to process scalars in 4-bit windows instead of individual bits. Precompute all 16 multiples for each window position, reducing multiplication from about 128 point additions on average to 64 table lookups and about 60 nonzero point additions. This trades a larger table and additional initialization work for cheaper repeated multiplications.
On my local machine (Macbook M2 Pro) the `feature_taproot.py`'s medium time decreased from 83.39s to 35.42s.
ACKs for top commit: fametrano: tACK b6fc3cf0046d3106e0dfb30f320d48514eff6fb2 theStack: ACK b6fc3cf0046d3106e0dfb30f320d48514eff6fb2 ViniciusCestarii: tACK b6fc3cf0046d3106e0dfb30f320d48514eff6fb2
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This commit is a pure performance optimization for Bitcoin Core's internal test framework. It changes how the test code performs certain mathematical operations on the secp256k1 elliptic curve, making tests run faster. There is no change to live network code, wallet behavior, consensus rules, or cryptographic security. It does not fix a vulnerability or introduce a known security risk.
Merge bitcoin/bitcoin#36415: rpc: clarify preciousblock help text
15d092639957242d443a680d380f8df1def2bd4e rpc: clarify preciousblock help text (ViniciusCestarii)
Pull request description:
The preciousblock help says only "Treats a block as if it were received before others with the same work". This isn't wrong but could be clearer and it also leaves out cases that confuse users, including me (see discussion in #35300):
- The call has no effect when the block has less work than the current tip, and that includes any ancestor of the tip. A successful return doesn't mean the tip changed. ([code](https://github.com/bitcoin/bitcoin/blob/69142eacd1374925cc9e4ea736c21fcec16307d0/src/validation.cpp#L3504-L3507)) - It only breaks ties between equal-work chains and doesn't pin the chain. If another chain gains more work, the node switches to it as usual. ([code](https://github.com/bitcoin/bitcoin/blob/69142eacd1374925cc9e4ea736c21fcec16307d0/src/node/blockstorage.cpp#L174-L182))
This adds both points to the help text and doesn't change any behavior.
ACKs for top commit: instagibbs: ACK https://github.com/bitcoin/bitcoin/pull/36415/commits/15d092639957242d443a680d380f8df1def2bd4e maflcko: lgtm ACK 15d092639957242d443a680d380f8df1def2bd4e
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100
This change only updates the help text shown by the preciousblock RPC command to explain more clearly when it has no effect and that it does not permanently lock the chain. No code behavior was changed.
Lower-priorityMerge bitcoin/bitcoin#36404: fuzz: don't set random state for private broadcast testby Ava Chow · c8e852d3 · Oct 2, 2026 · 1 fileMessage 96 · StrongTriage 0Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#36404: fuzz: don't set random state for private broadcast test
1d19cca0761ab35eb46867df2aacdc9715fa5ae0 fuzz: don't set random state for private broadcast test (Andrew Toth)
Pull request description:
The private broadcast fuzz test does not use any randomness. This was added in #35129 based on a draft created in #29415. That draft was created when the state of #29415 was still using `SaltedTxidHasher`s, but this usage was removed before it was merged.
Setting the random state while not using it is causing issues with nightly https://github.com/maflcko/bitcoin-core-nightly/issues/25.
ACKs for top commit: kevkevinpal: ACK [1d19cca](https://github.com/bitcoin/bitcoin/pull/36404/commits/1d19cca0761ab35eb46867df2aacdc9715fa5ae0) maflcko: lgtm ACK 1d19cca0761ab35eb46867df2aacdc9715fa5ae0 achow101: ACK 1d19cca0761ab35eb46867df2aacdc9715fa5ae0 vasild: ACK 1d19cca0761ab35eb46867df2aacdc9715fa5ae0
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36299: cli: Improve empty-response and fix -rpcclienttimeout regressionby Ava Chow · dd809d2c · Oct 2, 2026 · 2 filesMessage 100 · StrongLow 38Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#36299: cli: Improve empty-response and fix -rpcclienttimeout regression
1805716354b49ecb96e49b949a61e2c72ad2c1a3 cli: Apply -rpcclienttimeout per socket wait instead of per phase (Fabian Jahr) b841ab694215699cba53c4de8a7cc08b9fce259a cli: Treat a response with Content-Length: 0 as complete (Fabian Jahr)
Pull request description:
Two follow-ups to #34342
First commit: An empty body was not treated as a complete response. We currently check if `Content-Length` is greater than zero instead of whether the header was sent, so a response with a `Content-Length` of 0 falls into the branch for responses that carry no length and confinues to read until the peer disconnects. Our server sends an empty body with several types of errors such as a wrong RPC password but it does close the connection as well, which mitigates this from causing any serious issue. However, it would still be good to handle this correctly on the client side that we don't have to rely on the server to save us from hanging.
b-l-u-e found this in post-merge review in https://github.com/bitcoin/bitcoin/pull/34342#discussion_r3358700705 but I didn't manage to look into it until now.
Second commit: `-rpcclienttimeout` no longer measures real idle time. Before the libevent removal, it used to mean give up if really nothing arrives for this long, and any newly incoming data did reset the counter. With the new code the countdown ignores progress, so a large/slow response could be cut off while data still arrives. Revert this to the old behavior.
The second commit does not have a test because I didn't manage to construct one that didn't turn out to be flaky. It may be possible but I couldn't come up with something within a scope of complexity that seems reasonable for this.
ACKs for top commit: achow101: ACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3 0tuedon: tACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3 winterrdog: tACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3 hodlinator: ACK 1805716354b49ecb96e49b949a61e2c72ad2c1a3
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This update fixes two bugs in bitcoin-cli, the command-line tool used to talk to a Bitcoin node. First, when a server replied with an empty body but said it was intentionally empty (Content-Length: 0), the client would keep waiting instead of accepting the reply. Second, the client timeout stopped measuring actual idle time, so a slow but ongoing download could be cut off. The patch makes the timeout reset whenever new data arrives and treats a declared empty body as complete. The hang-on-empty-body case is the more security-relevant one, because a malicious or misbehaving server that keeps the connection open could make bitcoin-cli hang until the user kills it.
Lower-priorityMerge bitcoin/bitcoin#34213: net: preserve anchors when network is disabledby Ava Chow · 802eb7da · Oct 2, 2026 · 3 filesMessage 100 · StrongTriage 0Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#34213: net: preserve anchors when network is disabled
ddf033054ff66129e9307c7c4661ad20e08727fe test: cover anchor handling across network toggles with mocktime (Bruno Garcia) b0bff47d443279da7b77d782b739f3a7697ee796 net: log that anchors will be tried for connections only if network is active (brunoerg) 4b6b85428586fd2ae36386096b4a9beb467cfd8f test: disabling network activity should not affect anchors (brunoerg) 04d3d474c48da3fa24e13ee3fcc623da649a62e2 net: preserve anchors on shutdown when network is inactive (Bruno Garcia) 41771236b4d9903eb9bfb92c7d5073f0e031f177 net: store anchors in SetNetworkActive (brunoerg) e5f3ea3bf6f666ae9302f4823b2c96251537faa3 net: guard m_anchors with mutex (brunoerg)
Pull request description:
### Problem
When a node is shut down while network activity is disabled (e.g. via -networkactive=0 or `setnetworkactive` false), `anchors.dat` is overwritten with an empty list. This happens because `StopNodes()` collects anchors via `GetCurrentBlockRelayOnlyConns()`, which returns nothing when there are no active connections. The node then loses its anchors and cannot reconnect to them on the next startup.
### Fix
- Guard `m_anchors` with a mutex, since it is now accessed outside the connection-opening thread. - In `SetNetworkActive(false)`, save the current block-relay-only connections into `m_anchors` before the connections are closed, so the anchor list is preserved after the network is deactivated. Stored anchors are kept if there are no such connections. - In `ThreadOpenConnections()`, only consume anchors while the network is active; otherwise they would be popped and dropped by the connection attempt. - In `StopNodes()`, if the network is inactive and `m_anchors` is non-empty, use those stored anchors as the source for `anchors.dat` instead of the (empty) live connection list.
Also, log that "X anchors will be tried for connections" only if the network is active.
ACKs for top commit: achow101: ACK ddf033054ff66129e9307c7c4661ad20e08727fe willcl-ark: ACK ddf033054ff66129e9307c7c4661ad20e08727fe naiyoma: tACK ddf033054ff66129e9307c7c4661ad20e08727fe w0xlt: ACK ddf033054ff66129e9307c7c4661ad20e08727fe
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36411: ci: drop `-Wno-error=maybe-uninitialized` from win64 cxx flagsby merge-script · 65896ac5 · Oct 2, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script
Merge bitcoin/bitcoin#36411: ci: drop `-Wno-error=maybe-uninitialized` from win64 cxx flags
963f557a721b279a643db2982893c8aa667416c6 ci: drop -Wno-error=maybe-uninitialized from win64 flags (fanquake)
Pull request description:
I cannot see any `maybe-uninitialized` warnings in CI logs, and this passes locally on aarch64.
ACKs for top commit: maflcko: lgtm ACK 963f557a721b279a643db2982893c8aa667416c6 hebasto: ACK 963f557a721b279a643db2982893c8aa667416c6 for our current CI job.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-prioritykernel: document that btck_WriteBytes may receive a null pointerby Alexander Wiederin · b497a71c · Oct 2, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · Alexander Wiederin
kernel: document that btck_WriteBytes may receive a null pointer
btck_witness_stack_get_item_at passes std::vector::data() to the writer, which can be null for an empty witness item. Document this in the contract, together with the other btck_WriteBytes parameters.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36412: ci: drop `-U_FORTIFY_SOURCE` from TSAN jobby Hennadii Stepanov · a829aeaa · Oct 2, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · Hennadii Stepanov
Merge bitcoin/bitcoin#36412: ci: drop `-U_FORTIFY_SOURCE` from TSAN job
c57ef546c3915e110c3b3cd3aee317e7cb48ee82 ci: use LLVM libc++ 23.1.2 (fanquake) f2a0e7392c6e9029f87783dd83d49c116ba4c0bd ci: drop -U_FORTIFY_SOURCE from TSAN job (fanquake)
Pull request description:
#30586 was fixed upstream by Marco in https://github.com/llvm/llvm-project/pull/206228 (shipped in `23.1.0`). Also bump libc++ to `23.1.2`.
Followup to #36052.
ACKs for top commit: maflcko: lgtm ACK c57ef546c3915e110c3b3cd3aee317e7cb48ee82 hebasto: ACK c57ef546c3915e110c3b3cd3aee317e7cb48ee82.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityci: use LLVM libc++ 23.1.2by fanquake · c57ef546 · Oct 2, 2026 · 1 fileMessage 57 · ThinTriage 0Details
Commit message · fanquake
ci: use LLVM libc++ 23.1.2
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Lower-priorityci: drop -U_FORTIFY_SOURCE from TSAN jobby fanquake · f2a0e739 · Oct 2, 2026 · 1 fileMessage 80 · StrongTriage 0Details
Commit message · fanquake
ci: drop -U_FORTIFY_SOURCE from TSAN job
The issue was fixed upstream in https://github.com/llvm/llvm-project/pull/206228.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Security candidateMerge bitcoin/bitcoin#36052: ci: Doc: Move all config comments right next to the option they explainby merge-script · 9f059527 · Oct 2, 2026 · 26 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script
Merge bitcoin/bitcoin#36052: ci: Doc: Move all config comments right next to the option they explain
fa90a8a01318493d39bca924dbd51c72f0232e4c ci: [refactor] Use eval-based string-to-argv conversion for FUZZ_TESTS_ARGS (MarcoFalke) fa18f9aeac8e22d1aeae78f9bceb4a9694ed1b2c ci: Doc: Move all config comments right next to the option they explain (MarcoFalke) fa0e84ec53fcf9cc85af29e1a36983b0575e17d7 ci: refactor: Use printf %q quoting for BITCOIN_CONFIG (MarcoFalke)
Pull request description:
This is a CI doc-style-cleanup. `BITCOIN_CONFIG` is a single manually-formatted-and-quoted large string. This is fine, but shellcheck doesn't like when trailing comments are added: `SC2155 -- Declare and assign separately`.
Fix this style by using `printf` to format the single string. The second commit then moves the comments right into (or next to) the line that it concerns.
ACKs for top commit: hebasto: re-ACK fa90a8a01318493d39bca924dbd51c72f0232e4c. willcl-ark: ACK fa90a8a01318493d39bca924dbd51c72f0232e4c
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathauthentication pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit is a documentation and code-style cleanup for Bitcoin Core's continuous integration (CI) scripts. It changes how build configuration strings are formatted in shell scripts so comments can sit next to the options they describe, and it switches one fuzz-test argument handling pattern to use an array. There is no change to the Bitcoin protocol, wallet logic, networking, or any code that runs in production. It is purely a CI maintenance refactor.
Merge bitcoin/bitcoin#36272: guix: split Linux toolchain
c9d101ca7ab550d8b72e635741d38fcd6b401917 guix: split Linux toolchain (fanquake)
Pull request description:
This is a prerequisite for static release builds (#25573). A split toolchain also allows us to make other builds changes, like #36193 (building a more stripped down libstdc++, and shipping smaller binaries).
ACKs for top commit: hebasto: ACK c9d101ca7ab550d8b72e635741d38fcd6b401917. willcl-ark: ACK c9d101ca7ab550d8b72e635741d38fcd6b401917
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#35833: log: prevent user input from injecting fake log linesby Ava Chow · d4b0e1e4 · Sep 30, 2026 · 4 filesMessage 100 · StrongModerate 60Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#35833: log: prevent user input from injecting fake log lines
d93d366e204e95e873ef0b89425f84a520f8fabd log: escape newlines in messages (Lőrinc) 960dcdb62529a6498d1397e1cf1077fe3cb19d9f test: characterize RPC and wallet input logs (Lőrinc)
Pull request description:
**Problem:** Restricted RPC users and callers of `createwallet` or `restorewallet` can inject newlines through rejected methods or wallet names, and [global log escaping preserves them](https://github.com/bitcoin/bitcoin/pull/17095), making forged lines look like node messages.
**Fix:** Escape embedded newlines in log messages.
```bash 2026-07-28T23:18:57Z [warning] RPC User __cookie__ not allowed to call method getblock 2026-07-28T23:18:55Z ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent ```
> After
```bash 2026-07-28T23:19:45Z [warning] RPC User __cookie__ not allowed to call method getblock\x0a2026-07-28T23:19:41Z ERROR: ConnectTip: ConnectBlock 0000000000000000deadbeefdeadbeefdeadbeefdeadbeefdeadbeefdeadbeef failed, bad-txns-inputs-missingorspent ``` </details>
ACKs for top commit: achow101: ACK d93d366e204e95e873ef0b89425f84a520f8fabd ryanofsky: Code review ACK d93d366e204e95e873ef0b89425f84a520f8fabd. Fix is minimal now and tests have been expanded to ensure that newlines can't sneak into log messages through `InitWarning` or `InitError` calls by testing the `load_on_startup` case w0xlt reported https://github.com/bitcoin/bitcoin/pull/35833#issuecomment-5849713749. w0xlt: ACK d93d366e204e95e873ef0b89425f84a520f8fabd
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
This update fixes a way that people with limited access to a Bitcoin node could make fake log entries appear real. Normally, the node cleans up special characters in log messages but was leaving newlines alone. A clever user could slip a newline into a wallet name or a blocked RPC command, causing the log file to show a forged line that looks like an official node error or warning. The fix now escapes newlines too, so the whole injected text stays on one line and is clearly not a real log entry. This is mainly a log-integrity and anti-confusion issue, not a direct theft or remote-control bug.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit fixes a one-word typo in a comment inside a test file. The comment incorrectly referred to 'walletcreatepsbt' when the surrounding test code actually calls 'walletcreatefundedpsbt'. No code behavior changes, and there is no security impact.
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit fixes a typo in a comment within a test file. The comment incorrectly referred to 'walletcreatepsbt' when the surrounding test code actually exercises 'walletcreatefundedpsbt'. No code behavior changes, and there is no security impact.
Merge bitcoin/bitcoin#36377: doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.md
d57346d682f17e6cf09f8acc5e7893ee16eec193 doc: add 461 (Deterministic ECDSA signatures with low-R grinding) to bips.md (Sebastian Falbesoner)
Pull request description:
Note that the mailing list discussion on the [BIP](https://github.com/bitcoin/bips/blob/master/bip-0461.md) mentions Bitcoin Core and the linked pull request #13666 (released in v0.17.0) explicitly: https://groups.google.com/g/bitcoindev/c/boEZRlqczvw/m/F4Bvid36CwAJ
ACKs for top commit: achow101: ACK d57346d682f17e6cf09f8acc5e7893ee16eec193 davidgumberg: ACK https://github.com/bitcoin/bitcoin/commit/d57346d682f17e6cf09f8acc5e7893ee16eec193
This commit is a documentation-only update. It adds a single line to Bitcoin Core's list of implemented BIPs, noting that BIP 461 (a technique for making ECDSA signatures smaller and deterministic) has been implemented since version 0.17.0. No code was changed, and there is no security fix or vulnerability.
AI review queuedMerge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendallby Ava Chow · e7aef7e8 · Sep 29, 2026 · 2 filesMessage 81 · StrongLow 27Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#36375: wallet: accept uppercase addresses without amount in sendall
df2994b14a4ba26c4ccebd6df4c24d8aaf22d851 wallet: accept uppercase addresses without amount in sendall (FlashW)
Pull request description:
`sendall` keeps the recipients that were given without an amount as the strings the user passed (spend.cpp:1399). Later it finds their outputs by comparing against `EncodeDestination` of each output script (spend.cpp:1564), which for bech32 is the canonical lowercase form.
An address given in uppercase is valid bech32, and `validateaddress` and `sendtoaddress` accept it. In `sendall` it never matches, so its output keeps the placeholder amount of 0 and the call fails:
``` sendall '["BCRT1Q..."]' error code: -8 Specified output amount to bcrt1q... is below dust threshold. ```
This stores the decoded destinations of those addresses instead and compares them with the destinations of the outputs, so the match doesn't depend on how the address was written. Invalid addresses are still rejected later when the transaction is constructed.
The new `sendall_uppercase_address` in `wallet_sendall.py` sweeps the wallet to the uppercase form of an address. It fails on master with the dust error above and passes with the fix. `wallet_send.py` still passes.
ACKs for top commit: maflcko: lgtm ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851 achow101: ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851 polespinasa: ACK df2994b14a4ba26c4ccebd6df4c24d8aaf22d851
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100
This patch fixes a bug in Bitcoin Core's `sendall` wallet command. If a user typed a bech32 address in uppercase letters, the command would fail with a confusing 'below dust threshold' error instead of sending the funds. The fix compares decoded address data rather than raw text, so uppercase and lowercase addresses are treated the same. It is a usability/functional bug, not a vulnerability that lets someone steal funds.
Lower-priorityMerge bitcoin/bitcoin#36336: log: move CreateNewBlock() log line behind a new mining categoryby Ava Chow · de8892f9 · Sep 29, 2026 · 4 filesMessage 81 · StrongTriage 0Details
Commit message · Ava Chow
Merge bitcoin/bitcoin#36336: log: move CreateNewBlock() log line behind a new mining category
df3008418c20f7eb23736b893c2b997db93ce433 doc: add release notes (ismaelsadeeq) 54b8795121d3081019befd8a2bc70adcd06fcb65 log: move CreateNewBlock() log line behind a new mining category (ismaelsadeeq)
Pull request description:
Fixes #36334
The "CreateNewBlock(): block weight: ..." line was logged unconditionally and could not be turned off, filling the debug log when block templates are built frequently.
Move it behind a new "mining" logging category, enabled with -debug=mining.
ACKs for top commit: l0rinc: diff and code review reACK df3008418c20f7eb23736b893c2b997db93ce433 achow101: ACK df3008418c20f7eb23736b893c2b997db93ce433 w0xlt: ACK df3008418c20f7eb23736b893c2b997db93ce433