Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…
This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…
Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…
Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…
Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …
No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…
Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …
Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…
Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…
This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…
Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…
Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…
Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …
New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…
Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…
Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…
Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…
Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…
Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…
P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …
File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedwallet2: trim stale transfer maps after output importsby selsta · 80f75eaa · Oct 2, 2026 · 2 filesMessage 50 · ThinLow 42Details
Commit message · selsta
wallet2: trim stale transfer maps after output imports
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 42/100
This Monero wallet patch cleans up internal lookup tables (key-image and public-key indexes) when the list of owned transaction outputs is shrunk, for example during an output import. Without the cleanup, those indexes could point to entries that no longer exist, which could cause the wallet to crash or behave incorrectly when it later tries to spend or display funds. The patch also repairs any stale indexes when loading an older wallet cache that has never been refreshed from a node.
AI review queuedMerge pull request #11448by tobtoht · 24a01223 · Oct 2, 2026 · 1 fileMessage 58 · ThinLow 38Details
Commit message · tobtoht
Merge pull request #11448
ab343dc wallet2: keep received amount breakdown consistent (selsta)
ACKs: plowsof, jpk68, j-berman, PyXMR2025
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 38/100
This is a small code fix in Monero's wallet that keeps the recorded breakdown of received amounts consistent when a transaction output is 'burnt' (replaced or spent as part of a transaction the wallet is processing). The change adds a check that throws an internal wallet error if the expected amount cannot be found in the wallet's tracking list, and updates the tracked value to the remaining 'extra' amount. The commit message does not describe this as a security fix, and there is no direct evidence in the diff or supplied references that this is exploitable by an attacker.
AI review queuedMerge pull request #11443by tobtoht · c03c1f15 · Oct 2, 2026 · 1 fileMessage 58 · ThinModerate 60Details
Commit message · tobtoht
Merge pull request #11443
ff1157b wallet2: sanitize untrusted daemon status in sweep unmixable (selsta)
ACKs: SNeedlewoods, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 60/100
This patch fixes a spot in the Monero wallet where an untrusted remote server (daemon) could supply a misleading 'status' field. Previously, the wallet used that raw status directly in its error handling, which could potentially make a malicious daemon's response look trustworthy or cause the wallet to misbehave. The fix passes the status through a helper that treats the daemon as untrusted unless the user has explicitly marked it trusted.
AI review queuedMerge pull request #11391by tobtoht · 9b24b744 · Oct 2, 2026 · 1 fileMessage 58 · ThinModerate 64Details
Commit message · tobtoht
Merge pull request #11391
497984e epee: count buffered pipelined data against the request size limit (xmrack)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 64/100
This patch fixes a size-limit accounting bug in Monero's built-in HTTP server. When a client sends multiple HTTP requests back-to-back on the same connection (pipelining), leftover buffered data from the next request was not being counted toward the server's maximum allowed request size. A malicious or misbehaving client could therefore sneak in a request larger than the configured limit, potentially causing excessive memory use or a denial of service. The fix makes the server count that already-buffered data against the limit when it starts processing the next request.
AI review queuedMerge pull request #11386by tobtoht · 9df95286 · Oct 2, 2026 · 5 filesMessage 58 · ThinModerate 51Details
Commit message · tobtoht
Merge pull request #11386
0e2b994 wallet-rpc: honor --no-dns without a wallet (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 51/100
This patch fixes a privacy leak in Monero's wallet RPC server. Previously, the --no-dns flag was ignored when no wallet was loaded, so the validate_address RPC call could still perform a DNS lookup (OpenAlias) even though the user had explicitly disabled DNS. This could leak which address or alias a user was checking to DNS servers. The fix makes the RPC server honor --no-dns and --offline flags even without a wallet open.
AI review queuedMerge pull request #11383by tobtoht · 07e23b8f · Oct 2, 2026 · 2 filesMessage 58 · ThinInformational 21Details
Commit message · tobtoht
Merge pull request #11383
f4efec8 simplewallet: use set_daemon instead of init (SNeedlewoods)
ACKs: selsta, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This update improves the Monero wallet's command that connects to a network node (daemon). It lets users supply a username/password and a proxy address when switching daemons, and it replaces an older one-step connection method with a newer, more complete setup method. A small thread-safety lock was also added to the proxy-setting function. There is no clear security bug being fixed; it looks like a usability and consistency improvement.
AI review queuedMerge pull request #11253by tobtoht · ff738959 · Oct 2, 2026 · 1 fileMessage 58 · ThinLow 42Details
Commit message · tobtoht
Merge pull request #11253
7d702bf wallet_api: preserve output metadata in view-only wallet exports (selsta)
ACKs: jpk68, plowsof
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100
This change alters how Monero creates a view-only wallet copy. Previously, the code exported outputs using a method that could strip some metadata. Now it copies the full internal transfer records directly, then wipes and clears the multi-signature key field to avoid leaking a signing secret. The intent appears to be a security fix: preserving more metadata in view-only wallets while scrubbing data that should not be exported. However, the patch is small and the commit message does not explicitly call it a security fix, so the classification is uncertain.
AI review queuedMerge pull request #11268by tobtoht · dba16f07 · Oct 2, 2026 · 5 filesMessage 58 · ThinModerate 63Details
Commit message · tobtoht
Merge pull request #11268
a34b2a7 epee: avoid blocking RPC workers on full send queues (selsta)
ACKs: PyXMR2025*, jpk68, plowsof
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
parser or protocol pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 63/100
This Monero update fixes a networking bug where the server could accidentally block all of its worker threads while waiting for slow clients to accept data. If all workers became stuck this way, the node could stop processing any network traffic, effectively causing a denial-of-service. The patch removes the blocking wait and instead drops connections that exceed send limits. It also makes HTTP response failures propagate correctly so a failed send stops further request processing instead of continuing blindly.
AI review queuedMerge pull request #11260by tobtoht · 66dd773e · Oct 2, 2026 · 4 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht
Merge pull request #11260
1c7ba69 tx/partial tx validation hardening (koe)
ACKs: selsta, thomasbuilds, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This Monero wallet patch adds stronger safety checks when a wallet prepares, signs, or loads multi-step transactions (unsigned transactions, multisig transactions, and cold-device transactions). It verifies that money going into the transaction is not counted twice, that change addresses really belong to the wallet, that outputs do not exceed inputs, and that destination address types stay consistent. These are defensive hardening measures against mistakes or maliciously crafted transaction files that could otherwise make the wallet sign an invalid or harmful transaction.
AI review queuedMerge pull request #11362by tobtoht · 30860a26 · Oct 2, 2026 · 1 fileMessage 58 · ThinLow 46Details
Commit message · tobtoht
Merge pull request #11362
9663a86 wallet2: reset scan status for already processed outputs (selsta)
ACKs: jpk68, plowsof, j-berman, thomasbuilds
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 46/100
This small patch fixes a bug in the Monero wallet where, if an output had already been scanned once, the wallet would return early without clearing an error flag. In rare cases this could leave a stale 'error' state attached to a transaction output, potentially causing the wallet to misreport whether a payment was received or whether scanning succeeded. It is a defensive correctness fix rather than a clear exploit, but stale error state in financial software can have security-adjacent consequences.
AI review queuedfix: wallet_info for non-deterministic walletsby SNeedlewoods · a3860e7b · Oct 1, 2026 · 2 filesMessage 57 · ThinInformational 18Details
Commit message · SNeedlewoods
fix: wallet_info for non-deterministic wallets
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit fixes how Monero's wallet information display labels non-deterministic wallets (wallets not created from a standard seed phrase). Previously, these wallets were incorrectly labeled as 'Normal' with a 'Legacy' seed type. The change adds proper labels like 'Non-deterministic' and 'None' for seed type, and also adds a 'Hardware' wallet type label. This is a user-interface and reporting correction, not a security fix.
109b58b wallet2: bound the timestamp-to-height search (Thomas)
ACKs: jpk68, SNeedlewoods
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 34/100
This change fixes a binary search in the Monero wallet that previously could loop forever or behave incorrectly if something went wrong. The old code used an unbounded 'while (true)' loop and a midpoint calculation that could overflow. The patch limits the loop to 64 iterations (enough for any blockchain height) and switches to a safer midpoint formula. In the worst case, the old loop might never terminate, causing the wallet to hang when looking up a blockchain height from a timestamp.
AI review queuedwallet2: sanitize untrusted daemon status in sweep unmixableby selsta · ff1157b1 · Sep 30, 2026 · 1 fileMessage 50 · ThinLow 46Details
Commit message · selsta
wallet2: sanitize untrusted daemon status in sweep unmixable
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Low 46/100
This commit changes how a Monero wallet handles error status codes returned by a remote daemon during a cleanup operation called 'sweep unmixable.' Previously, the wallet trusted the daemon's raw status response. Now it passes that status through a helper that treats certain errors differently when the daemon is not trusted. This is a hardening fix: a malicious or compromised remote node could potentially return a misleading status code that the wallet would treat as a fatal error, possibly disrupting the operation or influencing wallet behavior. The patch narrows what the wallet believes from an untrusted daemon.
Signed-off-by: Arthur SC Chan <arthur.chan@adalogics.com>
70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new automated test tool (a fuzzer) for the Monero wallet's transaction-scanning logic. It does not change any production wallet, node, or consensus code. Fuzzers feed random data to functions to find crashes or bugs during testing, but adding one is a defensive quality-assurance change, not a vulnerability fix or a security flaw in itself.
be2cd75 wallet2: ignore long PIDs when block version is unknown (selsta)
ACKs: jpk68, tobtoht
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 45/100
This tiny change adjusts how the Monero wallet treats old-style unencrypted payment IDs when it cannot determine the block version of the transaction. Previously, if the block version was unknown (reported as 0), the wallet would still process the long payment ID. Now it ignores it, matching the intended privacy-preserving behavior for modern blocks. The risk is reduced privacy or accidental information leakage in edge cases, not theft of funds.
5626dfc wallet2: restore from a Polyseed with --generate-from-json (Thomas) 0214b32 simplewallet: keep the restore height from --generate-from-json (Thomas)
ACKs: jpk68, selsta
66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit fixes a wallet-creation bug: when restoring a Monero wallet from a special newer-style seed (called a Polyseed) using a JSON configuration file, the wallet software previously treated it like an older Electrum-style seed. This could cause the restore height to be set incorrectly and could apply an optional seed passphrase to the wrong key derivation path. The patch makes the JSON restore path recognize Polyseeds and handle their passphrase and birthday height correctly. It also preserves the restore height in the simplewallet command-line tool when no explicit restore height is provided.
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit adds a new read-only wallet command called get_wallet_info that lets an authenticated user ask the wallet for basic metadata such as the wallet file name, address, wallet type, which network it is on, the daemon address, and any configured proxy. It also fixes a small consistency bug where the stored proxy setting was not updated when set_proxy was called. The change is informational only: it does not move, spend, or expose private keys, and it is blocked in restricted RPC mode. The main security consideration is that it makes it slightly easier for a logged-in RPC user to learn the wallet's network setup, which could help target further attacks if the RPC endpoint is already compromised.
7e2e857 wallet2: validate block hash when repairing empty hashchain (selsta)
ACKs: PyXMR2025, jpk68
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100
This patch adds a safety check in Monero's wallet code when it asks the connected node (daemon) for a block hash to repair an empty local record of past blocks. Previously, if the daemon returned malformed or invalid data, the wallet would silently treat the conversion as successful and use an uninitialized or corrupted hash. Now the wallet explicitly checks whether the conversion succeeded and throws an error if it did not. This is a defensive hardening fix that prevents the wallet from accepting an invalid block hash during a recovery operation.
3e727c6 Expose wallet exist as rpc command (Deverick)
ACKs: PyXMR2025, jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 24/100
This commit adds a new wallet RPC command called wallet_exists that lets a caller check whether a wallet file or its keys file already exists in the configured wallet directory. It also refactors existing filename validation into a shared helper. The new command is blocked in restricted RPC mode and reuses the same path-separator checks as create/open wallet, so it does not appear to introduce a new security vulnerability. It could, however, make it slightly easier for an authenticated RPC user to probe for wallet names.
This Monero wallet update adds several safety checks to prevent the wallet software from crashing or behaving incorrectly when handling unusual wallet files, transaction proofs, or old account data. It does not appear to be a remote money-stealing bug, but rather hardening against malformed inputs that could cause errors or unexpected behavior.
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 48/100
This Monero wallet update fixes three separate issues: it prevents weird or malicious text from log/console messages from confusing the terminal (terminal escape-sequence injection), it stops the wallet from trusting and displaying invalid public node addresses from the network, and it improves error handling when the wallet talks to a daemon so that untrusted RPC responses are not silently accepted. None of these directly steal funds, but they reduce ways an attacker could trick a user or hide problems.
`get_accounts` currently scans all transfers twice for each matching account. compute account balances in one pass, including pending change and incoming payments, while preserving strict and unlocked balance rules.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit is a performance optimization for the Monero wallet's RPC interface. It changes how account balances are calculated so that all accounts are scanned in a single pass instead of scanning the entire transaction history separately for each account. The commit also adds tests to verify that the new batch calculation produces the same results as the old individual calculation. There is no indication this fixes a security vulnerability; it appears to be a correctness-preserving efficiency improvement.
a319868 wallet2: validate account tags before mutation (Samy)
ACKs: jpk68, selsta
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100
This commit fixes a bug in Monero's wallet software where the program would partially change account labels before checking whether all requested accounts actually exist. The fix moves the boundary check to the very beginning so the operation either fully succeeds or fully fails, and no partial changes are saved. The practical security impact is limited because the bug only affects account tagging metadata, not balances or transactions.
3f7dc4e wallet2: reject malformed multisig_info on import (jpk68)
ACKs: UkoeHB, SNeedlewoods
58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This Monero wallet update adds safety checks when a wallet imports 'multisig_info' data shared between co-signers in a multi-signature wallet. It now rejects files where the declared signer doesn't match the file header, or where the number of partial key images or signing nonces is wrong. These checks prevent malformed or mismatched multisig data from being processed further. The change includes new unit tests that confirm the rejections work.
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 61/100
This update adds a safety check in the Monero wallet software. When the wallet asks a network node (daemon) for details about specific transactions, it now verifies that the transactions it gets back are actually the ones it asked for. Without this check, a malicious or compromised node could potentially return the wrong transactions, which might confuse the wallet about balances or transaction history. The fix makes the wallet reject any response where the returned transaction IDs do not match the requested ones.