Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
51/100 average clarity
20Strong · 80–100
123Adequate · 60–79
534Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
This Monero wallet update fixes a bookkeeping bug. When a wallet imported a list of its owned outputs and that list was smaller than a previous import, internal lookup maps (key images and public keys) could still point to entries that no …
Internal index/cache consistency fix in wallet output handlingPrevents out-of-range references after transfer list resizeAdds defensive repair on wallet cache load for unrefreshed wallets
This commit simplifies how Monero's simplewallet decides whether a payment ID is a real encrypted ID or a dummy placeholder. Previously, the wallet checked both the payment ID value and whether any destination was an integrated address, an…
Removal of a CHECK_AND_ASSERT_MES consistency check between destination flags and payment ID valueChange from dual-factor classification (address type + payload) to payload-only classificationPotential for previously rejected transactions to be accepted if the old check was overly strict
This Monero wallet patch cleans up internal lookup tables (key-image and public-key indexes) when the list of owned transaction outputs is shrunk, for example during an output import. Without the cleanup, those indexes could point to entri…
Out-of-bounds index retained in wallet lookup maps after container shrinkPotential wallet crash or incorrect spend selection due to stale key-image / public-key mappingRepair-on-load for legacy wallet caches that predate the fix
This small change removes a consistency check in Monero's command-line wallet when loading a saved transaction. Previously, the wallet verified that a 'dummy' payment ID label matched a special zero-value payment ID. Now it labels the paym…
Removal of a CHECK_AND_ASSERT_MES consistency checkRemoval of integrated-address validation for payment ID classificationChange in UI/labeling logic for loaded transactions
This commit updates Monero's built-in blockchain checkpoints to match the v0.18.5.3 release. Checkpoints are hard-coded reference points that help nodes quickly verify they are following the correct chain and resist certain attacks. The ch…
Hard-coded blockchain checkpoint data updated to a newer height/hashExpected compiled-in block hashes digest changedNo new code paths, cryptographic changes, or bug fixes visible in the diff
This is a small code fix in Monero's wallet that keeps the recorded breakdown of received amounts consistent when a transaction output is 'burnt' (replaced or spent as part of a transaction the wallet is processing). The change adds a chec…
Defensive consistency check added (THROW_WALLET_EXCEPTION_IF)Fixes internal accounting of received output amountsNo explicit security claim in commit or supplied references
This patch fixes a spot in the Monero wallet where an untrusted remote server (daemon) could supply a misleading 'status' field. Previously, the wallet used that raw status directly in its error handling, which could potentially make a mal…
Untrusted input from remote daemon used in error-handling pathMissing trust check on daemon-reported RPC statusSingle-call-site hardening patch
This commit adds two new read-only options to the wallet's remote procedure call (RPC) interface so users can request their public view key and public spend key. Public keys are meant to be shared openly and are not secrets, so exposing th…
This commit only updates a submodule pointer for the external polyseed library from one commit hash to another. The actual code changes inside the submodule are not shown in the diff, and no public references were supplied. There is no vis…
This patch fixes a size-limit accounting bug in Monero's built-in HTTP server. When a client sends multiple HTTP requests back-to-back on the same connection (pipelining), leftover buffered data from the next request was not being counted …
Request size limit bypass via pipelined HTTP cachingDenial-of-service / memory pressure potential from oversized requestsFix in low-level network protocol handler
This patch fixes a privacy leak in Monero's wallet RPC server. Previously, the --no-dns flag was ignored when no wallet was loaded, so the validate_address RPC call could still perform a DNS lookup (OpenAlias) even though the user had expl…
Privacy leak: RPC ignored --no-dns when no wallet loadedDNS lookup performed despite explicit user opt-outOpenAlias resolution could disclose queried addresses/aliases to DNS resolvers
This commit adds cleanup of three additional memory buffers in Monero's seed-phrase key-stretching code. Before the change, leftover copies of intermediate secrets could remain in stack memory after the function finished. An attacker who c…
Sensitive intermediate key material left in stack memory after function returnUse of sodium_memzero to clear cryptographic buffersPBKDF2 implementation handling mnemonic-derived secrets
This update improves the Monero wallet's command that connects to a network node (daemon). It lets users supply a username/password and a proxy address when switching daemons, and it replaces an older one-step connection method with a newe…
Added mutex lock in wallet2::set_proxy to protect concurrent access to proxy and HTTP client stateset_daemon now passes RPC login credentials and proxy settings through the proper wallet2::set_daemon APITrust heuristic changed to only auto-trust local daemons when no proxy is in use
This change alters how Monero creates a view-only wallet copy. Previously, the code exported outputs using a method that could strip some metadata. Now it copies the full internal transfer records directly, then wipes and clears the multi-…
Sensitive field sanitization before export (memwipe + clear of m_multisig_k)Change in data export path for view-only wallet creationPreservation of 'complete output metadata' implying previous path was incomplete
This Monero update hardens how public keys and transaction pubkeys are handled. It moves a low-level 'torsion clearing' routine into the core crypto library, adds checks that wallet/destination addresses are valid points on the main subgro…
Adds main-subgroup membership validation for public address keys (spend/view)Normalizes transaction public keys before use in payment-ID decryption and tx proofsMoves torsion-clearing primitive into core crypto layer to ensure consistent behavior
This Monero update fixes a networking bug where the server could accidentally block all of its worker threads while waiting for slow clients to accept data. If all workers became stuck this way, the node could stop processing any network t…
Removal of blocking condition-variable wait in network send pathFail-fast on send-queue overflow instead of parking worker threadsHTTP handler now propagates send failures and enters error state
This Monero wallet patch adds stronger safety checks when a wallet prepares, signs, or loads multi-step transactions (unsigned transactions, multisig transactions, and cold-device transactions). It verifies that money going into the transa…
Adds duplicate-input detection across transaction setsAdds destination address type consistency checksAdds uint64 overflow guard for summed input amounts
This Monero update makes the network layer clean up leftover block download records when a peer connection fails or is rejected. Previously, rejected or disconnected peers could leave stale block spans in a queue, which might cause the nod…
Denial-of-service resistance: stale block spans from malicious or faulty peers could prevent a node from obtaining valid blocksState cleanup on peer disconnection/rejectionNo authentication or memory-safety bug evident in diff
This small patch fixes a bug in the Monero wallet where, if an output had already been scanned once, the wallet would return early without clearing an error flag. In rare cases this could leave a stale 'error' state attached to a transacti…
Stale error-state propagation in wallet scanning logicMissing reset of tx_scan_info.error on cached/short-circuit code pathPotential for incorrect received-payment or scan-failure reporting
This change fixes a binary search in the Monero wallet that previously could loop forever or behave incorrectly if something went wrong. The old code used an unbounded 'while (true)' loop and a midpoint calculation that could overflow. The…
Unbounded loop replaced with bounded iterationInteger overflow mitigation in midpoint calculationDefensive error handling added for search failure
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedCleanup some of the fragmented levin handlingby Lee *!* Clagett · 3e2c837b · Mar 11, 2026 · 2 filesMessage 45 · ThinModerate 58Details
Commit message · Lee *!* Clagett
Cleanup some of the fragmented levin handling
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Moderate 58/100
This commit tightens how Monero's network code reassembles split-up network messages. Previously, when fragments were stitched back together, the code trusted the size written in the message header without checking whether the actual reassembled buffer was at least that large. That could let a malformed message cause the code to read past the end of its buffer. The patch adds a size check and trims the buffer to exactly the claimed size before further processing. A new test confirms the handler now rejects a case where the header claims more data than the fragments actually provide.
AI review queuedAdd Socks v5 support to daemon and walletby Lee *!* Clagett · 23e29a50 · Mar 6, 2026 · 17 filesMessage 45 · ThinLow 27Details
Commit message · Lee *!* Clagett
Add Socks v5 support to daemon and wallet
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit adds SOCKS5 proxy support to the Monero daemon and wallet, expanding the older SOCKS4/SOCKS4a support. It introduces new URI parsing for proxy strings, optional username/password authentication, IPv6 support, and new command-line options. The change is a feature addition, not a documented security fix. The code does include some security-relevant notes (for example, warning that proxy credentials may appear in the process list), but nothing in the commit message or diff states that a vulnerability is being patched.
✓ Specific, descriptive subject✓ Provides an explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 59/100
This commit fixes a bug in how Monero builds the 'extra nonce' field inside transaction metadata. Previously, the code always reserved only 2 bytes for the length header, which is wrong for larger nonces because the protocol uses a variable-length integer (varint) that can take more than 1 byte. The patch now correctly calculates how many bytes the length needs and writes it as a proper varint. The bug could corrupt transaction extra data or cause parsing failures when nonces larger than 127 bytes are used, but the maximum allowed nonce size (255 bytes) limits the damage. There is no public statement from the Monero Project calling this a security issue, and no independent researcher is credited.
cryptonote_core: remove Boost serialization for tx_source_entry
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 11/100
This commit removes the Boost serialization code for a Monero internal data structure called tx_source_entry. It deletes about 20 lines of code that described how this structure is converted to/from a serialized format. The change appears to be a cleanup or hardening step, not a fix for an active vulnerability. There is no direct evidence in the commit that this change addresses a security bug, and no public references were provided.
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit changes the Monero build system (Makefile) to fix problems when running builds in parallel. It explicitly tells CMake to generate Unix Makefiles and uses the standard $(MAKE) command instead of cmake --build. There is no security relevance in the diff itself.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocolcryptography-sensitive pathsigning or wallet path
AI analysis · Informational 17/100
This commit renames and rewrites a Monero function used to compute a 'zero-commitment' Pedersen commitment (a cryptographic value that hides transaction amounts). The new implementation uses a precomputed table and a vartime (variable-time) bit-by-bit addition to make the calculation about six times faster. The commit does not claim to fix any security bug, and the diff itself shows no signs of a vulnerability. The main risk is that the new code must produce exactly the same results as the old code, otherwise consensus between nodes could break.
AI review queuedTransition asio::deadline_timer to asio::steady_timerby Lee *!* Clagett · 44869250 · Feb 17, 2026 · 19 filesMessage 50 · ThinInformational 19Details
Commit message · Lee *!* Clagett
Transition asio::deadline_timer to asio::steady_timer
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit replaces older Boost timer types with newer, more robust standard-library-based timers throughout Monero's networking code. It is primarily a modernization and maintainability change. There is no direct evidence in the commit that it fixes an active security vulnerability, though using the newer timer API can help avoid subtle timing bugs in the long run.
Security candidatesrc: update checkpoints to match v0.18.4.6by selsta · f459bd65 · Feb 13, 2026 · 4 filesMessage 45 · ThinInformational 15Details
Commit message · selsta
src: update checkpoints to match v0.18.4.6
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit is a routine maintenance update that adds a new blockchain checkpoint and updates version references in documentation. Checkpoints are like agreed-upon 'milestones' in the blockchain that help nodes sync faster and resist certain attacks. There is no indication of a security fix or vulnerability in this change.
* Use -O3 and other flags instead of -Ofast - https://discourse.llvm.org/t/rfc-deprecate-ofast/78687 - https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html * Find libunwind library based on C++ compiler type, not C compiler type * In stack_trace.cpp, pass stream modifiers to `std::stringstream` first, then send string to log * In stack_trace.cpp, remove dead code related to `stack_trace_log` path * Remove `virtual` method attributues from `final` class `cryptonote::core` * Remove unused `this` capture in cryptonote protocol handler * Remove unused variable `bad` in net node * Use `std::make_unsigned` instead of `boost::make_unsigned` - https://github.com/boostorg/type_traits/issues/171 - https://github.com/boostorg/type_traits/issues/202 - https://github.com/boostorg/type_traits/pull/199 * Cleanup `include`s in pair serialization * Test convergence b/t `std::make_unsigned` and `boost::make_unsigned`
Fixes compilation and silences warnings on: clang version 21.1.6 Linux 6.18.8-3-cachyos
69/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 27/100
This is a routine maintenance patch that makes Monero compile cleanly on the upcoming Clang 21 compiler. The most notable change is replacing the aggressive '-Ofast' optimization flag with '-O3 -ffast-math -fno-semantic-interposition', which removes a compiler option that could theoretically allow unsafe floating-point and memory optimizations. The rest of the patch removes dead code, unused variables, and compiler warnings. There is no direct evidence this fixes an active security vulnerability, but the compiler-flag change is a sensible hardening step.
src: dynamic span, to calculate span limit dynamically
Co-authored-by: nahuhh - jberman review - cryptonote_protocol: don't arbitrarily download 1000 blocks ahead - further restrict `proceed` to require `queue_proceed` in all cases. ensure queue_proceed is true if we need the next block, even if we already exceed the span and size limits
cryptonote_protocol: improved logging + const usage in span downloader
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 26/100
This Monero commit changes how many future blocks a node asks peers for during initial sync. Previously the node would always download up to 1,000 blocks ahead regardless of conditions. Now it calculates a dynamic limit based on recent download speed and a user-configurable 'span-limit' (default 2 minutes of blocks). The change also tightens the logic so the node only proceeds to request more blocks when it actually needs the next block or when queue limits allow. It is primarily a performance and robustness improvement, not a clear security fix, though the old behavior could have made nodes easier to overload with excessive download requests.
✓ Subject identifies a change✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit is a massive merge of pull request #9494 titled 'dynamic block sync size' into the Monero repository. The supplied diff only shows the addition of repository boilerplate files (git attributes, GitHub Actions CI workflows, gitignore, gitmodules, CMakeLists.txt, Dockerfile, Doxyfile, etc.) and does not include the actual code changes related to 'dynamic block sync size'. There is no security-relevant code change visible in the provided materials.
AI review queuedwallet: add source info to describe_transfer RPCby jeffro256 · 7a2ba648 · Jan 15, 2026 · 2 filesMessage 45 · ThinInformational 18Details
Commit message · jeffro256
wallet: add source info to describe_transfer RPC
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit adds more detailed information about where transaction inputs come from to a wallet RPC command called describe_transfer. It is a feature enhancement that exposes source details (amount, global index, ring signature type, public key) to RPC callers. There is no indication in the commit that this fixes a security vulnerability or introduces a dangerous capability.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · Informational 20/100
This commit swaps out one Monero project domain ending in .no for one ending in .co in three places: software update checks, a DNS debugging tool, and a peer network blocklist. It is a routine infrastructure/domain-list change. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be domain housekeeping, possibly because the .no domain was lost, expired, or no longer controlled by the project.
Does the following to speedup the `/is_key_image_spent` RPC endpoint: - Reads all on-chain key images in one LMDB read transacion - Uses `cryptonote_core::are_key_images_spent_in_pool()` instead of `cryptonote_core::get_pool_transactions_and_spent_keys_info()` for pool querying. This only does a LMDB read per key image if in the pool. - Filters known on-chain spent key images before querying for key images spent in pool
This RPC endpoint was causing major daemon slowdowns in the Carrot/FCMP++ Alpha Stressnet when using the `rescan_spent` command, especially for large wallets. The effect was much worse if the mempool was full.
privacy or spend-authorization protocolcryptography-sensitive path
AI analysis · Informational 18/100
This commit is a performance optimization for a Monero daemon RPC endpoint called /is_key_image_spent. It speeds up wallet rescan operations by reading on-chain key images in a single database transaction and by querying the memory pool more efficiently. The change is framed as a fix for severe daemon slowdowns during stress testing, not as a security vulnerability. There is no direct evidence in the commit of a security flaw, but the prior behavior could be abused to cause denial of service by sending many expensive queries.
AI review queuedwallet: unrestrict `get_transfers` and `get_transfer_by_txid`by jeffro256 · bc5cdf47 · Jan 5, 2026 · 2 filesMessage 50 · ThinLow 34Details
Commit message · jeffro256
wallet: unrestrict `get_transfers` and `get_transfer_by_txid`
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 34/100
This change makes two wallet RPC commands, `get_transfers` and `get_transfer_by_txid`, usable in 'restricted' mode, which previously blocked them entirely. In restricted mode, these commands can now read confirmed and historical wallet transaction data, but they still cannot refresh the mempool/pool state. The change is described by the project as an intentional relaxation of restrictions, not as a security fix. It may expose more wallet history to anyone who can reach a restricted wallet RPC, but it does not by itself bypass authentication or steal funds.
cryptonote_core: cache input verification results directly in mempool
This replaces `ver_rct_non_semantics_simple_cached()` with an API that offloads the responsibility of tracking input verification successes to the caller. The main caller of this function in the codebase, `cryptonote::Blockchain()` instead keeps track of the verification results for transaction in the mempool by storing a "verification ID" in the mempool metadata table (with `txpool_tx_meta_t`). This has several benefits, including:
* When the mempool is large (>8192 txs), we no longer experience cache misses and unnecessarily re-verify ring signatures. This greatly improves block propagation time for FCMP++ blocks under load * For the same reason, reorg handling can be sped up by storing verification IDs of transactions popped from the chain * Speeds up re-validating every mempool transaction on fork change (monerod revalidates the whole tx-pool on HFs #10142) * Caches results for every single type of Monero transaction, not just latest RCT type * Cache persists over a node restart * Uses 512KiB less RAM (8192*2*32B) * No additional storage or DB migration required since `txpool_tx_meta_t` already had padding allocated * Moves more verification logic out of `cryptonote::Blockchain`
Furthermore, this opens the door to future multi-threaded block verification speed-ups. Right now, transactions' input proof verification is limited to one transaction at a time. However, one can imagine a scenario with verification IDs where input proofs are optimistically multi-threaded in advance of block processing. Then, even though ring member fetching and verification is single-threaded inside of `cryptonote::Blockchain::check_tx_inputs()`, the single thread can skip the CPU-intensive cryptographic code if the verification ID allows it.
Also changes the default log category in `tx_verification_utils.cpp` from "blockchain" to "verify".
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarydefensive validationprivacy or spend-authorization protocolcryptography-sensitive path
AI analysis · Low 39/100
This commit is a performance refactor of how Monero nodes cache expensive ring-signature verification results for transactions sitting in the memory pool (mempool). It replaces an in-memory cache limited to 8,192 entries with a persistent verification ID stored in each mempool transaction's metadata. The change is described by the author as improving block propagation and reorg handling, not as a security fix. The main risk is that if the verification ID is ever set incorrectly or reused with the wrong mix-ring data, a node could skip cryptographic checks on a bad transaction, which would be a consensus bug. The diff includes careful checks and unit tests, but it is a large, complex change touching core consensus code.
Security candidatesrc: update checkpoints to match v0.18.4.5by selsta · 59055896 · Dec 29, 2025 · 4 filesMessage 45 · ThinInformational 21Details
Commit message · selsta
src: update checkpoints to match v0.18.4.5
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 21/100
This commit updates Monero's built-in blockchain checkpoints to match the latest software release (v0.18.4.5). Checkpoints are hardcoded reference points that help nodes quickly verify they are following the correct chain and protect against certain types of attacks. The change is routine maintenance: it adds one new checkpoint at block height 3576000, updates a hash that verifies the checkpoint data file, and updates the recommended minimum version in documentation. There is no indication this fixes an active security vulnerability.
Security candidatewallet2: fix edge case where tx's ki's remain marked unspentby j-berman · ab9bc649 · Dec 12, 2025 · 1 fileMessage 85 · StrongModerate 57Details
Commit message · j-berman
wallet2: fix edge case where tx's ki's remain marked unspent
If a tx is marked as failed (because it never shows up in the daemon's pool), its key images get reset back to unspent so they can be used in future txs.
If the tx re-enters the daemon's pool (e.g. it's removed from the pool and then relayed back), then the wallet incorrectly maintains that the tx's key images are unspent.
This change ensures the wallet re-marks the tx's key images as spent if the tx re-appears in the node's pool.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Moderate 57/100
This patch fixes a bookkeeping bug in the Monero wallet. When a transaction temporarily disappears from the network's pending pool and is later re-broadcast, the wallet could wrongly treat the coins it spends as still available. That could let the wallet try to spend the same coins twice, producing a conflict that prevents any of those follow-up transactions from confirming until the wallet state is manually repaired.
p2p: fix race causing dropped connections during sync
Without this commit: 1) read height from DB 2) add block to chain in separate thread 3) read chain for block id's and request them from peer 4) ERR in handle_response_chain_entry, peer's first block is the one that was added to the chain, which has block idx=height from step 1.
This commit reads the chain for height and highest block id's in one go while holding the m_blockchain_lock to avoid the race.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 29/100
This patch fixes a timing bug in Monero's peer-to-peer syncing. Previously, a node could read its own blockchain height, then a new block could be added in another thread, and then the node would ask a peer for older blocks using an out-of-date height. This mismatch could cause the node to think the peer's first returned block was wrong and drop the connection, making sync slower or less reliable. The fix reads the height and the list of block hashes together under the same lock so they cannot get out of step.
Security candidateRemove invalid constexprby Lee *!* Clagett · 86927f33 · Dec 4, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Lee *!* Clagett
Remove invalid constexpr
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This is a tiny C++ code cleanup. The function `cn_variant1_check` was marked `constexpr` (a hint that it can be evaluated at compile time), but because it contains a runtime-only check (`if (variant == 1 && length < 43)` followed by an error path), that marking is invalid in newer C++ standards. The patch simply removes the `constexpr` keyword so the code compiles correctly. There is no change to what the function actually does, no security behavior change, and no bug fix beyond compiler compliance.
AI review queuedsimplewallet: report file writing failure for export_transfers commandby WHR · 24ef3376 · Dec 3, 2025 · 1 fileMessage 50 · ThinInformational 17Details
Commit message · WHR
simplewallet: report file writing failure for export_transfers command
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100
This commit fixes a minor user-experience issue in Monero's command-line wallet. Previously, when you ran the export_transfers command, the wallet would always say the CSV file was exported successfully even if the file could not actually be written (for example, because of missing permissions or a full disk). Now it checks whether the file opened and whether writing succeeded, and reports a clear failure message instead of falsely claiming success.
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 17/100
This commit simply adds the USB product ID for a new Ledger hardware wallet model (Nano generation 5) to Monero's list of supported Ledger devices. It is a one-line addition to a device identification table and does not change any security logic, cryptography, or transaction handling.
Security candidatecryptonote_core: set prep-blocks-threads to max threadsby 0xfffc · dc1d0dd8 · Nov 30, 2025 · 1 fileMessage 50 · ThinInformational 19Details
Commit message · 0xfffc
cryptonote_core: set prep-blocks-threads to max threads
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 19/100
This commit changes a default setting for how many threads Monero uses when preparing block hashes. Previously it was hardcoded to 4 threads; now it uses the number of CPU cores the computer reports (falling back to 4 if that number can't be determined). This is a performance tuning change, not a security fix. There is no direct evidence in the commit that it addresses a vulnerability.
AI review queuedsimplewallet: edit desc. text for transferby Cat · b7b9bce9 · Nov 26, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Cat
simplewallet: edit desc. text for transfer
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit changes only a single word in the help text of the Monero command-line wallet's 'transfer' command. It swaps the order of two placeholders in the description from 'Transfer <amount> to <address>' to 'Transfer <address> <amount>' so the wording matches the actual command syntax. There is no code change, no security fix, and no behavior change.
Security candidatetx_memory_pool: speedup get_complement() for large requestsby jeffro256 · 0673c957 · Nov 26, 2025 · 6 filesMessage 73 · AdequateLow 29Details
Commit message · jeffro256
tx_memory_pool: speedup get_complement() for large requests
Changes complexity from M*N to (2*N+M)*log2(M). The FCMP++ stressnet recently hit mempool sizes of ~55k txs. If the requesting node's mempool is populated, this results in an average of (55000*55000)/2 (about 1.5 billion) comparisons for the responding node. Under this commit, this would be reduced to (55000+55000)*log2(55000) comparisons (about 2.6 million), a 99.83% reduction.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive pathparser or protocol path
AI analysis · Low 29/100
This commit is a performance optimization for Monero's transaction memory pool. When one node asks another for transactions it is missing, the old code compared every requested hash against every pool transaction one-by-one, which becomes extremely slow when the pool is large (tens of thousands of transactions). The new code sorts the requested hashes once and uses binary search, cutting the work by roughly 99.8%. The main security-relevant angle is that the old code could be abused to make a node waste CPU time, potentially contributing to a denial-of-service condition.