What the developer wrote
Authored by jpk68
simplewallet: fix some error messages
Co-authored-by: SNeedlewoods <sneedlewoods_1@protonmail.com>
What changed, and why it matters
This commit only changes the wording of four user-facing error messages in Monero's command-line wallet. It corrects grammar and fixes a swapped description of multisig threshold parameters. There is no change to program logic, validation, cryptography, or network behavior, so it has no security impact.
No security action needed; this is a cosmetic/UX wording fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch updates four fail_msg_writer() strings in src/simplewallet/simplewallet.cpp. Three replace ‘This is not a multisig wallet’ with ‘This wallet is not multisig’. One corrects an error message from ‘expected N > 1 and N <= M’ to ‘expected M > 1 and M <= N’, matching the actual check multisig_m <= 1 || multisig_m > multisig_n. No code paths, conditions, or data handling are altered.
Changed components
src/simplewallet/simplewallet.cppInspect captured patch +4 / −4
diff --git a/src/simplewallet/simplewallet.cpp b/src/simplewallet/simplewallet.cpp
index 02b33ee..213d15e 100644
--- a/src/simplewallet/simplewallet.cpp
+++ b/src/simplewallet/simplewallet.cpp
@@ -1487,7 +1487,7 @@ bool simple_wallet::sign_multisig_main(const std::vector<std::string> &args, boo
}
if (!ms_status.multisig_is_active)
{
- fail_msg_writer() << tr("This is not a multisig wallet");
+ fail_msg_writer() << tr("This wallet is not multisig");
return false;
}
if (!ms_status.is_ready)
@@ -1603,7 +1603,7 @@ bool simple_wallet::submit_multisig_main(const std::vector<std::string> &args, b
}
if (!ms_status.multisig_is_active)
{
- fail_msg_writer() << tr("This is not a multisig wallet");
+ fail_msg_writer() << tr("This wallet is not multisig");
return false;
}
if (!ms_status.is_ready)
@@ -1680,7 +1680,7 @@ bool simple_wallet::export_raw_multisig(const std::vector<std::string> &args)
}
if (!ms_status.multisig_is_active)
{
- fail_msg_writer() << tr("This is not a multisig wallet");
+ fail_msg_writer() << tr("This wallet is not multisig");
return true;
}
if (!ms_status.is_ready)
@@ -4322,7 +4322,7 @@ bool simple_wallet::init(const boost::program_options::variables_map& vm)
}
if (multisig_m <= 1 || multisig_m > multisig_n)
{
- fail_msg_writer() << tr("Error: expected N > 1 and N <= M, but got: ") << multisig_type_string;
+ fail_msg_writer() << tr("Error: expected M > 1 and M <= N, but got: ") << multisig_type_string;
return false;
}
if (multisig_m != multisig_n)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.