Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedcontrib/add_cosigner: fix for python 3.13by SomberNight · b495ee77 · Jan 23, 2026 · 1 fileMessage 80 · StrongInformational 16Details
Commit message · SomberNight
contrib/add_cosigner: fix for python 3.13
This script used to work, I assume my breakage is due to the python version.
``` Traceback (most recent call last): File "/home/user/wspace/electrum/./contrib/add_cosigner", line 35, in <module> version_spec = importlib.util.spec_from_file_location('version', 'electrum/version.py') ^^^^^^^^^^^^^^ AttributeError: module 'importlib' has no attribute 'util' ```
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 16/100
This is a trivial compatibility fix for a helper script. In Python 3.13, using importlib.util requires explicitly importing importlib.util. The change adds that missing import so the script can load a version file again. There is no security issue here.
AI review queuedqt: fix: addresses tab broken for imported watchonly walletsby SomberNight · 0e07128c · Jan 23, 2026 · 2 filesMessage 91 · StrongInformational 18Details
Commit message · SomberNight
qt: fix: addresses tab broken for imported watchonly wallets
regression from https://github.com/spesmilo/electrum/pull/10376
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit fixes a bug where the 'Addresses' tab in Electrum's Qt GUI would crash or fail to display for a specific type of wallet: imported watch-only wallets. These wallets contain addresses you are monitoring but do not own the private keys for. The crash happened because the code assumed every address had an associated public key/index, but watch-only imported addresses do not. The fix makes the sorting function safely handle a missing index by treating it as an empty string. There is no security vulnerability here—just a user-interface regression.
AI review queuedupdate block header checkpointsby SomberNight · 08fa871f · Jan 22, 2026 · 4 filesMessage 35 · OpaqueInformational 15Details
Commit message · SomberNight
update block header checkpoints
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply adds new Bitcoin block header checkpoints to Electrum's data files for mainnet, signet, testnet, and testnet4. Checkpoints are hardcoded reference points that help the wallet verify it is following the correct blockchain. There is no code change, no bug fix, and no security vulnerability visible in this commit.
AI review queuedupdate localeby ThomasV · d9091784 · Jan 22, 2026 · 1 fileMessage 18 · OpaqueInformational 10Details
Commit message · ThomasV
update locale
18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
This commit is a routine update to Electrum's locale (translation/language) files. There is no indication of any security-related change, and the actual code diff is unavailable. It appears to be a normal maintenance update for translations.
AI review queuedwallet: check swap provider liquidity for send change to lnby f321x · 7b828a83 · Jan 22, 2026 · 1 fileMessage 85 · StrongLow 46Details
Commit message · f321x
wallet: check swap provider liquidity for send change to ln
Check the swap providers liquidity as well if we try to send change to lightning in `make_unsigned_transaction`. It is now expected that the swap_manager is already initialized when calling `make_unsigned_transaction`, otherwise no dummy output will get added.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 46/100
This commit tightens the conditions under which Electrum automatically sends Bitcoin transaction change into a Lightning Network swap. Previously, the wallet only checked whether the Lightning node could receive the amount. Now it also verifies the swap provider actually has enough liquidity and that the amount meets minimum and maximum swap limits. Without this check, a user could create a transaction whose change is routed into a swap that cannot currently be fulfilled, potentially leaving funds stuck, failing the payment path, or producing a poor user experience. The change is defensive rather than a fix for an active exploit.
AI review queuedwallet: stop() to clean-up lnworker even in offline modeby SomberNight · 15067be5 · Jan 20, 2026 · 1 fileMessage 50 · ThinLow 29Details
Commit message · SomberNight
wallet: stop() to clean-up lnworker even in offline mode
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit fixes a cleanup bug in Electrum wallet shutdown. Previously, the Lightning Network worker (lnworker) was only stopped when the wallet was online. If the wallet was offline, the Lightning worker might not shut down cleanly, potentially leaving background tasks running or resources not released. The change ensures the Lightning worker is always stopped during wallet shutdown, regardless of whether a network connection exists.
AI review queuedqml: PasswordDialog: show error on invalid passwordby f321x · 07f61ebd · Jan 20, 2026 · 3 filesMessage 85 · StrongInformational 15Details
Commit message · f321x
qml: PasswordDialog: show error on invalid password
Currently the PasswordDialog on QML would just close if the user enters an incorrect password. This is confusing as the user doesn't know why the dialog closed and if it initiated any action or not.
With the change the PasswordDialog will get the ability to show an error message and will show "Invalid Password" if an incorrect password is entered. I also used it for the password unification warning ("Need to enter similar password ...") instead of showing a separate popup.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit fixes a confusing user-interface behavior in Electrum's mobile/QML app. Previously, when a user typed the wrong password, the password dialog simply closed without explanation, which could make them think an action had happened. Now the dialog stays open and shows an 'Invalid Password' message. It is a straightforward usability improvement, not a security vulnerability fix.
AI review queuedqml: QEDaemon.setPassword to restore invariant wallets are unlockedby SomberNight · 6d9ec728 · Jan 19, 2026 · 2 filesMessage 73 · AdequateModerate 59Details
Commit message · SomberNight
qml: QEDaemon.setPassword to restore invariant wallets are unlocked
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This commit fixes a bug in Electrum's mobile/QML wallet interface where changing a wallet password could leave some loaded wallets in a 'locked' state. The fix restores the app's internal rule that all loaded wallets must stay unlocked. A locked wallet could temporarily block the user from spending or viewing balances until re-unlocked, but this appears to be a reliability/UX bug rather than a direct theft vulnerability.
AI review queuedwallet: minor clean-up and sanity checks for unlock/lockby SomberNight · 91f286b4 · Jan 19, 2026 · 1 fileMessage 81 · StrongLow 29Details
Commit message · SomberNight
wallet: minor clean-up and sanity checks for unlock/lock
- unlock() did not handle password=="" well instead of the caller converting the arg, as in https://github.com/spesmilo/electrum/commit/7113cec4c724c2a443031c71cc8d08fee5e2f385, it is more robust for the function itself to do it - get_unlocked_password() should never return an invalid password - add is_unlocked()
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit tightens up how Electrum wallets handle being 'unlocked' with a password. It makes the unlock() function itself treat an empty string the same as no password, ensures the function that returns the in-memory password validates it first, and adds a helper to check whether the wallet is currently unlocked. These are defensive sanity checks rather than fixes for a known active attack.
This must be an old regression. The GUI was not allowing to open a wallet that did not have a password set: it prompted for a password and did not accept any string (should at least accept empty "").
Without this, it was only possible to open a passwordless wallet if that was the first wallet the user opened (as otherwise we would overwrite the empty pw with the pw of the current wallet).
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Low 26/100
This commit fixes a user-interface bug in Electrum's QML (mobile-style) GUI that prevented users from opening wallets that have no password. Previously, the GUI would always ask for a password and reject an empty answer, making passwordless wallets impossible to open in many cases. The fix correctly distinguishes between 'no password provided' and 'an explicitly empty password was provided,' allowing passwordless wallets to open. This is a usability/functional bug, not a direct security vulnerability, though it could indirectly affect users who rely on passwordless wallets.
AI review queuedtests: add TestLNWallet to test lnwallet utilsby f321x · 562839c5 · Jan 8, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · f321x
tests: add TestLNWallet to test lnwallet utils
Adds new unittest file test_lnwallet.py to allow unittesting utility functions of LNWallet.
70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new automated test file for an existing Lightning wallet utility function. It does not change any production code, add new features, or fix any bugs. There is no security relevance.
AI review queuedqt: WalletInfoDialog: sort keystores by root fingerprintby f321x · fb96ba41 · Jan 8, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · f321x
qt: WalletInfoDialog: sort keystores by root fingerprint
Sort the keystore tabs of the WalletInfoDialog by their root fingerprints. This makes it less confusing when looking at different wallet instances of the same multisig setup as the tabs will always have the same order.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a minor user-interface improvement, not a security fix. It simply sorts the tabs shown in the wallet information window by the keystore's root fingerprint so that multi-signature wallet tabs appear in a consistent order across different computers. There is no vulnerability or security-relevant change here.
AI review queuedAddressSynchronizer: invalidate balance cache on spvby f321x · 663fcddc · Jan 7, 2026 · 1 fileMessage 85 · StrongInformational 24Details
Commit message · f321x
AddressSynchronizer: invalidate balance cache on spv
There was a race incorrectly counting transactions with one confirmations to the unconfirmed balance instead of the confirmed balance. This happened because the balance cache of AddressSynchronizer got invalidated after `on_event_blockchain_updated` and then again after `receive_history_callback`->`add_transaction`, however when calling `AddressSynchronizer.get_balance()` before the tx got spv verified the height would still be counted as 0 (unconfirmed), populating the balance cache again with the unconfirmed balance. I noticed this only on QML due to timing differences to Qt. Invalidating the cache in `AddressSynchronizer.add_verified_tx()` after the tx got verified causes the balance to get recalculated and shown correctly.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
This commit fixes a display-only bug in Electrum where, under certain timing conditions, a transaction that already had one blockchain confirmation could briefly be shown as 'unconfirmed' in the wallet balance. The fix adds a cache refresh right after a transaction is SPV-verified, so the balance is recalculated with the correct confirmation count. It does not allow theft, transaction manipulation, or remote code execution.
These better hold, lol: wallet.lnworker.wallet == wallet lnworker.wallet.lnworker == lnworker
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a test-only refactor in the Electrum Bitcoin wallet. It fixes how mock Lightning Network wallets are created in unit tests so that the test objects match the real structure (wallet.lnworker.wallet == wallet and lnworker.wallet.lnworker == lnworker). It does not change production wallet behavior or fix a security vulnerability in shipped code.
AI review queuedlnworker: split LNWallet and LNWorker: LNWallet "has an" LNWorkerby SomberNight · 1006e809 · Jan 5, 2026 · 17 filesMessage 83 · StrongInformational 18Details
Commit message · SomberNight
lnworker: split LNWallet and LNWorker: LNWallet "has an" LNWorker
- LNWallet no longer "is-an" LNWorker, instead LNWallet "has-an" LNWorker - the motivation is to make the unit tests nicer, and allow writing unit tests for more things - I hope this makes it possible to e.g. test lnsweep in the unit tests - some stuff we would previously have to write a regtest for, maybe we can write a unit test for, now - in unit tests, MockLNWallet now - inherits LNWallet - the Wallet is no longer being mocked
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit is a large internal refactoring of Electrum's Lightning code. It changes the relationship between a wallet and its Lightning worker so that the wallet 'has' a separate peer manager instead of 'being' one. The main goal is to make unit tests easier and more realistic. There is no obvious security vulnerability introduced, but one safety assertion about wallet ownership of a channel's remote output address was commented out with a 'FIXME' note, which is a small red flag.
The done_callback for the callback tasks in _run_htlc_switch_iteration tried to access mpp_sets by key but they might already have been deleted when the callback is called, causing an KeyError. Instead forward the exceptions to the crash reporter so we get notice of them and they get logged correctly.
``` 20251219T131356.946565Z | ERROR | asyncio | Exception in callback Peer._run_htlc_switch_iteration.<locals>.<lambda>(<Task finishe.../util.py:1773>) at /home/user/code/electrum-fork/electrum/lnpeer.py:2907 handle: <Handle Peer._run_htlc_switch_iteration.<locals>.<lambda>(<Task finishe.../util.py:1773>) at /home/user/code/electrum-fork/electrum/lnpeer.py:2907 created at /usr/lib64/python3.14/asyncio/events.py:94> source_traceback: Object created at (most recent call last): File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner self._context.run(self.run) File "/home/user/code/electrum-fork/electrum/util.py", line 1145, in run_with_except_hook run_original(*args2, **kwargs2) File "/usr/lib64/python3.14/threading.py", line 1024, in run self._target(*self._args, **self._kwargs) File "/home/user/code/electrum-fork/electrum/util.py", line 1705, in run_event_loop loop.run_until_complete(stopping_fut) File "/usr/lib64/python3.14/asyncio/base_events.py", line 706, in run_until_complete self.run_forever() File "/usr/lib64/python3.14/asyncio/base_events.py", line 677, in run_forever self._run_once() File "/usr/lib64/python3.14/asyncio/base_events.py", line 2038, in _run_once handle._run() File "/usr/lib64/python3.14/asyncio/events.py", line 94, in _run self._context.run(self._callback, *self._args) Traceback (most recent call last): File "/usr/lib64/python3.14/asyncio/events.py", line 94, in _run self._context.run(self._callback, *self._args) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/electrum-fork/electrum/lnpeer.py", line 2909, in <lambda> f"{self.lnworker.received_mpp_htlcs[pk]=}", exc_info=t.exception()) if t.exception() else None ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^ KeyError: '0000980000010001:1' ```
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Low 25/100
This commit fixes a bug in Electrum's Lightning payment handling. When a background callback task finished, the code tried to read a payment record that might already have been deleted, causing a KeyError. The fix removes that unsafe lookup and instead sends any callback failure to the crash reporter. It is a robustness fix rather than a security vulnerability; the error was noisy and could hide real callback failures, but there is no evidence it could be exploited to steal funds or bypass protections.
AI review queuedqml: OpenWalletDialog: load any wallet if password matchesby f321x · aee0f8fb · Dec 18, 2025 · 5 filesMessage 73 · AdequateLow 38Details
Commit message · f321x
qml: OpenWalletDialog: load any wallet if password matches
If the user has wallets with different passwords (non-unified pw) and enters a password on startup that fails to unlock the recently used wallet this change will automatically open any other wallet if there is another wallet that can be unlocked with this password.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 38/100
This commit changes the mobile/QML version of Electrum so that, when the app starts and the user's entered password does not unlock the most recently used wallet, the app will automatically try to open any other wallet on the device that can be unlocked with that same password. The goal is to help users who have multiple wallets with different passwords. However, it means a password intended for one wallet may silently open a different wallet, potentially showing balances, transaction history, and addresses the user did not expect. It also adds a stored config flag that remembers whether all wallets previously used the same password.
When closing the OpenWalletDialog without unlocking a wallet the LoadingWalletDialog wouldn't get properly cleaned up as the LoadingWalletDialog.visible was never set true. This causes the connections to accumulate and the callbacks won't get unregistered after closing the LoadingWalletDialog again.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit fixes a resource leak in Electrum's mobile-style QML user interface. If a user closed the wallet unlock dialog without actually unlocking a wallet, a hidden 'LoadingWalletDialog' would keep running in the background. Its internal signal connections would pile up and never be cleaned up, which could gradually slow down or destabilize the app. The fix explicitly destroys the dialog when it was never shown, so its cleanup code runs.
AI review queuedqml: show wallet list as root if no wallet is loadedby f321x · 70084750 · Dec 18, 2025 · 4 filesMessage 73 · AdequateInformational 15Details
Commit message · f321x
qml: show wallet list as root if no wallet is loaded
Shows Wallets.qml as root if no wallet is loaded and removes the logic for no loaded wallet from the WalletMainView as WalletMainView won't be shown anymore without a Daemon.currentWallet.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a user-interface cleanup for Electrum's mobile/QML app. It changes the app so that when no wallet is open, the user sees a wallet list screen instead of a 'no wallet loaded' placeholder inside the main wallet view. It also moves handling of incoming payment links (URI intents) from the wallet view to the top-level app so the link is not lost if a wallet isn't open yet. There is no security fix here.
AI review queuedqml: enforce single password on password changeby f321x · 02abc0e6 · Dec 18, 2025 · 1 fileMessage 68 · AdequateInformational 19Details
Commit message · f321x
qml: enforce single password on password change
If a qml user with non-uniform wallet passwords tries to change their wallet password this will force them to change it to a password that is used by at least one other wallet. This will guide them towards a single wallet password and prevents the number of different passwords from increasing.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit changes the mobile-style QML wallet settings screen so that when a user tries to change their wallet password, the app encourages (and on Android enforces) using the same password already used by another wallet. It is a user-experience/policy change, not a security fix or vulnerability. There is no evidence of a security bug being patched.
AI review queuedqml: disable 'Create Wallet' before first unlockby f321x · 378a9e61 · Dec 18, 2025 · 3 filesMessage 80 · StrongLow 30Details
Commit message · f321x
qml: disable 'Create Wallet' before first unlock
If the user has not unlocked any wallet yet and tries to create a new wallet in the overview a dialog will prompt them to first unlock an existing wallet in order to be able to create a new wallet.
This ensures they remember at least one password so they can complete the wizard. The wizard will ask them for an existing password later and it would be annoying for the user to go through all steps (writing down the seed etc.) only to find out they need a password they don't remember. This way they can reinstall the app right before going through the wizard.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 30/100
This commit changes the Electrum mobile/QML wallet interface so that users cannot create a new wallet until they have first unlocked an existing wallet. The goal is to prevent a frustrating situation where a user goes through the entire new-wallet setup (for example, writing down a recovery seed) and only afterward discovers they must enter an existing wallet password they have forgotten. The change also fixes a related state issue where the single-password setting was not being updated after a password change. There is no direct evidence in the commit that this fixes an active security vulnerability; it reads as a usability and defensive hardening improvement.
AI review queuedqml: enforce use of existing password for wallet creationby f321x · 3b028b06 · Dec 17, 2025 · 7 filesMessage 73 · AdequateInformational 19Details
Commit message · f321x
qml: enforce use of existing password for wallet creation
When creating a new wallet in a Electrum instance with existing wallets this change forces the user to reuse a password of any existing wallet if `SimpleConfig.WALLET_USE_SINGLE_PASSWORD` is True. This prevents the amount of different passwords from increasing and guides the user towards a single wallet password (the intended default).
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit is a hardening and usability change for Electrum's mobile/QML wallet creation wizard. When the app is configured to prefer a single password across wallets, it now forces the user to reuse an existing wallet password when creating a new wallet, instead of allowing a new password. It also renames an internal configuration flag and exposes helper functions to check how many wallets a password can unlock. There is no direct security vulnerability being patched; it is a defensive measure to reduce password fragmentation.
AI review queuedlnwatcher: follow-up prevby SomberNight · f339a6b7 · Dec 17, 2025 · 2 filesMessage 35 · OpaqueLow 32Details
Commit message · SomberNight
lnwatcher: follow-up prev
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 32/100
This commit is a small follow-up to a previous change in Electrum's Lightning watchtower code. It changes how the wallet decides whether to keep monitoring certain transactions, allowing the code to say 'keep watching but don't sweep yet' instead of always requiring an immediate sweep action. The commit itself does not appear to fix a clear exploit; it is more likely a correctness or robustness improvement to avoid premature decisions.
AI review queuedtransaction: tx_from_any: follow-up: only rm whitespaces from stringsby SomberNight · 16363cc3 · Dec 11, 2025 · 2 filesMessage 50 · ThinLow 37Details
Commit message · SomberNight
transaction: tx_from_any: follow-up: only rm whitespaces from strings
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 37/100
This commit tightens how Electrum cleans up transaction data before parsing. Previously, when given raw transaction bytes, the code would strip out any byte that looked like whitespace (such as tab or newline bytes). That is risky because a real Bitcoin transaction can legitimately contain bytes like 0x0a (which looks like a newline). The fix only removes whitespace from text strings, and only trims leading/trailing whitespace from byte inputs. It also improves an error message so raw bytes are shown safely. This is a defensive hardening change that prevents possible transaction misparsing or crashes, but the commit itself does not claim a specific exploit.
AI review queuedtx: replace whitespace chars in raw tx stringby f321x · 7d307048 · Dec 11, 2025 · 2 filesMessage 68 · AdequateInformational 23Details
Commit message · f321x
tx: replace whitespace chars in raw tx string
Removes all whitespace characters from a raw transaction string. This is useful for example when loading raw transactions from text input as it happens that there are some newline characters in the text. I noticed this when copying-pasting from a timelock recovery pdf.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 23/100
This commit changes how Electrum cleans up raw Bitcoin transaction text that users paste into the wallet. Previously it only trimmed whitespace from the beginning and end. Now it removes all whitespace characters (including newlines and spaces) anywhere inside the string. This is a usability fix for copy-pasting transactions from documents such as a timelock recovery PDF. It is not a security patch, but it slightly reduces the chance that a malformed or trick pasted transaction could behave unexpectedly.