qt: WalletInfoDialog: sort keystores by root fingerprint
What the developer wrote
Authored by f321x
qt: WalletInfoDialog: sort keystores by root fingerprint
Sort the keystore tabs of the WalletInfoDialog by their root
fingerprints. This makes it less confusing when looking at different
wallet instances of the same multisig setup as the tabs will always have
the same order.
What changed, and why it matters
This commit is a minor user-interface improvement, not a security fix. It simply sorts the tabs shown in the wallet information window by the keystore's root fingerprint so that multi-signature wallet tabs appear in a consistent order across different computers. There is no vulnerability or security-relevant change here.
No security action needed. Treat as a normal UI/usability patch.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change replaces wallet.get_keystores() with sorted(wallet.get_keystores(), key=lambda _ks: _ks.get_root_fingerprint() or '') in the Qt WalletInfoDialog. This sorts the displayed keystore tabs deterministically by root fingerprint. The commit message explicitly describes this as a usability improvement to reduce confusion when comparing multisig wallet instances. No security boundary is crossed, no input is newly trusted, and no cryptographic or wallet logic is modified.
Changed components
electrum/gui/qt/wallet_info_dialog.pyInspect captured patch +1 / −1
diff --git a/electrum/gui/qt/wallet_info_dialog.py b/electrum/gui/qt/wallet_info_dialog.py
index b194f07..4c3912d 100644
--- a/electrum/gui/qt/wallet_info_dialog.py
+++ b/electrum/gui/qt/wallet_info_dialog.py
@@ -112,7 +112,7 @@ class WalletInfoDialog(WindowModalDialog):
labels_clayout = None
if wallet.is_deterministic():
- keystores = wallet.get_keystores()
+ keystores = sorted(wallet.get_keystores(), key=lambda _ks: _ks.get_root_fingerprint() or '')
self.keystore_tabs = QTabWidget()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.