Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedMerge pull request #11090 from accumulator/self_dirty_qetransactionlistmodelby accumulator · 57e11ce0 · Oct 29, 2026 · 3 filesMessage 73 · AdequateInformational 22Details
Commit message · accumulator
Merge pull request #11090 from accumulator/self_dirty_qetransactionlistmodel
qml: mark self dirty for qetransactionlistmodel
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 22/100
This commit is a code-quality refactor for Electrum's QML (mobile/light desktop) user interface. It moves responsibility for refreshing the transaction history list from one UI component into the transaction list model itself, and adds explicit 'mark dirty' calls when addresses are deleted. There is no direct evidence in the commit of a security vulnerability being fixed; it appears to address stale or missing UI updates in the transaction history view.
AI review queuedMerge pull request #11089 from f321x/qml_listmodel_parentby accumulator · a23a58b9 · Oct 28, 2026 · 2 filesMessage 73 · AdequateInformational 18Details
Commit message · accumulator
Merge pull request #11089 from f321x/qml_listmodel_parent
qml: set parent on list models created by QEWallet and QEAddressDetails
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This change is a small cleanup in Electrum's mobile-style QML user interface. It makes several on-screen data lists (transaction history, addresses, payment requests, invoices, and Lightning channels) properly declare their parent UI object. In Qt/QML, setting a parent helps ensure child objects are cleaned up when the parent is destroyed, which can prevent memory leaks or stale references. There is no direct evidence in the commit that this fixes an active security vulnerability, but it improves object lifetime hygiene and could indirectly prevent UI-related crashes or use-after-free issues.
AI review queuedqml: qetransactionlistmodel: refresh on payment_succeeded, request_status callbacksby Sander van Grieken · 75240bce · Oct 28, 2026 · 3 filesMessage 50 · ThinInformational 17Details
Commit message · Sander van Grieken
qml: qetransactionlistmodel: refresh on payment_succeeded, request_status callbacks
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100
This commit is a UI refresh fix for the Electrum mobile/QML wallet. It moves responsibility for updating the transaction history list from one wallet component to the transaction list model itself, and adds refresh triggers when a Lightning payment succeeds or a payment request is paid. It also fixes a minor typo where the wrong wallet variable was used when checking whether an address can be deleted. There is no direct security vulnerability here; it is a correctness and consistency improvement for the user interface.
AI review queuedqml: qetransactionlistmodel mark self dirty on tx eventsby f321x · 11800932 · Oct 28, 2026 · 2 filesMessage 81 · StrongInformational 18Details
Commit message · f321x
qml: qetransactionlistmodel mark self dirty on tx events
Only QEWallet marked its own history model dirty and refreshed it, so any other QETransactionListModel, like the per-address history model of QEAddressDetails, was never refreshed after it got created. Removing a local tx left it in the address history and new txs never showed up.
Move the dirty tracking on {new,removed}_transaction and adb_tx_height_changed, and the refresh on wallet_updated, from QEWallet into the model, as done for the address/coin list model in c74e790b5. Lightning history changes don't come with tx events (#9856), so only models including lightning are marked dirty on every wallet_updated.
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit fixes a user-interface bug in Electrum's mobile/QML wallet view. Previously, address-specific transaction lists were not refreshed when transactions arrived, were removed, or changed confirmation status, so stale or missing entries could remain on screen. The fix moves the refresh logic into the transaction list model itself so all such lists update correctly. There is no indication this is a security vulnerability.
AI review queuedqml: set parent on list models created by QEWallet and QEAddressDetailsby f321x · 831041b0 · Oct 28, 2026 · 2 filesMessage 73 · AdequateInformational 21Details
Commit message · f321x
qml: set parent on list models created by QEWallet and QEAddressDetails
The list models were created without a QObject parent, so their lifetime was only tied to the Python reference. Parent them to the owning object so they are destroyed (and unregister their callbacks) together with it, e.g. when an AddressDetails page is closed.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This change fixes how certain list-like data objects in Electrum's mobile-style QML interface are tied to their parent screens. Previously, these objects were only kept alive by Python references and might not be cleaned up promptly when a wallet or address details page was closed. By giving them a proper parent object, they are destroyed together with the page, which also removes their internal callback hooks. This is a cleanup and stability improvement rather than a direct fix for an active exploit, but poor object lifetime management can sometimes lead to crashes or subtle bugs.
AI review queuedMerge pull request #11088 from accumulator/self_dirty_qeaddresslistmodelby accumulator · 31121bef · Oct 28, 2026 · 2 filesMessage 73 · AdequateInformational 17Details
Commit message · accumulator
Merge pull request #11088 from accumulator/self_dirty_qeaddresslistmodel
qml: qeaddresslistmodel mark self dirty on {new,removed}_transaction events
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 17/100
This commit moves responsibility for refreshing an address list in Electrum's QML (mobile-style) user interface. Previously, the wallet object told the address list to refresh when transactions arrived or were removed. Now the address list listens for those events itself and refreshes. This is a code-quality/refactoring change with no visible security impact.
Lower-priorityMerge pull request #11086 from f321x/qml_unknown_txid_callersby accumulator · eac1dd99 · Oct 28, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · accumulator
Merge pull request #11086 from f321x/qml_unknown_txid_callers
qml: Addresses: refresh coin list when the page becomes visible again
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedqml: qeaddresslistmodel mark self dirty on {new,removed}_transaction eventsby Sander van Grieken · c74e790b · Oct 28, 2026 · 2 filesMessage 50 · ThinInformational 17Details
Commit message · Sander van Grieken
qml: qeaddresslistmodel mark self dirty on {new,removed}_transaction events
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100
This commit is a small UI cleanup in Electrum's QML (mobile/desktop modern interface) code. It moves responsibility for refreshing the address list when transactions arrive or are removed from one file to another, so the address list model refreshes itself instead of relying on the wallet object to tell it to refresh. There is no indication this fixes a security vulnerability; it appears to be a maintainability or correctness fix for UI consistency.
Lower-priorityREADME: (trivial) make code snippet copy-pasteableby SomberNight · f19be3b7 · Oct 28, 2026 · 1 fileMessage 50 · ThinTriage 0Details
Commit message · SomberNight
README: (trivial) make code snippet copy-pasteable
make clear comment is not syntax
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
Lower-priorityMerge pull request #11057 from accumulator/fix_oldtaskgroup_leaks_sibling_task_exceptionsby Felix · d9793703 · Oct 28, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Felix
Merge pull request #11057 from accumulator/fix_oldtaskgroup_leaks_sibling_task_exceptions
util: fix OldTaskGroup leaking task exceptions.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
For TxOutput we allow to click on is_mine addresses in the QML GUI TxDetails view to open the address. For TxInput this was not implemented, which is confusing to the user and asymmetric. I don't see a reason why TxInput shouldn't support this as well.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Lower-priorityMerge pull request #11037 from accumulator/qml_txdetails_error_stateby Felix · bf9447cc · Oct 28, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · Felix
Merge pull request #11037 from accumulator/qml_txdetails_error_state
txdetails: add 'error' property, which gets set when txid is not found
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #11079 from f321x/fix_wayland_appimageby ghost43 · af9a710e · Oct 26, 2026 · 2 filesMessage 73 · AdequateTriage 0Details
Commit message · ghost43
Merge pull request #11079 from f321x/fix_wayland_appimage
build: appimage: fix wayland, rm unused libs
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #11075 from f321x/interface_skip_stale_header_notifsby ghost43 · c3537cf0 · Oct 26, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · ghost43
Merge pull request #11075 from f321x/interface_skip_stale_header_notifs
interface: skip stale header notifications in run_fetch_blocks
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
release notes: 4.8.3: add links to security disclosures
55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
AI review queuedMerge pull request #11072 from SomberNight/202610_fixesby ghost43 · b774e151 · Oct 23, 2026 · 9 filesMessage 58 · ThinHigh 80Details
Commit message · ghost43
Merge pull request #11072 from SomberNight/202610_fixes
adb/txbatcher: assorted fixes
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · High 80/100
This commit hardens Electrum so that incoming transactions spending the user's own coins are checked for valid signatures before being accepted into the wallet. Previously, a malicious or buggy server could feed the wallet a transaction that appeared to spend the user's funds but had an invalid or forged signature, causing balance confusion, incorrect history, or unsafe follow-on transactions. The patch also fixes related bugs in the transaction-batching (RBF) code so the wallet does not accidentally pay outputs introduced by someone else's transaction replacement.
Lower-priorityMerge pull request #11073 from f321x/regtest_ex_2_0by ghost43 · 6a3e548c · Oct 23, 2026 · 3 filesMessage 83 · StrongTriage 0Details
Commit message · ghost43
Merge pull request #11073 from f321x/regtest_ex_2_0
test: regtest: update regtest to e-x 2.0
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #11074 from f321x/bump_appimage_alpine_depsby ghost43 · 7efcefba · Oct 23, 2026 · 1 fileMessage 73 · AdequateTriage 0Details
Commit message · ghost43
Merge pull request #11074 from f321x/bump_appimage_alpine_deps
contrib: appimage: fix type2-runtime build: bump musl-dev, base image
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
contrib: appimage: fix type2-runtime build: bump musl-dev, base image
musl-dev=1.2.6-r2 is no longer available in the alpine 3.24 repo, which breaks the type2-runtime build container. Bump it to 1.2.6-r3 and bump the pinned alpine:3.24 base image (3.24.3) which ships the matching musl.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI review queuedinterface: skip stale header notifications in run_fetch_blocksby f321x · c009a3a0 · Oct 23, 2026 · 1 fileMessage 73 · AdequateInformational 18Details
Commit message · f321x
interface: skip stale header notifications in run_fetch_blocks
run_fetch_blocks processed every queued headers notification in turn, each one costing a backward search and a catch-up request. Only the newest notification matters, as _process_header_at_tip fetches any missing headers up to it, so drop the older ones.
This showed up on regtest when bitcoind mines slowly (slow fsync): for `new_blocks 300` e-x sent a notification every ~5 blocks, and as its padded transport holds small responses for up to 1s, catching up took ~100s, timing out test_lnwatcher_waits_until_fees_go_down. With this change it takes ~2s.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100
This commit is a performance optimization, not a security fix. It changes how Electrum handles notifications about new Bitcoin blocks so that if several notifications pile up, only the newest one is processed. This avoids wasting time re-checking older blocks and prevents test timeouts on slow systems. There is no indication it fixes a vulnerability or protects against an attack.
AI review queuedci: regtest: bump electrumx to 2.0.0by f321x · 1bf86a3c · Oct 23, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · f321x
ci: regtest: bump electrumx to 2.0.0
Use the latest electrumx release in the regtest CI. Since 2.0.0 plyvel is no longer a default dependency, so install the leveldb extra.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
This is a routine update to Electrum's automated testing setup. It changes which version of ElectrumX (a separate server component used only in tests) is installed during continuous integration runs. There is no user-facing change and no security issue visible in the commit.
Add the flags required by electrumx 2.0 to the regtest config so the regtest tests can be run with the new e-x version.
70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Lower-priorityMerge pull request #11059 from f321x/release_4_8_3by ThomasV · 03cc401c · Oct 23, 2026 · 2 filesMessage 58 · ThinTriage 0Details
Commit message · ThomasV
Merge pull request #11059 from f321x/release_4_8_3
release notes for 4.8.3
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
merge-commit duplicate discount
AI review queuedMerge pull request #11068 from f321x/get_full_history_labelsby ghost43 · 3dbf0ba8 · Oct 23, 2026 · 2 filesMessage 73 · AdequateInformational 18Details
Commit message · ghost43
Merge pull request #11068 from f321x/get_full_history_labels
wallet: use db instead of adb in _get_default_label_for_txid (speedup history)
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This is a small performance optimization in the Electrum Bitcoin wallet. It swaps which internal database object is used when fetching transaction data for history labels and address display. There is no obvious security bug introduced by the change itself.
Security candidateMerge "verify_sigs": adb: check sigs of is_mine txins of unconf txsby SomberNight · 90fe3082 · Oct 23, 2026 · 7 filesMessage 83 · StrongCritical 90Details
Commit message · SomberNight
Merge "verify_sigs": adb: check sigs of is_mine txins of unconf txs
verify signatures of wallet.is_mine inputs for mempool txs only
PR: SE#1 (first 3 commits)
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Critical 90/100
This commit fixes a security flaw in the Electrum Bitcoin wallet where a malicious server could silently replace a transaction the user just broadcast with a fake version that spent the user's coins. Because the wallet trusted server-provided transaction data without checking signatures on inputs that spend the user's own coins, it could be tricked into thinking the fake transaction was valid. The attacker could then lure the user into using RBF (Replace-By-Fee) to 'bump' the fake transaction, which actually signed and sent the user's funds to the attacker. The vendor reports two victim reports and at least one loss of funds. The fix makes the wallet verify signatures for any input that spends coins belonging to the user before accepting a transaction, and it holds back server-claimed 'mined' transactions until they are independently verified.