EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Repository coverage

935 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

67security candidates208second-pass queue929AI analyses
61commits · 30 days
116commits · 60 days
465commits · 180 days
931commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

65/100 average clarity
194Strong · 80–100
415Adequate · 60–79
287Thin · 40–59
39Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV73272156
SomberNight35226350063
f321x37121371070
Sander van Grieken991098057
user323062
Roman Zeyde515053
Sasha Zykov414076
Aaron Fiore414068
ghost43312068
Róbert Nagy111098
Ferdinando Ametrano111096
Felix302074
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 15 AI analysisMessage 63 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10816 from accumulator/qml_auth_log_improvement

This commit is a minor logging cleanup in the mobile/QML authentication helper. It changes the wording and placement of debug/error log messages so they reveal the function name only after safely retrieving it, and avoids logging a raw tup…

8dddae68by ghost43+4−41 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10798 from SomberNight/202608_base43

This commit fixes a performance weakness in Electrum's handling of large Bitcoin transactions encoded in 'base43'. The base43 encoding and decoding functions run in quadratic time, meaning the work grows much faster than the input size. An…

Quadratic-time base43 encode/decode can be triggered on attacker-controlled inputDenial-of-service via CPU exhaustion / UI freeze on large transaction stringsInput-length cap added as a defensive guard, not a full algorithmic fix
0e9f1a0dby Felix+25−92 files
No security note in commit
Low 41 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10799 from SomberNight/202608_android_secure_window

This update tightens a privacy feature on Electrum's Android app that prevents the screen from being captured while sensitive Bitcoin private keys or seed phrases are visible. Before, the protection could be accidentally turned off when mu…

Adds visibility-gated secureWindow bindings to protect WIF keys and seed phrasesPrevents secureWindow from being cleared when multiple sensitive dialogs are stackedTargets Android screenshot/recents-thumbnail protection surface
4622390cby accumulator+17−05 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 98 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

docs: add Coldcard Mk3 seed-entropy security notice to plugin README (#10805)

This commit only adds a documentation warning to Electrum's Coldcard plugin README. It does not change any executable code, cryptographic logic, or wallet behavior. The warning tells users that Coldcard/Coinkite disclosed a firmware bug in…

Documentation-only changeReferences an external hardware-wallet firmware advisoryNo code, cryptography, or plugin behavior modified
2c2a40b6by Róbert Nagy+4−01 file
Vendor flagged security relevance
Low 48 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

qml/android: protect WIF keys from screenshots in more places

This commit tightens screen-shot protection for private Bitcoin wallet keys (WIF keys and seed phrases) in Electrum's Android/QML user interface. It also fixes a bug where one screen (AddressDetails) was leaving the 'secure window' flag pe…

Adds FLAG_SECURE-style screenshot protection to additional private-key dialogsFixes a bug where secureWindow was never unset in AddressDetailsUses QML Binding 'when' with restoreMode semantics to handle stacked secure dialogs safely
739cba5dby SomberNight+17−05 files
Vendor flagged security relevance
Moderate 60 AI analysisMessage 92 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

lnpeer: chan_reest: ctn overflow: force-close instead of disconnect

This commit fixes a bug in Electrum's Lightning Network code. Previously, if a malicious or malfunctioning peer sent a channel re-establishment message with extremely large commitment numbers (over 2^48), the local program would hit an int…

Addition of explicit overflow check on untrusted peer-supplied commitment countersReplacement of assertion-failure/disconnect behavior with force-close on misbehaviorNew test cases for ctn overflow in both next_local_ctn and oldest_unrevoked_remote_ctn
b3e441f8by SomberNight+22−32 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10791 from SomberNight/202608_wallet_sign_message2

This change moves the trimming of leading/trailing spaces in message-signing fields from the user-interface code into the shared wallet code. For the graphical interfaces (Qt and QML), spaces are still stripped automatically for convenienc…

Behavior change in message signing/verification input handlingCLI now preserves whitespace, which could affect signature validity for messages that intentionally contain leading or trailing whitespaceNo memory-safety, cryptographic, or authentication flaw visible in the diff
b1aa52d7by ghost43+27−185 files
No security note in commit
Informational 19 AI analysisMessage 96 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

wallet: sign_message: strip whitespaces in GUIs, do not strip in CLI

This commit tidies up how Electrum handles extra spaces around Bitcoin addresses, messages, and signatures when signing or verifying messages. Previously, different parts of the program (desktop GUI, mobile-style GUI, command line) behaved…

Behavior normalization across GUI and CLI interfacesNo cryptographic primitive changedNo privilege boundary crossed
4c3064f5by SomberNight+27−185 files
No security note in commit
Informational 22 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

wallet: decrypt_message: nicer error msg if pubkey is unrelated

This commit improves the error handling in Electrum's message decryption feature. Previously, if a user tried to decrypt a message using a public key that did not belong to their wallet, the code could proceed and likely fail with a confus…

Input validation added for public key before cryptographic operationUser-facing exception replaces potential internal failureDefensive check prevents use of unrelated key material
92e938f4by SomberNight+5−01 file
No security note in commit
Informational 16 AI analysisMessage 83 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

qt: main_window: use TaskThread for each of sign/verify/encrypt/decrypt

This commit moves four message-crypto operations (sign, verify, encrypt, decrypt) in Electrum's Qt wallet window onto a background worker thread so they all behave the same way. It also lets the background thread surface user-facing errors…

Moved blocking wallet crypto calls off the GUI thread, reducing UI freeze / DoS surfaceRemoved local exception swallowing for encrypt_message; errors now propagate through the window's on_error handlerAdded defensive RuntimeError guard for deleted Qt widget in async callback
4a9a199fby SomberNight+28−151 file
No security note in commit
Low 29 AI analysisMessage 35 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

wallet: sign_message: force kwargs

This commit changes how Electrum's message-signing function is called so that callers must explicitly name each argument (address, message, password) rather than passing them by position. The main practical effect is to prevent accidental …

API hardening: keyword-only arguments prevent positional argument swapNo explicit security bug fix or vulnerability disclosure in commit message or diffNo changes to cryptographic logic, password handling, or message parsing
e1eb2a34by SomberNight+9−44 files
No security note in commit
Low 39 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

wallet: sign_message: consolidate checks from UIs

This commit moves input-validation checks for signing, verifying, encrypting, and decrypting messages out of the user-interface code and into the shared wallet logic. It also adds type checks so that non-text inputs are rejected earlier. T…

Input validation moved from UI controllers into core wallet logicType checks added at the CLI command entry points for message-crypto operationsUserFacingException used consistently for address, wallet, script-type, and key-format errors
48893760by SomberNight+89−396 files
No security note in commit
Low 27 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

wallet: decrypt_message: consolidate checks from UIs

This commit moves input-validation and wallet-type checks for message decryption out of the user-interface and command-line layers and into the core wallet code. It also removes a faster, separate decryption path for imported wallets so al…

Input validation consolidated into a single core methodWatching-only wallet check moved from UI to wallet layerMultisig wallet unsupported-operation check moved from UI to wallet layer
9a0cc0d6by SomberNight+25−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

wallet: refactor: add encrypt_message method, consolidated from UIs

This commit is a simple code cleanup: it moves the message-encryption logic from two separate places (the command-line tool and the Qt graphical interface) into a single shared method on the wallet class. The actual encryption behavior is …

No change to cryptographic primitives or parametersNo change to trust boundaries or input sourcesPure refactor consolidating duplicate code
5e9c8df0by SomberNight+26−183 files
No security note in commit
Informational 13 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

wallet: refactor: add verify_message method, consolidated from UIs

This commit is a routine code cleanup: it moves message-signature verification out of three user-interface files into a single shared helper method in the wallet module. There is no security-relevant behavior change visible in the diff. Th…

No security-relevant functional changeRefactoring only: code deduplicationException handling broadened safely (ValueError covers binascii.Error and unicode errors)
ff5bbb04by SomberNight+26−304 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: main_window: add type hints to sign/verify, encrypt/decrypt

This commit only adds Python type hints and renames some function parameters for clarity in the Electrum desktop wallet's sign/verify and encrypt/decrypt message dialogs. It does not change what the code actually does, how it processes use…

0906fc20by SomberNight+45−181 file
No security note in commit
Informational 18 AI analysisMessage 50 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

coldcard: fix get_soft_device_id() discarding its return value

This is a tiny one-line bug fix in Electrum's Coldcard hardware wallet plugin. A helper method that is supposed to fetch a software-based device identifier was calling the parent implementation but accidentally throwing away the result ins…

Missing return value causes method to always return NoneAffects hardware wallet device identification onlyNo change to signing, encryption, or authentication code
d7500508by Felipe Micaroni Lalli+1−11 file
No security note in commit
Informational 19 AI analysisMessage 96 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

qml: strip whitespace from message before signing, as in qt gui

This commit fixes a minor consistency bug in Electrum's newer QML (mobile-style) user interface. When signing a message, the app now removes accidental spaces at the start or end of the message and address, just like the older desktop Qt i…

Behavioral inconsistency between GUI implementations could cause user confusion or failed verificationNo cryptographic weakness introduced; change is input normalizationNo memory-unsafe code, no privilege changes, no network changes
72507328by Ferdinando Ametrano+3−01 file
No security note in commit
Low 48 AI analysisMessage 85 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

config: don't save "hidden wallet" paths in CURRENT_WALLET cv

This commit fixes a privacy leak in the Electrum wallet app. Previously, if a user opened a 'hidden wallet' (one whose filename starts with a dot, like a secret file), Electrum would remember it as the last-used wallet and could reopen it …

Privacy leak: hidden wallet filename persisted in config and could be auto-reopenedInformation disclosure: hidden wallet path exposed in recently-opened listBehavioral fix: setter silently drops sensitive value rather than persisting it
c43cf8e4by SomberNight+14−23 files
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

lnrouter: liquidity hints: add extra penalty if amt near cannot_send

This commit tweaks how Electrum's Lightning Network payment routing avoids channels where a previous payment attempt already failed. Previously, the router would treat a channel almost at its known failure limit almost the same as a channe…

Routing/liquidity-hint logic changed to penalize amounts close to a known cannot_send thresholdAdds defensive assertions on num_inflight_htlcs type and rangeSelf-described by author as a 'completely naive bandaid' / heuristic improvement
ee75ea31by SomberNight+12−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedwallet_db: convert_version_66: trivial simplificationby SomberNight · 745318d1 · Dec 10, 2025 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · SomberNight

wallet_db: convert_version_66: trivial simplification

40/100 · ThinMessage clarity
✓ Specific, descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a one-line code cleanup that changes how a constant number is written. The value 147712 is rewritten as 0x24100, which is the exact same number in hexadecimal notation. A comment is also slightly reordered. There is no functional change and no security relevance.

AI review queuedledger: throw UserFacingException for OSErrorby f321x · aa47a960 · Dec 10, 2025 · 1 fileMessage 80 · StrongInformational 18Details
Commit message · f321x

ledger: throw UserFacingException for OSError

Throws UserFacingException if the communication with the ledger fails
due to an OSError. This happens e.g. if the Bitcoin app has been closed.
We shouldn't get crash reports for errors due to disconnection.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100

This is a small user-experience fix for Electrum's Ledger hardware wallet plugin. When the Ledger device disconnects or its Bitcoin app is closed during use, the software previously generated an internal crash report. Now it shows a friendly on-screen message instead. There is no indication this change fixes a security vulnerability or introduces one.

Lower-prioritylnchannel: allow deleting unfunded incoming channelsby f321x · c34efce9 · Dec 10, 2025 · 4 filesMessage 73 · AdequateLow 28Details
Commit message · f321x

lnchannel: allow deleting unfunded incoming channels

We tried to delete incoming channels that didn't get funded after
lnutil.CHANNEL_OPENING_TIMEOUT, however an assert prevented this:

```
3.63 | E | lnwatcher.LNWatcher.[default_wallet-LNW] | Exception in check_onchain_situation: AssertionError()
Traceback (most recent call last):
File "/home/user/code/electrum-fork/electrum/util.py", line 1233, in wrapper
return await func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/code/electrum-fork/electrum/lnwatcher.py", line 117, in check_onchain_situation
await self.update_channel_state(
...<5 lines>...
keep_watching=keep_watching)
File "/home/user/code/electrum-fork/electrum/lnwatcher.py", line 135, in update_channel_state
chan.update_onchain_state(
~~~~~~~~~~~~~~~~~~~~~~~~~^
funding_txid=funding_txid,
^^^^^^^^^^^^^^^^^^^^^^^^^^
...<2 lines>...
closing_height=closing_height,
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
keep_watching=keep_watching)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/code/electrum-fork/electrum/lnchannel.py", line 341, in update_onchain_state
self.update_unfunded_state()
~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/user/code/electrum-fork/electrum/lnchannel.py", line 382, in update_unfunded_state
self.lnworker.remove_channel(self.channel_id)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
File "/home/user/code/electrum-fork/electrum/lnworker.py", line 3244, in remove_channel
assert chan.can_be_deleted()
~~~~~~~~~~~~~~~~~~~^^
AssertionError
```

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 28/100

This commit fixes a bug where Electrum could not clean up incoming Lightning channels that never received their on-chain funding transaction. Previously, an internal safety check (assert) blocked deletion, causing repeated crashes in the background watcher. The patch adds proper timeout logic so these stale, unfunded channels can be removed safely. It is a reliability/DoS fix rather than a direct theft-of-funds vulnerability.

Lower-priorityqt: lnurlw: catch UserCancelled on lnurlw withdrawalby f321x · e1f1e6f7 · Dec 10, 2025 · 1 fileMessage 65 · AdequateInformational 17Details
Commit message · f321x

qt: lnurlw: catch UserCancelled on lnurlw withdrawal

Catch the UserCancelled exception if the user cancels the lnurlw
coroutine dialog during the withdrawal.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 17/100

This is a minor user-interface fix. When a user starts a Lightning LNURL-withdrawal in the Electrum desktop app and then clicks Cancel, the app now quietly handles that cancellation instead of possibly showing an unhandled error. It does not create a security vulnerability; it improves the user experience by suppressing a harmless exception.

Lower-prioritylnurlw: accept "null" minWithdrawable in responseby f321x · 4bd013ef · Dec 10, 2025 · 1 fileMessage 68 · AdequateInformational 19Details
Commit message · f321x

lnurlw: accept "null" minWithdrawable in response

Accept a `null` value as response for the `minWithdrawable` field in the
lnurlw response. Some servers seem to set this to `null` instead of 0
when having no minimum withdrawal amount.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This is a tiny compatibility fix for the Electrum Bitcoin wallet's handling of LNURL-withdraw (a way to withdraw bitcoins from a service). Some LNURL servers send a 'null' value for the minimum withdrawal amount instead of the number 0. Previously, Electrum would crash when converting 'null' to an integer. The change treats 'null' as 0 so the wallet can continue. It is not a security fix and does not introduce an obvious vulnerability.

Lower-prioritytests: lnpeer: add test_reject_mpp_for_non_mpp_invoiceby f321x · 7c01d9db · Dec 10, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · f321x

tests: lnpeer: add test_reject_mpp_for_non_mpp_invoice

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a new automated test to Electrum's Lightning networking code. It checks that a multi-part payment (MPP) is rejected when the recipient's invoice did not advertise support for MPP. There is no change to production code, no bug fix, and no security patch in the diff itself.

Lower-prioritylnpeer: fail htlcs if we get unwanted mppby f321x · 183d426e · Dec 10, 2025 · 2 filesMessage 60 · AdequateModerate 59Details
Commit message · f321x

lnpeer: fail htlcs if we get unwanted mpp

Fail incoming htlcs if we receive a payment consisting of multiple parts
if we signaled to not want mpp in the invoice.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Moderate 59/100

This commit fixes a bug in Electrum's Lightning payment receiving code. Previously, a merchant could create an invoice that said 'do not pay me using multiple payment parts (MPP)', but Electrum would still accept such multi-part payments anyway. The patch makes Electrum reject those unwanted multi-part payments. This matters because accepting MPP when it was not requested could let a payer split a payment in ways the receiver did not expect, potentially causing accounting confusion, channel fee issues, or problems with just-in-time (JIT) channel opening, which only supports single-part payments.

AI review queuedlnworker: add invoice features to PaymentInfo classby f321x · 125a921c · Dec 10, 2025 · 3 filesMessage 73 · AdequateLow 34Details
Commit message · f321x

lnworker: add invoice features to PaymentInfo class

Adds the invoice features to the `PaymentInfo` class so we can check if
the sender respects our requested features (e.g. if they tried to send
mpp if we requested no mpp).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 34/100

This commit changes how Electrum stores and uses Lightning invoice features. It records which features (like multi-part payments, or MPP) were advertised in an invoice, so the wallet can later check whether the sender followed those rules. The change also fixes a minor bug where the wallet read from the wrong config object. There is no direct evidence in the commit that this fixes an active exploit, but it is a defensive hardening change that prevents a sender from ignoring the receiver's invoice rules.

AI review queuedlnworker: use channel_id instead of scid in ReceivedMPPHtlcby f321x · 5be598b8 · Dec 9, 2025 · 4 filesMessage 73 · AdequateLow 32Details
Commit message · f321x

lnworker: use channel_id instead of scid in ReceivedMPPHtlc

Store the channel id instead of the scid in ReceivedMPPHtlc.
The scid can be None, in theory even for multiple channels at the same
time. Using the channel_id which is always available and unique seems
less error prone at the cost of temporarily higher storage requirements
in the db for the duration of the pending htlcs.

Alternatively we could use the local scid alias however using the
channel_id seems less complex and leaves less room for ambiguity.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 32/100

This commit changes how Electrum's Lightning wallet internally tracks incoming multi-part payments. Instead of using the short channel ID (which can be missing or ambiguous), it now uses the permanent channel ID. The change includes a database upgrade to convert old stored data. The commit message frames this as a robustness improvement, not a security fix, but the scenario it addresses—multiple channels lacking short IDs—could theoretically lead to mis-routing or incorrect handling of pending payments.

Lower-prioritylnworker: add type assert to get_channel_by_short_idby f321x · 8a88ebe6 · Dec 9, 2025 · 1 fileMessage 65 · AdequateLow 29Details
Commit message · f321x

lnworker: add type assert to get_channel_by_short_id

Prevents accidentally passing None if channel.short_id is not set yet

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 29/100

This commit adds a safety check to a Lightning Network function so it refuses to accept an empty or wrong-type channel identifier. The change is defensive: it turns a silent 'no match found' return value into an immediate crash if a caller accidentally passes an invalid identifier. There is no direct evidence in the commit that this fixes an active security vulnerability or real-world exploit.

Lower-prioritylnworker: write rationale for PaymentInfo class in docstringby SomberNight · 6d1e8e86 · Dec 8, 2025 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · SomberNight

lnworker: write rationale for PaymentInfo class in docstring

ref https://github.com/spesmilo/electrum/commit/4ad9caddab3fe5d3b25fc53d7ffa7ccf5cbd3b6c
ref https://github.com/spesmilo/electrum/commit/f08e5541aeda9524eb456477f93732de7357c792

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit only adds explanatory comments (a docstring) to a data class used in Electrum's Lightning payment handling. It does not change any code behavior, fix any bug, or alter any security mechanism. There is no security issue here.

Lower-prioritylnpeer: deduct JIT fees also for trampolineby ThomasV · da998150 · Dec 6, 2025 · 1 fileMessage 45 · ThinLow 41Details
Commit message · ThomasV

lnpeer: deduct JIT fees also for trampoline

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 41/100

This is a one-line fix in Electrum's Lightning Network code. It adjusts when Electrum considers the first part of a trampoline payment 'complete' by subtracting JIT (just-in-time) channel opening fees from the amount being forwarded. Without the fix, a trampoline payment stage could be incorrectly marked complete too early, potentially causing accounting or routing issues. The commit message frames it as a bug fix, not a security issue, and no security impact is directly stated.

Lower-prioritylnpeer: deduct jit channel fees from total amountby f321x · fb566eb5 · Dec 6, 2025 · 2 filesMessage 76 · AdequateModerate 59Details
Commit message · f321x

lnpeer: deduct jit channel fees from total amount

Deduct the just in time channel opening fees from the total amount so
htlcs don't get timed out if they come from a just in time channel with
opening fee.

Related: https://github.com/spesmilo/electrum/pull/9584

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Moderate 59/100

This commit fixes a bug in Electrum's Lightning payment handling for 'just-in-time' (JIT) channels. When a payment arrives through a JIT channel, the channel opener charges an opening fee. Previously, the code did not properly subtract this fee when checking whether the full payment amount had been received. This could cause multi-part payments to time out or fail even though the sender had sent enough money, because the receiver's accounting compared the raw amount received against the invoice total without accounting for the fee already taken by the JIT channel. The patch renames the fee field for clarity and deducts the JIT opening fee from the total before deciding whether the payment is complete.

AI review queueddnssec: log warning if dependency is missingby SomberNight · cf8c243b · Dec 5, 2025 · 1 fileMessage 68 · AdequateInformational 18Details
Commit message · SomberNight

dnssec: log warning if dependency is missing

Calling dnssec.query() with missing "cryptography" dep behaves the same as if DNSSEC validation failed: validated=False will be returned.
When used for openalias, we mandate validated=True.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsecond-pass: broader security terminology
AI analysis · Informational 18/100

This commit only changes how Electrum logs a message when the optional 'cryptography' Python package is missing. It does not change any actual security behavior: DNSSEC validation still fails and falls back to plain DNS, and OpenAlias still rejects unvalidated results. The change simply makes the missing-dependency warning more visible in logs.

Lower-priorityopenalias: always enforce DNSSEC validation succeedsby SomberNight · cdcac8cb · Dec 5, 2025 · 6 filesMessage 50 · ThinModerate 59Details
Commit message · SomberNight

openalias: always enforce DNSSEC validation succeeds

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 59/100

This commit removes the ability to skip DNSSEC security checks for OpenAlias lookups in the Electrum Bitcoin wallet. OpenAlias turns human-readable names like 'donate@example.com' into Bitcoin addresses using DNS. Previously, users or commands could pass a 'nocheck' flag to accept unvalidated DNS results, which is dangerous because DNS responses can be spoofed or tampered with. The patch now enforces that DNSSEC validation must succeed before any OpenAlias result is used, and it strips out the old 'nocheck' options and unvalidated warnings. This is a hardening change that closes a known weak path where an attacker on the network could trick the wallet into sending money to the wrong address.

Lower-priorityonion_message: verify ONION_MESSAGE feature on peer before forwardingby Sander van Grieken · 23b64657 · Dec 5, 2025 · 1 fileMessage 60 · AdequateLow 48Details
Commit message · Sander van Grieken

onion_message: verify ONION_MESSAGE feature on peer before forwarding

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Low 48/100

This commit adds a safety check in Electrum's Lightning 'onion message' forwarding code. Before passing an encrypted message to the next peer in the chain, Electrum now verifies that the peer actually advertises support for onion messages. Without this check, Electrum could forward messages to peers that do not understand them, which could leak information about the route, waste bandwidth, or cause protocol confusion. The change is small and defensive.

Lower-priorityonion_message: fix forwarding, blinding was renamed path_key followup 130af597600364d235e97ca46c2eca59d25ef4efby Sander van Grieken · fb58d210 · Dec 5, 2025 · 1 fileMessage 65 · AdequateLow 42Details
Commit message · Sander van Grieken

onion_message: fix forwarding, blinding was renamed path_key
followup 130af597600364d235e97ca46c2eca59d25ef4ef

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 42/100

This is a one-line bug fix in Electrum's Lightning onion message forwarding code. The developer renamed a parameter from 'blinding' to 'path_key' when sending an onward onion message. The change aligns the code with a prior commit that renamed related concepts, and prevents the outgoing message from carrying the wrong/obsolete field name, which could cause forwarding to fail or behave incorrectly.

Lower-priorityqml: fix: paying to openaliasby SomberNight · 49430e97 · Dec 5, 2025 · 1 fileMessage 78 · AdequateInformational 18Details
Commit message · SomberNight

qml: fix: paying to openalias

regression from in https://github.com/spesmilo/electrum/pull/9993
7d0ac64d065a5d5b700507ac88fe3463553e913d

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 18/100

This is a small bug fix in Electrum's mobile-style QML user interface. A previous code change accidentally left OpenAlias payment addresses out of the list of recognized invoice types, so users trying to pay to an OpenAlias address (for example, a human-readable name like 'donate@example.com') would see an 'Unknown invoice' error instead of completing the payment. The patch simply adds OpenAlias back to the accepted list. It is a functionality regression fix, not a security vulnerability.

Lower-priorityelectrum refuses to exchange gossip with CLN nodes, due to missing feature OPTION_CHANNEL_TYPE_OPT. moving OPTIONAL_CHANNEL_TYPE_OPT to BASE_FEATURESby Sander van Grieken · 3e4f80aa · Dec 5, 2025 · 1 fileMessage 85 · StrongLow 25Details
Commit message · Sander van Grieken

electrum refuses to exchange gossip with CLN nodes, due to missing feature OPTION_CHANNEL_TYPE_OPT.
moving OPTIONAL_CHANNEL_TYPE_OPT to BASE_FEATURES

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 25/100

This commit fixes a Lightning Network compatibility bug in Electrum. Electrum nodes were refusing to exchange network routing gossip with Core Lightning (CLN) nodes because Electrum was not advertising a specific feature flag called OPTION_CHANNEL_TYPE_OPT in its baseline feature set. The fix moves that feature flag from the wallet-only features to the base features shared by all Lightning operations, including gossip. There is no direct security vulnerability here; it is an interoperability/availability fix.

Lower-priorityTest JIT channels: check that lnpay success is true.by ThomasV · 55cc27d2 · Dec 5, 2025 · 1 fileMessage 75 · AdequateInformational 14Details
Commit message · ThomasV

Test JIT channels: check that lnpay success is true.

This test fails since 0f314d1dd965424d898f4d8c564449ee42c21e97

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
AI analysis · Informational 14/100

This commit only adds a check in a test script to verify that a Lightning payment succeeds. It is a test-only change and does not modify any production wallet or Lightning code. The commit message says the test has been failing since an earlier commit, but it does not describe any security problem.

Lower-prioritylnwatcher: remove address callback if keep_watching is Falseby ThomasV · cd1d384d · Dec 5, 2025 · 1 fileMessage 65 · AdequateLow 34Details
Commit message · ThomasV

lnwatcher: remove address callback if keep_watching is False

(follow-up 9b72dc297b799a01b03a95c25aec75bd4f492543)

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 34/100

This is a small follow-up fix in Electrum's Lightning watchtower code. It ensures that when a channel closure no longer needs monitoring, the software stops watching the associated Bitcoin address. Without this cleanup, Electrum could keep polling or reacting to address updates indefinitely, wasting resources and potentially causing stale state or minor errors. The change itself is defensive housekeeping rather than a clear-cut vulnerability patch.

Lower-prioritytest accounting_addresses: stop alice before requesting, because we need a new session.by ThomasV · 40729aa0 · Dec 5, 2025 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · ThomasV

test accounting_addresses: stop alice before requesting, because we need a new session.

(follow-up 9b72dc297b799a01b03a95c25aec75bd4f492543)

87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a minor change to a test script for the Electrum Bitcoin wallet. It stops a test wallet daemon before running a command and adds a flag to use a new session. There is no security issue here—it's purely a test reliability fix.

AI review queuedtxbatcher: add TODOs re nLocktime block-height vs timestamp confusionby SomberNight · ef0e4e02 · Dec 4, 2025 · 3 filesMessage 65 · AdequateLow 32Details
Commit message · SomberNight

txbatcher: add TODOs re nLocktime block-height vs timestamp confusion

seems harmless atm but some rethinking is needed and checks should be added

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 32/100

This commit adds comments and TODOs warning that the wallet code may be mixing up two different kinds of Bitcoin time locks: block heights and wall-clock timestamps. It also fixes some helper functions to explicitly return None instead of implicitly returning nothing. The commit itself says the issue 'seems harmless atm' but needs rethinking. There is no actual exploit shown, only a note that future checks are needed.

Lower-prioritylnwatcher: remove rearly return that breaks accounting_addressesby ThomasV · 9b72dc29 · Dec 4, 2025 · 2 filesMessage 65 · AdequateLow 29Details
Commit message · ThomasV

lnwatcher: remove rearly return that breaks accounting_addresses

This reverts 6ffaa55.
Also, in regtests, add a check that fails if accounting_addresses are broken.

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Low 29/100

This commit fixes a bug in Electrum's Lightning watchtower code where an early exit was preventing the wallet from properly tracking certain closing transactions. The fix removes an unnecessary 'return early' check so that the wallet continues to process and account for these transactions. A new regression test checks that the closing transaction appears in the user's on-chain history even when it doesn't directly involve the user's wallet addresses. This is primarily an accounting/visibility bug, not a direct theft-of-funds vulnerability.

Lower-priorityplugins: nwc: don't mutate aionostr Eventby SomberNight · 75ac8bce · Dec 4, 2025 · 1 fileMessage 60 · AdequateInformational 18Details
Commit message · SomberNight

plugins: nwc: don't mutate aionostr Event

I want to change the Event class to be immutable.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 18/100

This is a small code cleanup in Electrum's Nostr Wallet Connect (NWC) plugin. The developer stopped modifying an incoming message object directly and instead passes the needed data as separate function parameters. The commit message says the goal is to make the underlying Event class immutable in the future. There is no direct security bug being fixed here, but the change removes a fragile pattern where error responses depended on whether the message had been previously altered.