qewallet: replace some threads with coroutines
What the developer wrote
Authored by f321x
qewallet: replace some threads with coroutines
Allows to simplify a bit and has less overhead.
What changed, and why it matters
This commit is a routine code cleanup in Electrum's mobile/QML user interface. It replaces two background threads with lightweight coroutines (async functions) for broadcasting Bitcoin transactions and paying Lightning invoices. There is no indication this change fixes or introduces a security vulnerability.
No security action required. Review as normal code-quality change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch refactors broadcast() and pay_invoice() in electrum/gui/qml/qewallet.py from threading.Thread wrappers to asyncio.run_coroutine_threadsafe() scheduling. It also consolidates the broadcast cleanup into a finally block and adds a broad Exception logger. The functional behavior—network calls, error emission, and state cleanup—remains equivalent.
Changed components
electrum/gui/qml/qewallet.pyInspect captured patch +11 / −12
diff --git a/electrum/gui/qml/qewallet.py b/electrum/gui/qml/qewallet.py
index 2b7b303..c51d9bb 100644
--- a/electrum/gui/qml/qewallet.py
+++ b/electrum/gui/qml/qewallet.py
@@ -602,26 +602,27 @@ class QEWallet(AuthMixin, QObject, QtEventListener):
def broadcast(self, tx):
assert tx.is_complete()
- def broadcast_thread():
+ async def broadcast_coro():
self.wallet.set_broadcasting(tx, broadcasting_status=PR_BROADCASTING)
try:
- self._logger.info('running broadcast in thread')
- self.wallet.network.run_from_another_thread(self.wallet.network.broadcast_transaction(tx))
+ self._logger.info('broadcasting tx in coroutine')
+ await self.wallet.network.broadcast_transaction(tx)
except TxBroadcastError as e:
self._logger.error(repr(e))
self.broadcastFailed.emit(tx.txid(), '', e.get_message_for_gui())
- self.wallet.set_broadcasting(tx, broadcasting_status=None)
except BestEffortRequestFailed as e:
self._logger.error(repr(e))
self.broadcastFailed.emit(tx.txid(), '', repr(e))
- self.wallet.set_broadcasting(tx, broadcasting_status=None)
+ except Exception:
+ self._logger.exception("failed to broadcast tx")
else:
self._logger.info('broadcast success')
self.broadcastSucceeded.emit(tx.txid())
self.historyModel.requestRefresh.emit() # via qt thread
- self.wallet.set_broadcasting(tx, broadcasting_status=PR_BROADCAST)
+ finally:
+ self.wallet.set_broadcasting(tx, broadcasting_status=None)
- threading.Thread(target=broadcast_thread, daemon=True).start()
+ asyncio.run_coroutine_threadsafe(broadcast_coro(), get_asyncio_loop())
# TODO: properly catch server side errors, e.g. bad-txns-inputs-missingorspent
@@ -663,16 +664,14 @@ class QEWallet(AuthMixin, QObject, QtEventListener):
if self._invoiceModel:
self._invoiceModel.initModel()
- def pay_thread():
+ async def pay_coro():
try:
- coro = self.wallet.lnworker.pay_invoice(invoice, amount_msat=amount_msat)
- fut = asyncio.run_coroutine_threadsafe(coro, get_asyncio_loop())
- fut.result()
+ await self.wallet.lnworker.pay_invoice(invoice, amount_msat=amount_msat)
except Exception as e:
self._logger.error(f'pay_invoice failed! {e!r}')
self.paymentFailed.emit(invoice.get_id(), str(e))
- threading.Thread(target=pay_thread, daemon=True).start()
+ asyncio.run_coroutine_threadsafe(pay_coro(), get_asyncio_loop())
@pyqtSlot()
def deleteExpiredRequests(self):
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.