contrib: android: make_apk.sh: add/update testnet comments
What the developer wrote
Authored by Aaron Fiore
contrib: android: make_apk.sh: add/update testnet comments
What changed, and why it matters
This commit only updates comments in a build script for Android. It adds guidance about how to build test versions of the Electrum Android app and warns about a known build issue. No code behavior changes, no security fix or vulnerability introduced.
No security action needed. This is a documentation-only change in a build helper script.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies contrib/android/make_apk.sh, a shell script used to build the Android APK. It adds and rewords comments regarding APP_PACKAGE_NAME and APP_PACKAGE_DOMAIN overrides for testnet builds. No executable commands are added, removed, or altered. The only functional line still present is the existing conditional if [ $CI ]; then block, unchanged.
Changed components
contrib/android/make_apk.shInspect captured patch +12 / −3
diff --git a/contrib/android/make_apk.sh b/contrib/android/make_apk.sh
index 2b6ee73..3f75c35 100755
--- a/contrib/android/make_apk.sh
+++ b/contrib/android/make_apk.sh
@@ -34,12 +34,21 @@ info "apk building phase starts."
# Uncomment and change below to set a custom android package id,
# e.g. to allow simultaneous mainnet and testnet installs of the apk.
# defaults:
+#
# export APP_PACKAGE_NAME=Electrum
# export APP_PACKAGE_DOMAIN=org.electrum
-# FIXME: changing "APP_PACKAGE_NAME" seems to require a clean rebuild of ".buildozer/",
-# to avoid that, maybe change "APP_PACKAGE_DOMAIN" instead.
-# So, in particular, to build a testnet apk, simply uncomment:
+#
+# FIXME: changing "APP_PACKAGE_NAME" seems to require a clean rebuild of ".buildozer/".
+# However, even with a clean build, the build appears to break in the final stages (~4.7.0).
+# To avoid these issues; only change "APP_PACKAGE_DOMAIN" instead.
+#
+# So, in particular, to build testnet APKs, simply uncomment one of the following at a time (per-build):
+#
+# Testnet3
#export APP_PACKAGE_DOMAIN=org.electrum.testnet
+#
+# Testnet4
+#export APP_PACKAGE_DOMAIN=org.electrum.testnet4
if [ $CI ]; then
# override log level specified in buildozer.spec to "debug":
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.