EP
← All projectsElements Project

Core Lightning

Modular C implementation of the Lightning Network protocol and node stack.

BitcoinLightning NetworkNormal
Repository coverage

1856 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

158security candidates263second-pass queue1853AI analyses
140commits · 30 days
227commits · 60 days
804commits · 180 days
1839commits · 365 days
Backfill bands
Aug 5 → Feb 61049 seen37 candidatesComplete
Feb 6 → Jun 6579 seen10 candidatesComplete
Jun 6 → Jul 678 seen1 candidatesComplete
Jul 6 → Aug 5147 seen16 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

70/100 average clarity
432Strong · 80–100
1164Adequate · 60–79
231Thin · 40–59
29Opaque · 0–39
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
dovgopoly15015164
Rusty Russell95873958072
Sangbida Chaudhuri14731146066
Dusty Daemon771377066
ShahanaFarooqui931093063
daywalker9090589062
Níckolas Goline40540076
Lagrang376476069
Christian Decker36436072
Vincenzo Palazzo838080
Chandra Pratap56256082
ekzyis222063
Analysis record

Published AI watches

Last scanned 48 minutes ago

Informational 15 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Revert "doc: require Homebrew GNU make and gpatch on macOS"

This commit is a simple documentation revert. It undoes a previous change that told macOS users to install GNU make and GNU patch from Homebrew and to put those tools first in their command path. The reverted instructions now omit gpatch a…

0cfa949fby Sangbida Chaudhuri+4−81 file
No security note in commit
Informational 15 AI analysisMessage 75 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Revert "tests: drop obsolete x-prefix in compacter-slow.sh"

This commit re-adds an old-style 'x' prefix to a string comparison in a test helper script. It is a test-only change with no effect on the actual Core Lightning node software, user funds, network behavior, or security. The change simply re…

116fd7cdby Sangbida Chaudhuri+1−11 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

doc: require Homebrew GNU make and gpatch on macOS

This commit only updates macOS installation instructions in the documentation. It tells macOS users to install newer GNU versions of 'make' and 'patch' from Homebrew because Apple's built-in tools are too old for building and running sourc…

d3ff1474by Sangbida Chaudhuri+8−41 file
No security note in commit
Informational 15 AI analysisMessage 83 · Strong
EP Elements ProjectCore Lightning BitcoinLightning Network

tests: drop obsolete x-prefix in compacter-slow.sh

This commit is a trivial shell script cleanup. It removes an old-fashioned 'x' prefix from a string comparison in a test helper script so that a newer version of the Shellcheck linter stops warning about it. The change does not alter progr…

474c272aby Sangbida Chaudhuri+1−11 file
No security note in commit
Informational 18 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

common: hoist amount+currency parsing into common code.

This commit moves existing code that parses payment amounts (Bitcoin millisatoshis, 'any' amount, or fiat currency amounts) from one plugin file into a shared library so it can be reused by a future feature. It is a code refactoring with n…

Refactoring of amount-parsing code into a shared helperAddition of explicit u64 overflow guards (mul_overflows_u64, add_overflows_u64) in the new common codeNo change to wire protocol or RPC interface semantics
e0f86c17by Rusty Russell+112−723 files
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: internal cleanups since all non-command JSON IDs are strings.

This is a routine internal cleanup commit in Core Lightning. It removes an unused helper function and simplifies how JSON-RPC request IDs are stored and formatted, since the project now always uses string IDs for non-command JSON traffic. …

No security-relevant keywords in commit title or messageNo CVE, advisory, or bug reference presentChanges are refactor/cleanup in nature
a70ae963by Rusty Russell+25−378 files
No security note in commit
Informational 15 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

common: hoist hash_str helper into its own header.

This commit is a routine code cleanup: it moves a small string-hashing helper function into a shared header file so it can be reused without being copied and pasted. There is no change to behavior, no bug fix, and no security relevance.

581bbb1fby Rusty Russell+16−176 files
No security note in commit
Informational 23 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

downgrade: we need to remove "impressions" from askrene datastore when downgrading to v26.06.

This is a database downgrade helper fix, not a live network vulnerability. Core Lightning's downgrade tool previously failed to strip out new 'channel impression' records when rolling a database back to version v26.06. The patch teaches th…

Database downgrade path could leave incompatible records in older schemaOffline tool only; no remote or on-chain triggerFix prevents potential node startup failure after version rollback
4d926285by Rusty Russell+43−111 file
No security note in commit
Low 31 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

downgrade tool: fix invalid memory bug

This commit fixes a typo in a database downgrade helper tool. The bug caused the tool to pass a negative number (turned into a huge positive size) when copying data, which led to an out-of-memory (OOM) error. The fix swaps two variable nam…

Integer underflow / negative-to-size_t wrap leading to excessive allocationOut-of-memory crash in maintenance toolMemory corruption potential if allocation somehow succeeded
42995326by Lagrang3+8−81 file
No security note in commit
Informational 24 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

xpay: actually tell askrene when a payment succeeded.

This commit fixes a bookkeeping bug in Core Lightning's xpay plugin. Previously, when a payment succeeded, xpay did not tell the askrene routing-helper that the route worked. As a result, askrene kept stale or overly pessimistic ideas abou…

Missing success feedback to routing layer can degrade payment reliabilityStale negative impressions may bias future path selection toward worse or failing routesNo direct funds-loss primitive is introduced or fixed
a66fabd4by Rusty Russell+40−02 files
No security note in commit
Low 49 AI analysisMessage 58 · Thin
EP Elements ProjectCore Lightning BitcoinLightning Network

askrene: correctly order constraints.

This commit fixes a bug in Core Lightning's routing helper (askrene) where two kinds of channel information—hard limits called 'constraints' and usage estimates called 'impressions'—were being applied in the wrong order. Because impression…

Routing decision bug caused by incorrect ordering of time-relative channel statePotential payment failure or acceptance of an over-capacity routeRegression test added demonstrating incorrect route acceptance before fix
4b6fe4a1by Rusty Russell+211−1182 files
No security note in commit
Low 35 AI analysisMessage 68 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

askrene: don't leak channel intel entries

This commit fixes a memory leak in the askrene plugin of Core Lightning. When individual channel intelligence entries were deleted, the code removed the entry from its array but forgot to free two internal pointers (impression and constrai…

Memory leak in plugin data structure cleanupMissing deallocation of nested pointers before array removalFix located in routing/intelligence plugin (askrene)
8891f414by Lagrang3+5−01 file
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

xpay: tests should expect the new error messages

This commit only updates test files so that automated checks expect slightly different error wording from the xpay payment command. It does not change any production code, so it cannot introduce a security vulnerability or fix one on its o…

0b67601fby Lagrang3+24−32 files
No security note in commit
Low 43 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

offers: limit invoices to 10 minutes for recurring offers in other currencies.

This change tightens the lifetime of recurring invoices priced in foreign currencies (like USD) to 10 minutes by default, and refreshes them with current exchange rates when they expire. Previously, such invoices could remain valid for the…

Fixes stale exchange-rate exposure for currency-denominated recurring invoicesAdds configurable expiry cap for recurring currency invoicesDistinguishes user-cancellation (0s expiry) from natural expiry to avoid misleading errors
446312cfby Rusty Russell+134−148 files
No security note in commit
Low 45 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

offers: limit expiry to offer limit, or 10 minutes with currency conversion.

This commit tightens the expiration time on invoices created from BOLT12 offers. Previously, all such invoices defaulted to a 2-hour payment window. Now, if the offer has an absolute expiry, the invoice expires when the offer expires; and …

BOLT12 invoice expiry now bounded by offer absolute expiryCurrency-converted invoices use short expiry to limit exchange-rate exposureNew regression test added for expiry behavior
a6cf4915by Rusty Russell+55−22 files
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

fetchinvoice: don't bother with checking recurrence timing.

This commit removes local timing checks in Core Lightning's fetchinvoice plugin for recurring payments. Instead of the plugin refusing too-early or too-late invoice requests, it now lets the remote node decide and report back. The change i…

Removal of local input-validation checks for recurring invoice requestsReliance on remote-party enforcement for recurrence period limits and pay windowsTest expectations changed from local rejection to remote failure messages
3e49d908by Rusty Russell+2−682 files
No security note in commit
Low 32 AI analysisMessage 73 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

lightningd: don't do previous invoice checking in createinvoicerequest.

This commit removes a local sanity check in Core Lightning's experimental 'createinvoicerequest' command. Previously, when creating a recurring invoice request, the code looked up past payments by label to verify the previous recurrence wa…

Removal of local payment-state validation for recurring invoice requestsParameter rename from recurrence_label to label in internal RPC callsTest expectations changed from local 'previous invoice has not been paid' errors to remote failure messages
4348d8acby Rusty Russell+5−1224 files
No security note in commit
Low 35 AI analysisMessage 65 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

fetchinvoice: handle weird labels in recurrence_label parameter.

This commit fixes how the fetchinvoice plugin handles user-supplied labels that contain special characters such as backslashes, quotes, tabs, and newlines. Previously these labels were passed as raw strings, which could cause JSON encoding…

JSON injection / improper escaping of user-controlled input passed between RPC componentsPotential mismatch between label parsing and label serialization leading to functional failures or unexpected behaviorFix is narrowly scoped to a single plugin and parameter
d7f87f2dby Rusty Russell+37−102 files
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

Add unit tests for str_to_u64

This commit only adds a new automated test file that checks how a helper function (str_to_u64) converts text strings to unsigned 64-bit integers. It does not change any production code, so it cannot by itself introduce a security vulnerabi…

dddb455dby Lagrang3+203−01 file
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
EP Elements ProjectCore Lightning BitcoinLightning Network

pytest: add tests for what we want askrene to do.

This commit only adds a new pytest test file. It does not change any production code. The test describes desired future behavior for the askrene routing module's error messages when a payment source or destination lacks enough channel capa…

518620aeby Rusty Russell+67−01 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityplugins: lsps: remove lsps2 moduleby Peter Neuroth · f678a706 · Dec 16, 2025 · 10 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: remove lsps2 module

Separate concerns of the lsps2 modules into their respective layers:
core for tlv, as it is lightning related, not specifically
core-lightning. cln_adapters for core-lightning related types.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a straightforward internal code reorganization (refactoring) in the Core Lightning LSPS plugin. It removes a dedicated 'lsps2' module and splits its contents between a new 'core/tlv' module for generic Lightning TLV parsing and a new 'cln_adapters/types' module for Core Lightning-specific data structures. No security fixes or functional behavior changes are visible in the diff.

Lower-priorityplugins: lsps: refactor client to use jsonrpcresponseby Peter Neuroth · 52745565 · Dec 16, 2025 · 3 filesMessage 73 · AdequateInformational 14Details
Commit message · Peter Neuroth

plugins: lsps: refactor client to use jsonrpcresponse

This makes it easier for client implementations to separate transport or
parser related issues from actuall json-rpc error responses. Also this
helps to segregate the individual responsibilities of the crates
further.

This further alows us to remove the error enum from proto/jsonrpc
completely as this now only deals as a from/to-wire module

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 14/100

This commit is a straightforward internal code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It changes how JSON-RPC responses are handled so that transport/parser problems are kept separate from actual JSON-RPC error responses returned by a remote server. There is no indication this fixes a security bug or introduces a vulnerability; it is a refactoring for better code organization.

Lower-priorityplugins: lsps: add router compatible lsps2 service handlerby Peter Neuroth · 461065af · Dec 16, 2025 · 4 filesMessage 73 · AdequateInformational 10Details
Commit message · Peter Neuroth

plugins: lsps: add router compatible lsps2 service handler

This commit copys and adapts the lsps2 service handlers to match the
slim router handlers

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 10/100

This commit adds a new experimental plugin feature for the LSPS2 protocol, which lets a Core Lightning node act as a service provider that opens just-in-time channels for payments. The change is purely additive (about 1,500 lines of new Rust code plus tests) and does not patch any reported vulnerability. There is no vendor statement or external report linking it to a security incident.

Lower-priorityplugin: lsps: simplify json-rpc response objectby Peter Neuroth · bad42c71 · Dec 16, 2025 · 6 filesMessage 68 · AdequateInformational 13Details
Commit message · Peter Neuroth

plugin: lsps: simplify json-rpc response object

We can use an enum as a more idiomatic rust style to create and retreive
json-rpc responses. The actual response data is kept in the body enum
while the surrounding only holds the identifier.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 13/100

This commit is a routine internal code cleanup in Core Lightning's experimental LSPS plugin. It replaces one Rust programming pattern for building JSON-RPC response messages with another, more idiomatic pattern. There is no indication it fixes a security bug, changes wire behavior, or introduces a vulnerability. It is purely a refactor.

Lower-priorityplugins: lsps: use transport specific errorby Peter Neuroth · e08756cd · Dec 16, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: use transport specific error

instead of using std::error, this is more specific and keeps the errors
"type-safe"

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a tiny code cleanup in a Lightning plugin. The developer replaced a generic Rust error type with a project-specific error type in two function signatures. There is no functional change visible in the diff, no bug fix, and no security-relevant behavior change.

Lower-priorityplugins: lsps: move primitives into lsps0by Peter Neuroth · ba93a7ca · Dec 16, 2025 · 6 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move primitives into lsps0

Those primitives are actually defined in lsps0

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This is a straightforward code reorganization: the developer moved shared data types (like monetary amounts and channel identifiers) from a file called 'primitives.rs' into a file called 'lsps0.rs' because the LSPS0 specification actually defines those types. Other files were updated to import from the new location. No behavior changes, bug fixes, or security fixes are visible in the diff.

Lower-priorityplugins: lsps: add slim generic json-rpc routerby Peter Neuroth · ffc05ddc · Dec 16, 2025 · 3 filesMessage 68 · AdequateInformational 12Details
Commit message · Peter Neuroth

plugins: lsps: add slim generic json-rpc router

This router is very lightweight and can handle routing for the lsps
service. It avoids allocations by just borrowing from the request. This
is much cleaner than what we have now and reduces the amount of
serializations by a lot.

Also it supports typed handlers which will remove serialization overhead
from the handlers in future commits

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 12/100

This commit adds a new internal JSON-RPC routing helper for the experimental LSPS plugin. It is a code-refactoring change: it introduces a lightweight router that borrows from incoming requests instead of copying data, and enables typed handlers to reduce serialization work. There is no indication in the commit that this fixes a security bug or introduces a vulnerability.

Lower-priorityplugins: lsps: add peer_id to transportby Peter Neuroth · 0f624ed6 · Dec 16, 2025 · 3 filesMessage 68 · AdequateInformational 14Details
Commit message · Peter Neuroth

plugins: lsps: add peer_id to transport

Frankly, transport without a target doesn't make sense, so this commit
adds a PublicKey (from secp256k1) as the target to the Transport trait.
It can easily be replaced by a common PeerId without changing the api
for external implementations if needed in the future

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 14/100

This commit is a routine code refactor in an experimental plugin. It adds a peer identifier (a public key) to the internal transport layer so every message knows which Lightning peer it is intended for. There is no indication this fixes a security bug; it is a design improvement.

Lower-priorityplugins: lsps: move client transport to cln_adaptersby Peter Neuroth · 74015850 · Dec 16, 2025 · 5 filesMessage 73 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move client transport to cln_adapters

cln_adapters is the layer that holds concrete implementations that are
related to core-lightning.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a pure code reorganization: it moves the client transport module from one directory (lsps0) to another (cln_adapters) without changing any behavior. The same code is deleted from one file and added to another, with only import paths updated. There is no security fix or vulnerability introduced.

Lower-priorityplugins: lsps: add own trait for lightning providerby Peter Neuroth · e001652a · Dec 16, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: add own trait for lightning provider

Clean up the CLN interface

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup in Core Lightning's experimental LSPS (Lightning Service Provider Specification) plugin. It replaces a custom 'ClnApi' trait with a more focused 'LightningProvider' trait, moving the details of how channels are funded and checked into one place. There is no indication this fixes a security bug or introduces a vulnerability; it is a refactoring change.

Lower-priorityplugins: lsps: remove cln dependencies from core module and clean up serviceby Peter Neuroth · c7bbf84c · Dec 16, 2025 · 3 filesMessage 73 · AdequateInformational 16Details
Commit message · Peter Neuroth

plugins: lsps: remove cln dependencies from core module and clean up service

The core module shouldn't depend on anything from the cln_adapters
module. This ensures that we can switch out interfaces in the future
(e.g a different database than cln's datastore).

This change made it necessary to refactor the service plugin which
allowed us to clean it up on the go

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 16/100

This commit is a code cleanup inside Core Lightning's experimental LSPS (Lightning Service Provider Specification) plugin. It removes a direct dependency between the plugin's core logic and the CLN-specific adapter types, replacing them with generic types. The service layer now converts between CLN-specific hook request/response formats and the new generic core types. There is no obvious security vulnerability introduced or fixed; it is primarily an architectural refactor.

Lower-priorityplugins: lsps: move lsps2 model to proto moduleby Peter Neuroth · b88dc597 · Dec 16, 2025 · 6 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move lsps2 model to proto module

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a pure code refactor: it moves the LSPS2 data model (request/response types, fee calculation, validation, and tests) from one internal module path to another within the same plugin crate. No functionality, logic, or security behavior changes. It is not a security fix.

Lower-priorityplugins: lsps: move errors into proto moduleby Peter Neuroth · a94885ba · Dec 16, 2025 · 2 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move errors into proto module

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a routine code reorganization in Core Lightning's experimental LSPS plugin. It moves standard JSON-RPC error code constants from one internal Rust module to another and adds a new client-rejected error type. There is no security-relevant behavior change, no bug fix, and no vulnerability patch.

AI review queuedplugins: lsps: replace heavy transportby Peter Neuroth · 462ca844 · Dec 16, 2025 · 6 filesMessage 68 · AdequateLow 27Details
Commit message · Peter Neuroth

plugins: lsps: replace heavy transport

We replace the legacy transport by a slim custommsg hook that makes use
of the lightweight multiplexed transport and avoids deserialization and
serialization through this extra layer

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Low 27/100

This commit refactors the LSPS (Lightning Service Provider Specification) plugin in Core Lightning to replace a heavier custom-message transport layer with a slimmer one. It removes a 536-line transport module and introduces a simpler hook-based multiplexer. The change is a code-quality/architecture refactor; there is no direct evidence in the commit or supplied references that it fixes a security vulnerability.

Lower-priorityplugins: lsps: move transport error to client moduleby Peter Neuroth · 9c474a6d · Dec 16, 2025 · 4 filesMessage 73 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move transport error to client module

The error belongs to the transport definition, not into the
wire/protocol module.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a simple internal code cleanup in the Core Lightning LSPS plugin. It moves the definition of transport-related errors from one Rust module to another and renames one error variant from 'Other' to 'Internal'. No security vulnerability is fixed or introduced; it is purely a refactoring change.

Lower-priorityplugins: lsps: move id generation into jsonrpcrequestby Peter Neuroth · 2546642c · Dec 16, 2025 · 4 filesMessage 73 · AdequateInformational 12Details
Commit message · Peter Neuroth

plugins: lsps: move id generation into jsonrpcrequest

There is no need to generate the id in some client when we can actually
generate it on a lower layer as we know by LSPS0 how we have to generate
it.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 12/100

This commit is a routine code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It moves the generation of random request IDs from the transport/client layer down into the JSON-RPC request construction layer. There is no security-relevant change: the same secure random number generator is still used, and request IDs are still generated for normal requests while notifications remain without IDs. The change simply removes duplicated ID-generation logic and aligns the code with the LSPS0 specification.

AI review queuedplugins: lsps: remove anyhow from tlvsby Peter Neuroth · 4a1c9220 · Dec 16, 2025 · 1 fileMessage 68 · AdequateInformational 12Details
Commit message · Peter Neuroth

plugins: lsps: remove anyhow from tlvs

Remove anyhow as a dependency from the tlv module. This allows for a
cleaner error handling

Changelog-None

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 12/100

This commit is a routine code cleanup in a Core Lightning plugin. It swaps one Rust error-handling library (anyhow) for another (thiserror) in the TLV (type-length-value) parsing module. The actual parsing logic and security checks remain the same; only the way errors are represented and reported is changed. There is no indication this fixes a security bug.

Lower-priorityplugins: lsps: add slim multiplexing transportby Peter Neuroth · 3cf99c35 · Dec 16, 2025 · 1 fileMessage 68 · AdequateInformational 12Details
Commit message · Peter Neuroth

plugins: lsps: add slim multiplexing transport

We can separate concerns here by adding a lightweight multiplexing
transport client. This helps us to clean up any direct dependencies on
CLN

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 12/100

This commit adds a new internal helper for the LSPS (Lightning Service Provider Specification) plugin that multiplexes JSON-RPC request/response messages over a generic sender. It is purely a refactor/addition of new code with no obvious security bug, no disclosed vulnerability, and no change to existing behavior that callers rely on.

Lower-priorityplugins: lsps: add own trait for blockheight providerby Peter Neuroth · 38c84be2 · Dec 16, 2025 · 1 fileMessage 73 · AdequateInformational 14Details
Commit message · Peter Neuroth

plugins: lsps: add own trait for blockheight provider

The ClnApi trait is way overloaded. We break things down to make it more
modular on the service side.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 14/100

This is a routine internal code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It splits an overloaded interface into smaller, more focused pieces. There is no user-facing behavior change, no bug fix, and no security relevance visible in the commit.

Lower-priorityplugins: lsps: move feature helpers to core moduleby Peter Neuroth · 30268ad9 · Dec 16, 2025 · 4 filesMessage 73 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move feature helpers to core module

This removes the util.rs module and leaves us with proto, core and
cln_adapters

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a simple code reorganization: it moves helper functions for checking feature bits from a general 'util.rs' file into a new 'core/features.rs' module. No behavior changes are visible in the diff, and no security fixes or vulnerabilities are introduced.

Lower-priorityplugins: lsps: move jsonrpc into proto moduleby Peter Neuroth · 5847cd44 · Dec 16, 2025 · 11 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move jsonrpc into proto module

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a straightforward code reorganization: it moves the JSON-RPC protocol definitions from one Rust module to another inside the LSPS plugin. No security-sensitive logic is added, removed, or changed. It is purely a refactoring step to make the code more modular for third-party plugin developers.

Lower-priorityplugins: lsps: move primitives into proto moduleby Peter Neuroth · 06fe54c4 · Dec 16, 2025 · 7 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move primitives into proto module

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a straightforward code reorganization. It moves shared data types (like monetary amounts and channel identifiers) from one internal module location to another, without changing how they work. There is no security-relevant change visible in the diff.

Lower-priorityplugins: lsps: move lsps0 model into proto moduleby Peter Neuroth · 39c36a03 · Dec 16, 2025 · 6 filesMessage 68 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: move lsps0 model into proto module

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a straightforward code reorganization: it moves the data structures that define the LSPS0 protocol messages from one internal module to another. No behavior changes, no bug fixes, and no security-sensitive logic is introduced or altered.

Lower-priorityplugins: lsps: refactor lsps2 and lsps0 error enumsby Peter Neuroth · b7be5ef3 · Dec 16, 2025 · 8 filesMessage 73 · AdequateInformational 14Details
Commit message · Peter Neuroth

plugins: lsps: refactor lsps2 and lsps0 error enums

Split them up how they are actually defined.

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 14/100

This is a routine code cleanup in Core Lightning's LSPS (Lightning Service Provider Specification) plugin. It reorganizes how error codes are defined and generated, moving from hand-written helper functions to a macro-generated trait pattern. There is no security fix or behavior change visible in the diff.

Lower-priorityplugins: lsps: remove debug print from library moduleby Peter Neuroth · a51f6e1e · Dec 16, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · Peter Neuroth

plugins: lsps: remove debug print from library module

This commit is part of a series that refactor the lsp plugin crate into
a modularized crate with the goal to separate the actual plugin runtime
as much as possible from library code to make it accessible for 3rd
party plugin implementations.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit simply removes a debug logging line from a Rust source file in the LSPS plugin. It is a code-cleanup change with no security relevance visible in the diff or commit message.