Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit only updates documentation. It adds new version entries to the manual page for the lightning-downgrade tool and mentions the tool in the upgrade guide. No code, database logic, or security behavior is changed.
This is a packaging/build fix, not a security vulnerability. The `lightning-downgrade` utility was being compiled but accidentally left out of the list of programs installed by `make install`. As a result, official release archives contain…
This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a fol…
Database migration failure could prevent node startup after upgradeFixes missing table creation before data backfillAdds regression test for upgrade path from v26.06.10
This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-se…
This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an ad…
Data integrity bug causing incorrect error reporting across payment retry groupsNo memory safety, authentication, authorization, or cryptographic issues presentNo external input is trusted or validated differently
This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin…
panic on send failure replaced with stderr fallbacklog message no longer silently dropped on writer task exitunit test added for dropped-receiver scenario
This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no n…
This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.
This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was re…
This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "…
No security-relevant signals presentFix is a routine correctness/robustness improvement
This commit is a trivial formatting cleanup (removing an extra blank line and adding one) in a test file. It does not change any code behavior, fix any bug, or alter any security-relevant logic.
This update fixes a crash in two wallet commands, addpsbtoutput and addpsbtinput. These commands let users add extra transaction outputs or inputs to a PSBT (a Bitcoin transaction planning file). If a user supplied a PSBT whose version 2 '…
Daemon crash (assertion failure) on crafted/strict PSBT inputMissing validation of PSBT v2 modifiable flags before mutationUser-controlled input directly passed to libwally without precondition check
This commit only adds a new test case that demonstrates two Core Lightning commands, addpsbtoutput and addpsbtinput, crash with an internal assertion when given a v2 PSBT that does not allow adding inputs or outputs. The test is marked as …
Daemon abort due to failed assertion in PSBT helper functionsRPC commands addpsbtoutput and addpsbtinput lack validation of PSBT modifiability flags before calling libwallyPotential denial-of-service vector: any caller able to submit a crafted v2 PSBT can crash lightningd
This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is …
This commit adds missing safety checks in Core Lightning when a peer sends signatures for opening or splicing a dual-funded Lightning channel. Before the patch, the software accepted peer-provided transaction witnesses without verifying th…
Missing input validation on peer-provided witness dataBOLT-2 compliance fix for tx_signaturesRejection of empty witness stacks
This fix prevents a user-issued 'abort channels' command from incorrectly failing a Lightning channel when a splice transaction has already been signed. Previously, the code would pass the latest in-flight splice to a routine that aborts i…
Denial-of-service/availability impact: user-initiated abort could inadvertently fail a funded channelProtocol compliance fix: avoids sending tx_abort after tx_signatures, which BOLT 2 forbidsState-handling bug in splice negotiation lifecycle
This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump …
NULL pointer dereference leading to daemon crash (denial of service)Crash occurs in cooperative-close path for unconfirmed dual-funded/RBF channelsFix uses canonical channel funding key instead of splice-only field
This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()'…
Denial-of-service via malformed gRPC request causing tonic worker task panicDenial-of-service via std::process::exit(1) in ProofField conversion on missing oneofSilent integer truncation of u16/u8 fields via 'as' casts
This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bind…
This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedwallet: create bwatch tables before backfilling themby daywalker90 · ce2a6836 · Nov 17, 2026 · 2 filesMessage 83 · StrongLow 27Details
Commit message · daywalker90
wallet: create bwatch tables before backfilling them
Databases from v26.06.10 are at migration version 284 and never ran the our_outputs/our_txs CREATE TABLE migrations, which master placed at indices 283/284. On upgrade, migrate_backfill_bwatch_tables (index 285) then inserts into our_outputs and fails with "no such table".
Create both tables with IF NOT EXISTS at the start of the backfill, so it works whether or not the earlier CREATEs ran. Existing databases already have the tables, so this is a no-op for them.
Add a unit test that starts from a v26.06.10-shaped database without the bwatch tables.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit fixes a database upgrade bug in Core Lightning. Wallets created with version v26.06.10 were missing two new tables (our_outputs and our_txs) because they skipped the migrations that create them. When users later upgraded, a follow-up migration tried to insert data into those non-existent tables and crashed. The fix simply creates the tables if they don't already exist right before filling them, and adds a test that simulates the problematic v26.06.10 database state. It is a reliability/data-integrity fix, not an exploitable security vulnerability.
AI review queuedv26.12rc1by Níckolas Goline · 4002c4e9 · Nov 16, 2026 · 10 filesMessage 5 · OpaqueInformational 15Details
Commit message · Níckolas Goline
v26.12rc1
Changelog-None
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5/100 · OpaqueMessage clarity
✓ Provides an explanatory body! Very short subject! Too few words to establish purpose
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit is a routine version bump from v26.06.10 to v26.12rc1 for Core Lightning. It only updates version strings in packaging files, a changelog, and a lockfile. There are no code changes that introduce, fix, or modify any security-sensitive behavior in this specific commit.
AI review queuedwallet: store payment failure details per groupidby daywalker90 · 24082c6d · Nov 12, 2026 · 4 filesMessage 68 · AdequateLow 30Details
Commit message · daywalker90
wallet: store payment failure details per groupid
wallet_payment_set_failinfo() matched rows on payment_hash and partid only, a leftover from before groupid became part of the payments key. Every failed retry in a new group therefore overwrote the failure details of all earlier failed groups with the same partid, so waitsendpay (and erroronion in listsendpays/listpays) for an earlier group reported the latest group's error.
Match on groupid too, like wallet_payment_set_status() and wallet_payment_get_failinfo() already do.
Changelog-Fixed: JSON-RPC: `waitsendpay` for an earlier `groupid` now reports that attempt's failure, not the failure of a later retry.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100
This commit fixes a database bug in Core Lightning where failure details for a payment attempt were being overwritten by later retry attempts that shared the same payment identifier fragment. The fix makes the failure record match on an additional 'groupid' field, so each retry group's error is stored separately. It is a correctness bug, not a security vulnerability: no funds are at risk and no attacker can exploit it.
AI review queuedcln-plugin: do not panic when the log writer task is goneby cdecker · 8661ffab · Nov 12, 2026 · 1 fileMessage 83 · StrongLow 43Details
Commit message · cdecker
cln-plugin: do not panic when the log writer task is gone
LoggingLayer::on_event forwarded events to the log writer task with sender.send(...).unwrap(). Once that task is gone -- the runtime is shutting down, or the task was dropped or panicked -- the receiver has been dropped, send returns Err(SendError(entry)) and the unwrap panics in whichever code emitted the log event. This usually showed up during node shutdown, after "Lost connection to the RPC socket."
Take the entry back out of the SendError and write it to stderr instead: logging must never panic, and we must not drop the entry either. stderr and not stdout, since stdout is the JSON-RPC channel to lightningd.
Add a unit test that drives the LoggingLayer with a dropped receiver via a local subscriber; it panics without the fallback.
Changelog-Fixed: cln-plugin: a plugin no longer panics when it logs after its log writer task has exited (e.g., during shutdown); the message is written to stderr instead.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Low 43/100
This commit fixes a bug in Core Lightning's Rust plugin library where a plugin could crash with a panic if it tried to log a message after the internal log-writing task had already stopped, such as during shutdown. The fix makes the plugin print the message to stderr instead of crashing. It is a reliability fix rather than an active remote exploit.
Document the recovery bundle, where each input comes from, the point-only peer workflow, transaction timing, and operator verification steps.
Co-authored-by: Cursor <cursoragent@cursor.com>
90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
This commit only adds documentation to the manual page for an existing command-line tool (hsmtool). It explains how to recover funds from old Lightning payment commitments (HTLCs) after losing channel state. There are no code changes, no new behavior, and no security fix or vulnerability introduced.
AI review queuedtests: make test_delpay_works deterministicby daywalker90 · a224ca81 · Nov 11, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · daywalker90
tests: make test_delpay_works deterministic
The test relied on force-disconnecting l2 from l3 to make the cheap route fail. Whether that failure happened depended on timing: the disable channel_update for l2<->l3 could reach l1 before it computed the route, in which case l1 never tried the cheap route and only one payment was recorded. This was seen as a CI flake.
Instead, run l2 with the fail_htlcs plugin so it rejects the forward on purpose. The first attempt always fails and the retry via l4 always succeeds.
Also rename the variable that holds the successful payment from `failed` to `success`.
This commit only changes a test file to make a flaky test more reliable. It does not modify any production code, so it has no security impact on real users.
AI review queueddoc: say that listtransactions gives blockheight 0 for a tx not in a blockby Peter Neuroth · bc281be3 · Nov 7, 2026 · 2 filesMessage 73 · AdequateInformational 20Details
Commit message · Peter Neuroth
doc: say that listtransactions gives blockheight 0 for a tx not in a block
listtransactions also lists transactions that are not in a block: ones we sent that aren't mined yet, and ones a reorg took out of the chain. For those, blockheight and txindex are 0, which the schema didn't say.
Changelog-None
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100
This commit only updates documentation to explain that the `listtransactions` command reports a block height and transaction index of 0 when a transaction is not currently in a block (for example, because it hasn't been mined yet or was removed by a blockchain reorganization). No code behavior was changed.
AI review queuedfixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zeroby Amartya Singh · 02612ed5 · Nov 5, 2026 · 1 fileMessage 50 · ThinInformational 20Details
Commit message · Amartya Singh
fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 20/100
This is a small bug fix in a Python helper library used by Core Lightning. The Millisatoshi.to_approx_str() method previously crashed with a math error when converting a zero amount to a human-readable string. The patch makes zero return "0btc" instead of raising an exception. It is a correctness fix, not a security vulnerability.
AI review queuedfixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zeroby Amartya Singh · 081ca6c1 · Nov 5, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Amartya Singh
fixup! pyln-client: don't crash Millisatoshi.to_approx_str() on zero
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit is a trivial formatting cleanup (removing an extra blank line and adding one) in a test file. It does not change any code behavior, fix any bug, or alter any security-relevant logic.
AI review queuedpyln-client: don't crash Millisatoshi.to_approx_str() on zeroby Amartya Singh · 5ebe365d · Nov 5, 2026 · 2 filesMessage 73 · AdequateInformational 20Details
Commit message · Amartya Singh
pyln-client: don't crash Millisatoshi.to_approx_str() on zero
round_to_n() took log10() of the amount to find its magnitude, which fails for 0. Zero needs no rounding, so return it as is; the shortest unit then comes out as "0btc", the same way 1 BTC prints as "1btc".
Changelog-Fixed: pyln-client: `Millisatoshi(0).to_approx_str()` no longer raises a ValueError.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 20/100
This commit fixes a minor bug in Core Lightning's Python client library where calling a pretty-printing method on a zero-amount payment would crash with a ValueError. It is a routine correctness fix, not a security vulnerability. There is no way to exploit it to steal funds, bypass security, or attack a node.
AI review queuedlightningd: fix crash on mutual close of an unconfirmed dual-funded channelby Sangbida Chaudhuri · 555143be · Oct 29, 2026 · 1 fileMessage 73 · AdequateModerate 51Details
Commit message · Sangbida Chaudhuri
lightningd: fix crash on mutual close of an unconfirmed dual-funded channel
After an RBF the channel has more than one candidate funding tx. After a mutual close we watch the ones we didn't close on, in case they confirm. To build that watch we need the peer's funding key, and we were reading it from a field that only splices fill in. For RBF it is NULL, and we crashed on it:
RBF never changes the funding keys, so use the channel's own copy of the peer's key instead.
Changelog-Fixed: lightningd: fix a crash on cooperative close of an unconfirmed dual-funded channel.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 51/100
This update fixes a bug where a specific type of Lightning channel close could crash the node. It only happens when both parties cooperatively close a dual-funded channel that has not yet been confirmed and has gone through a funding bump (RBF). The crash is due to the software looking in the wrong place for a needed public key. The fix makes it use the correct copy of that key.
AI review queuedcln-grpc: reject malformed request values instead of panickingby daywalker90 · b2703436 · Oct 28, 2026 · 5 filesMessage 73 · AdequateHigh 74Details
Commit message · daywalker90
cln-grpc: reject malformed request values instead of panicking
The msggen-generated inbound conversions parsed client-controlled pubkeys, hashes, secrets, short channel ids and enum values with unwrap(), so malformed requests could panic the tonic worker task. The hand-written ProofField conversion called std::process::exit(1) when its oneof was missing, killing the plugin, and narrowing u16 fields were silently truncated by `as` casts.
Generate TryFrom impls that return tonic::Status, map parse failures, missing required fields and out-of-range numbers to INVALID_ARGUMENT, and propagate the errors from the server handlers.
Changelog-Fixed: cln-grpc no longer panics on malformed request values.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · High 74/100
This commit fixes a security bug in Core Lightning's gRPC plugin (cln-grpc). Previously, a malformed request from a gRPC client could crash the plugin: bad public keys, hashes, secrets, channel IDs, or enum values triggered Rust 'unwrap()' panics, a missing 'oneof' field caused the plugin to call process::exit(1) and shut down, and large numbers were silently truncated when stored as smaller integer types. The patch replaces these crash-prone conversions with fallible TryFrom implementations that return a proper INVALID_ARGUMENT error to the client instead of crashing or killing the plugin.
AI review queuednix: drop protobuf againby Peter Neuroth · a0459eee · Oct 28, 2026 · 1 fileMessage 51 · ThinInformational 15Details
Commit message · Peter Neuroth
nix: drop protobuf again
cln-grpc stopped looking for protoc on PATH in 608f6952e ("cln-grpc: vendor protoc as a build-dependency"): its build script now uses the statically linked protoc from protoc-bin-vendored, which also runs on NixOS. Nothing else in the build calls protoc; the Python bindings use grpc_tools.protoc.
Changelog-None
51/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit removes the protobuf package from the Nix build environment because it is no longer needed. A previous change made the cln-grpc component use its own bundled protoc compiler instead of relying on the system one. The Python bindings already used a different tool. There is no security-relevant change here.
AI review queuedmake: check gRPC protos for breaking changes against the last releaseby daywalker90 · db5fea70 · Oct 27, 2026 · 4 filesMessage 73 · AdequateInformational 15Details
Commit message · daywalker90
make: check gRPC protos for breaking changes against the last release
Add check-grpc-breaking to check-source. It finds the newest release tag reachable from GRPC_BREAKING_BASE_REF and runs buf breaking against the protos at that tag, using the WIRE_JSON rules. The buf CLI is installed as a dev dependency via buf-bin.
Changelog-None
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit adds a new automated check to the project's build process that compares gRPC protocol definitions against the last release to catch accidental breaking changes early. It does not change any runtime code, fix a bug, or introduce a vulnerability. It is purely a development tooling and quality-assurance improvement.
AI review queuedlightningd: store the revocation secret before acting on its HTLCsby Christian Decker · 1d9bd904 · Oct 26, 2026 · 1 fileMessage 73 · AdequateModerate 63Details
Commit message · Christian Decker
lightningd: store the revocation secret before acting on its HTLCs
peer_got_revoke() applied the HTLC changes which a revoke_and_ack locks in -- forwarding the final accepts, settling updates and failing fails -- before it had checked the revocation secret. If wallet_shachain_add_hash() rejects that secret we fail the channel anyway, so it must not act on them first.
Run the shachain and revokenum checks before acting on the HTLCs. Nothing in between touches HTLC state, and crash-consistency is unchanged: sd_msg_read() wraps every channeld message in a single DB transaction, so a crash replays the whole message or nothing.
Reported-by: Erick C (@erickcestari)
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 63/100
This commit fixes an ordering bug in Core Lightning's handling of 'revoke_and_ack' messages from a peer. Previously, the node would apply pending HTLC (payment channel) changes—such as forwarding payments or settling/failing them—before verifying and storing the peer's revocation secret. If that secret was invalid, the channel would be closed anyway, but only after the HTLC state had already been altered. The fix moves the revocation-secret verification and storage to happen before any HTLC state changes, preventing a potentially inconsistent or exploitable state.
AI review queuedlightningd: record why a local forward failed in listforwardsby Andezion · 03d51eea · Oct 26, 2026 · 34 filesMessage 85 · StrongInformational 19Details
Commit message · Andezion
lightningd: record why a local forward failed in listforwards
Changelog-Added: JSON-RPC: 'listforwards' and the 'forward_event' notification have a new 'failure_reason' field with the root cause of a local forward failure ('insufficient_outgoing_liquidity', 'too_many_htlcs', 'max_htlc_value_in_flight')
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit adds a new 'failure_reason' field to the listforwards RPC output and forward_event notification. It records why a local HTLC forward failed (for example, not enough outgoing liquidity, too many HTLCs, or the peer cannot afford the commitment fee). It is primarily an observability and diagnostics improvement, not a security fix or vulnerability.
AI review queuedlightningd: remove deprecations due in v26.12by daywalker90 · d2a278b4 · Oct 23, 2026 · 20 filesMessage 78 · AdequateLow 29Details
Commit message · daywalker90
lightningd: remove deprecations due in v26.12
These were deprecated in v25.05 or v25.09 and last supported in v26.06 or v26.09:
- `coin_movement` notification: `tags`, `txid`, `utxo_txid` and `vout`. - `channel_state_changed` notification: `short_channel_id` was `null` when unconfirmed. It is now omitted. - Plugin notifications: the legacy `payload` object and flat unwrapped fields. - `pay_notifications.raw_fields`: `channel_hint_update`, `pay_failure` and `pay_success` already wrap their members in an object of the same name. - `wait.details`: the subsystem-specific object is used instead.
The shared coin movement serializer no longer takes the legacy flags. The Python plugin client no longer recreates `payload` for old plugins. The Rust plugin client sends custom notifications in the modern shape only, without the deprecated flat copy of the fields.
The test harness still skips `channel_state_changed` when `message` is `null`: it is deprecated since v25.12 and still supported until v26.12, unlike the removed `short_channel_id` null.
Changelog-Removed: Plugins: `coin_movement` notification `tags`, `txid`, `utxo_txid` and `vout` fields (use `primary_tag`, `extra_tags`, `spending_txid` and `utxo`). Changelog-Removed: Plugins: `channel_state_changed` notification omits `short_channel_id` when the channel is unconfirmed, instead of `null`. Changelog-Removed: Plugins: notifications no longer include the legacy `payload` object or flat unwrapped fields; use the object named after the method instead. Changelog-Removed: JSON-RPC: `wait` no longer returns the `details` object for `invoices`, `forwards` and `sendpays`; use the subsystem-specific object instead.
78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: unusually broad change
AI analysis · Low 29/100
This commit removes old, previously-announced deprecated API fields and shapes from Core Lightning. It is a planned cleanup, not a security fix. Plugins or clients that still relied on the old fields will break or need to be updated, but there is no new vulnerability introduced.
AI review queueddocs: relabel v26.09 feature markers as v26.12by daywalker90 · b55aca37 · Oct 23, 2026 · 11 filesMessage 80 · StrongInformational 15Details
Commit message · daywalker90
docs: relabel v26.09 feature markers as v26.12
Features added in the v26.09 cycle are now marked for v26.12, the next release. The 26.09 release was skipped, so the version-based `added` markers move to v26.12. Deprecation end markers keep their time-based values.
Changelog-None
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is purely a documentation and metadata relabeling change. It updates version markers from 'v26.09' to 'v26.12' because the v26.09 release was skipped. No code logic, security behavior, or runtime functionality was changed.
AI review queuedci: replace broken katyo/publish-crates with a native cargo publish stepby daywalker90 · 2646184f · Oct 20, 2026 · 1 fileMessage 85 · StrongInformational 20Details
Commit message · daywalker90
ci: replace broken katyo/publish-crates with a native cargo publish step
The katyo/publish-crates action no longer publishes anything: the Release Rust workflow ran on the push that bumped lsps-types to 0.7.0 and did not publish it.
The new step publishes each crate only when its Cargo.toml version is newer than the highest version on crates.io, in dependency order (cln-rpc, cln-grpc, cln-plugin, lsps-types).
Cap the job at 30 minutes and give the crates.io index request a 30 second timeout so a hung network call cannot stall the release.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
This commit updates the project's automated release workflow for publishing Rust crates to crates.io. It replaces a third-party GitHub Action that had stopped working with a custom shell script that checks whether each crate's local version is newer than what is already published before running the official cargo publish command. The change also adds a 30-minute job timeout and a 30-second network timeout for checking crates.io. There is no direct security vulnerability in the diff, but any change to a release pipeline that handles a secret publishing token deserves a routine security review.
AI review queuedlsps-types: echo valid_until verbatim and send the LSPS0 datetime formatby Peter Neuroth · 2d187383 · Oct 11, 2026 · 3 filesMessage 85 · StrongLow 35Details
Commit message · Peter Neuroth
lsps-types: echo valid_until verbatim and send the LSPS0 datetime format
bLIP-52, "2. Request JIT Channel":
Clients MUST copy it verbatim from an entry of `opening_fee_params_menu` from a result of a `lsps2.get_info` call.
bLIP-50, LSPS0.datetime:
Particular points of time in the modern era (a "datetime") MUST be encoded as a JSON string containing the [ISO 8601][] format `"YYYY-MM-DDThh:mm:ss.uuuZ"`. These are always in the UTC timezone.
`DateTime` was serialized by chrono, which writes as many fractional digits as needed: a spec-conforming "2023-02-23T08:47:30.000Z" from an LSP came back from the client as "2023-02-23T08:47:30Z", and "...30.5112Z" as "...30.511200Z". That only worked because the in-tree service checks its promise against the parsed value; an LSP that checks the string it sent would reject the client. The service itself sent whole seconds without the milliseconds.
`DateTime` now keeps the string it was deserialized from and serializes it back unchanged. A datetime built from a chrono value is truncated to milliseconds and serialized as `YYYY-MM-DDThh:mm:ss.uuuZ`. Equality, ordering and hashing still only compare the point in time. Parsing is unchanged. `DateTime` is no longer `Copy`.
The service builds the `valid_until` it sends from the policy plugin's value this way and computes the promise over the truncated value, so the promise still verifies on what the client echoes.
Behavior change: the client echoes `valid_until` exactly as received; the service sends `valid_until` with millisecond precision in the LSPS0 format.
Changelog-Fixed: lsps-plugin: the LSPS2 client now copies `opening_fee_params` verbatim (including `valid_until`), and the service sends `valid_until` in the LSPS0 datetime format.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Low 35/100
This commit fixes a protocol-compatibility bug in Core Lightning's LSPS (Lightning Service Provider Specification) support. When a client received an opening-fee offer from a service provider, it was accidentally changing the exact timestamp text before echoing it back. Some strict providers would then reject the client's reply because the timestamp no longer matched. The fix makes the client preserve the original timestamp text exactly, and makes the service send timestamps in the precise format the spec requires. There is no direct theft-of-funds or remote-code-execution vulnerability here, but the bug could cause legitimate JIT-channel requests to fail.
AI review queuedlsps-types: add empty crateby Peter Neuroth · e5ca96e3 · Oct 11, 2026 · 9 filesMessage 80 · StrongInformational 15Details
Commit message · Peter Neuroth
lsps-types: add empty crate
Add a new top-level crate `lsps-types` for the LSPS0 and LSPS2 protocol types and the LSPS2 opening fee computation, so that LSPS clients and services share one implementation and cannot disagree on amounts.
The crate is wired up like cln-rpc: a workspace member and workspace dependency versioned in lockstep with cln-rpc, cln-grpc and cln-plugin, a Makefile included when building with Rust, and a crates.io publish step. The LSPS plugin binaries list its sources as prerequisites so they rebuild once the plugin depends on it.
Changelog-None
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit adds a new, empty Rust code crate called lsps-types to the Core Lightning project. It contains no executable logic, only build and packaging configuration. There is no security issue in this change.
AI review queuedtools: add sign-release-arm.shby Níckolas Goline · 224130eb · Oct 6, 2026 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · Níckolas Goline
tools: add sign-release-arm.sh
build-release.sh's sign target cannot be used for the ARM tarballs: it hardcodes `cd release/` rather than honouring RELEASEDIR, and globs the zip, so running it for an ARM build would rewrite the amd64 manifest.
Checksum one architecture's tarballs, from release-arm64/ or release-armv7/, into SHA256SUMS-<version>-<arch> and sign it. arm64 and armv7 keep separate manifests: arm64 builds natively and armv7 is cross-compiled, so they are reproduced and co-signed separately.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit adds a new helper script used by Core Lightning release engineers to create and sign checksum files for ARM release tarballs. It does not change any wallet, network, or node code, and there is no indication it fixes or introduces a security vulnerability. It is purely a release tooling addition.
AI review queuedchanneld: bound HTLC additions by our own splice-out amountby jaonoctus · 0b41f819 · Oct 5, 2026 · 1 fileMessage 73 · AdequateModerate 66Details
Commit message · jaonoctus
channeld: bound HTLC additions by our own splice-out amount
While a splice is inflight, every HTLC has to fit on the commitment for each funding candidate, so get_room_above_reserve() charges each side's lowest splice change (lowest_splice_amnt) against its balance. But update_view_from_inflights() set our side's bound from the inflight's new funding total, which is positive, so it stayed at zero and our splice-out was never charged.
We then admitted HTLCs that fit only the pre-splice commitment. Building the post-splice commitment took our balance negative, channel_txs() returned NULL, and channeld dereferenced it and crashed, then did the same on every reconnect:
during the splice, payments were forwarded out through the channel cumulatively they exceeded our post-splice balance (invalid on the post-splice commitment) ... channeld crashed building the post-splice commitment: our balance went negative, the commitment build returned nothing, and channeld dereferenced it every reconnect rebuilds the same commitment, so it loops
Use the inflight's signed local change for our bound, as the remote side already does. Also fix the REMOTE-view assignments, which compared against one side's bound and wrote the other's.
Reported-by: Ken Sedgwick <ken@bonsai.com> Changelog-Fixed: channeld: no longer crash-loops when an HTLC that only the pre-splice commitment can carry is added during a splice-out. Co-Authored-By: Ken Sedgwick <ken@bonsai.com>
(cherry picked from commit 733c42e823bb204e6d91cca4f0450158842404e3)
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 66/100
This fix repairs a bug in Core Lightning's channel daemon that could crash and permanently loop-crash a node during a specific kind of Bitcoin channel upgrade called a 'splice-out.' While the splice was in progress, the program failed to subtract the node's outgoing splice amount when checking whether new forwarded payments would fit in the updated channel. It therefore allowed payments that were valid only for the old channel state. When it later tried to build the post-splice commitment transaction, the node's balance went negative, the builder returned nothing, and the daemon dereferenced that null pointer and crashed. On every reconnect it rebuilt the same bad commitment, so the node would crash again in a loop. The patch corrects the accounting so the splice-out amount is properly charged against the balance, and also fixes a related indexing mistake that mixed up local and remote views.
AI review queuedchanneld: fail the channel instead of crashing if we can't build a commitmentby jaonoctus · 77e1f180 · Oct 5, 2026 · 1 fileMessage 85 · StrongModerate 60Details
Commit message · jaonoctus
channeld: fail the channel instead of crashing if we can't build a commitment
channel_txs() returns NULL when it can't build a commitment, for example when a splice amount would take one side's balance below zero:
channel_txs fails to amount_msat_add_sat_s64 ... LOCAL (side_pay + splice_amnt)
Neither send_commit_part() nor handle_peer_commit_sig() checked for that, so channeld dereferenced NULL and crashed. Since every reconnect rebuilds the same commitment, it then crashed again on each one, leaving the channel stuck in a crash loop that only a unilateral close would end.
There's no way to continue on a commitment we can't build, so fail the channel and say why. The next commit stops the case we know about reaching here at all.
Changelog-None
Co-Authored-By: Ken Sedgwick <ken@bonsai.com>
(cherry picked from commit 2594edab350be11c68459e546921e6c0d1d07739)
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 60/100
This update fixes a bug where a part of the Core Lightning node (channeld) would crash and enter an endless crash loop if it couldn't build a commitment transaction, for example due to a splice that would push one side's balance below zero. The fix makes the node fail the channel gracefully instead of crashing. A malicious or buggy peer could potentially trigger this crash repeatedly on reconnection, causing denial of service for that channel.
AI review queuedlightningd: conceal secret config values in listconfigsby Andezion · ef48dcd2 · Oct 5, 2026 · 5 filesMessage 73 · AdequateModerate 65Details
Commit message · Andezion
lightningd: conceal secret config values in listconfigs
Changelog-Changed: JSON-RPC: `listconfigs` shows `...` instead of the value of `wallet`, `recover`, `tor-service-password`, `bitcoin-rpcpassword` and the old `bookkeeper-db`, for every caller; unset ones are omitted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
(cherry picked from commit 6ed212e4856bce2b3392bac1d2fe2df90f3edfde)
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Moderate 65/100
This commit changes Core Lightning's `listconfigs` RPC command so that several secret or sensitive configuration values are hidden and shown as '...' instead of their real content. Previously, anyone who could call `listconfigs` could see values like the Bitcoin RPC password, wallet database connection string, recovery seed, Tor service password, and old bookkeeper database details. The commit also fixes a bug where concealed options were still being shown when they were not actually set. This is a security hardening change that reduces the risk of leaking credentials to unauthorized callers.